GitLab

|last_visible_index_| of the main shelf view is updated in
CalculateAppCenteringStrategy. However, when the scrollable shelf
is enabled, |last_visible_index_| may be accessed before that function
is called. As a result, an illegal index value may be used. Given
that in scrollable shelf, |last_visible_index_| is always the index
of the last shelf item. So updates |last_visible_index_| when
a shelf item is added/removed.

Bug: 1006165
Change-Id: I4bc13e204835828bb1d5f77024ce274b9899ced0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816142Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699020}

Start using util::IdType from base.

Change-Id: I1419a4a1065d99493e2d51f9e220cf20828716e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795895Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699019}

Change the GURL parameter from base::Optional to a pointer, per guidance
in docs/optional.md. Also simplify some related code and fix lint
errors.

Change-Id: I899f3877370a916ff8dc30402b2325351390286e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817660
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699018}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/314adcb844e1..fdb59f0d9088

git log 314adcb844e1..fdb59f0d9088 --date=short --no-merges --format='%ad %ae %s'
2019-09-23 tandrii@google.com Revert "git-cache: don't limit pack files to 2GiB."
2019-09-23 rharrison@chromium.org Add Dawn to projects for my_activity.py
2019-09-23 qyearsley@chromium.org Remove some unused private things in git_cl

Created with:
  gclient setdep -r src/third_party/depot_tools@fdb59f0d9088

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: None
Change-Id: I3c71eb86c8026762ef5fdfd99aec8c7da028a915
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819107Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699017}

This CL enables two currently disabled flaky tests:
  - ExtensionWebRequestApiAuthRequiredTest.WebRequestAuthRequired
  - ExtensionWebRequestApiAuthRequiredTest.WebRequestAuthRequiredAsync

Additional debugging is added to detect the cause of flakiness. Once we get new
failure logs for these, we can hopefully find a fix.

Note for sheriffs: This is enabling flaky tests. Please paste failure logs on
the bug (from deterministic failures) before disabling the test again. Also,
prefer disabling the test to reverting this CL.

BUG=1003598

Change-Id: I921bec19f038319e4a530c3437e6582363ef694e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814867
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699016}

This was really a bounds change listener.

Also reorder functions to match View declaration order.

Bug: 1005568
Change-Id: Ic69db01b130d0e75f19bab186f6379e4902206d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817362
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699015}

This is a reland of e475b274

Original change's description:
> Update WMR display info when starting session
> 
> I3491d43245bb53100212fd2d0ab38d8f1222e7c9 addresses the issue where the
> render width/height is not initially sent back to the render process.
> This is accomlpished by updating the display info when the session starts
> instead of on the first render frame.
> 
> A subsequent change, I4cf2ab2ed6455963b1f43f8717941e7a0368416a, wraps
> this update around the visibility state. Since the visibility state is
> initially hidden, the display info isn't updated resulting in
> WebVR/WebXR pages using the wrong resolution
> 
> This change explicitly updates the display info and sends it back to the
> MixedRealityDevice when the session starts.
> 
> Change-Id: Ifb4516b36203139038aa943d68e8c3ba717003f3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810303
> Commit-Queue: Patrick To <patrto@microsoft.com>
> Reviewed-by: Alexander Cooper <alcooper@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#698172}

Change-Id: I7289fdc18f2d99a0ab29eb86af0b9dbed13ba275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819703Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699014}

Toggle switch on settings page that opts in/out the user from using FIDO Auth for card unmasking.

Bug: 949269
Change-Id: Idd1a04479c0f7c7a4f085714769e04ee7672ef4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738721
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699013}

This is CL [3/4] in a series of CLs to expose "display: none"
elements to the browser process AXTree.

1. Add and improve tests for CSS display and visibility.
2. Introduce new command line flag and chrome://flags entry.
3. Update AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree
   and relevant logic for the feature to work, disabled using the
   feature flag.
4. Enable the feature in tests; update expectation files.

---

This change hooks up everything required to expose nodes that are
"display: none" to be exposed to the browser-side AX tree with the
State::kIgnored, but behind a RuntimeEnabledFeatures.
Doing so allows elements with "display: none" to be returned from
UIA_DescribedByPropertyId and UIA_LabeledByPropertyId.
This change can be observed in the update to
AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree().

---

There was a bug with AXNodePosition::AsUnignoredTextPosition when a
leaf text position was the first or last in a document.
It would fail to find the next/previous unignored position because it
only searched in one direction. In the case where the last node in a
document is ignored, we must search in reverse order if no unignored
position can be found in the forward direction.

---

In response to AXEventGenerator::Event::IGNORED_CHANGED, we now also
need to fire menu opened / closed events for MSAA and UIA. This is
because when a menu goes from ignored to unignored it is exposed to
the accessibility tree as a new node, similar to if a new unignored
menu was added to the DOM via script.

---

Modifying AXObjectCacheImpl::HandleRoleChangeWithCleanLayout so that
it will create the AXObject if it doesn't exist already. This fixes an
invalidation issue when changing the role of an element where the
parent object may not be invalidated for a change in its children.

This is needed to fix :
blink/web_tests/accessibility/is-ignored-change-sends-notification.html

I tested |divWithoutRoleContainer| in isolation without my change and
it appears that test case was providing a false-positive before.

---

Deferring ax::mojom::Event::kBlur and ::kFocus when calling
|AXObjectCacheImpl::HandleFocusedUIElementChanged|.
I needed to defer this event due to my changes in
|AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree|.

This is because the following stack will have a DCHECK failure :
Check failed: !GetDocument().NeedsLayoutTreeUpdateForNode( *this, true )
```
blink::Element::EnsureComputedStyle
blink::AXObject::IsHiddenForTextAlternativeCalculation
blink::AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree
blink::AXObject::UpdateCachedAttributeValuesIfNeeded
blink::AXObject::AccessibilityIsIgnored
blink::AXObjectCacheImpl::GetOrCreate
blink::AXObjectCacheImpl::FocusedObject
blink::AXObjectCacheImpl::HandleFocusedUIElementChanged
```

---

Bug: 651614
Change-Id: Ieef8e43d19de147beb827139e761085b1d13d0e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808430
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#699012}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3a8610d6571..112a550769c4


Created with:
  gclient setdep -r src-internal@112a550769c4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I9c67890315403d5cc936b6af8277d8771e436dee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819135Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699011}

Moves all the remaining logic to the Interceptor. Also renames the
GetURL method to something more specific to this preview type.

Bug: 1005295
Change-Id: I4a129d1689887d55089f64ffdcc6446047e8e7a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818433Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699010}

This CL ensures that the gradient zone shows correctly under RTL.

Bug: 1004134
Change-Id: Ie59f7df4242daf2ae5cb13d01e3d9e971d69ed9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805188Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699009}

This CL changes StatusIconLinuxDbus to send the icon as a file instead
of as a DBus property.  All of the StatusNotifierItem client libraries
send icons as files, so some StatusNotifierHosts don't behave well when
given an icon property since that codepath wasn't ever tested.

gnome-shell-extension-appindicator doesn't scale property icons, but
does scale file icons.  wingpanel-indicator-ayatana (used on Pantheon)
only supports file icons.  There's no way using StatusNotifierWatcher to
get information about specific StatusNotifierHosts.  So the only way we
can detect these two hosts is based on the desktop environment.

To prevent race conditions involved with cleanup up the icon file,
StatusIconLinuxDbus must be made ref-counted, which adds some
unfortunate complexity.

BUG=10034265
R=thestig

Change-Id: I79db4b83f6ab49319069b11ab761bd23985eeba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815055
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699008}

https://pdfium.googlesource.com/pdfium.git/+log/bf5be75f420c..c171a2106b2b

git log bf5be75f420c..c171a2106b2b --date=short --no-merges --format='%ad %ae %s'
2019-09-23 thestig@chromium.org Split shading rendering code into its own file.
2019-09-23 nigi@chromium.org Fix the TrueType font not rendered correctly issue.
2019-09-23 thestig@chromium.org Add a test for a checkbox that does not print.

Created with:
  gclient setdep -r src/third_party/pdfium@c171a2106b2b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=pdfium-deps-rolls@chromium.org

Bug: chromium:861842
Change-Id: I3604d12cde621e4abd689d4d48e2c6cdac78adb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819133Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699007}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/605c2e3c0ea7..3a762d54f649

git log 605c2e3c0ea7..3a762d54f649 --date=short --no-merges --format='%ad %ae %s'
2019-09-23 dsinclair@google.com Add missing GN dependency (#2899)
2019-09-23 afdx@google.com Employ the "swarm testing" idea in spirv-fuzz (#2890)
2019-09-23 afdx@google.com Fix operand index in spirv-fuzz (#2895)
2019-09-23 dneto@google.com Update DEPS: effcee, re2, googletest (#2881)
2019-09-23 dneto@google.com Add method comment for opt::Function::WhileEachInst (#2867)
2019-09-20 stevenperron@google.com Use OpReturn* in wrap-opkill (#2886)
2019-09-20 afdx@google.com Fix to CMakeLists for spirv-fuzz tests (#2888)
2019-09-20 afdx@google.com Allow validation during spirv-fuzz replay (#2873)
2019-09-20 afdx@google.com Disable long-running fuzzer tests by default (#2887)
2019-09-20 stevenperron@google.com Revert "Use OpReturn* in wrap-opkill"
2019-09-20 stevenperron@google.com Use OpReturn* in wrap-opkill
2019-09-19 ehsannas@gmail.com Fix header include syntax. (#2882)
2019-09-19 stevenperron@google.com Handle OpConstantNull in copy-prop-arrays. (#2870)
2019-09-19 dneto@google.com Fix comment typo found by protobufs linter (#2884)
2019-09-19 dsinclair@google.com Move docs into docs/ folder (#2872)

Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@3a762d54f649

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com,dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com,dsinclair@google.com

Bug: None
Change-Id: I77a97a0a64eb19f82d4d6eb65a8f088c5ee8ffb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819101Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699006}

This CL:

* updates parseLocalizableResourceMaps to return maps of localizable
resources
* removes localizable resources from exports
* fixes non-async functions
* fixes existing parsing error

This CL is in preparation of https://crrev.com/c/1671848.

Bug: 941561
Change-Id: Id18faf3086fb8d9d3c75b110733784ba95cf56e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814539
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699005}

Change-Id: I7ecb680714be3a4459fb49bb8290eec66d5295a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816447Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699004}

Change-Id: I5ff12697f60a2d98f979823f2179aafd5cdc409b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810841
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699003}

https://android.googlesource.com/platform/external/perfetto.git/+log/eb06d51adc82..d239d4d3493a

git log eb06d51adc82..d239d4d3493a --date=short --no-merges --format='%ad %ae %s'
2019-09-23 skyostil@google.com Merge "Disable leak sanitizer tests on debug and embedder builds"
2019-09-23 treehugger-gerrit@google.com Merge "Fix comment referencing GetLastError."
2019-09-23 taylori@google.com perfetto-ui: Fix build
2019-09-23 primiano@google.com Merge "PacketStreamValidator: get rid of libprotobuf"
2019-09-23 hjd@google.com Merge "perfetto-ui: Add search for userland slices"
2019-09-23 nicomazz@google.com Perfetto UI: Fix unresponsive probe clicks
2019-09-21 primiano@google.com Merge "Do clang-format on gpu_counter_descriptor."
2019-09-20 lalitm@google.com trace_processor: remove virtual track table and replace with async track table
2019-09-20 lalitm@google.com Merge "trace_processor: add hint flags indiciating the content of the column"
2019-09-20 treehugger-gerrit@google.com Merge "perfetto-ui: Fix snake_case variable"
2019-09-20 primiano@google.com Enable sanitizer tests only on Linux/Android
2019-09-20 fmayer@google.com Merge "Use trace processor for `trace_to_text symbolize`."
2019-09-20 lalitm@google.com Merge "bazel: expose merged proto to Bazel"
2019-09-20 rsavitski@google.com Merge "Fix build rules in tools"

Created with:
  gclient setdep -r src/third_party/perfetto@d239d4d3493a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: chromium:135177627
Change-Id: I2fd2001d5e318a7e09cc31c403a9576f085645f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819134Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699002}

This is a followup of crrev.com/c/1816800.

Currently these flags control not only the demuxing, but the platform
support in some cases. Rename the flags so they become generic flags
controlling platform codec support.

Updated:
- enable_ac3_eac3_audio_demuxing
- enable_mpeg_h_audio_demuxing
- enable_dolby_vision_demuxing

Also updates the corresponding buildflags.

Test: No functionality change.
Change-Id: I0c8e504bf922232d3eadef1803bd34a598c87179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817025Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699001}

The patch introduces a feature toggle that can enable sync datatype in
DeviceInfo for users that are signed-in but not sync-ing.

In this simplest form, the regular instance of the model
(DeviceInfoTracker) is reused and storage is persistent. Follow-up
patches will polish this behavior.

The patch also introduces the first sync integration tests for
DeviceInfo, both prior to and after the newly supported transport-
only mode (i.e. sync the feature not enabled).

Bug: 1005651
Change-Id: I7399139f0ea506654d2df80e7c8e508853bec408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816560
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699000}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/16f6f6e4dd63..1f5e48f34c74

git log 16f6f6e4dd63..1f5e48f34c74 --date=short --no-merges --format='%ad %ae %s'
2019-09-23 jclinton@chromium.org cbuildbot: Add firmware hack for upload to GS dir prefixed by board

Created with:
  gclient setdep -r src/third_party/chromite@1f5e48f34c74

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I78316d4f5960f381a4b155e62b0cef503f58aa46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819102Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698999}

This broke the build with MSSTL and libstdc++ (introduced in crrev.com/c/1786449)

Bug: 957519
Change-Id: If4fdb2c4e08202d5a36870292138978ac68a5a4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817205
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Auto-Submit: Jeremy Apthorp <jeremya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698998}

This source file was getting a bit hard to read. So some minor cleanups:

  * Pull the window tree host out into its own source file. Rename to
    CastWindowTreeHostAura to reflect naming scheme elsewhere in
    chromecast/graphics. (CastFocusClientAura, CastWindowManagerAura,
    etc.)
  * Move CastLayoutManager into the anonymous namespace
  * Fix order of methods in the window manager header.

Bug: none
Test: build & unit tests
Change-Id: I1e9f6a3ac30417b9f02ddf2c9d4439eb7b3bc734
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819639
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698997}

The code has been updated with self-evident variable names, so we can
delete the obsolete comments.

Bug: none.
Test: manually.
Change-Id: Ia73d990edb8d223b35a30ab621ca48e1ec7595c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819682Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698996}

This has the following benefits:
- It forces us to consider data duplication across FrameNavigationEntry
  and PageState/ExplodedFrameState (e.g. url and referrer today).  The
  CL makes the FrameNavigationEntry the authoratitative source of the
  information.
- It is a prerequisite for persisting the |initiator_origin| of a
  navigation inside ExplodedFrameState (see also
  https://crrev.com/c/1679162).

Because of the above, this CL changes the code so that:
- Calls to NavigationEntryImpl::GetPageState *always* go through
  RecursivelyGenerateFrameState (before this CL this wasn't
  true for single-frame pages).
- Calls to NavigationEntryImpl::SetPageState *always* go through
  RecursivelyGenerateFrameEntries (before this CL this wasn't
  true for single-frame pages).

As a consequence of the changes above:
- Test Impact: Tests can no longer use an arbitrary string as the PageState
  (although empty string as a PageState is still supported).
- Performance Impact: The call to NavigationEntryImpl::SetPageState
  always (not just for multi-frame pages) will drop old
  FrameNavigationEntries and create a new tree of
  FrameNavigationEntries.
- Deserialization/Restore Impact: Session-restore code needs to take
  care to supply a correct PageState.  In particular, care needs to
  be taken to avoid using an empty PageState (see the changes this CL
  makes in sessions::ContentSerializedNavigationBuilder::ToNavigationEntry
  and android_webview::<anonymous>::RestoreNavigationEntryFromPickle).

Bug: 976055, 999078
Change-Id: Ica7036111fcbea1ddcb44acda8e4c8b21166a531
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787868Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698995}

This is CL [2/4] in a series of CLs to expose "display: none"
elements to the browser process AXTree.

1. Add and improve tests for CSS display and visibility.
2. Introduce new command line flag and chrome://flags entry.
3. Update AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree
   and relevant logic for the feature to work, disabled using the
   feature flag.
4. Enable the feature in tests; update expectation files.

---

In this change I added a new RuntimeEnabledFeature flag and an
associated chrome://flags switch entry to enable the feature.

This CL does not use the flag, but prepares for use in CL [3/4].

Bug: 651614
Change-Id: I5cd4b517820a593994318d30a3ace8692e40a754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809610
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#698994}

Chrome now supports fuchsia, but t_a_extractor.exe does not. So when
compiling it, we need the `--without-fuchsia` flag.

Change-Id: I04648ae7aaeeb550d3ba4585f7b61bb2423ada3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815912
Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698993}

Just fixing casing of the name SuperSize in the links output by the
binary size trybot.

Change-Id: I7ea4a55139d964f280d06346f80b0f1f8579a68d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819108Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698992}

Bug: 1002711
Change-Id: Ie2cbd988b27c0342edbf24626727916875e04841
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801915
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698991}

Bug: 977170
Change-Id: I79acbb3d4f1fd13449c515b8fc7e8731bf470296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819561
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698990}

https://skia.googlesource.com/skia.git/+log/e7bd1cb4f650..d166d2e62f3b

git log e7bd1cb4f650..d166d2e62f3b --date=short --no-merges --format='%ad %ae %s'
2019-09-23 ethannicholas@google.com SkSL interpreter now properly short-circuits boolean operators
2019-09-23 robertphillips@google.com Create a GrGpu::createBackendTexture choke point
2019-09-23 bsalomon@google.com Remove a few GrSurfaceProxy::config() usages

Created with:
  gclient setdep -r src/third_party/skia@d166d2e62f3b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@google.com

Bug: None
Change-Id: Ide3056d3de83ecb282dc26fc018b841bc2fe00ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819099Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698989}

Following WebGPU spec change at https://github.com/gpuweb/gpuweb/pull/414,
this CL adds a default value to offset in setIndexBuffer.

Bug: 877147
Change-Id: I15709fb73f4121a023a2b871a1232824f16b6460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815021
Auto-Submit: François Beaufort <beaufort.francois@gmail.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698988}

This matches LayoutDeprecatedFlexibleBox, which uses
ClampToZero() in a couple of places.

BUG=993813
TEST=fast/deprecated-flexbox/002.html

Change-Id: Ib6a9abfbc50759fa7c819046ee4f173bb67ba06c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809105
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698987}

Currently the "content_security_policy" manifest key is restricted to trunk.
However it is mandatory for Mv3 extensions. Hence, always allow it if the
manifest version is 3.

Also, make some other minor cosmetic changes.

BUG=993530

Change-Id: Ifca0c588d923a36644002e865f853d74533d7356
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815277
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698986}

To reduce thread hops when generating VideoFrames, this CL adds
PooledSharedImageVideoProvider.  It builds on the direct provider by
maintaining a pool of SharedImageVideo objects, which it hands out
on its own thread to clients.

It also adds histograms to track VideoFrame creation time, so that
we can see which device(s) benefit from pooling.

All of this is turned off by default; it must be switched on by
enabling UsePooledSharedImageVideoProvider.

Change-Id: I4cfc03938dd4717252f3f527a3bcab0e7ae085a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699138
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698985}

Adding a new interface to AutocompleteEditText as a go-to observer to
use. The existing one UrlBar.UrlTextChangeListener with the method
onTextChangedForAutocomplete is very specifically tied to the lifetime
of the native autocomplete counterparts. Having a generalized observer
open to java features is preferable.

Bug: 1002130
Change-Id: If171d1266e4ab0a2aeeb494badac5266ee5461a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792240
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698984}

******************************Resource Sizes Diff******************************

Specifics:
       +73,728 bytes main lib size
      +620,276 bytes main dex size
    +1,046,995 bytes normalized apk size
InstallSize:
      +398,048 bytes APK size
    +1,123,771 bytes Estimated installed size (Android Go)
    +2,903,963 bytes Estimated installed size
InstallBreakdown (+2,898,339 bytes):
        +3,954 bytes Native resources (no l10n) size
        +2,284 bytes Non-compiled Android resources size
       +73,728 bytes Native code size
        +3,412 bytes PNG drawables size
          +637 bytes Package metadata size
    +2,786,312 bytes Java code size
       +28,012 bytes Compiled Android resources size
Dex:
        +2,963 entries fields
        +2,507 entries strings
        +3,770 entries unique methods
        +1,270 entries types
        +3,770 entries methods


Bug: 948739
Change-Id: I65320fcf8c554eae07a1563134701747a7edeecf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815906Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698983}

Specifically, for positioned elements in a webkit-box with
a column orientation. This matches similar code in
LayoutDeprecatedFlexibleBox::LayoutVerticalBox.

BUG=993813
TEST=fast/deprecated-flexbox/012.html

Change-Id: Ibad9868a077d3a1ff62f2b2844cb086b78c33612
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809526
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698982}

Accessibility testing revealed the following issues within the tool:
1. no label for the group by combobox
2. link is not keyboard accessible

This change adds:
1. better aria-placeholder for filter input bar
2. aria-label for icons and group by combobox
3. context menu for links

Bug: 963183

Change-Id: I63f343e4cc056468c3e640b735b50f7bec3051c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633332Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#698981}