GitLab

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I6796f9607a75c620f5bc7a8a0fd9d8828752b93e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611812Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#840340}

Shaves off ~500ms off of blink_public_mojom_mojom_platform

With python3 & change applied, logs on my machine:
I     18 Started (mojom_parser.py)
I     30 Parsing 177 .mojom into ASTs
I   2117 Processing dependencies
I   2342 Loaded 92 modules from dependencies
I   2342 Ensuring inputs are loaded
I   2488 Serializeing 177 modules
I   2958 Finished

Bug: 1143399
Change-Id: I926e9ea71b44b1b754ab00b0c42dd718922fdd1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605873Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840339}

Text fragments have been enabled in stable since M80 so we can now
remove the flag. The runtime feature remains since the feature can still
be disabled via enterprise policy so this just removes the about:flag.

Bug: 919204
Change-Id: Ifccc631362795c35dc0ac2fd78c519916cb28066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606129Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840338}

Prior to this patch what was the non-snapshotting backend did not use
timestamps. This is racy, as it means the file is potentially in a bad
state if WebLayer were to crash before the initial state was written.
This changes the kOther backend to use time stamps.

This required some changes in the WebLayer to deal with the
additional files.

BUG=648266
TEST=covered by tests

Change-Id: I232cdfbf44ddc90b8942048d92028a646d746a8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605525
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840337}

flat_map construction prefers taking a vector so that it need only be
sorted once (and it happens that here, it will always be correctly
sorted) rather than having to do a binary search for each insertion.

host_model_features is also now searched only once, rather than once in
contains() and another in find(). Technically it could be searched
slightly more efficiently (given its sorted order is guaranteed to match
the other two flat trees here), but this is slightly awkward to do and
so I'll stop this premature optimization short of doing that.

Change-Id: I9ce61d68c16e63cefbcd2d758bee522696f6528d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605649Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840336}

The maximum animation scale may be unknown in the following cases:

1. ui:TransformAnimationCurveAdapter's AnimationStartScale() and
MaximumTargetScale() always return false for any animation curve, making
cc not able to optimize raster scale for ui transform animations.

2. When the maximum animation to screen scale can't be computed, e.g.
when there are nested scale animations.

This CL partly reverts crrev.com/c/2566053 for the case that the scale
is unknown by using the native scale.

For 1, in the future we need to
1. distinguish translation-only transform animation (scale==1, but
for now kNotScaled) and transform animations with non-computable scale
(scale==kNotScaled).
2. implement ui::TransformAnimationCurveAdapter scale methods
(crbug.com/1161586).

Bug: 1157407, 1163100
Change-Id: I104261aa4c9400eded02e850bd2cc0e61394e2ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602699
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840335}

The handler is meant to be called repeatedly so convert to
RepeatingCallback. The caller already uses BindRepeating.

Bug: 1152268
Change-Id: I62af30b2ce6fa0234a7efd5f2788c4e045c25a00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605876Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840334}

* PredictionModel was using SequenceChecker incorrectly, to no effect.
  Since the fields it was guarding are immutable, this sequence check
  was in any event unnecessary. Instead, the members have been made
  const.

* PredictionModel::model_info_ was never set or read. It is removed.

* The PredictionModel constructor has been made explicit, consistent
  with Chromium style.

* The code was very inconsistent about whether optimization_guide::
  qualification was used. For consistency, brevity and style it has
  been rewritten in these places to not be qualified.

* It is inefficient to construct a flat_set by repeated insertion.
  It is equally easy, and preferred (see base/containers/flat_set.h)
  to construct a vector that can be sorted on construction. This
  reduces complexity from O(n^2) to O(n log n).

* PredictionModel::GetModelFeatures returned a copy, unneecessarily.
  It now returns a const reference.

* Fewer conversions between std::unique_ptr<proto::PredictionModel>
  and const proto::PredictionModel& are now done. std::unique_ptr
  is left where ownership is passed or where it interfaces with
  other code that uses unique_ptr in a more complicated way. This
  reduces copies and heap allocations. Regrettably it requires a
  number of trivial changes to the unit tests.

* DecisionTreePredictionModel::ValidateTreeNode's node_index argument
  is changed to int, which is more efficient and more usual than
  const int&.

Change-Id: Ib6b9d77d4f5941f578d3213c323ead01319715b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607485
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840333}

The trial is no longer active (Document Policy has shipped) and
so this configuration is no longer needed.

Bug: 993790
Change-Id: Iaefea88f07c123a68f742de301dc83160df21465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600034Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Charlie Hu <chenleihu@google.com>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840332}

This is a reland of bb97ab9b

I believe all of the breakages we encountered on the first
go-round have been fixed.

Original change's description:
> Force Python 3 to be used in build.
>
> This CL makes Python 3 be the default script executable used by Ninja
> to run action() and action_foreach()'s during the build.
>
> This does *not* mean that everything works with Python3; many targets
> may still use Python 2 via the python2_action() and
> python2_action_foreach() targets or via custom logic.
>
> However, it does mean that it should prevent regressions from
> creeping in.
>
> This CL should not be taken to imply that we can start to write
> Python3-specific code that can run during the build; we should
> still be trying to ensure that everything is compatible with Python2.
>
> Also, this CL does not enable the use of vpython in actions; we should
> still avoid that because vpython is slower than direct Python
> invocations.
>
> Bug: 1112471
> Change-Id: I472b032b500715156d955b0758640a7ed0384305
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#836234}

Bug: 1112471
Change-Id: I075999ef45df00708fabe480d4b71fdbf25a2ba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591588
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840331}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-win-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: Ib470f5bf4c8969d112c79c13fdaaa73a064d3401
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611813Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#840330}

It looks like we are getting some crashes on VrModule.getImpl() even in
versions where we use SplitCompatAppComponentFactory. I suspect this is
due to the vr preload, so disabling to see if it stops crashes. If this
works, I'll see if there's anything we can do to prevent crashing with
the preload.

Bug: 1142589
Change-Id: I7de6c48edbb9d0a37ee271bff49295912b549d53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611847Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840329}

This causes trichrome's dex to be compile with "speed" rather than
"speed-profile", which is a substantial binary size regression.

Also adds a histogram to track when the work-around happens.

Bug: 1152970, 1159608
Change-Id: I25e2c350b54724613234b23505078f5df88d9cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602657
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840328}

Bug: 1152274
Change-Id: I6677026925fc0914197e51de557ab5df37d08c39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595835Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840327}

This change introduces a count histogram for the number of routines a
user runs during one session in the Diagnostics App. The count starts at
zero each time the app is opened, and it is emitted when the app is
closed.


Bug: 1128204
Change-Id: I5dc7eec4f33006a9694c6c694d5a83a06d59a3a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570345
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840326}

This flag has been matching the value of the overlay-scrollbars flag
since M63 so we can remove it. It's used in the corresponding
LayerTreeSettings member. The setting can now (remain) always-disabled
on Android and enabled on other platforms whenever overlay scrollbars
are.

Bug: 746342
Change-Id: I799dcfd52e97d0ee1745ad73d19951341e9f25f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605883Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840325}

This change implements a new NetworkCallback class used for listening to
changes to the default network on Android.  It includes two fixes:
1. Avoids calling synchronous ConnectivityManager methods which
   is prohibited inside NetworkCallbacks.  This is a preemptive fix, not
   known to actually be causing issues.
2. Catches onCapabilitiesChanged() which includes cellular connections
   transitioning to and from SUSPENDED states.  Failing to catch this
   could leave the NetworkChangeNotifier in an incorrect disconnected
   state, see crbug.com/1120144.
This new NetworkCallback is used on Android R and newer versions to
limit retesting and as these are the only versions experiencing issues.
I've tested this thoroughly on Android R.  Additional automated testing
isn't feasible given the code's closeness with Android APIs involving
immutable classes with no public constructors (e.g. NetworkCapabilities).

Bug: 1120144
Change-Id: If77d4524f8f8e0be78563412176c2ea2d07f00c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605304
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Auto-Submit: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840324}

Notable differences from the existing fake CI bots:
1. Instead of splitting the bots by dEQP/non-dEQP they are split now by
   Chromium/ANGLE-specific, which means:
2. Suites which don't depend on Chromium, like angle_end2end_tests and
   angle_perftests now run together with dEQP suite.
3. Some tests suites were removed from ANGLE bots - gpu_unittests,
   as well as all GLES2 conformance tests.

Bug: angleproject:4483
Change-Id: I5aac17351c8067c6f53a1527be3285cbd80822ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603577
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840323}

Due to the fact that we reuse TSF document for text fields with same
input type, we should property reset the state by clearing focus before
re-using the document.

Bug: 1162974
Change-Id: Ia92187705e93cc064e992e28c8638d5647e06ea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610147Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Reviewed-by: Siye Liu <siliu@microsoft.com>
Commit-Queue: Siye Liu <siliu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#840322}

The current token expired on December 29th, and should be updated.

Change-Id: Ia7dbcd367b5bb0ba6b536b0bd44fba5039fbaa19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611688
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840321}

Bug: 1157892
Change-Id: I386fb6bc5377c0a32c504eac5d8f0f92497a2943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599446Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840320}

BUG=1157672

Change-Id: Ib31d8dd60486f8634d9477ad82d5d9bbbc095dea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590428
Commit-Queue: Alice Gong <alicego@google.com>
Reviewed-by: Marc-André Decoste <mad@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840319}

Bug: 1027683
Change-Id: Idd35bc8cdb81f7e04ddfd997d28d128902e1ee4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611288
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840318}

This CL adds a lacros browser test that creates a lacros window,
triggers overview mode, and then closes the window while overview mode
is still active.

Change-Id: Ib16b9f8dedabc49a3f1722bd6416f9c99ec7a8fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601260
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840317}

This class added an unnecessary layer of complexity to access
memory instrumentation functionality.

Follow-up: Rename //services/resource_coordinator/ to
//services/memory_instrumentation and remove "memory_instrumentation"
subdirectories.

Change-Id: I556423d2004ab0d2b2462ae5b0cac529712d50de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593829Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Auto-Submit: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840316}

Bug: 1149691
Change-Id: I9d89fed2bab361c8ea34d24ed0a42f40041b09d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593246
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840315}

This CL converts a pattern in extensions tests where a RunLoop quit
closure is bound to a callback argument. In most of these cases we can
simply convert to a OnceClosure.

printer_provider_apitest has one exception that's a RepeatingClosure
because the API actually may call the callback multiple times. In this
case, the quit closure must be copied so it must be a RepeatingClosure.

Bug: 1152268
Change-Id: I4a201cbd78d818f1793b94a8c106d62bb59ba8f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605647
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840314}

This is the usual boilerplate in SessionManagerClient and friends to
expose the new function.

BUG=chromium:1073940
TEST=None

Change-Id: Id9144ac921d8ab5f26f0874da9476838a3ebef5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560271
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840313}

This saves significant time in offer/answer.

Bug: webrtc:12215
Change-Id: Ifec4e8fbb630f09b68299b880a94055f7a068027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596266Reviewed-by: Markus Handell <handellm@google.com>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840312}

Disable showing of offline pages using finch.
This will be used to disable showing offline pages on Android
R and later where offline detectivity is broken.

Bug: 1138728, 1120144
Change-Id: Ic0665a117981ef91f85807f33818dabb3d08cca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564217Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840311}

Seems that WebViewImpl may be null, but that doesn't make much sense.
Add a few checks to see if they fire.

BUG=1160652

Change-Id: I5979a5ad62d91f9b8868d5ce72f29b47297e2c56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611126Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840310}

Add instructions for rubber stamping expectations.

Bug: 1159542
Change-Id: Ifc546f0e8915ed2291322d4af38a8066c40ac728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611667Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840309}

This CL updates each card in the OS Settings page such that rows that
appear at the very top of the card do not have top borders to prevent
double borders caused by a top border and the card's shadow.

Bug: 997034
Change-Id: I0a5a3ee7810bcfc994103ac8eea06e17b43fe2fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605625Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840308}

This CL changes LocalToRemoteSyncer::Continuation from Callback to
OnceCallback.

Bug: 1152272
Change-Id: Ie839b5982775429332c48d9c3930151a74f42423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604677
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840307}

TBR=govind@chromium.org

Change-Id: I562a07104074aba6a105abc5c9f9ad04dd854003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611525Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840306}

This renames SiteSettingsClient to SiteSettingsDelegate to match other
similar interfaces, and merges SiteSettingsHelpClient and
WebappSettingsClient into SiteSettingsDelegate so there's only one
interface for embedders to implement.

Things were originally split into multiple interfaces to help group
methods together and make it easier to reason about. Whether or not that
actually worked is debatable, but now that we've removed the need for
multiple of these sub-interfaces, the 2 that remain should be merged
into the main one.

Bug: 1077007
Change-Id: Ia02d8e47d38d1b4878b4a4d0cda5ccbb74de6352
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594441
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840305}

Noticed when trying to enable UnnecessaryParentheses that many generated
files were failing the check. It is likely not worth fixing errorprone
checks for generated files, and we can save on build times by not
compiling generated files with errorprone.

Bug: None
Change-Id: I52f69d3d69dfe61e78143cffd34700e5ada05bb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606128
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840304}

Screenshot: https://screenshot.googleplex.com/iGaHZcsb7RMuKDB.png

Bug: 1093185
Change-Id: I09ccf1b5cbe68ebcf479727cd616710578ca6e06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611334Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#840303}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: If6cf34eb2161289cb3551ca44dee6e4acf841d1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611112
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#840302}

I'm no longer actively working on Chromium.

Replace myself with smcgruer@ in most places. Note that
third_party/blink/web_tests is already owned by all committers (*) and
the OWNERS files within are only informative.

Regarding blinkpy, Stephen has made significant contributions there:
https://chromium-review.googlesource.com/q/owner:smcgruer%2540chromium.org+blinkpy+-%2522import+wpt%2522+-%2522roll+wpt%2522
so I'm confident with this nomination.

Change-Id: I38eac7d102ecf86dc9273acde496ca6d9d072c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611086Reviewed-by: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840301}