- 18 Jul, 2018 40 commits
-
-
rbpotter authored
Use ListPropertyUpdateBehavior to avoid always changing the full list when new destinations load. Observed a ~10% improvement in time to refresh the list when cloud destinations were added to destination store. Bug: 773928 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I11c00701c8c3dd1c8f3bf06937a72d3640ff43c5 Reviewed-on: https://chromium-review.googlesource.com/1141083 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#575962}
-
Matt Falkenhagen authored
Change-Id: Iaee118571685b3018bcf377391953543e73733f0 Reviewed-on: https://chromium-review.googlesource.com/1141452 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#575961}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/59113645075d..77552dbce365 git log 59113645075d..77552dbce365 --date=short --no-merges --format='%ad %ae %s' 2018-07-18 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 d691aeeb956f..04f0f133032c (2 commits) 2018-07-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@77552dbce365 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I274d9b36b85f7a4f16ee9dc781ae2c8276bea3ee Reviewed-on: https://chromium-review.googlesource.com/1140695Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575960}
-
Oscar Johansson authored
When building using jumbo, files may end up in the same scope. In chrome/browser/ui, ui elements defined with the same name in both browser/ui and browser/ui/cocoa conflict. This is relevant for the classes: HoverButton ReloadButton TabStripController TabController NewTabButton BookmarkBarView DownloadShelfViewCocoa ToolbarButton AvatarButton SadTabView AlertIndicatorButton ToolbarView This commit solves the issue by adding "Cocoa" to the classes defined in chrome/browser/ui/cocoa. This is changed in chrome/browser/ui/cocoa and ui/base/cocoa. Bug: 803406 Change-Id: Iafd3b9447e4ed6960d86d43d12213ad367919357 Reviewed-on: https://chromium-review.googlesource.com/1140055Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#575959}
-
Luciano Pacheco authored
Fix issue where My files doesn't propagate updates in the directory tree when folders are displayed or hidden. Test: Integration test and checked that it fails without the fix. Bug: 864453 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2e7cee1b0d34bccb7d417d650ede04b9bd5aa6fd Reviewed-on: https://chromium-review.googlesource.com/1141454Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#575958}
-
Tetsui Ohkubo authored
This CL fixes two issues: * Fix do-not-disturb button to turn on DND automatically on the label click. * Fix network button to ignore the icon click when Ethernet is connected. TEST=manual BUG=859831,861709 Change-Id: I064db9687084ac21aa9a059b7cd90f740e734d4d Reviewed-on: https://chromium-review.googlesource.com/1139849 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#575957}
-
Nigel Tao authored
Launch_container is more consistent with the existing terminology in extensions/common/constants.h Change-Id: I695f28353b8adc7d13851cd1447bad262619ab47 Reviewed-on: https://chromium-review.googlesource.com/1141444Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575956}
-
Christopher Lam authored
This may have been fixed, re-enabling to gather data. BUG=734716 Change-Id: If5400ae8e7ee202ba367d6f7fdeb71a1e4798ff7 Reviewed-on: https://chromium-review.googlesource.com/1140018Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#575955}
-
Koji Ishii authored
This patch rebaselines space and tabs only differences from the build 8046, as per the test result viewer. TBR=xiaochengh@chromium.org, yosin@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic26ffff722dcd3503489199456a0d115e7bf04ae Reviewed-on: https://chromium-review.googlesource.com/1141463 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#575954}
-
Jia authored
Change-Id: I163da12c827cb4880b561bf4099abdd758d17031 Reviewed-on: https://chromium-review.googlesource.com/1141456Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#575953}
-
kristipark authored
Add API to support adding/deleting custom links. Once custom links are enabled, MV tiles are "frozen" and converted to custom links. Design doc: go/chrome-ntp-custom-links Bug: 856394 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib3255d7253fa9964b6f7845edf5cba4be2fa3db9 Reviewed-on: https://chromium-review.googlesource.com/1124104 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#575952}
-
Christopher Lam authored
This CL adds support to the Mojo JS Externs generator for Constants and Enums so they can be used with the Closure Compiler. It also fixes an issue with conflicting modules. Bug: 864298 Change-Id: I1d3412ab21b638c16b6aa332165bfff1cee45bb6 Reviewed-on: https://chromium-review.googlesource.com/1139453Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#575951}
-
Yutaka Hirano authored
Mark virtual/scroll_customization/fast/scroll-behavior/scroll-customization/scroll-customization-property.html as failing Bug: 864891 Change-Id: Iff16e5ae02793ffb9d0afb0a806b92ea0ea08b1b Tbr: ekaramad@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1141458Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#575950}
-
Koji Ishii authored
This patch rebaselines one text dump differences which is as intended, and two 1px line position differences in vertical flows. From the manual review of build 8046. TBR=cathiechen@tencent.com NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4de0239b88bb3f7bf06e829c0f9f5a3e62f20000 Reviewed-on: https://chromium-review.googlesource.com/1141457 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This patch implements |std::string DumpSelectionInfo()| so that we can check a SelectionStatus tree with text diff. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib42cebfc5a7f1908a4e748f622bbdae9c24987c6 Reviewed-on: https://chromium-review.googlesource.com/1136335Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#575948}
-
Yutaka Hirano authored
Bug: 864888 Change-Id: I2cd98b7c79479f7a5965fdbf9ef2182cb578d5a2 Tbr: yosin@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1141455Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8e0c0dbc4876..89063ecda876 git log 8e0c0dbc4876..89063ecda876 --date=short --no-merges --format='%ad %ae %s' 2018-07-18 thestig@chromium.org Improve image size validation in CPDF_ScaledRenderBuffer. 2018-07-18 thestig@chromium.org Simplify CPDF_Creator::InitID(). Created with: gclient setdep -r src/third_party/pdfium@89063ecda876 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I095055060147434724d4269cbac046344fb3e385 Reviewed-on: https://chromium-review.googlesource.com/1141464Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575946}
-
Yutaka Hirano authored
Bug: 864887 Change-Id: I9210134ed670cd46026cd6f9d83a6336460ea140 Tbr: sunyunjia@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1141453Reviewed-by:
-
Tatsuhisa Yamaguchi authored
As a known issue, this doesn't respond to turning on/off the docked magnifier. Test: manually verified by rotating screen and zooming by ctrl-shift-+. Bug: 862575 Change-Id: I7e74b4ce701c017b77df59cce00a30b0c3ebc821 Reviewed-on: https://chromium-review.googlesource.com/1134633Reviewed-by:
-
Sam McNally authored
When an onDirectoryChanged event is received for that grand root, rescan the grand root and update its visiblity in the UI. Bug: 854153 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie36dabdd9348e7c174a22438b29ce8953c81d68e Reviewed-on: https://chromium-review.googlesource.com/1136332Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#575943}
-
Adam Rice authored
Remove the constants kMaximumValidPortNumber and kInvalidPortNumber from kurl.cc as they are confusing and don't actually do anything. Also change remaining CHECKs in KURL::Port back to DCHECKs now that we have confidence the change is safe. Also make the method comment less confusing. BUG=606462 Change-Id: I4719b8611cc6f3f0c5f488d8c86f3b6b8ad6d88f Reviewed-on: https://chromium-review.googlesource.com/1127083 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#575942}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I68c759b8cb4d6672e58699454053481adf6c7afd Reviewed-on: https://chromium-review.googlesource.com/1141273Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#575941}
-
Tetsui Ohkubo authored
Tab focusing to notification control buttons was broken in UnifiedSystemTray because UnifiedMessageCenterView did not implement the same OnDidChangeFocus logic as MesageCenterView did. TEST=manual BUG=862506 Change-Id: Ide2d9e170ecefcc87db2d43b6d8d3b1042492374 Reviewed-on: https://chromium-review.googlesource.com/1132907Reviewed-by:
-
Koji Ishii authored
This patch changes ascent and descent from LayoutUnit to integer, so that the use is consistent. In future, we'll want to switch to LayoutUnit, but inconsitent use is likely to be a source of problems than to help the migration. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I81bb766eaf4579b50bbe1896e48018b3aea81c20 Reviewed-on: https://chromium-review.googlesource.com/1075909 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#575939}
-
Keishi Hattori authored
When we set compositor_will_send_main_frame_not_expected flag when no PageSchedulers exist, MainThreadSchedulerImpl::BeginMainFrameNotExpectedUntil() never gets called. This means that StartIdlePeriod rarely gets called and the idle tasks may not be executed for a long time. After this CL, compositor_will_send_main_frame_not_expected will not be set when no PageSchedulers exist, so MainThreadSchedulerImpl will try calling RequestBeginMainFrameNotExpected next time. Bug: 862589 Change-Id: I06f9c813df6cc7270269d9ffb3a01f24b9c911ce Reviewed-on: https://chromium-review.googlesource.com/1134630 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575938}
-
Victor Costan authored
Change-Id: Ie3ad5785f82ccafdbcc630a5a26423ecc0b6c4bc Reviewed-on: https://chromium-review.googlesource.com/1137846 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#575937}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/829d1b2098b5..2c45cd174a95 $ git log 829d1b209..2c45cd174 --date=short --no-merges --format='%ad %ae %s' 2018-07-11 marpan vp9: Force hybrid_intra on scene change 2018-07-15 jingning Account for quantization effect in the tpl model 2018-07-16 jingning Assign estimate qp for overlay frame 2018-07-16 johannkoenig Revert "Enable tpl model for speed 0" 2018-07-13 jingning Use the estimate qp to set motion search control 2018-07-13 jingning Set the estimate frame qp in tpl_frame 2018-07-13 jingning Estimate the frame qp in a gop 2018-07-12 marpan vp9: Enforce intra search on scene_change 2018-07-12 jingning Refactor rc_pick_q_and_bounds_two_pass parameters 2018-07-11 wtc Backport libaom bug fixes. 2018-07-12 jingning Enable tpl model for speed 0 2018-07-12 jingning Use regular filter type for tpl model motion compensation 2018-07-11 jingning Clean up mc_flow_dispenser() 2018-07-09 jingning Add 32x32 Hadamard transform 2018-07-10 jingning Relax multiplier adjustment limit 2018-07-06 jingning Change the tpl model operating block size to 32x32 2018-07-06 paulwilkins Delete invalid assert. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I2c82f58f662c09c00139f5bd62f13888a94c7956 Reviewed-on: https://chromium-review.googlesource.com/1140786Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#575936}
-
Alex Moshchuk authored
While investigating issue 794625, I noticed that it is possible for RFHI::SwapOut to not actually create the proxy. This happens if (1) the RFHI to be swapped out is already pending deletion, and (2) the RFHI to be swapped out is not live. Nonetheless, the sole caller of RFHI::SwapOut, RenderFrameHostManager::SwapOutOldFrame, assumes that a replacement proxy is always created and unconditionally calls proxy->set_render_frame_proxy_created(true) afterward. This seems wrong - instead, the proxy should be set to be live if the IPC to create it was actually sent, which is what this CL does. I can't pinpoint any specific issues this might lead to, so this is more of a speculative/preventative fix for problems in this area. There's a chance it might be related to issue 794625, though in that issue, I'd expect the problem to be that we send a message to create a proxy to a process where the proxy had already been created, and here, the resulting problems would be from a proxy being marked as live without actually having been created. Bug: 794625 Change-Id: I7e3f53c17b541f9d5796714ef7c530a7955cf143 Reviewed-on: https://chromium-review.googlesource.com/1139215 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#575935}
-
Scott Chen authored
This CL changes the non-DICE welcome page to a custom element in order to reuse paper-button-style. This CL also updates the win10 welcome page's paper-button to use paper-button-style. Bug: 860274 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8678e89fb99fda64c0e5f1f54b53f2edeb14e3a9 Reviewed-on: https://chromium-review.googlesource.com/1138984Reviewed-by:
-
Daniel Murphy authored
R=pwnall@chromium.org Bug: 857464 Change-Id: I7f9206e1ac75c905ae35c44e44edfca0e8b82e0f Reviewed-on: https://chromium-review.googlesource.com/1140518 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dbdb3a00797d..0f5400acfa40 git log dbdb3a00797d..0f5400acfa40 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 steveanton@webrtc.org [Unified Plan] Implement FiredDirection for RtpTransceiver Created with: gclient setdep -r src/third_party/webrtc@0f5400acfa40 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I95a9d62e1d8b54f20f47d3a75ea619c5cc79d16f Reviewed-on: https://chromium-review.googlesource.com/1140623Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575932}
-
Amos Lim authored
Empty <input type=file> is represented incorrectly in FormData. If there are no selected files, then append an entry to entry list with name and a new File object with an empty name, application/octet-stream as type, and an empty body [1]. [1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set Bug: 840714 Change-Id: Ifadade1e260e0314664549df2d35f0cd38c76bea Reviewed-on: https://chromium-review.googlesource.com/1140236Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#575931}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3df683e6..65ea3e26 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib0d8e2febefd2f3b42417184c8304859fc87bdb2 Reviewed-on: https://chromium-review.googlesource.com/1141089Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575930}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/82b059ecb6a4..1b00ba716473 git log 82b059ecb6a4..1b00ba716473 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 dgarrett@google.com chrome_committer: Select service account per builder. Created with: gclient setdep -r src/third_party/chromite@1b00ba716473 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If19ec61c67987901f6ba8917e64fd971c4d0c128 Reviewed-on: https://chromium-review.googlesource.com/1141137Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575929}
-
Alex Kalugin authored
If two parallel gethash requests are running and the first fails but the second succeeds, then gethash error counters are reset and next_gethash_time_ is not. In this case all following GetFullHashes calls (until time is out) does not incur actual network requests and gethash result is improperly reported as MIN_WAIT_DURATION_ERROR, even though server did not sent min_wait_duration to the client. Example steps (implemented in unit test): - Initiate two separate full hash requests. - Make the first request fail. - Make the second request succeed. - Call GetFullHashes method. Expected result: - As long as the second request was successful, the following requests are run as usual. Actual Result: - Network request is not issued. - MIN_WAIT_DURATION_ERROR is reported to SafeBrowsing.V4GetHash.Result Change-Id: Ieeb08046515f87239ec00d9ad13b80c257b59435 Reviewed-on: https://chromium-review.googlesource.com/1119908 Commit-Queue: Alexander Kalugin <akalugin@yandex-team.ru> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575928}
-
David Tseng authored
Bug: 863093 Change-Id: I3307df10ca8c438c3683418f3e50c9e4859918bd Reviewed-on: https://chromium-review.googlesource.com/1136530Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#575927}
-
kristipark authored
These will be used in https://chromium-review.googlesource.com/c/chromium/src/+/1139108. Bug: 851293 Change-Id: I246bae76d785bea6426bbe6a170272cebcdcc079 Reviewed-on: https://chromium-review.googlesource.com/1141120Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#575926}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/252ec9191125..e2c00841a55f git log 252ec9191125..e2c00841a55f --date=short --no-merges --format='%ad %ae %s' 2018-07-18 yizhou.jiang@intel.com GenerateMipmaps should generate INVALID_OPERATION in ES 2.0 with EXT_sRGB 2018-07-17 geofflang@chromium.org Vulkan: Expose an unimplemented EGL_ANGLE_robust_resource_initialization. Created with: gclient setdep -r src/third_party/angle@e2c00841a55f The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ia51bf51d1d14bcdef45081568b482b499bb1b93f Reviewed-on: https://chromium-review.googlesource.com/1141139Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575925}
-
Joel Hockey authored
Change-Id: I339695d5f7f2a733c09d5d19a167c7fa2ed02d35 Reviewed-on: https://chromium-review.googlesource.com/1140344Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#575924}
-
Kent Tamura authored
We'd like to fix a confusing UI issue, and to know the impact of a possible fix. This relands #575575, which caused node leaks. If a document is navigated out while a file chooser is opening, ChromeClientImpl holded a strong reference to a FileInputType and the whole document leaked. This CL changes the reference from strong one to weak one. Bug: 637639 Change-Id: I5dccade80e433ac53de4bb205abab58380b0a5f2 Reviewed-on: https://chromium-review.googlesource.com/1140339Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#575923}
-
