- 21 Nov, 2020 40 commits
-
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I04ae76aa7c32c1e266375be85d0a78df7fb4fd1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553381Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829980}
-
Rune Lillesveen authored
Prepare for tree-scope specific CSSFontSelectors. Bug: 336876 Change-Id: I51a7e77d785df9cc404d3cc66bb5c8a179501239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550043Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#829979}
-
Zhaoliang Ma authored
Bug: None Change-Id: I3feb4c93e4b6b9ffe4187cb5e71623d0f2ce16f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551330 Auto-Submit: Zhaoliang Ma <zhaoliang.ma@intel.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#829978}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/068400262b84..55067f5fc677 2020-11-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4c5ce582b10f0eaa892897ad4a0387393adc3dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550852Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829977}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1605916713-5c2651f0c6431583f545a63fcbde858a51a7c7b1.profdata to chrome-mac-master-1605938293-d0094673cff9061368c7d398071897c24cf0b757.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iff9731a403d37fee48cc524e3c59c77793cdf34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553361Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605916713-42186a780bbf4a6606356f169d60384bd3619cf2.profdata to chrome-linux-master-1605938293-31eb6c6115dde673481dc80b9e3d062ea1588481.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id027dc456d062f9d0e157412788ccd1914f56498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553180Reviewed-by:
-
Judy Wang authored
This reverts commit 85559b2c. Reason for revert: <The latest change wasn't checked in!> Original change's description: > dark mode: Apply ash styling to overview "No recent items". > > Test: Manual test. > Bug: 1018302 > Change-Id: I50faaae459dba0126325c2a3b8225e8441b4b62c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536935 > Commit-Queue: Judy Wang <shidi@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829821} TBR=sammiequon@chromium.org,shidi@chromium.org Change-Id: I1b58c03b1eff4d1ee15218bd5dc146f7db28425d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553027 Commit-Queue: Judy Wang <shidi@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#829974}
-
Alison Maher authored
Forced colors should now happen at used value time. This change adjusts the used value of text-decoration-color, -internal-visited-text- decoration-color, column-rule-color, -internal-visited-column-rule-color, -webkit-tap-highlight-color, -webkit-text-emphasis-color, and -internal- visited-text-emphasis-color to take forced colors into account. No internal properties were needed since we only ever force these set of properties to currentColor in forced colors mode. The only remaining property to move to used value time is 'color'. Bug: 970285 Change-Id: Ica77609ce631f1768bdd52753535a484a32d3a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523664 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#829973}
-
Shakti Sahu authored
This CL 1 - Fixed a crash when there are no read/unread elements, and added more unit tests 2 - Adds IPH event when bookmark star icon pressed, and when bookmark folder is seen on bottom sheet Bug: 1151034 Change-Id: I61d3d95590282b837aa35b9371811c389fcfe1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548390Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829972}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a89c212b104..068400262b84 2020-11-21 vidorteg@microsoft.com [Loc] Migrate lighthouse panel to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I23cf4619188ffe31f137dd0725f45d9e86764d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552934Reviewed-by:
-
Jasmine Chen authored
Adds CameraActiveClientObserver for UI integration. - Pick a random class in the browser to make a class that extends CameraActiveClientObserver. - Register the observer with CameraHalDispatcher 1. Open camera 0 2. Close camera 0 3. Open camera 0, camera 1 4. Close camera 0 5. Close camera 1 - Verify the above steps work as expected. Bug: b:170075468 Test: Simplechrome. Manually tested by doing the following: Change-Id: Id8e2e0140562c9ee5f6d405ed8e84390fde8207d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489788 Commit-Queue: Jasmine Chen <lnishan@google.com> Reviewed-by:Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#829970}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fa2966f1..22f2e5ef Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie1982c093b8c43758a23adaef282bc2831b00091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553342Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829969}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e481e2bf2ea..2ee6d7025407 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I608371f1a43c3958c1e1253c15ca148ca0565a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553176Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829968}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I72e10ccd60cb6659a0fecf1450655ca91bdec7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552380Reviewed-by:
-
Toni Barzic authored
The thubmail loader is already checking whether the holding space item is a folder, but it used to return an empty bitmap in this case (relying on the placeholder icon creation to generate the icon; which relies purely on the file path, and may thus generate an incorrect icon - currently it generates a generic file icon; with this change this will be WAI). Instead, create the correct folder icon in the holding space thumbnail loader. BUG=1141034 Change-Id: I7d619adc892d2595284df210cefcab44f9279f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552370Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#829966}
-
Lachlan Ford authored
Implemented the genric-hand-select-grasp input profile on top of OpenXR using the XR_MSFT_hand_interaction interaction profile Change-Id: I31f9899d004700328186da5023eb1026f21a8989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533235Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Lachlan Ford <laford@microsoft.com> Cr-Commit-Position: refs/heads/master@{#829965}
-
Christopher Cameron authored
The helper function ImageData::ImageDataInCanvasColorSettings is used to convert between pixel formats and color spaces, using SkCMS. A simpler and more robust way to do this is to call SkPixmap::readPixels, specifying the desired format. ImageBitmap::ImageBitmap does this to create a bitmap from ImageData. R=yiyix TBR=fserb Bug: 1150969 Change-Id: I23e37d74d0a3519fafc9860e6b932a8fdb1a0e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551225 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#829964}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/040de9214830..e51c9068a84f 2020-11-21 cnorthrop@google.com Tests: Add Google Maps trace 2020-11-21 cclao@google.com Vulkan: Track specialization constant usage bit and feedback to ctx 2020-11-20 cnorthrop@google.com Tests: Add LEGO Legacy trace 2020-11-20 jdarpinian@chromium.org Misc. iOS fixes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: angle_perftests --gtest_filter="*google_maps*"Test: Test: angle_perftests --gtest_filter="*lego_legacy*" Change-Id: I744b155c5f86fab4bbd26e850871ce7fe802bd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552451Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605895128-0d0cfee41041bede7470dc9636efcf6ef0284e30.profdata to chrome-win64-master-1605905851-000df8c5d9233d8cd72a75f96d63436b1fbb2537.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia923ecfd724ad970cc30be58d05d73c4ee4113ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552726Reviewed-by:
-
Alison Maher authored
Forced colors should now happen at used value time. This change adds an internal property to store the forced colors value of outline-color. This internal value is then applied to the visited /unvisited outline-color at used value time when appropriate. The other forced color properties will be moved in follow up changes. Bug: 970285 Change-Id: I100438fbf9d5230f905a7d16067d387c65876448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518280 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/797831c3aa24..d90024d49829 2020-11-21 herb@google.com split subrun API into Blob and Op interfaces 2020-11-21 reed@google.com other ways to organize samplingoptions? If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: Ib364ca90ff0e06f562c1d67bf4110122232cbbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553303Reviewed-by:
-
Kevin McNee authored
Bug: None Change-Id: I3666cb3d44672ff800b12fb11bfc17aed5eae81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551263 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#829959}
-
Piotr Pawliczek authored
This patch switches the default parameter in Uri::GetNormalized(bool) method from false to true. As a result, simple call to Uri::GetNormalized() will return normalized form including port number. In the previous default (for parameter equals false), the port number is omitted when equals to the default scheme's port number. BUG=none TEST=unittests on my workstation Change-Id: Iee55e2f4eaa811c8b056e6b93d130eba922cc60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550587 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#829958}
-
Shimi Zhang authored
No logic change, just to update the link Bug: None Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ib29e01c0dcee4311a0da4d82727c68483e224ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553187 Auto-Submit: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#829957}
-
Ahmed Mehfooz authored
Bring fonts for system tray and secondary trays up tp new spec. Bug: 1145336 Change-Id: If5c102d94e21e1b84f5554896126e0acd681c77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548404 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#829956}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605873573-36e181f5df5da0c9aa7b43458275355d6ec5a576.profdata to chrome-win32-master-1605905851-758120749a95f1789e143f45329cd7e7ce463c52.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5027df9334d30dd6d299777c1c9fab8a5fecae48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553181Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6497e90dd284..5a89c212b104 2020-11-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-21 vidorteg@microsoft.com [Loc] Migrate animation panel to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1c6a326f88986ca895cd98f2632c5c7b10db582a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552452Reviewed-by:
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsTtsSubpage* Change-Id: I5a8ce723184396d9218e29d55799b24c7d61ee90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552253Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#829953}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/67965b97..fa2966f1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iffb3d753ba80799710b5276ace87bef92ded0440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550332Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a593bd1e937a..1e481e2bf2ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I0e62db1f31e3105871e959b95fa3195831de9438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552933Reviewed-by:
-
Tomasz Wiszkowski authored
This change fixes a problem, where a call to resetSelection() not only rewinds the selected suggestion position, but also selects the top suggestion, invoking an associated onSelect action. this causes problems with headers specifically, where HeaderSuggestion needs to clear the Omnibox input field when selected (eg. using DPAD on keyboard) as header suggestions do not have any associated suggestion text. This change ensures the resetSelection() call clears any currently selected input, allowing the keyboard management logic to let user select the first suggestion on the list by using DPAD down key. Tested on phones and tablets, with physical keyboard and accessibility features turned on. Bug: 1150877 Change-Id: Id794281e8aec33c5ea955b4ba0b4741d47237a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553152 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#829950}
-
Adam Langley authored
GMSCore is expected to start triggering caBLEv2, rather than doing caBLEv1, for accounts.google.com logins. This change allows it to send Intents to start Chrome to perform the caBLEv2 interaction. BUG=1002262 Change-Id: I557f89d3bb191b738fe50e6a2377573a334fdb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552623Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#829949}
-
Alison Maher authored
Forced colors should now happen at used value time. This change adjusts the used value of fill, stroke, -internal-visited-fill, and -internal-visited-stroke to take forced colors into account. No internal properties were needed since we only ever force fill and stroke to one value in forced colors mode. The other forced color properties will be moved in follow up changes. Note: This change will result in some functional differences with the current fill/stroke behavior in forced colors mode. SVG elements have "forced-color-adjust:none" set. Previously, SVG elements could inherit forced colors from their ancestors. Now, since we force at used value time, the used value of fill/stroke for SVG elements can no longer inherit forced colors (unless "forced-color-adjust:auto" is set by the author). The related web tests have been updated to reflect this change in behavior. Bug: 970285 Change-Id: I5bcc498a67dbd49d7b319f7f079d062d73586013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515228 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Idf0f43a55b29711e6cd8b60775c4389c42472792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553282Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829947}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c5a37b1d7286..797831c3aa24 2020-11-20 robertphillips@google.com Reland "Hook up ShaderErrorHandler in the Metal backend." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: I901279bbbf10764241c9b99d5b61a738aaa4caa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552180Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/929fc7c79f0c..6497e90dd284 2020-11-21 bingler@chromium.org Update Schemeful Same-Site DevTools issue link If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1030938,chromium:1151553 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8d567b39c849950de3e0a92849933d0e423e7537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552255Reviewed-by:
-
Nektarios Paisios authored
Cleanup: Uses BrowserAccessibilityManager::GetActiveDescendant to retrieve the active descendant regardless of the focused node This patch makes a list of readability and code health improvements: 1. BrowserAccessibilityManagerMac::GetFocus already calls GetActiveDescendant on the focused node, so calling it in BrowserAccessibilityCocoa::selectedChildren is unnecessary. 2. BrowserAccessibilityManager::GetActiveDescendant does not need to be tied to the concept of the focused node, and can handle nullptr arguments correctly, so it can be used more easily and in more places. 3. BrowserAccessibilityCocoa::selectedChildren was re-written to improve its readability. 4. BrowserAccessibilityCocoa::activeDescendant is not needed and was removed. AX-Relnotes: n/a. R=dmazzoni@chromium.org, abigailbklein@chromium.org Change-Id: Ia5c3c9cf0af55a7fe9ddff175f0cda4fedf30e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551815 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#829944}
-
Gyuyoung Kim authored
This CL replaces all uses of ui::HoverType with blink::mojom::HoverType to reduce type conversion between them in blink. Bug: 919392, 1097943 Change-Id: I1c7bdc9c8113fb65aa94eac2699610a1012f7b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548703 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#829943}
-
Adam Langley authored
BUG=1002262 Change-Id: Ic2ee06eab6944116e4139525967d9810cbf55893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551742 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#829942}
-
Hiroshige Hayashizaki authored
This CL merges the logic for getting `v8::Context` in ScriptController into ToScriptState*() methods, in order to Unify code paths around script evaluation and decouple them from ScriptController. This is preparation for https://chromium-review.googlesource.com/c/chromium/src/+/2413430 that will move out script evaluation methods out of ScriptController. Since `ScriptController::window_proxy_manager_` is equal to its LocalDOMWindow's Frame's `window_proxy_manager_`, this CL keeps the existing behavior, except that ToScriptState*() methods have more checks that result in null ScriptState and thus skipping script evaluation. This CL removes MainWorldProxy() methods that are no longer used after this CL. Bug: 1111134 Change-Id: I49247650ec984d04f3dd44115d197044f021c1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543189Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#829941}
-
