- 05 Dec, 2017 40 commits
-
-
Morten Stenshorne authored
Allows for narrower windows without causing scrollbar issues. Blink uses 800px when running layout tests. Bug: 788337 Change-Id: I7abd46699d1d58511ec3489f180f8733d3f7f1c3 Reviewed-on: https://chromium-review.googlesource.com/808306Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#521675}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fb9e2b3a..f5d857d3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia852333d38cf3fc924d7aaf5f9e1026c3f0477c3 Reviewed-on: https://chromium-review.googlesource.com/808064Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#521674}
-
Rune Lillesveen authored
A text node gets its style from its flat tree parent. The problem is that our layout code expects the LayoutObject parent to have the same inherited styles as the text node. That is not the case if a text node has display:contents ancestors and the display:contents parent does not have the same inherited styles as the closest ancestor generating a box. Example: <div> <div style="display:contents;font-size:50px">Text</div> </div> We're solving this by inserting an anonymous inline between the LayoutText and its parent LayoutObject. We do not try to merge inline wrappers for subsequent text nodes, so for: <div style="display:contents:color:pink">A<!-- -->B</div> we create one wrapper for each of A and B, even though one would suffice. We attach and detach these wrappers on-demand, so if, for instance, the inherited computed styles of the display:contents change so that it matches the computed styles of the LayoutObject parent, we detach the wrapper as it's no longer needed. We also currently detach the wrapper when the computed style of the display:contents and hence the computed style of the wrapper changes. We could have optimized this through more checking and SetStyle on the anonymous wrapper. Bug: 717460, 706316, 709808, 713019 Change-Id: Ia53b9fe2c0a6067c4600dab49cdf43f23b95b8fa Tests: see removed lines from TestExpectations. Reviewed-on: https://chromium-review.googlesource.com/806158 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:Robert Hogan <robhogan@gmail.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#521673}
-
Olivier Robin authored
It is possible for the PasswordController to be detached between the call to GetPageURLAndCheckTrustLevel and the JS completion. In that case, passwordManager is reset and there is a nullptr exception. Bug: 791710 Change-Id: Ibec514aefbaf5fb7a8773cd0254f0bf2f785e06e Reviewed-on: https://chromium-review.googlesource.com/808045Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521672}
-
Christian Dullweber authored
Create a UserConsent object and pass it to the UserEventService. UserConsent objects are whitelisted to not require history sync permission as they don't contain history data. They are also whitelisted to be sent for users who have a passphrase. Bug: 781765 Change-Id: I13800d9b3a28d3acf44052011adcaa3d7ca172fa Reviewed-on: https://chromium-review.googlesource.com/785912Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#521671}
-
Henrik Boström authored
Enable two tests: - WebRtcRtpBrowserTest.AddAndRemoveTracksWithoutStream - WebRtcRtpBrowserTest.AddAndRemoveTracksWithIndividualStreams Also remove the AppendSwitch for "RTCRtpSender", a flag which has been removed and enabled by default. TBR=phoglund@chromium.org Bug: 788760 Change-Id: I2942aed11dca4bf70e4540840ff796def64a3f1d Reviewed-on: https://chromium-review.googlesource.com/808384Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#521670}
-
Koji Ishii authored
Revert "Create NGPhysicalFragment for every SPAN element for LayoutNGPaintFragments runtime feature enabled" This reverts commit 813190a7. Reason for revert: It turned out that this change regressed 387 tests when NGPaintFragment is enabled. Local test here: https://chromium-review.googlesource.com/c/chromium/src/+/802840 The assumption was that this change fixes several failures without any additional failures (after bidi was fixed in CL:802673.) Since the assumption didn't stand, revert this once and we'll revisit again when we have more insights on what's happening. Original change's description: > Create NGPhysicalFragment for every SPAN element for LayoutNGPaintFragments runtime feature enabled > > This patch changes |ShouldCreateBoxFragment()| to return |true| for producing > box fragments for plain SPAN when |LayoutNGPaintFragments| runtime feature > enabled, to locate |NGPhysicalFragment| associated to |LayoutInlinline| for > computing bounding box and other kinds rects. > > Without this patch, we need to traverse fragment tree rooted by > |LayoutBlockFlow| containing |LayoutInline|. > > In legacy layout tree, we don't generate |InlineBox| for |LayoutInline| for > performance optimization and called "Culled InlineBox". To compute rects in > legacy layout tree, we traverse layout tree and line boxes in |LayoutInline|. > This code makes |LayoutInline| implementation complicated. Note: There is a > flag disabling "Culled InlineBox" as |AlwaysCreateLineBoxesForLayoutInline|. > > Once LayoutNG is stable enough to have profiling, we investigate whether > generating fragment for every SPAN causes performance regression or not. > > > [1] http://crrev.com/c/763188: ONE [LayoutNG] Utilize DCHECK(CanUseInlineBox()) > in core/layout/ > > Bug: 789390 > Change-Id: Ife87fc9ee487397891ae4515d1bcaea1afcf9c04 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Reviewed-on: https://chromium-review.googlesource.com/790177 > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520865} TBR=yosin@chromium.org,kojii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 789390 Change-Id: I7cdbb2ca7ab9b07718a2ce6b7f998f4b38803f3b Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/807426 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
yosin (OOO Dec 11 to Jan 8) <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521669}
-
Thomas Tangl authored
When DICE is enabled and Sync is not turned on, the user menu should display a view that contains an illustration on top, a promo text and a "Turn on Sync" button. This CL adds this feature. Mocks can be found in the bug report. Additional changes: - Extend the user menu width to 288px when DICE is enabled. - Add unit test for a negative |between_child_spacing| in BoxLayout. Bug: 786369 Change-Id: I816ee93c8b8105182c599e42ca10fd7e413fe62b Reviewed-on: https://chromium-review.googlesource.com/793451 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#521668}
-
Vaclav Brozek authored
The resetList method tries to call PreferenceGroup#removeAll on TextMessagePreference (which is not a PreferenceGroup) if an update of the settings happens while the last state had no saved passwords to display. This is a rare situation because people who have no saved passwords are not very often inspecting their passwords settings, but can happen in reality as well (e.g., when somebody inspects the page during early moments of syncing and Chrome sync populates the page as the user views it). This CL introduces a special method to do the job of resetList in the case there are no lists, and adds a test which executed the invalid cast before the fix. Bug: 788701 Change-Id: I64ada510deb78cc7b8f22f085ef2f401e9bb76ba Reviewed-on: https://chromium-review.googlesource.com/806165 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#521667}
-
Roman Sorokin authored
EnterpriseEnrollmentTest.TestAttributePromptPageGetsLoaded EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_UIErrors BUG=chromium:746723 Change-Id: If65f47d6193822c692d1a337621e94944153768d Reviewed-on: https://chromium-review.googlesource.com/803315Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521666}
-
Ned Nguyen authored
This allows us to remove credentials_path later on as it's currently handled by Telemetry's page (https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/page/__init__.py?rcl=a12fb2d1ad961877f3fc1ca4b72965394270419d&l=47) Bug: 787500 Change-Id: I74217522183322fd533aaa0e84c029c9f4b9d2b8 Reviewed-on: https://chromium-review.googlesource.com/806802Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#521665}
-
Nicolas Dossou-gbete authored
- Introduces @ChromeHome.Enable and @ChromeHome.Disable - @ChromeHome.Enable automatically causes the test test to be skipped when running on a tablet - @ChromeHome now works for unit tests, ensures the cached state is reset between tests. The plain @ChromeHome should eventually be removed in favour of the dedicated annotations, that will happen in a subsequent cleanup patch. Bug: 783160,754778 Change-Id: I60c69c2fb97a08aa1d0bcf533a8378cbbc1a548b Reviewed-on: https://chromium-review.googlesource.com/796672 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521664}
-
mallikarjun82 authored
Bug: 791427 Change-Id: Ic421215d3e77e1d6381512d29e1457fba15135ca Reviewed-on: https://chromium-review.googlesource.com/796250 Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#521663}
-
Vaclav Brozek authored
The connected base::Features are also used on Android, but the about:flags page is set up to only allow changing it on desktop. This CL adds the possibility to control those two base::Features through about:flags on Android as well. Bug: 788701 Change-Id: Ib6ae924ed453c8ceda746746fb10659d718d18e0 Reviewed-on: https://chromium-review.googlesource.com/808105Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521662}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/3337fb647c42..4ba80741d0fc $ git log 3337fb647..4ba80741d --date=short --no-merges --format='%ad %ae %s' 2017-11-30 perezju [Telemetry] Unify forwarders API and remove public PortPairs Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I93e4dc677f150001cb6fbb11003b05152e8a93ad Reviewed-on: https://chromium-review.googlesource.com/808127 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521661}
-
Koji Ishii authored
This patch supports LayoutInline::LinesVisualOverflowBoundingBox() when LayoutNGPaintFragments is enabled. Layer painting use this function to determine dirty regions. This is a split of CL:803875 to measure the fix impacts. Estimated to fix 385 tests in LayoutNGPaintFragments. Bug: 714962 Change-Id: I2822528a56d116037fd507dc2c086cdb27c50b2e Reviewed-on: https://chromium-review.googlesource.com/807972 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Daniel Bratell authored
X11 header files are infamous for creating macros with common names such as None, True, False, Status, Bool, ... To save oursaves the mess that creates, they are now wrapped in a header, ui/gfx/x/x11.h, which puts those symbols in the x11 namespace and removes the global macros. Bug: 782184 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I10a9acecb8e7adacd170d1080a411bc9d1e49f79 Reviewed-on: https://chromium-review.googlesource.com/806275Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#521659}
-
Scott Chen authored
This CL changes the layout and text that is used in sync-confirmation dialog for the DICE profiles. Screenshot of the UI after the changes: https://imgur.com/a/DxMd6 Bug: 782155 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia04733f23a0b249789cd5dc965358a62514553b5 Reviewed-on: https://chromium-review.googlesource.com/768876Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521658}
-
Morten Stenshorne authored
It's obsoleted by multicol-nested-column-rule-001.xht, according to that test. Bug: 788337 Change-Id: I8a4b324c936d25137e0775164b7bee21b1fdaa0a Reviewed-on: https://chromium-review.googlesource.com/807927Reviewed-by:
-
Thomas Tangl authored
When DICE is enabled and there is a sync error, the user menu should show a red field containing the profile photo, an action title and a short overview of the error. This field should be clickable and replace the current action button. Mocks can be found in the bug report. Additional changes: - The spacing in the HoverButton class for the badged profile photo is corrected. Bug: 786369 Change-Id: I3165100d16dd75a57e5381edddfb56ae37668bbf Reviewed-on: https://chromium-review.googlesource.com/781692Reviewed-by:
-
Markus Heintz authored
- virtual/gpu-rasterization/images/color-profile-clip.html - virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb.html - virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb.html BUG=791941 NOTRY=true Change-Id: Id70d34e000a38280738b7937d108c082ad8d56ab Reviewed-on: https://chromium-review.googlesource.com/807932Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#521655}
-
Gauthier Ambard authored
The toolbar has a shadown below it. Bug: 791469 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaf6ee9fe5190d2c4d5b6243bca3282d01ecba7ca Reviewed-on: https://chromium-review.googlesource.com/806175 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#521654}
-
Findit authored
This reverts commit d298a4dd. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 521649 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QyOThhNGRkNzMyZjA5YzlhMWMzMDZhMjA2NTA3YzEyM2EzNzYxZTIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/24801 Original change's description: > Replace WTF::Function with base::OnceCallback. > > This patch makes WTF::Function an alias of base::OnceCallback. After > this, all the single-threaded callbacks in Blink will become base > callbacks. > > This patch doesn't remove the WTF::Funtion type nor ConvertToBase- > Callback() function. The use sites of those names will be removed > individually. > > Bug: 771087 > Change-Id: I15e7758c29bb9f63b7db7ad7aba6c9cb2d9ae7d1 > Reviewed-on: https://chromium-review.googlesource.com/807672 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Commit-Queue: Yuta Kitamura <yutak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521649} Change-Id: I60fec5e188923122bb3b090acc49cfd0f0363df1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 771087 Reviewed-on: https://chromium-review.googlesource.com/808224 Cr-Commit-Position: refs/heads/master@{#521653}
-
Greg Thompson authored
This reverts commit e1ccd581. Reason for revert: Widespread "Check failed: false. Observers can only be added once!" failures. Original change's description: > Enable interactive_ui_tests on Windows that now run mostly reliably. > > r516772 was the last of many commits that resolved a number of problems > that made this test suite flaky on Windows. This CL enables tests that > had been disabled over time due to flakes, yet now seem to run okay. > > BUG=133341,751031,751543,764415,789913 > This CL was uploaded by git cl split. > > R=sky@chromium.org > > Change-Id: I753c741a9194f489f072cd86d72407a1294150c3 > Reviewed-on: https://chromium-review.googlesource.com/784937 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521416} TBR=sky@chromium.org,grt@chromium.org Change-Id: I33b192c628fdfebe9cfd93b71abd3b394faad9e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 133341, 751031, 751543, 764415, 789913 Reviewed-on: https://chromium-review.googlesource.com/808204Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#521652}
-
Koji Ishii authored
Following bot results are included. new-expected 0 lines were removed by consecutive passes since 0. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: I522a7a341c807b38c8a72369e377495bbec06d4b Reviewed-on: https://chromium-review.googlesource.com/807756 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Kenneth Russell authored
Needed to get this bot green again. BUG=791733 TBR=ynovikov@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If14d4b875f650c2d7c4fb82393d4b3c3aad509cb Reviewed-on: https://chromium-review.googlesource.com/808124Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521650}
-
Yuta Kitamura authored
This patch makes WTF::Function an alias of base::OnceCallback. After this, all the single-threaded callbacks in Blink will become base callbacks. This patch doesn't remove the WTF::Funtion type nor ConvertToBase- Callback() function. The use sites of those names will be removed individually. Bug: 771087 Change-Id: I15e7758c29bb9f63b7db7ad7aba6c9cb2d9ae7d1 Reviewed-on: https://chromium-review.googlesource.com/807672Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#521649}
-
Jungshik Shin authored
1. Map Malaylam U+0D1F to 's'. 2. Map 'small-cap-like' Cyrillic letters to "look-alike" Latin lowercase letters. The characters in new confusable map entries are replaced by their Latin "look-alike" characters before the skeleton is calculated to compare with top domain names. Bug: 784761,773930 Test: components_unittests --gtest_filter=*IDNToUni* Change-Id: Ib26664e21ac5eb290e4a2993b01cbf0edaade0ee Reviewed-on: https://chromium-review.googlesource.com/805214Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521648}
-
Morten Stenshorne authored
It doesn't seem too interesting (given that we have other tests that test column-fill:auto), and the reference it's paired with has nothing to do with the test. Bug: 788337 Change-Id: Ic98b339219bee74fe07ebfa5778869cdd2bfa28e Reviewed-on: https://chromium-review.googlesource.com/806277Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#521647}
-
Eddy Mead authored
This CL: - creates a new generator that creates AtRuleDescriptors.h/cpp in a very similar way to CSSPropertyNames.h/cpp. - creates a new "AtRuleDescriptorParser" to hold all the @rule parsing logic. - creates a new method in CSSParserToken that parses it as an AtRuleDescriptorID. - adds new templated methods in CSSPropertyValueSet to handle AtRuleDescriptorIDs. - updates the relevant parsing methods For now, descriptors appear both as AtRuleDescriptorIDs and in CSSPropertyID. This means I don't need to refactor CSSPropertyValueSet yet. Bug: 752745 Change-Id: I81df46b43cdac0835c918764254834873d45591f Reviewed-on: https://chromium-review.googlesource.com/754762 Commit-Queue: meade_UTC10 <meade@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#521646}
-
Kenneth Russell authored
This will help prevent breakage of the ANGLE CQ by running currently non-default configurations. BUG=none TBR=jmadill@chromium.org NOTRY=true Change-Id: Ib49f1a0911f7a1430f6dc513fea4573c5720a8b0 Reviewed-on: https://chromium-review.googlesource.com/808089 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Xi Cheng authored
Bug: 734095 Change-Id: Ie533f1b07f6bf8d284c199a1595258e1a6f887e9 Reviewed-on: https://chromium-review.googlesource.com/767848 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
-
Kenneth Russell authored
Everything's now just a "machine". Absence of the test_suites key is no longer an error. Fixed two builders which were actually running the check_network_annotations.py script. BUG=662541 TBR=dpranke@chromium.org NOTRY=true Change-Id: I7c28088676974cdda402cf020d097e69614ecf12 Reviewed-on: https://chromium-review.googlesource.com/808084 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL removes GoogleLandingMediator/Consumer and moves their functionalities in NTPHomeMediator/Consumer. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iae7ca5707afd04933c189391a50e384940303eb2 Reviewed-on: https://chromium-review.googlesource.com/801012Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#521642}
-
Patricia Lor authored
Follow up to r475019, which dismisses the (non-internal) page info bubble when using global browser hotkeys. This fixes the same issue, but for the internal page info bubble. Bug: 786361 Change-Id: If0a04f057e023871ff2b665d98941b836920625a Reviewed-on: https://chromium-review.googlesource.com/799651 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
-
mallikarjun82 authored
Bug: 504160 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Id1eeeb429ae3ca4bd28b44d731515c070bb7fec7 Reviewed-on: https://chromium-review.googlesource.com/790270 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#521640}
-
Matt Giuca authored
This is to support https://crrev.com/c/792315, which adds a new observer for logging engagement-type UMA in PWA app windows. The major interface changes are: - Renamed OnEngagementIncreased to OnEngagementEvent to indicate that it is now for all events that modify engagement, not just increases. - OnEngagementEvent is now called on launch (so now every place where an engagement UMA is logged also corresponds to an OnEngagementEvent). - OnEngagementEvent now takes an EngagementType enum, indicating what caused the engagement event. Because the engagement type is now exposed through the observer (and can therefore be used for non-metrics purposes), it has been moved out of SiteEngagementMetrics into SiteEngagementService. Also refactored SiteEngagementService to record UMA from the OnEngagementEvent method, rather than in many places. Bug: 785661 Change-Id: I352d0363c9ee3a40293e7b99d5b8f6e75c0e999b Reviewed-on: https://chromium-review.googlesource.com/802661Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#521639}
-
Greg Thompson authored
It times out quite frequently. BUG=419468 TBR=grt@chromium.org NOTRY=true Change-Id: Ie8b8658dbad3e13c496267d8555c60b9e0a23702 Reviewed-on: https://chromium-review.googlesource.com/807905Reviewed-by:
-
Prashant Malani authored
BUG=chromium:785338 TEST=fuzzer works. Change-Id: I2c51a5a5280079f08a012b409f616ac4112f4d6e Reviewed-on: https://chromium-review.googlesource.com/804832Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Prashant Malani <pmalani@google.com> Cr-Commit-Position: refs/heads/master@{#521637}
-
Klaus Weidner authored
The WebKit/Source/modules/vr/ code uses gfx::GpuMemoryBufferHandle and gpu::MailboxHolder for transferring frame images, these symbols shouldn't block presubmit checks. BUG=763980 Change-Id: I2f9fdd173f0173bdb51337d3943b590f42550528 Reviewed-on: https://chromium-review.googlesource.com/804742 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521636}
-
