- 21 Nov, 2020 40 commits
-
-
Ahmed Mehfooz authored
Bring fonts for system tray and secondary trays up tp new spec. Bug: 1145336 Change-Id: If5c102d94e21e1b84f5554896126e0acd681c77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548404 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#829956}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605873573-36e181f5df5da0c9aa7b43458275355d6ec5a576.profdata to chrome-win32-master-1605905851-758120749a95f1789e143f45329cd7e7ce463c52.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5027df9334d30dd6d299777c1c9fab8a5fecae48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553181Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829955}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6497e90dd284..5a89c212b104 2020-11-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-21 vidorteg@microsoft.com [Loc] Migrate animation panel to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1c6a326f88986ca895cd98f2632c5c7b10db582a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552452Reviewed-by:
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsTtsSubpage* Change-Id: I5a8ce723184396d9218e29d55799b24c7d61ee90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552253Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#829953}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/67965b97..fa2966f1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iffb3d753ba80799710b5276ace87bef92ded0440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550332Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829952}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a593bd1e937a..1e481e2bf2ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I0e62db1f31e3105871e959b95fa3195831de9438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552933Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829951}
-
Tomasz Wiszkowski authored
This change fixes a problem, where a call to resetSelection() not only rewinds the selected suggestion position, but also selects the top suggestion, invoking an associated onSelect action. this causes problems with headers specifically, where HeaderSuggestion needs to clear the Omnibox input field when selected (eg. using DPAD on keyboard) as header suggestions do not have any associated suggestion text. This change ensures the resetSelection() call clears any currently selected input, allowing the keyboard management logic to let user select the first suggestion on the list by using DPAD down key. Tested on phones and tablets, with physical keyboard and accessibility features turned on. Bug: 1150877 Change-Id: Id794281e8aec33c5ea955b4ba0b4741d47237a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553152 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#829950}
-
Adam Langley authored
GMSCore is expected to start triggering caBLEv2, rather than doing caBLEv1, for accounts.google.com logins. This change allows it to send Intents to start Chrome to perform the caBLEv2 interaction. BUG=1002262 Change-Id: I557f89d3bb191b738fe50e6a2377573a334fdb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552623Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#829949}
-
Alison Maher authored
Forced colors should now happen at used value time. This change adjusts the used value of fill, stroke, -internal-visited-fill, and -internal-visited-stroke to take forced colors into account. No internal properties were needed since we only ever force fill and stroke to one value in forced colors mode. The other forced color properties will be moved in follow up changes. Note: This change will result in some functional differences with the current fill/stroke behavior in forced colors mode. SVG elements have "forced-color-adjust:none" set. Previously, SVG elements could inherit forced colors from their ancestors. Now, since we force at used value time, the used value of fill/stroke for SVG elements can no longer inherit forced colors (unless "forced-color-adjust:auto" is set by the author). The related web tests have been updated to reflect this change in behavior. Bug: 970285 Change-Id: I5bcc498a67dbd49d7b319f7f079d062d73586013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515228 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#829948}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Idf0f43a55b29711e6cd8b60775c4389c42472792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553282Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829947}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c5a37b1d7286..797831c3aa24 2020-11-20 robertphillips@google.com Reland "Hook up ShaderErrorHandler in the Metal backend." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: I901279bbbf10764241c9b99d5b61a738aaa4caa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552180Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/929fc7c79f0c..6497e90dd284 2020-11-21 bingler@chromium.org Update Schemeful Same-Site DevTools issue link If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1030938,chromium:1151553 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8d567b39c849950de3e0a92849933d0e423e7537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552255Reviewed-by:
-
Nektarios Paisios authored
Cleanup: Uses BrowserAccessibilityManager::GetActiveDescendant to retrieve the active descendant regardless of the focused node This patch makes a list of readability and code health improvements: 1. BrowserAccessibilityManagerMac::GetFocus already calls GetActiveDescendant on the focused node, so calling it in BrowserAccessibilityCocoa::selectedChildren is unnecessary. 2. BrowserAccessibilityManager::GetActiveDescendant does not need to be tied to the concept of the focused node, and can handle nullptr arguments correctly, so it can be used more easily and in more places. 3. BrowserAccessibilityCocoa::selectedChildren was re-written to improve its readability. 4. BrowserAccessibilityCocoa::activeDescendant is not needed and was removed. AX-Relnotes: n/a. R=dmazzoni@chromium.org, abigailbklein@chromium.org Change-Id: Ia5c3c9cf0af55a7fe9ddff175f0cda4fedf30e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551815 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#829944}
-
Gyuyoung Kim authored
This CL replaces all uses of ui::HoverType with blink::mojom::HoverType to reduce type conversion between them in blink. Bug: 919392, 1097943 Change-Id: I1c7bdc9c8113fb65aa94eac2699610a1012f7b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548703 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#829943}
-
Adam Langley authored
BUG=1002262 Change-Id: Ic2ee06eab6944116e4139525967d9810cbf55893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551742 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#829942}
-
Hiroshige Hayashizaki authored
This CL merges the logic for getting `v8::Context` in ScriptController into ToScriptState*() methods, in order to Unify code paths around script evaluation and decouple them from ScriptController. This is preparation for https://chromium-review.googlesource.com/c/chromium/src/+/2413430 that will move out script evaluation methods out of ScriptController. Since `ScriptController::window_proxy_manager_` is equal to its LocalDOMWindow's Frame's `window_proxy_manager_`, this CL keeps the existing behavior, except that ToScriptState*() methods have more checks that result in null ScriptState and thus skipping script evaluation. This CL removes MainWorldProxy() methods that are no longer used after this CL. Bug: 1111134 Change-Id: I49247650ec984d04f3dd44115d197044f021c1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543189Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#829941}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/11b40137016b..91c1a7c2dc0a 2020-11-21 wenbinzhang@google.com [benchmarking] pass possible_browser for CustomzeOptions to avoid calling FindBrowser there If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1149275 Tbr: sadrul@google.com Change-Id: Iefed6013e27ed8f35b6e66e4814abae543d05301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552899Reviewed-by:
-
Kyle Horimoto authored
This class manages partially-transferred payloads with type "stream". Stream payloads are transferred in chunks of 1980 bytes each, so this class buffers these chunks until the transfer is complete, then provides an API for clients to retrieve the completed payload. This CL also updates NearbyConnections to use this class. Bug: 1150565, 1106937 Change-Id: Ib6b18702b7feedc854f22dabe6fdeddc066e7636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551352 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#829939}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4d62438ecdeb..7d75f2ca782f 2020-11-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 81ed1058..039670a4 (829759:829870) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I778a0146205249b809fb2d23762f5338d8695382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552254Reviewed-by:
-
Charlie Reis authored
This reverts commit 824b062d. Reason for revert: Causing crashes with hosted apps in https://crbug.com/1141721. Original change's description: > Origin isolation: enable by default > > Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/WW4fGjvroWI > > Further work on removing origin trial code and the flags is tracked in > https://crbug.com/1148056 and https://crbug.com/1148057. > > Bug: 1042415 > Change-Id: Icbeecd0b592c76d36e2111b8e4d8fe30dbb63343 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533145 > Commit-Queue: Domenic Denicola <domenic@chromium.org> > Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826910} TBR=creis@chromium.org,alexmos@chromium.org,jochen@chromium.org,domenic@chromium.org,yoavweiss@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1042415, 1141721 Change-Id: I428b190fc4c6bdf39de5ffb43226ba91851e7544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553209Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#829937}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cd00d19b5ae3..a593bd1e937a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I035940736a30a32250badae7e96cad4d5174ec9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552179Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605895128-ea3f86e674d4361d5284b25de8910e19181b674b.profdata to chrome-linux-master-1605916713-42186a780bbf4a6606356f169d60384bd3619cf2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8c71f1248ea776c8ffc1057af767f9e8d944f7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552725Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts ExtensionMsg_SetSessionInfo to mojo and introduces channel_mojom_traits.h to convert version_info::Channel to extensions.mojom.Channel. Bug: 1146103 Change-Id: Iacc3d116bf08a7f32eadb5066cd9690b3aec89ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548943 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#829934}
-
David Tseng authored
This change builds on top of the logic to enqueue utterances for tts platforms (which are interfaces to native tts api for that platform) while initializing/loading. It adds the same treatment for TtsEngineDelegate, which is responsible for built-in tts engines shipped as extensions for each platform. This starts off for built in engines on Chrome OS, but can encompass the network tts engine we ship for other platforms. The new behavior will be to enqueue until the built-in engine(s) are ready; readiness is signaled by detecting at least one voice for the built-in engines (Googletts/Espeak). Note it can be uninitialized in this scheme. R=dmazzoni@chromium.org Change-Id: Ie681e5830909245b566969b491043225c0640be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552369 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829933}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I822c4c6f4db2012091eea993c28681a9f8c0a7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550612Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1605895128-00d55e6bb356ebbc13be21f27095ad3409f51b0e.profdata to chrome-mac-master-1605916713-5c2651f0c6431583f545a63fcbde858a51a7c7b1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If268008d1a40a45939a4ab6cd9060bd60b6847c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552932Reviewed-by:
-
Eugene Zemtsov authored
This is an improved version of crrev.com/827150. The original CL caused test flakiness and was rolled back. Bug: 1119892, 1146168, 1148686 Change-Id: I37a39c679b62eddd22bc1be88d9a939da20fc434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549830 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#829930}
-
Scott Violet authored
When 'overflow: clip' is set along a particular axis, scrollWidth/Height should return the overflow size. BUG=1087667 TEST=external/wpt/css/css-overflow/overflow-clip-scroll-size.html Change-Id: I447d6249ca0234c491521d42b1139e415b78bcbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531117 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#829929}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605884021-38c8ae5c2e6706d9e606dfe2bcddc4d1100361a4.profdata to chrome-win64-master-1605895128-0d0cfee41041bede7470dc9636efcf6ef0284e30.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6a4b8849c5c6eb1cb95a894a6d11ee30601c7efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552449Reviewed-by:
-
Ahmed Fakhry authored
This is a reland of https://crrev.com/c/2548880 which was reverted due to a flaky test. The flakiness root cause was resolved in https://crrev.com/c/2552921. Therefore, there're no changes in this CL from the original. TBR=jamescook@chromium.org, poromov@chromium.org, isandrk@chromium.org, bmalcolm@chromium.org Original CL description: Capture Mode should be disabled when the `kDisableScreenshots` policy is disabled. It also should be disabled when a tab requests to be in a locked fullscreen mode, and any on going recording should be interrupted. BUG=1150585 TEST=Existing, and added a new test. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548880Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#829390} Change-Id: If427589bcaf9837d0def703dbeff6fc03b8167cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552215Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#829927}
-
James Cook authored
Attempting to open a downloaded file from the download shelf would trigger a DCHECK because I was using the file manager mojo remote on the wrong thread. The code is asynchronous already, so post a task to the UI thread to do the work. Bug: none Change-Id: Ib43969c51b479ab4bbfecc7198eea7d1a193a1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553082 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#829926}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8a682e08..67965b97 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3e7538b632b0eb6b89e20d5bfc61c99ad091e8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552885Reviewed-by:
-
Michael Hansen authored
This updates the layout of the contact visibility page to show the "no contacts" state on its own without the description text above it, and switches out the iron-list for a dom-repeat so that we can let the entire content area scroll so that you can see more contacts at once. Screenshots: https://screenshot.googleplex.com/7V92cx9RbcrXUXx.png https://screenshot.googleplex.com/C2cmhbM2GEAAhY4.png Bug: b:168841167 Change-Id: Iaddbd317a9a167ee6193ca9afc0d1ac08397b132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548454 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
-
Xing Liu authored
The code that uses this enum is deleted in: https://chromium-review.googlesource.com/c/chromium/src/+/2486031 This CL marks the enum deprecated in enums.xml. TBR=bcwhite@chromium.org Bug: 1130635 Change-Id: Ib148fc0e6632aa5fc70db2c8c5d82e88a59178c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551297Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829923}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c4ca12e32e6a..040de9214830 2020-11-20 courtneygo@google.com Vulkan: Move FenceRecyler to CommandQueue. 2020-11-20 cnorthrop@google.com Capture/Replay: Limit GL_MAX_IMAGE_UNITS further 2020-11-20 jmadill@chromium.org Trace Tests: Screenshot within the render loop. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: LEGO MEC Change-Id: Ia09078d0510390fec7d30f143cdd17f8a494c124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552177Reviewed-by:
-
Sam Maier authored
Bug: 1151350 Change-Id: I913b01265232168fcf3833bc59f4d343501a75b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553001 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Peter Wen authored
As recommended in the lint README, lint-suppressions.xml should only be used for temporary and permanent ignores, not for old code that should be fixed at some point: https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.md Thus, bulk-moving ignores for old code into lint-baseline.xml. The one exception is for UnusedResources, since having these checks in lint-baseline.xml causes a lot of bloat in terms of lines since each language's xml file is listed on a separate line for every resource. Bug: 1069186, 1077861, 1116130, 1085410, 1039415 Fixed: 1069186, 1085410 Change-Id: Iac10f4dc087e12b43595aae154dc7ffb821f2325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552853 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/16973d613fed..8f8e2dc7d50f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I528774ac7c0b843af830e1ae05b848a745ccf4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551517Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ce4be1e64050..4d62438ecdeb 2020-11-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7ffc87db..81ed1058 (829478:829759) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I812fc276305fcb5eaa811972fec50ef74ad0130a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552900Reviewed-by:
-
David Van Cleve authored
This CL updates blink::SecurityOrigin and url::Origin to include port-0 origins' ports in their serializations. Right now, url::SchemeHostPort has the following control flow: serialize the scheme and host if port == 0, return if there's a default port for the scheme, and the port is not the default, serialize the port The port == 0 branch was previously necessary because blink::SecurityOrigin didn't support port-0 origins and some tests compared blink::SecurityOrigins' serializations to those of url::Origins. With crbug.com/1136678 fixed, blink::SecurityOrigins now support port 0 and we can update the serialization behavior in blink::SecurityOrigin and url::Origin simultaneously to be the above pseudocode with the "port == 0" branch removed. Test: Adds unit tests covering port 0 serialization Change-Id: Ide11b75302a1abda7a602b24678e2985bfe39e3b Fixed: 1136966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472446 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#829917}
-
