- 14 Dec, 2017 40 commits
-
-
Mostyn Bramley-Moore authored
fake_platform_sensor_and_provider.h also contains a MockPlatformSensorClient class, which collides in jumbo builds. BUG=794692 Change-Id: Ib3769a25bb0927766757ba5b37ec99fc4f15768f Reviewed-on: https://chromium-review.googlesource.com/827766Reviewed-by:
Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#524195}
-
Ryan Sturm authored
This tracks per host data savings for offline previews as well as cleaning up the code somewhat. Bug: 794642 Change-Id: I2660beeee2c6ef8f7939eff4861b78203dab63d6 Reviewed-on: https://chromium-review.googlesource.com/825362 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#524194}
-
Yash Malik authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I27c2689ebf8b4c5027cb272cf8359f68a6e2918a Reviewed-on: https://chromium-review.googlesource.com/822234 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#524193}
-
Charlie Andrews authored
Disable flaky smoothness.tough_texture_cases story on Android One TBR=vmiura@chromium.org, nednguyen@google.com Bug: 795060 Change-Id: I9dbaa1e3563b60ad95f20f4ee18935637ee09925 Reviewed-on: https://chromium-review.googlesource.com/827530Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#524192}
-
Dmitry Gozman authored
This is a reland of 5fc3b9d0 Original change's description: > [DevTools] Implement waitForDebugger for OOPIFs > > Using NavigationThrottle for this. Since during throttling > the navigation has not committed yet, we have to create > agent host for soon-to-be-committed frame in advance. > > Bug: 750901 > Change-Id: I88dbd982481b88eeec36209b6bf3ad7f74863200 > Reviewed-on: https://chromium-review.googlesource.com/818076 > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523835} TBR=pfeldman Bug: 750901 Change-Id: I96e6c083aa0de96799fbd4a529ae97019738ed87 Reviewed-on: https://chromium-review.googlesource.com/826318Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524191}
-
Nektarios Paisios authored
1. Stopped using the value attribute to hold the inner text of spin buttons and other range controls because this could result in showing the inner text as the control's value which, depending on the control's author, could be totally meaningless. For spin buttons, now the value attribute only holds the contents of aria-valuetext if present. 2. Took the opportunity to write some more tests and clean up some of our Blink code. R=dmazzoni@chromium.org, aleventhal@chromium.org Also: Bug: 792056 Change-Id: Ib4eb98c2c1a351f40e2ac144b1967142040f0675 Tested: manually with dropdowns on kayak.com, browser tests, sample HTML snippet of an ARIA spin button Reviewed-on: https://chromium-review.googlesource.com/823136 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#524190}
-
Jungshik Shin authored
Add a test for German time format (12hr with AM/PM marker). It has 3 changes: https://chromium.googlesource.com/chromium/deps/icu.git/+log/e3b480d..94d819f 2017-12-13 jshin@chromium.org Update German AM/PM marker to the previous value 2017-12-13 jshin@chromium.org Cherry-pick an upstream fix for UTF8 to UTF8 conversion 2017-12-12 jshin@chromium.org Cherry-pick an upstream fix for Calendar class Bug: 794737,794390,792537 Test: base_unittests --gtest_filter=TimeFormat*.*TimeOfDayDE Test: crbug.com/794737#c2 Change-Id: Ifa6d31624cbd9d4edc1b776e34527d8e842f7290 Reviewed-on: https://chromium-review.googlesource.com/826363 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#524189}
-
Miriam Gershenson authored
The special error handling for this case is strange and I want to delete it. This histogram will track how often it's useful so we can decide whether it's okay to delete. Bug: 779589 Change-Id: Ieadcb1214486bd468e5e9c18d2f06915b6ee1fff Reviewed-on: https://chromium-review.googlesource.com/822832Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#524188}
-
Aaron Leventhal authored
Windows includes trailing space/punctuation in selection of a word or move by word (Ctrl+right). This code change makes views consistent with Blink and with other apps on Windows. This is perhaps a subtle difference for most users, however, it is an important bug fix for screen reader users who need to hear the word they land upon rather than the previous word. Bug: 196326 Change-Id: I31244da3e73af68b810027b5f825f1cb71d19124 Reviewed-on: https://chromium-review.googlesource.com/824802 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#524187}
-
Mike Wasserman authored
Add AshWindowTreeHostMusUnified and AshWindowTreeHostMusMirroringUnified. (near copies of AshWindowTreeHostUnified and AshWindowTreeHostMirroringUnified) Make ShellPortMus::CreateAshWindowTreeHost construct these like AshWindowTreeHost::Create. Loosen DisplayManager::SetDisplayConfiguration restrictions for unified (w/o viz). Do not show the PlatformDisplay's window for the virtual/offscreen unified display. TODO: Fix targeting of events on the second display during capture. TODO: Fix a crash on shutdown when unified mode is still active. Bug: 764472,770243 TBR: dpranke@chromium.org Test: Unified mode works reasonably in Mus (needs event handling work) Change-Id: I25a4f2f917275b4fd9f73cb62a5f22aaf01806ca Reviewed-on: https://chromium-review.googlesource.com/817761 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#524186}
-
David Valleau authored
R=hcarmona@chromium.org, skau@chromium.org Bug: 780284 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia9508803a34cde2c957cf4ca03047990039e3a29 Reviewed-on: https://chromium-review.googlesource.com/809536Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#524185}
-
Joel Einbinder authored
Bug: 725710 Change-Id: I356edbb435a5f877726b0f480130fb715f36f9ce Reviewed-on: https://chromium-review.googlesource.com/826052Reviewed-by:
-
Michael Thiessen authored
We were resizing the content window based off of an uninitialized projection matrix, causing it to be very large. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6fabecefefe75c78bfecef746ec298e24da5b771 Reviewed-on: https://chromium-review.googlesource.com/827625Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#524183}
-
Darren Shen authored
When setting multiple values on a non list valued property, we resolved to throw a TypeError. Spec: https://github.com/w3c/css-houdini-drafts/issues/512 Bug: 785132 Change-Id: I2a1a06ffc3eb6db66e08e2537eeaa570feaff0d3 Reviewed-on: https://chromium-review.googlesource.com/826744Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#524182}
-
Darren Shen authored
This patch changes all the TODO(shend)s into either FIXMEs or TODO(crbug.com/XXX). There are also some outdated TODOs. Change-Id: I3ea6eb1807c9332d07700a7e0664eec2e07ef1e1 Reviewed-on: https://chromium-review.googlesource.com/826831Reviewed-by:
-
Marc-Antoine Courteau authored
This policy forces spellcheck to be enabled for a set of languages. The user can still enable spellcheck for other languages. Bug: 246628 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If3e1322f1c6fd1e74a5c2587d6fd582ac31bae7b Reviewed-on: https://chromium-review.googlesource.com/820154Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#524180}
-
Alexei Filippov authored
Bug: Change-Id: I4177e94f6dc7cbb55392f6c70f0c7a711023edf8 Reviewed-on: https://chromium-review.googlesource.com/826364Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#524179}
-
Christos Froussios authored
This reverts commit a22b9873. Reason for revert: Password Manager initialisation depends on oscrypt, which creates the possibility of deadlock. See crbug/795019 Original change's description: > [OSCrypt][Password Manager] Introduce TaskRunner for libsecret > > A SequencedTaskRunner will be used to guarantee no race conditions > between the two clients of libsecret. > > Bug: 782851 > Change-Id: I6549f867a14378d019404429bab42008fca548a7 > Reviewed-on: https://chromium-review.googlesource.com/803954 > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Reviewed-by: Vaclav Brozek <vabr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523409} TBR=vabr@chromium.org,cfroussios@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 782851,795019 Change-Id: Ie435a623de544767189571b80f929777af881012 Reviewed-on: https://chromium-review.googlesource.com/826070Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#524178}
-
Kenneth Russell authored
Studying the code in src/build/android/test_runner.py and related files (like test_instance_factory and gtest_test_instance), there were no dependencies on this specific argument's name. Change to use the standard one so that Android works the same as the other platforms. BUG=794767 Change-Id: I22f3eea9cb9d1029b778b1d4a878d0e74dc6449c Reviewed-on: https://chromium-review.googlesource.com/826490Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524177}
-
Christos Froussios authored
This reverts commit 96bca08b. Reason for revert: Initialisation of password manager depends on OSCrypt. This introduces a deadlock, as seen crbug/795019 Additionally, this CL failed to schedule the destruction of the KeyStorage on the dedicated thread. Original change's description: > [OSCrypt] KWallet/dbus implementation should use dbus' thread > > Dbus, which we use to communicate with KWallet, requires to be called > on a dedicated thread. > > Bug: 782851 > Change-Id: I7c55c0c6cec03d3cf688b6f1ad60326e4d5f417f > Reviewed-on: https://chromium-review.googlesource.com/803481 > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Vaclav Brozek <vabr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520980} TBR=thestig@chromium.org,vabr@chromium.org,cfroussios@chromium.org Bug: 782851, 775843, 795019 Change-Id: I8b5d4c4ed8c2fe6949591336904befe80ef4fb42 Reviewed-on: https://chromium-review.googlesource.com/826069 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
Gabriel Charette authored
R=thestig@chromium.org Bug: Returns scoped object which should never go unused, warn for good measure. Change-Id: I15992a1cd0d1d83157a66532f883311e36f4e621 Reviewed-on: https://chromium-review.googlesource.com/827133Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#524175}
-
Koji Ishii authored
Following bot results are included. 2486 2490 2492 511 lines were removed by consecutive passes since 2446. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia8574e9f56b10c70d8fad0a4d4b910b62682fa66 Reviewed-on: https://chromium-review.googlesource.com/827044 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#524174}
-
kylechar authored
These tests were failing because of a flag not being passed which has been fixed. Bug: 793302 Change-Id: Ia5eb10f390011b27179e93e50392d97421b75101 Reviewed-on: https://chromium-review.googlesource.com/826868Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#524173}
-
Mike Reed authored
Bug: Change-Id: I33cde31a43e54240e4753177809445f7e28b3e9e Reviewed-on: https://chromium-review.googlesource.com/826170Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
-
Joel Einbinder authored
This patch removes the overrides panel from the settings. Bug: 760316 Change-Id: I443a3afd81c1b9414d47106e15c95c7ab9f4a99f Reviewed-on: https://chromium-review.googlesource.com/826144 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524171}
-
Hiroki Nakagawa authored
Bug: 778796 Change-Id: I323c022b01bab44be459fca6cd7fcac88ef65e67 Reviewed-on: https://chromium-review.googlesource.com/822313 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#524170}
-
Corentin Wallez authored
BUG=chromium:795052 BUG=chromium:794339 TBR=zmo@chromium.org Change-Id: I7edd3dfeb1ecc02cbf5d9c9056cd8c1f5ed79408 Reviewed-on: https://chromium-review.googlesource.com/827589Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#524169}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/604f5b9e0422..fe9d640ea90c $ git log 604f5b9e0..fe9d640ea --date=short --no-merges --format='%ad %ae %s' 2017-12-14 dsinclair Create classes for XFA JS objects Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I59061412b1a11f0bcbe0f7c08015aa4f047e78c6 Reviewed-on: https://chromium-review.googlesource.com/827553 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524168}
-
Dale Curtis authored
This uses the player ID assigned to every MediaMetricsProvider per WebMediaPlayerImpl instance to correlate metrics like watch time, video decoder stats, and more. A new Media.WebMediaPlayerState UKM event is added which tracks the player id and final pipeline status. Later on we can add other one-time lazily-generated metrics like time to first frame, or time to load, etc. The player id value is then added to both the existing UKM events for watch time and decoder stats. Also later on we can use this to move more of the metrics logged through MediaInternals today to the metrics provider. BUG=706276,794263 TEST=updated unittests. TBR=bauerb Change-Id: I59ecad7f858b228f1fddb4eb8215b127e606ca93 Reviewed-on: https://chromium-review.googlesource.com/822168 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#524167}
-
Dominic Mazzoni authored
I don't think we currently have a way that this bad cast could be triggered on the open web, we only call hit test on the LayoutView. But it was possible to trigger this bad cast from a test, so we should fix it. Bug: 777150 Change-Id: I8ec81a4a86edd5956936a480e2733e6bee9a5865 Reviewed-on: https://chromium-review.googlesource.com/827528 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
Ian Vollick authored
With this change, button becomes disc button and the base class can be used as a generic button (a thing with hover, press states and a callback). This was used to get hover states in the omnibox suggestions. This change also includes some color scheme changes (mostly for these new buttons, but also brings a number of other colors up to spec). Bug: 777542 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id0262e5c677d2022593e9bf3574dd92c12cfe7f0 Reviewed-on: https://chromium-review.googlesource.com/827034Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#524165}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/0e2365136c55..6ee03a73439b $ git log 0e2365136..6ee03a734 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 dtu [pinpoint] Adjust statistical parameters. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1153424b3a54f680863e1f12feab056268df2ace Reviewed-on: https://chromium-review.googlesource.com/827529 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524164}
-
Takumi Fujimoto authored
We will record the type of the sink (Cast, Audio, Hangouts, etc.) when Media Router attempts to create a route. Bug: 783850 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I697af8c9d032bfbd0c6033a87261b75a9f408982 Reviewed-on: https://chromium-review.googlesource.com/764188Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#524163}
-
Charlie Andrews authored
This is the last part of a three-sided change in which the return value of StopTracing() was changed from a TraceValue object to a (TraceValue object, list of nonfatal exceptions) tuple. Bug: catapult:#3798 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6e237ce13f7cf263ca453fa47c859f65d1c051b8 Reviewed-on: https://chromium-review.googlesource.com/827549Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#524162}
-
Tim Brown authored
Cinnamon uses a different settings schema to specify the window button layout compared to Gnome. This affects Ubuntu 14.04 using Cinnamon since my change to use GSettings to read the button layout. To fix this I had to add an enum value for Cinnamon. system title bar, and changed window button layout. Bug: 794376 Test: Forced the use of the GSettings provider, ran Chrome not using Change-Id: I2e41df59a71467ac9161751c1fd3e6582c99fdab Reviewed-on: https://chromium-review.googlesource.com/826027 Commit-Queue: Tim Brown <timbrown@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#524161}
-
Reilly Grant authored
This patch adds a new constructor for RefCountedBytes that initializes it with a given length of zeros and non-const versions of the front() and front_as<>() methods to accompany the non-const data() method. This is split out from https://crrev.com/c/786680 which uses this class as a replacement for net::IOBufferWithSize (but with an unsigned buffer). Change-Id: I36c16d02e0a524da3da8679b883321388febaf82 Reviewed-on: https://chromium-review.googlesource.com/822165Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/327c9d94..7f26ff95 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ifaf67c873c6fa0f5e7d7201bd0d50aebb779134b Reviewed-on: https://chromium-review.googlesource.com/826087Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#524159}
-
Lei Zhang authored
Change-Id: Iab66904da43d2aaee616f754691e3e0f720637c7 Reviewed-on: https://chromium-review.googlesource.com/826472Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#524158}
-
Jialiu Lin authored
Proto change copied from cl/176384092. This CL expand the "has_user_gesture" boolean field into a enum to include more information on how the navigation happens. Tests updated accordingly. Bug: 780532 Change-Id: Ic13d8472aa6ea3e42f268f92bf46c6cae64f4066 Reviewed-on: https://chromium-review.googlesource.com/802185 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#524157}
-
Ian Vollick authored
This change reverts my previous attempt at sorting the reticle into the list of UI elements. It turns out that this is more subtle than I'd originally appreciated, and until we can come up with a robust approach that avoids all artifacts, I'm reverting to a state where the reticle consistently draws atop all UI elements. Bug: 779692 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I185b70f4c0137a6513c67765c1696fe16f996352 Reviewed-on: https://chromium-review.googlesource.com/826431Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#524156}
-
