- 30 Aug, 2019 36 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium b7449a2b. With Chromium commits locally applied on WPT: 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" 90789f54 "Implement fallback to element anchor" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia1d33b9e6d8378ff74b927351f2ad7cf0a9a61e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772646Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691899}
-
Leszek Swirski authored
Bug: 865098 Bug: 945321 Change-Id: I557f5b6a2d2ed8f3d24add92830120a6b294878b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774456 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#691898}
-
Kai Ninomiya authored
Bug: 475095, 478572, 479260, 606096, 610951 Bug: 772651, 792210, 798117, 844311 Bug: 857644, 903903, 906742, 945903, 949249 Bug: 951628, 951771, 957644, 974347, 979444 Bug: 979641, 981579, 983142, 986808 Bug: angleproject:1007, angleproject:2708 Bug: angleproject:2722, angleproject:2909, angleproject:2910 Bug: angleproject:2911, angleproject:2912, angleproject:2913 Bug: angleproject:2918, angleproject:2919, angleproject:2920 Bug: angleproject:2922, angleproject:2929, angleproject:2931 Bug: angleproject:2987, angleproject:3343 Change-Id: I7007f383bf625b2d67081d3428958cd187649ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773437Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#691897}
-
rbpotter authored
Bug: 721073 Change-Id: Iaef46bc33ba84563942b68d44a8684d8571914b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762544 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#691896}
-
Robert Sesek authored
Using global defines pollutes the build. The preferred method for feature defines are to use buildflags, which are scoped to the targets and files that require them. Change-Id: Ib583735e21f83b5a0084e52282bfba0f06a4ec71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775876Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#691895}
-
K Moon authored
Drops PDFiumPage constructor arguments that are mutable after construction. Long lists of constructor arguments are less clear than named calls, and callers can avoid setting arguments they don't care about. For example, the page rectangle can be initialized by a layout calculation, rather than at construction time. In the same spirit of removing undesirable degrees of freedom, the set_available(boolean) method has been replaced with a one-way MarkAvailable() method. (It doesn't make sense for an available page to become unavailable.) Bug: 885110 Change-Id: I98cf558320b4b752d7d7b8da2144d70a36b80a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771042 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |LayoutText::SetTextWithOffset()| to reduce text shaping by reusing |ShapeResult| of before and after replaced range for improving performance, 10% to 15% faster but 3 times slower than legacy layout. (Profile data: http://bit.ly/33B9rfg) From this patch, |SetTextWithOffset()| does: 1. Get offset mapping to map DOM offsets to text content offsets for replaced range. 2. Collect inlines into |text_content| and |NGInlineItem| to get newly inserted text. 3. Copy before and after |ShapeResult| from current data to |NGInlineItem| list in step 2. 4. Call |NGInlineNode::ShapeText()| with |NGInlineItem| list to reuse |ShapeResult|. This patch gets rid of NGInlineNodeTest.InvalidateSetTextWithOffset because new test case replaces this test and this test call |SetTextWithOffset()| with wrong parameter. It shoulbe |SetTextWithOffset("baftere", 1, 4)| as result of |"before".replaceData(1, 4, "after")|. Note: This is reland of http://crrev.com/c/1729330 TBR=yosin@chromium.org Bug: 707656, 998507,998683, 999005 Change-Id: I016180de37b7afcb71998658ad66c001482029fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775647Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691893}
-
Joel Hockey authored
Supports only CLIPBOARD selection and not PRIMARY (for now) since ozone only supports a single clipboard. Regisers to receive XFixesSetSelectionOwnerNotify events and prefetches and caches supported mime types whenever ownership changes. Also prefetches clipboard contents as 'text/plain' since that is the most likely type to be requested. If clients request a different type, it will be fetched at the time of requesting. Converts text/plain[;charset=utf-8] <=> [UTF8_]STRING to allow interoperability with other applications which do not use the same mime types as chrome. This code can be patched into linux-chromeos (chrome os running on a linux desktop) by modifying the build file: sed -i s/is_desktop_linux/is_linux/ ui/base/clipboard/BUILD.gn Bug: 985187 Change-Id: I4277f903ab8f11e0f5ad14d095eb099cf775f771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736619Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#691892}
-
Nandhini authored
Bug: 999272 Change-Id: If23c397fc23a657e09b2291ab9ea1c12b319ee35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776609 Commit-Queue: Nandhini Raman <nraman@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#691891}
-
Adam Langley authored
The HID code was correctly ignoring messages for unknown channels, but only if they fit in a single frame. For multi-frame messages, the first frame was ignored and then the continuation was considered to be an initial frame again and would generally cause a parse error. Bug: 998452 Change-Id: Ia21ee44b7c690c897c1cca52d94e0c4e88eb16db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776985 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#691890}
-
Caleb Rouleau authored
See bug for context. Bug: 997257 Change-Id: I884668d55e28c2b0df7253467abe125cea71c431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773513Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#691889}
-
Adam Ettenberger authored
AXObjectCacheImpl::GetOrCreate(LayoutObject*) can return a nullptr if the node is an area element. This change makes sure that the AXObject is valid before calling |IsAnchor|. Bug: 996460 Change-Id: I63b966615aec010c6df03292addbcd0a71e405ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772283Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#691888}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bad3985ba95f..f7919e0eeb73 Created with: gclient setdep -r src-internal@f7919e0eeb73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Idac521bb4452e349dace51c83e0ff3ab30a17c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776852Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691887}
-
Jinsuk Kim authored
With a new haptic response for navigation added by https://crrev.com/c/1772780, UX recommends the one for navigation sheet triggering be removed. Bug: 998943 Change-Id: Ibae6cf53227762036bb4413c177d5db76d10cf91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772870Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#691886}
-
Matt Reynolds authored
This CL avoids a crash when disconnecting a Joy-Con Charging Grip gamepad. The Joy-Con Charging Grip is a USB-C device that docks with two Nintendo Switch Joy-Cons and allows them to behave like a single USB gamepad. When disconnecting, NintendoDataFetcher::RemoveDevice decomposes the gamepad representing the charging grip into its Joy-Con subcomponents (composite_left_ and composite_right_). The parent device is then shut down, which may trigger a "stop vibration" command. This causes a null dereference when it tries to forward the vibration command to the subcomponent. To fix, the vibration command is sent before the subcomponents have been removed from the parent device and additional checks are added to ensure the subcomponents are not dereferenced after the parent is decomposed. BUG=995548 Change-Id: I1d82e423b134ab3c99dd1e98a6615555cfadd47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758980Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#691885}
-
Kyle Horimoto authored
Previously, we would only connect when Enter was pressed on the password field. However, for networks with no password, the Enter key did not trigger a connection when pressed in the SSID field. Bug: 999106 Change-Id: I5996b1c31d1026a2a294e469da6c54c346e14f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776939 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#691884}
-
Erik Chen authored
Previously, the class was keeping a raw pointer to a WebWidget object. While we would eventually like the lifetime of RenderWidget and WebWidget to be synchronized, they are not yet. This CL updates the pointer to be to a RenderWidget object, guaranteed to outlive the WebWidgetLockTarget. Bug: 999243 Change-Id: I9a2a546823b658a24d25fc9ae7a2d4e7e61ad5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776981 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#691883}
-
Stephen McGruer authored
This reverts commit 6caf7e08. Reason for revert: the Settings can be nullptr, see https://crbug.com/999333 Original change's description: > Hook up animations to ValidationMessageOverlayDelegate > > ValidationMessageOverlayDelegate hosts an internal blink::Page > which is not properly integrated into the normal BeginMainFrame > flow. As such, it needs to be manually prodded in various places. > Integration already existed for layout and paint - this CL adds > animations as well. > > This previously worked because blink::AnimationClock would advance > its own time (against the spec), and so the internal Page would see > advancing time and the animation would keep ticking. When we fixed > blink::AnimationClock to be by the spec, we also broke this. > > This CL also makes sure that the animation used by > ValidationMessageOverlayDelegate is not composited; the internal Page > has no compositor so composited animations will not work. > > Bug: 990680 > Change-Id: I16aaddbfa57eaefadfb557fc9cb435d94672e637 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763162 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691673} TBR=flackr@chromium.org,pdr@chromium.org,smcgruer@chromium.org Change-Id: If639ac736d0f00ea673f432e93ffd00440289dd4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 990680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777083Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#691882}
-
Avery Musbach authored
The present CL follows up after [1] about overview not stealing focus from a window snapped in split view. The present CL makes the solution simpler and less error prone. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1756550 Test: ash_unittests TabletModeControllerTest.StartSplitViewAndThenOverview Bug: 993403 Change-Id: I9c25fbdfa8fd63050769817e1e2b4380389bd015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768833Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#691881}
-
Thomas Guilbert authored
The following commit: 3483b4af Added or renamed a series of tests that time out on the Webkit Linux Msan bot. This CL disables the ones that are causing failures due to timing out. TBR=robertma Bug: 856601 Change-Id: Ic68e86201a79e53732c767321d53f25bd2c33d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777076Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#691880}
-
Albert J. Wong authored
RenderWidgetHost::GetVisualProperties() was doing 3 separate things (1) Actually calculating the VisualProperties (2) Checking against the last stored VisualProperties to determine if the stored copy needs updating. (3) Determining if an ack should be expected if an update is eventually sent with the result of this function. This CL breaks it out into 3 new functions: GetVisualProperties() - Generates the VisualProperties. This should be const but too much of the call chain underneath it did not annotate their getters with const that annotating would be too annoying. DidVisualPropertiesSizeChange() - Helper function that extracts a common query used by DoesVisualPropertiesNeedAck() and StoredVisualPropertiesNeedsUpdate(). DoesVisualPropertiesNeedAck() - Returns true if sending the given VisualProperties update to the renderer will generate an ack. StoredVisualPropertiesNeedsUpdate() - Returns true if the stored copy of the VisualProperties is different enouhg from the incoming one that it needs an update. Bug: 998273 Change-Id: Ie8fee3ddedc1ea8b492765cb5b35e7bda99234de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773878 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#691879}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6431d3a8dd5f..fc8238875e84 git log 6431d3a8dd5f..fc8238875e84 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 mmortensen@google.com Implement DevInstall binhost uploads in the Build API. 2019-08-29 yueherngl@google.com chromeos_config_boards: add kevin-arc64 board 2019-08-29 evanhernandez@chromium.org packages: Small fix for sample PUpr hack Created with: gclient setdep -r src/third_party/chromite@fc8238875e84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I30d160e324033162aa18dd7900c9d78b0b43d847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777039Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691878}
-
Yi Xu authored
In OffscreenCanvasPlaceHolder, placeholder used to refer to both Canvas and OffscreenCanvas. This updates all function names to avoid ambiguity. Change-Id: Ia272c3b9e6f978c8c4f638cc7a8b1606d4a2b29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776405Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#691877}
-
Julian Watson authored
Bug: 990117 Change-Id: I272428fd2c32fd0fddb84dc97ad88693a704f539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775951 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#691876}
-
Kevin Ellis authored
This is a speculative fix for 997076. Animation::ContextDestroyed sets a flag to indicate that the animation is finished and prevents propagation of the finished event. With the code health refactoring in 1739386 and 1773536, the updates could continue after an execution context is destroyed. Bug: 997076 Change-Id: I81d80b45428801abde61ad4122c2027ffe15efc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776732 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
-
Gary Kacmarcik authored
Change-Id: I576dde6f0f55f9fe9ebaec0cfd6c763dd0995337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777077 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#691874}
-
Bettina authored
Previously, we were saving |username_| but still having to create a new ReusedPasswordAccountType in multiple calls from different classes. This could provide inconsistency as there's a possibility that each time we create a new instance, it might refer to a different account. Now, we have one source of truth for an instance of ReusedPasswordAccountType where a warning was shown last for it. Note that we do still have to keep |username_| because GetOrganizationName needs it to grab the AccountInfo which gives us the email to grab the domain. Bug: 914410 Change-Id: I39c0c09baaa03158727a52ac631cbaed7e57d30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754793Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#691873}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/961b4af1ff28..8fe3e6ac1d7a git log 961b4af1ff28..8fe3e6ac1d7a --date=short --no-merges --format='%ad %ae %s' 2019-08-29 rmhasan@google.com Reland "[Telemetry] Remove StoryExpectations class which was used for the old expectations format" Created with: gclient setdep -r src/third_party/catapult@8fe3e6ac1d7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:973936 Change-Id: I631bee2216538d87b699dedbde6c4834f24c9137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777038Reviewed-by:
-
Erik Chen authored
Asynchronous IPCs can be invoked re-entrantly from DevTools debugger. This means that it is not safe to synchronously destroy RenderWidget from IPC. Bug: 998419 Change-Id: I7bce6c00c82c93606fe978d5db1711035197fb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776737 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Vikas Soni authored
SkiaRenderer GL mode started failing recently because StreamTextureSharedImageInterface can now be initialized later (MCVD path) after creating the shared image in which case StreamTextureSharedImageInterface don't have gfx::Size information at shared image construction time. This CL fixes above issue by passing gfx::Size param explicitly in constructor. Vulkan mode is still broken and will be fixed by a follow up CL. Change-Id: Ib57378cae09d6bee9200219d6743baf811fafa50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775205Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#691870}
-
Gayane Petrosyan authored
In this CL the logo and shortcut color calculation is split into 2 parts. The color calculation based on the theme is moved to themes, and defaults are moved to ThemeProperties. The logo and shortcut colors can be overridden when custom background is set. This logic is moved to instant_service. NTP text and logo_alternate logic is also moved out of searchbox_extension. Bug: 983717 Change-Id: I12b938ba8a833bd920cf224171163781889989a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759150Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#691869}
-
Sam Goto authored
Per our UX guidance [1], we want to parse the one time code from the SMS message and display it in our InfoBar. This CL updates the SMSParser to extract the one time code from the URL parameters as a server-side convention and plumbs it all the way to the InfoBar. [2] has a screenshot of how close we get in this CL to our UI mocks [1]. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=994874#c3 [2] https://storage.cloud.google.com/chromium-translation-screenshots/ec42e9bf6331f8ff015d0965578b87c52b19d4bd Bug: 994874 Change-Id: I1dbfcca50f733f91531e173db8bf23b58af13b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761525Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#691868}
-
Fabrice de Gans-Riberi authored
This skips a file copy. Bug: 973159 Change-Id: Idb3883c7afec3ad1b6725ff0b47f9640c3bc8c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776608 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#691867}
-
Julian Watson authored
Bug: 995615, 991461 Change-Id: I7dd728be3e8889103df660b92d16893367150f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775883 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
-
Pavel Shmakov authored
When a Custom Tab is started with COLOR_SCHEME_SYSTEM on Android versions before Q, it will now follow the system power saving mode. Behavior on Q is unchanged. Monitoring power saving mode is part of GlobalNightModeStateController. We can't reuse it as a whole, because it also looks at Chrome's theme setting. So tracking power saving is extracted into PowerSavingModeMonitor to be reused in Custom Tabs. Bug: 994702 Change-Id: Ib7550eddf2c70ca68c25f654fffdd2922f62e2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762219Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#691865}
-
Xiaocheng Hu authored
Currently, CSSTransformInterpolationType calls AccumulateLengthArray() only to obtain the length unit types involved in a <length> value, which is an overkill. Hence, this patch changes it into obtaining the types only. This also unblocks the code from working on <length> values involving min/max, as these values cannot be converted into a length array. Bug: 991672 Change-Id: Ib2865be502e2306fdbf2e1b5f4bafe26047ed5bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775424Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#691864}
-
- 29 Aug, 2019 4 commits
-
-
Khushal authored
There seems to be a race condition in the framework which results in a crash if we transition between SurfaceViews too soon at app startup. This change removes that to verify the theory. It was initially added to avoid additional color layers when we use video overlays with SurfaceControl, but its unclear what the cost of this is. For now, just remove the transition altogether and if it turns out that this is an issue we can try delaying the transition after startup. R=dtrainor@chromium.org Change-Id: I422a396aa3616773629933657dd1a5baf1341ce7 Bug: 998311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776906 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#691863}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/eb56ee5a28b4..565f1b848215 git log eb56ee5a28b4..565f1b848215 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 misterg@google.com Merge pull request #2398 from kuzkry:custom-type-traits-iterator_traits 2019-08-29 misterg@google.com Merge pull request #2420 from kuzkry:remove-autotools-section Created with: gclient setdep -r src/third_party/googletest/src@565f1b848215 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/googletest-chromium-autoroll Please CC isamsonov@google.com,staphany@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official TBR=isamsonov@google.com,staphany@google.com Bug: None Change-Id: I64aa93681d28db0a120f61c79000c7072a195fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775810Reviewed-by:
-
Jenny Blessing authored
Button: https://screenshot.googleplex.com/QomEiR3L6as.png Confirmation dialog: https://screenshot.googleplex.com/txvwbkxyFBe.png Bug: 987177 Change-Id: Ib869fba73ea266f50bb0ea2fed0900c0e9268f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762210Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Jenny Blessing <jblessing@google.com> Cr-Commit-Position: refs/heads/master@{#691861}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68cb8b023920..165ca3f85b7a git log 68cb8b023920..165ca3f85b7a --date=short --no-merges --format='%ad %ae %s' 2019-08-29 fmalita@chromium.org [skottie] Text selector ease-high/ease-low support Created with: gclient setdep -r src/third_party/skia@165ca3f85b7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: Ib5f1996dc561236927f3cdf38fc4ec415a14b810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775835Reviewed-by:
-
