- 25 Feb, 2019 40 commits
-
-
Darren Shen authored
We would like to test the accessibility keyboard in Tast, but it's activated based on a pref. We'll whitelist this pref so that Tast can set it to true to bring up the accessibility keyboard. Note: this introduces another ash dependency from chromeos. Bug: 879073 Change-Id: I593e4d544ea4f0e1717c4a683d0fe65d2a7a7a38 Reviewed-on: https://chromium-review.googlesource.com/c/1485691Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#635254}
-
Xiaocheng Hu authored
Bug: 935688 Tbr: mek@chromium.org NoTry: True Change-Id: Ic7add940d264e1fc4b3e77cbaf7e49e2c3f6fd2f Reviewed-on: https://chromium-review.googlesource.com/c/1487370Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635253}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d7d9726d..9e322313 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie4d815edd2d1a055297e2c17b54bf5496afd3902 Reviewed-on: https://chromium-review.googlesource.com/c/1487071Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635252}
-
Xianzhu Wang authored
Add the following UMA metrics: - Blink.Paint.CachedItemPercentage: percentage of cached display items among all display items. Higher number means higher performance because of less invalidated display items. - Blink.Paint.IndexedItemPercentage: percentage of indexed display items during out-of-order matching of display items. Lower number means higher performance because of less cost of out-of-order matching and indexing. - Blink.Paint.CachedSubsequencePercentage: percentage of cached subsequences. Higher number means higher performance because of less invalidated subsequences. The numbers are accumulated for multiple PaintController paint sessions. We report the percentages after updating paint in a document lifecycle when we have enough data to report. They will help analyze progression/regressions of Blink.PrePaint.UpdateTime and Blink.Paint.UpdateTime. Change-Id: I000cff61165673c7e9a3c132e0007d85a7d96fc1 Reviewed-on: https://chromium-review.googlesource.com/c/1485234Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635251}
-
Toni Barzic authored
Removes update screen related exit codes from ScreenExitCode enum, and adds a separate enum to UpdateScreen class. Error exit codes are condensed into a single UPDATE_ERROR code (as the action taken by wizard controller is pretty much the same for all), and the decidion whether non-critical updates should be ignored is moved from WizardController to UpdateScreen - i.e. for non critical updates, UpdateScreen will return UPDATE_NOT_REQUIRED result instead of an error. Changes how UpdateScreen reports exit - instead of calling the BaseScreenDelegate::OnExit, it runs a callback that is provided in its constructor. BUG=930267 Change-Id: I74b9c4c87f213eafbe6adb98f8942d4d8450dc09 Reviewed-on: https://chromium-review.googlesource.com/c/1481852Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#635250}
-
Nate Fischer authored
This implements WebView's SetCheckClearTextPermitted functionality for the NetworkService code path, fixing the related test. This mostly copies the legacy code path implementation (which uses a static method on AwURLRequestContextGetter). To implement this, we must extend the NetworkContext mojo interface. Since this functionality is entirely Android specific (no other OS enforces cleartext at the moment), this exposes this as an Android-only method on the interface. As a special note: we must set the cleartext setting for both code paths, for every run. This is because we configure this setting before the FeatureList itself is initialized, so we can't reliably know which code path we will use. Therefore, we plumb the setting to both code paths, so it's always available for the code path we need. Bug: 899012 Test: run_webview_instrumentation_test_apk \ Test: --enable-features=NetworkService,NetworkServiceInProcess \ Test: --gtest_filter=AwContentsStaticsTest.testSetCheckClearTextPermittedTrue Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Ic4b93fb65e79676cef8eda268ac70725ebdc2517 Reviewed-on: https://chromium-review.googlesource.com/c/1484585Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#635249}
-
Nico Weber authored
Bug: 926235 Change-Id: Idbe191988ab7b912c9b9af2e5c9f266fa633b274 Reviewed-on: https://chromium-review.googlesource.com/c/1486874 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635248}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f6b0439fb639..9dc060116dbd git log f6b0439fb639..9dc060116dbd --date=short --no-merges --format='%ad %ae %s' 2019-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1776af77065f..8c1e8f1fb771 (1 commits) 2019-02-25 scroggo@google.com Reland "Treat kWEBP encode with quality=100 as lossless" 2019-02-25 scroggo@google.com Add a wuffs Release bot 2019-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5efe61188243..1776af77065f (1 commits) Created with: gclient setdep -r src/third_party/skia@9dc060116dbd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I4d277300acb50e5923e9fc0ec68fe2f75c5bcdbe Reviewed-on: https://chromium-review.googlesource.com/c/1487134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635247}
-
vitaliii authored
Enable scrypt key derivation when setting sync custom passphrase in testing/variations/fieldtrial_testing_config.json. Bug: 875901 Change-Id: Idcfb76d8e1c1977875bd401520e665ffb0010399 Reviewed-on: https://chromium-review.googlesource.com/c/1483077 Auto-Submit: vitaliii <vitaliii@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#635246}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/986b2bef7f47..2d403737b88f $ git log 986b2bef7..2d403737b --date=short --no-merges --format='%ad %ae %s' 2019-02-24 marpan vp9-rtc: Fix to Q clamp in adjust_q_cbr 2019-02-22 marpan vp9-rtc: Decrease noise estimation thresh for kLow 2019-02-22 kyslov Fix 32-bit unsigned integer overflow in block_variance 2019-02-21 marpan vp9-rtc: Adjust thresholds for noise estimation. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I822c29345662f2a24976af4e56af25a1f606c8cf Reviewed-on: https://chromium-review.googlesource.com/c/1487171Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#635245}
-
Robert Ogden authored
Change-Id: Ie6a5dbe84f22c21a296cd7c40a74b6ebb895fbb7 Reviewed-on: https://chromium-review.googlesource.com/c/1484414 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#635244}
-
John Abd-El-Malek authored
Stop running network_service_headless_browsertests on linux bots as network service is now enabled there. Bug: 933880 Change-Id: I9c8122968c0d6f6132a84481cb6e4afe63be2eaa Reviewed-on: https://chromium-review.googlesource.com/c/1487703 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#635243}
-
Mike Wittman authored
Eliminates the internal null Module state in favor of nullptr. Bug: 931418 Change-Id: I8d7f6f00f5433d189542bceb790ca23c5b97fb4d Reviewed-on: https://chromium-review.googlesource.com/c/1478095 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#635242}
-
Etienne Bergeron authored
The trace event is setting an args on a SkString which may no longer exists when the trace event id dumped. This trace event needs to duplicate the string. As this is a SkString, we can't use the default tracing macro that detect a str::string argument. R=oysteine@chromium.org TBR=drott@chromium.org Change-Id: I2935bb8162c79edc2f3dc213eb1600fa7f2183e5 Reviewed-on: https://chromium-review.googlesource.com/c/1486873 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
-
Koji Ishii authored
This was added in r564717 (CL:1084314), but more recent changes that makes NG selection more similar to legacy makes this no longer necessary. Bug: 636993 Change-Id: I181bff37b32f142c2dd1e2897a519f2191a7b607 Reviewed-on: https://chromium-review.googlesource.com/c/1482352 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635240}
-
Xiaocheng Hu authored
Bug: 935688, 935689, 935690 Tbr: xiaochengh@chromium.org NoTry: True Change-Id: I5c4cab2bb7ebf6cb66dc60a13ac47bf39becd4a3 Reviewed-on: https://chromium-review.googlesource.com/c/1487707Reviewed-by:
-
David Jacobo authored
After intent picker taking a more generic role (not used for ARC apps only), AppsNavigationThrottle was introduced, which implements the throttle logic ArcNavigationThrottle was responsible for before. This CL proposes renaming ArcNavigationThrottle to ArcIntentPickerAppFetcher so it reflects more accurately its usage. Bug: 915852 Test: Previous unit/browser tests passing. Change-Id: I5fceb11524ddac2b74345ce4924aaf3ebfba3b12 Reviewed-on: https://chromium-review.googlesource.com/c/1483704Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635238}
-
Eugene But authored
Bug: 934379 Change-Id: Idaaffef3e449f3ea7250028f6507c5ebb63d1d12 Reviewed-on: https://chromium-review.googlesource.com/c/1483736Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#635237}
-
Jacob Dufault authored
We may want to just use FakeGaia directly instead of introducing a mixin, but that can be decided later. For now let's focus on simplifying all of the test bases. Bug: 912704 Change-Id: Id4a7ab8e0c23343b7e6e59c7b7d2aefc16891515 Reviewed-on: https://chromium-review.googlesource.com/c/1366895 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4a8da2c58a9d..62f4f3343374 Created with: gclient setdep -r src-internal@62f4f3343374 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:916361,chromium:790424,chromium:790423,chromium:790405 TBR=mmoss@chromium.org Change-Id: I4f1e49cb37fb2ed240bc6ca6f8a001890bc0ca3a Reviewed-on: https://chromium-review.googlesource.com/c/1487591Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635235}
-
Joshua Peraza authored
b1739cc67f57 crashpad: Remove semicolons, Windows edition 9d26012e9c73 POSIX: don’t be overly restrictive about mmap() region length dc17650336ad fuchsia: Update MultiprocessExec.BuiltinTrapTermination for task kill revamp 99bf283e54d0 android: Add methods to start handler with /system/bin/linker Change-Id: Ia525db34270c866d1f28fbdf71c9487720a2b110 Reviewed-on: https://chromium-review.googlesource.com/c/1487177 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#635234}
-
Peter Kasting authored
This will be used by drag-and-drop tests to trigger actions when the drop menu appears. Bug: 923188 Change-Id: I52cc3a0eab14f562c98653defcaaba9cad9bf50d Reviewed-on: https://chromium-review.googlesource.com/c/1483699 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Tim Song authored
Some notifications automatically dismiss themselves, and if it is currently focused, its desctructor invokes a refocus and scroll that causes it to be referenced, resulting in a crash. The fix is to introduce a flag marking the UnifiedMessageListView as currently deleting notifications to prevent re-entrancy. TEST=new test case, manually verified no behaviour change BUG=933327 Change-Id: Ib070ddfc73f62a4c321e6a22e942cb559cfe65fe Reviewed-on: https://chromium-review.googlesource.com/c/1480275 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#635232}
-
Owen Min authored
Add a new |is_pretty_print| flag to GetAllPolicyValuesAsDictionary and GetAllPolicyValuesAsJSON function. All JSON objects including JSON policy values will not be pretty printed if the parameter is set to False. This is mainly used by cloud reporting to reduce report size. Bug: 935653 Change-Id: Iec94b27582758bcef866d69dbb8df561544ae95b Reviewed-on: https://chromium-review.googlesource.com/c/1487511Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635231}
-
Mike Reed authored
Bug: skia:8773 Change-Id: Ib8695ce0ed7a1018781c2b9161a1d29c3a1d0b1e Reviewed-on: https://chromium-review.googlesource.com/c/1476535Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#635230}
-
Joel Hockey authored
This reverts commit ee05382c. Reason for revert: browser_tests fail to compile for chromeos ../../chrome/browser/chromeos/login/sync_consent_interactive_ui_test.cc:82:10: error: allocating an object of abstract class type 'test::TestConditionWaiter' return test::TestConditionWaiter(base::BindRepeating( ^ ../../chrome/browser/chromeos/login/test/test_condition_waiter.h:17:16: note: unimplemented pure virtual method 'Wait' in 'TestConditionWaiter' virtual void Wait() = 0; ^ 1 error generated. Original change's description: > cros: Introduce common concept for conditions that can be awaited it tests. > > Bug: 912704 > Change-Id: Ie1804ce8a6f05721e28a6d2c703530d8e0c53841 > Reviewed-on: https://chromium-review.googlesource.com/c/1481511 > Commit-Queue: Denis Kuznetsov <antrim@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635114} TBR=antrim@chromium.org,alemate@chromium.org,rsorokin@chromium.org,jdufault@chromium.org Change-Id: Id0e69390d0d106f00d1a4527479b4a1752402324 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912704 Reviewed-on: https://chromium-review.googlesource.com/c/1487433Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#635229}
-
Bence Béky authored
Change-Id: I1806570ef5d7d6f62dd2e7d3bbe9d33d7dce2646 Reviewed-on: https://chromium-review.googlesource.com/c/1484825Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#635228}
-
Jao-ke Chin-Lee authored
TBR=hinoka Bug: 907562 Change-Id: Ibe6c3d12fa8fadd5f05fd6b8a5b3a95fee5f7a0e Reviewed-on: https://chromium-review.googlesource.com/c/1485065Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#635227}
-
Xiaocheng Hu authored
Bug: 935678 Tbr: dmazzoni@chromium.org NoTry: True Change-Id: Ib2d2182069250b68196c43e707ccbd30c9b1fd3e Reviewed-on: https://chromium-review.googlesource.com/c/1487700Reviewed-by:
-
John Abd-El-Malek authored
NOTRY=true TBR=mek@chromium.org Bug: 933880 Change-Id: Iaabc83ae1386bc536a56961fbb930eb2cb88f881 Reviewed-on: https://chromium-review.googlesource.com/c/1487702Reviewed-by:
-
Bruce Dawson authored
This reverts commit 7a0168cc now that we don't need to work around the VC++ bug. Bug: 934323 Change-Id: I594c2c6b86096ffc8643e0f9ceb5b357e1c214be Reviewed-on: https://chromium-review.googlesource.com/c/1484353 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#635224}
-
Ted Choc authored
This will remove the dependency on the server experiment to disable it while we test on earlier channels. BUG=927509 Change-Id: I933bfd29d8df6284a51ed182bf124c883f789f4d Reviewed-on: https://chromium-review.googlesource.com/c/1487358Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#635223}
-
Eugene But authored
This CL fixes 'Copy to Chrome' in multitasking mode when kExternalFilesLoadedInWebState flag is enabled. URL is set to completeURL (which is file:// URL) and virtualURL is set to externalURL (which is chrome:// URL). This is necessary because WebState knows how to render file URLs but can not render chrome:// URL. The code was copied from UserAcrtivityHandler, so this CL can be cherry-picked to M73. Code duplication cleanup will be done in a follow up CL. Bug: 934789 Change-Id: I490cea33171b25ff73ef713c8610a64da9d8145f Reviewed-on: https://chromium-review.googlesource.com/c/1484631 Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#635222}
-
Joe DeBlasio authored
This is a reland of c9078153 which was reverted because it triggered a bug fixed in http://crrev.com/c/1483732 . Original change's description: > Hide URL from lookalike URL warning interstitial. > > This CL adds support for hiding of URLs in the omnibox by security > interstitials so as to enable it for the lookalike URL interstitial. > > Bug: 927924 > Change-Id: I2a7c7311480d6626d2ef27572e326c0a473dc20b > Reviewed-on: https://chromium-review.googlesource.com/c/1478358 > Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634067} Bug: 927924 Change-Id: I14e5db4d7eec03b060df25569fa38ce1cd1e8522 Reviewed-on: https://chromium-review.googlesource.com/c/1482940Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#635221}
-
Yi Su authored
ios_web_shell_egtests.NavigationTestCase can be removed now since it's covered by ios/web/navigation/history_state_operations_inttest.mm. Bug: 930859 Change-Id: Ib14239b206799d1429070800ad7ee259faaaee69 Reviewed-on: https://chromium-review.googlesource.com/c/1486338 Commit-Queue: Yi Su <mrsuyi@chromium.org> Auto-Submit: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#635220}
-
Martijn Croonen authored
This updates from revision 5af964eadf5b6baaf5f612746837cb154e1f73b1 (2018-11-08) to revision 0e2a405f597a3c1be456d704b42bdd5e0d4954bb (2019-02-21) Bug: 928091 Change-Id: I2c0582cbd3724211fca8990ded30232351290588 Reviewed-on: https://chromium-review.googlesource.com/c/1484301Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#635219}
-
Xiaocheng Hu authored
[Sheriff] Mark virtual/bidi-caret-affinity/editing/selection/modify_move/move_left_word_09_rtl_multi_line.html as flaky leak Bug: 894651 Tbr: xiaochengh@chromium.org NoTry: True Change-Id: I501a7dd5576570cb26075aa16b2cde53064a387d Reviewed-on: https://chromium-review.googlesource.com/c/1487694Reviewed-by:
-
Lukasz Anforowicz authored
This is a 2nd reland of https://crrev.com/c/1441277 (1st reland was in https://crrev.com/c/1481535). This reland lands just the product code changes, without a test that flakily failed on linux-chromeos-rel. We will attempt to also reland the test in separate follow-up CL - this work will be tracked in http://crbug.com/934612. Original CL description follows below: Google Translate executes its scripts inside "isolated worlds". This is quite similar to how extension content scripts execute and has a consequence of using |request_initiator| set to the origin of the isolated world (rather than to the origin of the page where the script was injected). This is problematic for 2 reasons: 1. It leads to renderer kills, when an AppCache verifies |request_initiator| using CPSPI::CanAccessDataForOrigin. 2. It leads to incompatibility between |request_initiator| and |request_initiator_site_lock| which can also cause wrong/harsh security decisions (e.g. CORB blocking of otherwise benign requests). This CL addresses the problems above, by making sure that requests initiated by the Translate's "isolated worls" will use a separate URLLoaderFactory. - For injecting and selecting the factory on the renderer side, the same mechanism is used as for extension content scripts (i.e. URLLoaderFactoryBundleInfo::initiator_specific_factory_infos is populated for the origin associated with the "isolated world"). - For simplicity and to avoid races, the separate URLLoaderFactory is sent from the browser to the renderer process in the same, single IPC that triggers script injection into an isolated world (i.e. in translate::mojom::Page::Translate method). As a side effect, this CL also causes Translate's requests to go directly to the NetworkService (rather than to the AppCache's AppCacheSubresourceURLFactory). This seems desirable. Bug: 925457, 934612 Tbr: John Abd-El-Malek <jam@chromium.org> Tbr: Daniel Cheng <dcheng@chromium.org> Change-Id: I638d3065c2afc001e67d7631e09658015c9c9d3c Reviewed-on: https://chromium-review.googlesource.com/c/1482944 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#635217}
-
Peter Kasting authored
Bug: 431427, 820435, 828063, 863296 Change-Id: I40b7b8129ebc72b3798f5d360e4ed2fa933847c7 Reviewed-on: https://chromium-review.googlesource.com/c/1483677Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#635216}
-
Mei Liang authored
This CL integrates TabModelFilter into the following UI: * TabCountProvider * LayoutManager and changes these UIs to wait for events from TabModelFilter instead of TabModel. TabModelFilters are provided by TabModelFilterProvider class. They observe TabModel changes and notify their observers about the changes. Bug: 930960 Change-Id: Iad95594f9b3f9002103fcac564f2197468cbee58 Reviewed-on: https://chromium-review.googlesource.com/c/1464118 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635215}
-
