- 12 Mar, 2018 40 commits
-
-
Daniel Bratell authored
Change-Id: I9ce1985082125ab6099f3576d6742aaed73d21d7 Reviewed-on: https://chromium-review.googlesource.com/958165Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#542487}
-
Tommi authored
This call got removed in my last CL by mistake: https://chromium-review.googlesource.com/c/chromium/src/+/890738 Bug: 808801, 820936, 820769, 820830, 820827 Change-Id: I6c6efb3d40d43bc564e18b013ddf5d5d3b09e1eb Reviewed-on: https://chromium-review.googlesource.com/958218 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#542486}
-
Tibor Goldschwendt authored
This is a reland of 83931b97 Original change's description: > [vr] Add compatibility to component 1.y, check integrity of WAV files > > Bug: 811987 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I5c33b4210727b62357e0706c7b19800b98bdebc4 > Reviewed-on: https://chromium-review.googlesource.com/956251 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542128} TBR=waffles@chromium.org,cjgrant@chromium.org Bug: 811987 Change-Id: I806e84ff18a771fda9ea38f2bfe435b0cdba84f2 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/958008Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542485}
-
Jeremy Roman authored
Currently the exception is not thrown until after serialization. This makes us consistent with Gecko and WebKit, which throw before serialization. This fixes the second test case in https://github.com/w3c/web-platform-tests/pull/9672 (not yet pushed to upstream WPT). Bug: 816447 Change-Id: I30b798b5d21dc8d6f2a40d049ced6aa7f60dd090 Reviewed-on: https://chromium-review.googlesource.com/956254Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542484}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/42dd0fcc..7e11bad4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ibf93d6f4568d856119cda3dfcac30fb2468a938b Reviewed-on: https://chromium-review.googlesource.com/957910Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542483}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a9778699. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13763 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Ibe2f1dba251ca56dc114b86bba342d232950b3dc Reviewed-on: https://chromium-review.googlesource.com/957909 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542482}
-
Misha Efimov authored
Bug: 819302 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I218c03a6a308afa265468876db28ff710a09399b Reviewed-on: https://chromium-review.googlesource.com/957126 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#542481}
-
Charles Harrison authored
These lists are scanned for scheme matches hundreds of times per page load. Since most resource requests are https now, we should make sure that the first check is a match more frequently. This patch also does the same with ws/wss, though we don't really have metrics backing up the decision. Bug: None Change-Id: I7fc9bebdafe8cb2b6ca5ede6998b8fa693b08584 Reviewed-on: https://chromium-review.googlesource.com/955730 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#542480}
-
Christian Dullweber authored
This reverts commit 12ac6f19. Reason for revert: Test is flaky Original change's description: > Unskip acid3/numbered-tests.html > > Looks like crbug.com/807627 has been fixed by the recent roll of wpt tools, > in which case this test won't be flaky any more. > > Bug: 805463 > Change-Id: I184560ed406a082c661f313047830d79d5d152d1 > Reviewed-on: https://chromium-review.googlesource.com/957223 > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Commit-Queue: Philip Jägenstedt <foolip@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542263} TBR=foolip@chromium.org,robertma@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 805463 Change-Id: Iec79614a2dfa66353bf4900d95ac7defc3b7a0bf Reviewed-on: https://chromium-review.googlesource.com/959062 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#542479}
-
David Roger authored
This CL adds a dummy refresh token (kInvalidRefreshToken) that can be passed to UpdateCredentials in order to revoke the existing token and put the account in a authentication error state, without doing a full signout. This new functionality is used on Dice web signout for the main account. Bug: 810860 Change-Id: I706b28f91401a8be8108a0d40fbf19d7a5b493cb Reviewed-on: https://chromium-review.googlesource.com/952964 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#542478}
-
Christian Dullweber authored
Disable ContentSettingsTest.BasicCookies and BasicCookiesHttps because they are flaky in network_service_browser_tests. TBR=jam@chromium.org Bug: 820969 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I99e73d50942b04f680750abf0ad40e5dd21b6913 Reviewed-on: https://chromium-review.googlesource.com/958909Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#542477}
-
Gauthier Ambard authored
This CL adds the possibility to trigger side swipe for tab by swiping on the bottom toolbar. Bug: 814735 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I94556de2237fc67ffd41f58a29c3df75f3a7130e Reviewed-on: https://chromium-review.googlesource.com/957185 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#542476}
-
https://skia.googlesource.com/skia.git/+log/ef9b79338675..947326638a25 $ git log ef9b79338..947326638 --date=short --no-merges --format='%ad %ae %s' 2018-03-12 caryclark add SkDebugCanvas to undocumented Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Idce74e35e77a3080a6bc3a657c20f028b1ae30fb Reviewed-on: https://chromium-review.googlesource.com/957751Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542475}
-
Christian Dullweber authored
This reverts commit e23bd4d7. Reason for revert: The change broke compilation on https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder%20(dbg)/63827 Original change's description: > Don't have two copies of //device/fido. > > Prior to this change, both libcontents.so and content_unittests would > each have a copy of //device/fido because the test_support code would > pull in a copy directly. This caused there two be two copies of > |U2fDiscovery::g_factory_func_| – one used by the test_support code and > one by the code that's used for actual processing. That obviously breaks > things. > > This CL makes //device/fido a `component` instead of a `source_set`, > which, however, necessitates adding COMPONENT_EXPORT annotations to all > exported classes/functions/constants. > > The CL also cleans up the components by: > -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and > -- moving dependencies included in public headers into `public_deps`. > > Bug: 785955, 820441 > Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a > Reviewed-on: https://chromium-review.googlesource.com/955698 > Commit-Queue: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Adam Langley <agl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542472} TBR=agl@chromium.org,engedy@chromium.org,jdoerrie@chromium.org Change-Id: I39770f2cd99eafabe50501ad3d90a6442cb3c343 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 785955, 820441 Reviewed-on: https://chromium-review.googlesource.com/959061Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#542474}
-
Sylvain Defresne authored
If a place holder is scheduled to be displayed, do not allow capturing a snapshot. This prevents calling WebState::GetView before WebState::NavigationManager::LoadIfNecessary and thus prevents bumping into issue crbug.com/820484. Bug: 820111 Change-Id: I9d326a0fdccd7b6ea22b1b5477e79b7b7b82a586 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/956188Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#542473}
-
Balazs Engedy authored
Prior to this change, both libcontents.so and content_unittests would each have a copy of //device/fido because the test_support code would pull in a copy directly. This caused there two be two copies of |U2fDiscovery::g_factory_func_| – one used by the test_support code and one by the code that's used for actual processing. That obviously breaks things. This CL makes //device/fido a `component` instead of a `source_set`, which, however, necessitates adding COMPONENT_EXPORT annotations to all exported classes/functions/constants. The CL also cleans up the components by: -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and -- moving dependencies included in public headers into `public_deps`. Bug: 785955, 820441 Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a Reviewed-on: https://chromium-review.googlesource.com/955698 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#542472}
-
jonross authored
Something introduced a lot of flakiness to viz_browser_tests on Windows. So I'm disabling them until we can isolate the cause. TBR=dprank@chromium.org TEST=viz_browser_tests Bug: 820963 Change-Id: I8fc4929ffa7499115928101badbc96f2a7c4dd72 Reviewed-on: https://chromium-review.googlesource.com/957757Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#542471}
-
Rune Lillesveen authored
RecalcStyleForReattach would compute style for slot elements even though they were not part of the flat tree before SlotInFlatTree runtime flag was introduced. Moved SetNonAttachedStyle(nullptr) to Element to make sure we only ever set or clear non-attached style on Elements, and added DCHECKs to support that and the fact that we only set non-attached style on elements which are part of the flat tree. This was partly the regression for 792080, but will not have an effect for the performance tests on master since SlotInFlatTree is enabled. Bug: 792080 Change-Id: I47659300dea9cf4411a4e06f574dbad15c29fdfb Reviewed-on: https://chromium-review.googlesource.com/958465Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#542470}
-
Daniel Bratell authored
Bug: 814776 Change-Id: If68e4015c54a0b60f9a68b7941fb3e5d14b58502 Reviewed-on: https://chromium-review.googlesource.com/958466Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#542469}
-
https://webrtc.googlesource.com/src.git/+log/abff7dd7c9e0..0f1c0bd3265d $ git log abff7dd7c..0f1c0bd32 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia3c3e64106cf89677bc256ebb9faea517b3dd0fa Reviewed-on: https://chromium-review.googlesource.com/957749Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542468}
-
https://chromium.googlesource.com/angle/angle.git/+log/b7d924a8f4ad..391bda23b56d $ git log b7d924a8f..391bda23b --date=short --no-merges --format='%ad %ae %s' 2018-02-23 oetuaho Generate code for initializing built-in variables Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iabf098337876dca36580ab6010b4a7574715718e Reviewed-on: https://chromium-review.googlesource.com/957750 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542467}
-
Jan Krcal authored
This CL makes use of the new API function of FaviconService and thus avoids an unnecessary network request if the icon cannot be stored. Bug: 799447 Change-Id: I187ff46c3b56f895b168eaae04023280e261f1a9 Reviewed-on: https://chromium-review.googlesource.com/951763Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#542466}
-
Denis Yaroshevskiy authored
Change-Id: Ic55a3e2fb14743dd9033e2d5151ebcde8f99212a Reviewed-on: https://chromium-review.googlesource.com/951590Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Denis Yaroshevskiy <dyaroshev@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#542465}
-
Yuta Kitamura authored
This patch moves the WebViewScheduler object currently owned by WebViewImpl to Page. Additionally, a few delegates used by WebViewSchedulerImpl and RendererWebSchedulerImpl are removed and they are replaced with callbacks in PlatformChromeClient. As a side- effect of this, WebViewSchedulerImpl now holds a Persistent handle to PlatformChromeClient. WebViewScheduler is soon to be called "PageScheduler", and some functions in this patch use that name, but the class itself is not renamed in this CL. That will be done in a follow-up CL. Bug: 812986 Change-Id: I09c6b655274abc22cf4289259d9d9eefc0a5c73a Reviewed-on: https://chromium-review.googlesource.com/923688 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#542464}
-
Chris Nardi authored
We internally represent all page-break-* properties as shorthands for break-* properties, per the spec [1]. However, we do not check this on serialization, meaning style.pageBreak* is always "". Add logic into StylePropertySerializer to check for the page break shorthands. [1]: https://drafts.csswg.org/css-break/#page-break-properties Bug: 659297 Change-Id: Id8fc71f7f279d474f39ce37fbd3ad7791e1b40c7 Reviewed-on: https://chromium-review.googlesource.com/957836Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#542463}
-
https://skia.googlesource.com/skia.git/+log/e8de02456a10..ef9b79338675 $ git log e8de02456..ef9b79338 --date=short --no-merges --format='%ad %ae %s' 2018-03-12 angle-skia-autoroll Roll skia/third_party/externals/angle2/ b7d924a8f..391bda23b (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ic5df3381f477803f783ea7310b3783b70b947f52 Reviewed-on: https://chromium-review.googlesource.com/958004Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542462}
-
Mikel Astiz authored
We introduce a dedicated method in ModelTypeStore to avoid round trips across threads when a datatype's desire is to delete it all (data and metadata). Benefits include: - Simpler code: bridge's don't need to read+delete. - (Hopefully) more robust against crashes during DisableSync(). - Less error-prone: we've had examples in the past where overriding DisableSync() forgot to call the base class's implementation, leading to metadata staying around. Bug: 819233, 820049 Change-Id: If6b7b04ee73b8c6a28aef7380a7eb91b866f1567 Reviewed-on: https://chromium-review.googlesource.com/955624 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#542461}
-
Max Morin authored
The lock shouldn't be very contended, but in this case the lock is easy to get rid of, so we probably should. Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I53ac4bed5b4d97e5cf67e388f32fe8facaf6b170 Reviewed-on: https://chromium-review.googlesource.com/955843Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542460}
-
Yuichiro Hanada authored
KeyEventDoneCallback is converted to OnceCallback. LanguageNameLocalizationCallback and GetLocalizedStringCallback in FakeInputMethodDelegate are converted to RepeatingCallback. Also, base::Passed() with BindOnce is replaced to std::move(). Test: Unit tests pass. Change-Id: Icae5aa23b66e376e90552d185da11039514313cf Reviewed-on: https://chromium-review.googlesource.com/897174 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#542459}
-
Alexander Timin authored
content/renderer/scheduler is empty and not used. Delete it. R=skyostil@chromium.org Change-Id: I723805bba5ed3eb5a34ab304217ca610f04913b9 Reviewed-on: https://chromium-review.googlesource.com/956136Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542458}
-
Chris Nardi authored
css3/calc/color-{hsl/rgb}.html are already covered by external/wpt/css/css-values/calc-in-color-001.html, and fast/css/named-colors.html is already covered by external/wpt/css/css-color/color-resolving-keywords.html. Remove these duplicate tests. Change-Id: I2540ae5a6280bbfad0eb2192862826fc483d8314 Reviewed-on: https://chromium-review.googlesource.com/958285Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#542457}
-
Alexander Timin authored
Split scheduler-bugs@chromium.org into scheduler-bugs+cc@chromium.org and scheduler-bugs+blink@chromium.org Introduce scheduler-bugs+base@chromium.org covering base/task. R=skyostil@chromium.org Change-Id: I404eceac5352d24494ccb5bd3d016c8441a582d2 Reviewed-on: https://chromium-review.googlesource.com/955650Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542456}
-
Daniel Cheng authored
IsLocalRoot() is needed since WebLocalFrame::FrameWidget() is changing to always return a WebFrameWidget. IsProvisional() is useful to have a common check for the workarounds for provisional frames so they can be easily cleaned up later. Bug: 478281, 578349, 820782 Change-Id: Icf1411261a044b2fa393c614c9bec93b3f3bc4b7 Reviewed-on: https://chromium-review.googlesource.com/958582 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#542455}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6487d3d1..42dd0fcc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib1019dc5eb91862fd4c3a90f33104f654bb685d4 Reviewed-on: https://chromium-review.googlesource.com/957906Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542454}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fdc9e0f1. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13762 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=foolip No-Export: true Change-Id: Ib56c733fa2f22e10258dfa36b00c8bcf91517eec Reviewed-on: https://chromium-review.googlesource.com/957904 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542453}
-
Boris Sazonov authored
This CL exposes UnifiedConsent feature to Java and adds a skeleton of SigninActivity, which is created if this feature is enabled. This activity currently contains an empty container for SigninFragment that will be added by subsequent CLs. Bug: 814728 Change-Id: Ic12cfeb7b1fa3732ac625095412473fd12d1781b Reviewed-on: https://chromium-review.googlesource.com/952971Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#542452}
-
Ned Nguyen authored
Change-Id: Ifd0d8b0fd24aea3fa45965722543dbb0641e1991 Reviewed-on: https://chromium-review.googlesource.com/949807 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#542451}
-
Tsuyoshi Horo authored
To match spec text changes in https://github.com/WICG/webpackage/commit/3cae549. Bug: 803774 Change-Id: I31dc56506cdaf1d67b05eba15b77d3c7fef89b33 Reviewed-on: https://chromium-review.googlesource.com/958748 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#542450}
-
Christian Dullweber authored
The test is flaky on linux-chromeos-dbg. TBR=xiyuan@chromium.org Bug: 811379 Change-Id: If35f60f4f24df396e181628a276ad94fc6ccba94 Reviewed-on: https://chromium-review.googlesource.com/958467Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#542449}
-
Takashi Toyoshima authored
Now, ResourceLoader calls WebURLLoader's interface in DidChangePriority if |loader_| instance is already created. But we do not want to call it if the instance is still in the ResourceLoadScheduler's queue. Bug: 819931 Change-Id: I93bd5abc3d32a2b9a822372700d864adb8bbdf93 Reviewed-on: https://chromium-review.googlesource.com/958648Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#542448}
-