GitLab

BUG=396557

Review URL: https://codereview.chromium.org/424613003

Cr-Commit-Position: refs/heads/master@{#289279}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289279 0039d316-1c4b-4281-b951-d872f2087c98

Pass systrace categories to chrome_profiler as a comma separated single
argument instead of one argument per category. This fixes a bug where
only the first category was actually enabled.

We also set the output format to JSON because it's not necessary to wrap
the resulting systrace into a HTML container as we end up zipping the
result anyway.

TEST=tools/perf/run_benchmark smoothness.key_mobile_sites --browser=android-chrome --page-filter=linked --profiler=android-systrace

Review URL: https://codereview.chromium.org/457823004

Cr-Commit-Position: refs/heads/master@{#289277}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289277 0039d316-1c4b-4281-b951-d872f2087c98

http://crrev.com/287864 fixed an issue where a renderer that was killed in
background and later reloaded was being respawned with incorrect process
visibility, causing it to be killed on Android.

The fix skipped resetting the |is_hidden_| flag of RenderWidgetHost, so that
RenderWidgetHost crashing in background would retain its visibility status and
trigger the ::Show() paths correctly when recreating the View in foreground,
fixing the process visibility issues.

Unfortunetely, this wasn't that good of an idea.

It turns out that while it is the RenderWidgetHost that is the authoritative
source of visibility truth that views rely on, it is the view that is
responsible for providing signals (WasShown / WasHidden) to the widget host.
That means that after a renderer crashes and the view is destroyed,
RenderWidgetHost has no way to track its visibility anymore and all bets are
off.

It turns out that view implementations on Aura and Mac relied on the
RenderWidgetHost visibility being reset upon crash (http://crbug.com/401859).
Hence, this patch undoes the original "fix" and instead ensures that resetting
the |is_hidden_| flag issues a notification for the RenderProcessHost, so that
the process visibility signal that we attempted to fix with the original patch
is still working.

Regression test for http://crbug.com/399521 is in Chrome for Android repo
(BindingManagerIntegrationTest).

BUG=399521
BUG=401859

Review URL: https://codereview.chromium.org/459613007

Cr-Commit-Position: refs/heads/master@{#289276}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289276 0039d316-1c4b-4281-b951-d872f2087c98

This patch returns the bitmap of the current tab favicon.

BUG=

Review URL: https://codereview.chromium.org/364793005

Cr-Commit-Position: refs/heads/master@{#289275}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289275 0039d316-1c4b-4281-b951-d872f2087c98

The existing DVLOG creates a huge amount of log output when using a */media/*=1 filter.

TBR=xians1
BUG=none

Review URL: https://codereview.chromium.org/465313002

Cr-Commit-Position: refs/heads/master@{#289274}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289274 0039d316-1c4b-4281-b951-d872f2087c98

XLookupString depends on user's locale settings (LC_CTYPE).  The returned string is encoded in LC_CTYPE, and if the string cannot be respresented in LC_CTYPE, it becomes an empty string.  i.e. users cannot input characters.

This CL introduces our own map from KeySym (virtual key code in X) to Unicode character.  This map works independent from user's locale.

BUG=395019
TEST=Done manually.
R=sadrul@chromium.org, wez@chromium.org

Review URL: https://codereview.chromium.org/430463005

Cr-Commit-Position: refs/heads/master@{#289272}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289272 0039d316-1c4b-4281-b951-d872f2087c98

Clear trivially solvable dirty flag in earlier phase than before, so that consecutive local changes doesn't conflict to each other.

BUG=344769
TEST=unit_tests --gtest_filter=DriveBackendSyncTest.*

Review URL: https://codereview.chromium.org/443793003

Cr-Commit-Position: refs/heads/master@{#289271}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289271 0039d316-1c4b-4281-b951-d872f2087c98

Allow enhanced bookmarks external component extensions to be
disabled/uninstalled. This facilitates ongoing development and testing
of multiple versions of extensions that are ultimately released as
external component extensions.

BUG=401315

Review URL: https://codereview.chromium.org/445233002

Cr-Commit-Position: refs/heads/master@{#289270}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289270 0039d316-1c4b-4281-b951-d872f2087c98

Use ContextCreationAttribHelper through the context creation in both
in-process and out-of-process cases, instead of duplicate structures such
as GLInProcessContextAttribs. Enums used for serializing the attributes
are now defined in only one place, instead of three.

Remove small pieces of dead code related to share groups.
share_resources_ attrib is removed since it is not in use anywhere.

gpu_unittests are changed to better model how bind_generates_resource
gets set, and new checks are added to make sure it is set consistently
everywhere.

TEST=WebGL conformance tests (with and without --in-process-gpu),
cc_unittests, gpu_unittests

BUG=

Review URL: https://codereview.chromium.org/455783002

Cr-Commit-Position: refs/heads/master@{#289269}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289269 0039d316-1c4b-4281-b951-d872f2087c98

This broke CertLoader initialization (e.g. required for configuring EAP-TLS networks) when
 a) the device was enterprise enrolled and the user has modified chrome://flags
 b) the browser crashed and restarted.

BUG=399807, 401800
TEST=Enterprise enroll device, modify a flag on chrome://flags, restart, try to configure/connect to an EAP-TLS network with client certificate.

Review URL: https://codereview.chromium.org/460423002

Cr-Commit-Position: refs/heads/master@{#289267}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289267 0039d316-1c4b-4281-b951-d872f2087c98

Content is swizzled when texture format has different component order
than expected format by platform. RGBA_4444 implies to use 4444 bits and
does not affect component order. So, no need to swizzle contents.

BUG=399634

Review URL: https://codereview.chromium.org/460563003

Cr-Commit-Position: refs/heads/master@{#289266}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401921

Review URL: https://codereview.chromium.org/454983002

Cr-Commit-Position: refs/heads/master@{#289265}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289265 0039d316-1c4b-4281-b951-d872f2087c98

This reapplies r289149: GN: Specify grit generated output paths to be the same as gyp's.
together with outstanding CL: https://codereview.chromium.org/467023003/

TBR=brettw@chromium.org,thestig@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=

Review URL: https://codereview.chromium.org/468733003

Cr-Commit-Position: refs/heads/master@{#289264}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289264 0039d316-1c4b-4281-b951-d872f2087c98

When CL 430573002 landed, it forced the use of libpci on linux, but
many embedded systems lack this library (and probably lack a pci bus
altogether). Let's add a new config variable to make it possible to
disable the use of libpci.

BUG=398416

Review URL: https://codereview.chromium.org/462433002

Cr-Commit-Position: refs/heads/master@{#289262}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289262 0039d316-1c4b-4281-b951-d872f2087c98

In the current Android code structure, ContentViewCore is just acting as a wrapper to many WebContents functions.

In this patch we are trying to position the WebContents functionalities to web_contents_android file from
ContentViewCoreImpl to make it functionally readable. Ensuring there is a one-to-one mapping between
WebContents Java and native counterparts.

BUG=398263

Review URL: https://codereview.chromium.org/414423002

Cr-Commit-Position: refs/heads/master@{#289261}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289261 0039d316-1c4b-4281-b951-d872f2087c98

The ChromeExtensionNetworkDelegate::OnBeforeURLRequest is called for new
requests as well as for redirects. This results in the lazy keep alive
count in extensions to be incremented several times if there is a redirect
but then it is decremented only ones when the request finishes. In consequence
the lazy extension page never shuts down because the count never reaches
zero.

With this commit requests that have been redirected at least once are
ignored when incrementing the keep alive count.

BUG=175279

Review URL: https://codereview.chromium.org/464933002

Cr-Commit-Position: refs/heads/master@{#289260}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289260 0039d316-1c4b-4281-b951-d872f2087c98

Updated strings for setup error messages
Added few new error strings
Added strings for "Adding Nth Chromebook" notification
Added strings for the screenlock
Added strings for setup dialog button label in error state.

BUG=393792, 397366, 397532, 402106, 402269, 402584, 401787
TEST=NONE

Review URL: https://codereview.chromium.org/452243003

Cr-Commit-Position: refs/heads/master@{#289259}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289259 0039d316-1c4b-4281-b951-d872f2087c98

The LocalServerController closes the LocalServer now.

Review URL: https://codereview.chromium.org/471443002

Cr-Commit-Position: refs/heads/master@{#289258}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289258 0039d316-1c4b-4281-b951-d872f2087c98

This also fixes the value of [inner|outer]Bounds.[width|height]
to account for the border added by
AppWindowDesktopWindowTreeHostWin::GetClientAreaInsets

BUG=394567, 395929

Review URL: https://codereview.chromium.org/405323002

Cr-Commit-Position: refs/heads/master@{#289257}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289257 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
NOTRY=True

Review URL: https://codereview.chromium.org/367593002

Cr-Commit-Position: refs/heads/master@{#289256}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289256 0039d316-1c4b-4281-b951-d872f2087c98

It's the third step to accept Android's heap profiler discussed in http://crbug.com/382489.

BUG=391212
NOTRY=True

Review URL: https://codereview.chromium.org/467563002

Cr-Commit-Position: refs/heads/master@{#289255}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289255 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/457563002

Cr-Commit-Position: refs/heads/master@{#289254}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289254 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397360

Review URL: https://codereview.chromium.org/466213002

Cr-Commit-Position: refs/heads/master@{#289253}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289253 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399311

Review URL: https://codereview.chromium.org/459023002

Cr-Commit-Position: refs/heads/master@{#289252}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289252 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289251}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289251 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dsinclair

Review URL: https://codereview.chromium.org/461353002

Cr-Commit-Position: refs/heads/master@{#289250}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289250 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tonyg@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/469693005

Cr-Commit-Position: refs/heads/master@{#289249}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289249 0039d316-1c4b-4281-b951-d872f2087c98

Profile related business is handled by KeywordExtensionsDelegateImpl.

BUG=388515
TEST=unit_tests

Review URL: https://codereview.chromium.org/460313002

Cr-Commit-Position: refs/heads/master@{#289248}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289248 0039d316-1c4b-4281-b951-d872f2087c98

This brings browser_unittest's run time from 21s to 7s on a Z620 Linux, one of our fastest
configurations. (We still need 3 browser launches to test browser options and profile loading.)

Add BrowserTestCase as the new parent class of TabTestCase. The separation is very clean :)
Also add helper method UrlOfUnittestFile - many tests are using http_server.UrlOf incorrectly,
and this helper ensures the HTTP server is running and we're pointing to the right file.
Also move page_test_test_case from testing/ to unittest/ and remove testing/.


BUG=388256
TEST=tools/telemetry/run_tests

Review URL: https://codereview.chromium.org/469593002

Cr-Commit-Position: refs/heads/master@{#289247}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289247 0039d316-1c4b-4281-b951-d872f2087c98

OnNativeWindowChanged is normally called when a window's bounds change.
However, if an app maximizes via the AppWindow API, but its bounds are
the same as that of a maximized window, OnNativeWindowChanged does not
end up being called.

This CL ensures that OnNativeWindowChanged is called whenever the app
maximizes or restores.

BUG=395900

Review URL: https://codereview.chromium.org/434343004

Cr-Commit-Position: refs/heads/master@{#289246}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289246 0039d316-1c4b-4281-b951-d872f2087c98

Eliminating the dependency of Profile from TtsMessageFilter by
delegating GetProfile function to TtsEngineDelegate.
This is part of an effort to move TTS to content.

BUG=347045

Review URL: https://codereview.chromium.org/448033002

Cr-Commit-Position: refs/heads/master@{#289245}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289245 0039d316-1c4b-4281-b951-d872f2087c98

properties too.

BUG=397199
TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/424233002

Cr-Commit-Position: refs/heads/master@{#289244}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289244 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289243}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289243 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/ea13afff6e46d8a969611cdd56c996bfb05a27c1..b62508be81839be96f3d935d1e568e2ff3663670

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
TBR=bsalomon@google.com
BUG=

Review URL: https://codereview.chromium.org/468003002

Cr-Commit-Position: refs/heads/master@{#289242}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289242 0039d316-1c4b-4281-b951-d872f2087c98

R=lcwu@chromium.org,byungchul@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/463563003

Cr-Commit-Position: refs/heads/master@{#289241}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289241 0039d316-1c4b-4281-b951-d872f2087c98

This consolidates IPC messages for setting up version attributes
(ie. installing, waiting and active), and cleans up related functions.

The new message is intended to be used for ServiceWorkerRegistration
object that will be introduced by following CL[1] and it doesn't have
the controller field, so the controller still use a separate message.

[1] https://codereview.chromium.org/463013002/


BUG=384119,396400
TEST=content_unittests --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py --debug http/tests/serviceworker

Review URL: https://codereview.chromium.org/445883003

Cr-Commit-Position: refs/heads/master@{#289240}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289240 0039d316-1c4b-4281-b951-d872f2087c98

This is a re-submission of https://codereview.chromium.org/446323002/.
Fixed the new browsertest which intercept worker script request but returns
response without corret worker content type.

BUG=400604
TEST=https://codereview.chromium.org/448063002/

Review URL: https://codereview.chromium.org/460943002

Cr-Commit-Position: refs/heads/master@{#289238}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289238 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289237}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289237 0039d316-1c4b-4281-b951-d872f2087c98

The only changes this picks up are:
https://codereview.chromium.org/450213003/
https://codereview.chromium.org/332413005/

BUG=124610
TBR=sergeyu

Review URL: https://codereview.chromium.org/464103002

Cr-Commit-Position: refs/heads/master@{#289236}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289236 0039d316-1c4b-4281-b951-d872f2087c98

The default implementation provides no subservices. Its purpose is to fulfill a dependency (in unit tests)
when other BrowserContextKeyedServices depend on an ExtensionSystem. Tests that actually need subservices
can override the necessary methods to provide them.

Also, this defines a MockExtensionSystemFactory template for ease of use with MockExtensionSystem subclasses.

BUG=348066

Review URL: https://codereview.chromium.org/460203002

Cr-Commit-Position: refs/heads/master@{#289235}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289235 0039d316-1c4b-4281-b951-d872f2087c98