- 09 Oct, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602223197-d9c33dbbd5ccae4e4a4bd70010f4c3ef94132fb3.profdata to chrome-mac-master-1602244639-6cd23926ee4e898bd11627c63cc4edf5ffd59847.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8e6670da96a83279fc57a5ccff10136434036d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463383Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815593}
-
Richard Knoll authored
If a NotificationDelegate calls RemoveNotification in the Close handler we're trying to close it twice if the user clicks the "Close all" button in the message center. Instead remove the Notification from the list before calling Close so the next call exits early and is a noop as expected. This was fixed for RemoveNotification before in crrev.com/c/2330019 and this CL implements the same fix for RemoveAllNotifications. Bug: 1135709 Change-Id: I27e365957554c56a6cbea0200c408c6706189f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461119 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#815592}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ie97ce45f6b57218e5e7c61405348415385557282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462229Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#815591}
-
Robert Ma authored
This was likely missed in https://crrev.com/c/1769846. With this change, kill_tree now works on Windows and Linux in the same way. Change-Id: Ib5de5bff3ab934846e46ee0e9210d5be5f308dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462197Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#815590}
-
Aya ElAttar authored
No-Presubmit: true No-Tree-Checks: true No-Try: true TBR: bsheedy@chromium.org Bug: 1136875 Change-Id: Icfc17da6cb3633697ef0c09f2e8a7a5b7e617edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461385Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#815589}
-
Fredrik Söderqvist authored
Implement ingenious idea for image document. Bug: 844743 Change-Id: I6fa9b373999a77e1a8eb8fd399b8f0e59834063c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455448 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#815588}
-
Richard Knoll authored
This test was flaky because the NotificationShownCallback is called before the new notification is added to the expected map. Changed it now to wait until that is the case and re-enabled the test. Bug: 1135576 Change-Id: I659c4acd4f6ae531748d4e428d7cb7e338bfd084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453250 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Updates a few chrome/ui classes for compatibility with ephemeral Guest profiles. Ephemeral guest profiles are not off-the-record and cannot open an Incognito window or have bookmarks, but they have history and Recent Tabs menu, and Clear Browsing Data option. Please see go/guest-on-disk for more context. Bug: 1125474 Change-Id: I8a1f6ceb03d4c72f310b225211728f8eaeb0d296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449250Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#815586}
-
Ryan Daum authored
* Registers and watch for text input focus events within webview content. * Defines a new gRPC payload for said events, and broadcasts them. Bug: internal b/161811385 Test: manually with wayland client tool Change-Id: Ie6d5167bc21f40d603e990b08a3e27b3802eeafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422501Reviewed-by:Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#815585}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 68a10bbc. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I0b3cfcda931d91f8d8d963c3d7dbae28d1363dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460947Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815584}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7c2d888fdffc..2bf76269e147 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib4bfdd4b8a29aa91096e423d033cc32859a2799d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462170Reviewed-by:
-
Rune Lillesveen authored
Both enabled on stable since M81. Bug: 925935, 939811 Change-Id: I558796309333c598169749e34b8f6a297837e4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461376Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#815582}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7c2d888fdffc..2bf76269e147 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idc51544693482594bfcbbdcc48609a2718de4fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462169Reviewed-by:
-
Sebastien Lalancette authored
This reverts commit eea6b735. Reason for revert: This new test is making any subsequent test fail, thus constantly failing the builder. Original change's description: > [iOS] Add New Window EG test. > > Original CL by marq: crrev/2424125 > > - Adds a cleanup step to EarlGreyTestCase that closes all but one window. > > - Adds test utilities for closing all (but one) windows, counting windows, > and waiting for a specific window count. > > - Adds a test utility to check for multiple window support. > > - Adds a simple test of the tools menu "New Window" item. > > - Updates & reenables the history and bookmarks EG tests to wait for a > window count (and to skip the tab-closing step, which wouldn't have > closed the window in any case). > > Bug: 1126893 > Change-Id: Id6b3ab02058e0db036045b0653a716fe19271b74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450096 > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Commit-Queue: Mark Cogan <marq@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815179} TBR=marq@chromium.org,stkhapugin@chromium.org Change-Id: I5d9d449a91c4032446cc61b0b27d521e6ae50103 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463322Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#815580}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4fe27472..11158c21 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibdda0cebc622b6426676d644842f103f5ee4007f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460948Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815579}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/56df381f7893..e611beb18340 2020-10-09 dberris@chromium.org auto-triage: Assign to sheriff for single-CL range 2020-10-09 dberris@chromium.org pinpoint: Always re-assign to culprit owners 2020-10-09 dberris@chromium.org chromeperf: Fix issue management If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1122554,chromium:1131908,chromium:1136443 Tbr: sadrul@google.com Change-Id: Ibc0e35f81fb15bb75ef910627798a5a8100ba46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462778Reviewed-by:
-
Mikhail Khokhlov authored
Adds a UMA metric to chrome/android that reports signal strength for Wifi or cellular connection (depending on which is active at the moment) as well as a number of outgoing and incoming bytes over the last 30 secs. This metric will be used in conjunction with battery discharge metrics to estimate the relative importance of radio usage in battery drain. Bug: b/167544787 Change-Id: I806076896408fd4ac32ca67d21cbb281bea64453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450049 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#815577}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2bf76269e147..c251d370b65e 2020-10-09 primiano@google.com Merge "Add support for symbolizing kernel symbols for ftrace events" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I41c1bcd2e8bd2427385d7a9d045306b265e52062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463246Reviewed-by:
-
Mohamed Adel authored
Added categories that show close and settings buttons on banners. Settings button is determined by whether the notification wants one or not. Bug: 1129398, 1136040 Change-Id: I1d3d9b2c440780293aa23bd842a4b8c587bbbb58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456106Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Auto-Submit: Mohamed Adel <adelm@google.com> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#815575}
-
Peng Huang authored
The rotation issue is fixed by https://crrev.com/2459569 Bug: 1115065 Change-Id: Idb8767dd075cda95accc13ee62733eb005f1133a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462682 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#815574}
-
Anqing Zhao authored
Previously, we decided to force Managed Guest Sessions (MGS) into immersive mode to avoid security concern for those auto-launch applications. But actually all applications in MGS can only be launched manually. Such a special logic also leads to inconsistent behavior in MGS and user session that confuses customers. After discussion with PM and original author, we plan to remove it. Bug: 1128725 Change-Id: Ic1b8d9caea9bfcf2517628eb068a65989a9d184b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445014Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#815573}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Id0fd407adad7a55d165d63c4477eb3d177f1797b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462637Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815572}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e078093198e5..fc8f5e0ae349 2020-10-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 090102a7 to 77bfcdcd (466 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I59d6f8e54cbe287ba3d0cc3bdfe7e236703e3fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463178Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602179909-18dbc89acedf4f15864b841a6fe7487536bbc059.profdata to chrome-win64-master-1602212356-910f3b9c14ad8fb9eb002bc49aff02d2bc68cf6f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib573b283a4571f70d3962d6cedcc056979fe5a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462583Reviewed-by:
-
Simon Zünd authored
Design doc: http://bit.ly/devtools-trust-tokens The Trust Token API has some parameters that can be passed to a corresponding fetch or XHR request (or iframe). This CL surfaces the parameters as understood by the backend as part of the Network.Request CDP structure. R=sigurds@chromium.org Bug: chromium:1126824 Change-Id: I9cf4b1f17dc3b2f193b900eb26cfc9e11964f56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448370 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#815569}
-
sandromaggi authored
This change adds the non-padded month for credit card expiry to deal with forms where the month is "1" for January (instead of "01"). Bug: b/168227057 Change-Id: Ibf030936e638ea5df57fe8e3da36fe6cf06589ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461314 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#815568}
-
dpapad authored
Specifically removing logic related to handling <if expr> and <include> tags, which seems to only be triggered by tests, and nowhere in prod code. Bug: 1135226 Change-Id: I7d362420e0d94df3c29e6f646cfe25acc5d23e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448658Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#815567}
-
Antonio Sartori authored
This CL attaches a PolicyContainer to a NavigationRequest. For a local scheme navigation, the NavigationRequest is initialized with a copy of the initiator's PolicyContainer, it gets a new PolicyContainer. At DidCommitNavigation time, the NavigationRequest's PolicyContainer is moved into the target RenderFrameHostImpl. Change-Id: I66bb4950c9939a9a81227025549d860ec8c461df Bug: 1130587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424147 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#815566}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fd9afd0a756b..78768c9a86bf 2020-10-09 patrick.brosset@microsoft.com Network: Make the initiator column jump to the right position 2020-10-09 patrick.brosset@microsoft.com Track clicks on var() function links If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1124707,chromium:1134064 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id2194f1698799529497ed831f5e6f49b47655bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463179Reviewed-by:
-
Morten Stenshorne authored
Create additional legacy fragmentainer groups when necessary, i.e. when contiguous column content (i.e. without intervening spanners) is laid out over multiple outer fragmentainers. We also need to include block-size consumed in previous outer fragmentainers, since the legacy engine expects everything to be in the flow thread coordinate space. Correct legacy write-back is necessary for position querying DOM APIs, such as offsetLeft and offsetTop. Bug: 829028 Change-Id: If6adaa0d6324376061e66a3fa73403c008559b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450097 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#815564}
-
Kent Tamura authored
Port LayoutTextControlMultiLine::NodeAtPoint() to LayoutNGTextControlMultiLine. - Make LayoutTextControl::HitInnerEditorElement() public and static in order to share it with LayoutNGTextControl*. This CL fixes the following web tests with LayoutNGTextArea flag: - fast/events/inputevents/inputevent-drag-drop.html - fast/forms/input-readonly-select.html - fast/forms/textarea/drag-into-textarea.html - fast/forms/textarea/drag-out-of-textarea.html This CL has no behavior changes. The flag is not enabled yet. Bug: 1040826 Change-Id: Ia369377659d78476302f8c4b7e32532d60f938f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463007 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#815563}
-
Elizabeth Popova authored
Testing of shopping websites in these countries has shown that most address forms do not contain ZIP or State field. It was preventing addresses from being saved. See go/manual-autofill-test-q4-2020. Change-Id: Iee397c8a5bf5f9bfbda0ecce3ef0ed3f1556687f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461732Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#815562}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7c2d888fdffc..2bf76269e147 2020-10-09 treehugger-gerrit@google.com Merge "Added key navigation for flow events" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0af82dc6dc85d361a213363d5e8cc336062a2b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463176Reviewed-by:
-
Colin Blundell authored
I happened to notice that these are not referenced anywhere (I built chrome_apk and chrome_test_apk as well). Change-Id: I5cfe0bb106880bacaef718d6bb4e382055d47a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461229 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#815560}
-
Tommy Steimel authored
This CL adds a new icons.js file to the Kaleidoscope WebUIDataSource. Bug: b:150614426 Change-Id: Id3f57e4ae61d69bf863c3446b142f0de3ee7c619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460979Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#815559}
-
Ben Reich authored
Set callCount to true to capture the number of times a JavaScript code block is invoked during execution. Minor: remove unnecessary blank line. Test: browser_tests --gtest_filter="*FilesApp*" --devtools-code-coverage Bug: 1113941 Change-Id: I6a934708db329f7095146331322c07b7bf631043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462828 Auto-Submit: Ben Reich <benreich@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#815558}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fc8264854c53..c2553a315f5c 2020-10-09 afdx@google.com spirv-fuzz: Do not expose synonym facts for non-existent ids (#3891) 2020-10-08 afdx@google.com spirv-fuzz: Do not add synonyms involving irrelevant ids (#3890) 2020-10-08 afdx@google.com spirv-fuzz: Do not replace irrelevant ids that are not in blocks (#3892) 2020-10-08 afdx@google.com spirv-fuzz: Wrap OpKill and similar in function calls (#3884) 2020-10-08 dj2@everburning.com Update val to handle reversed instruction sections. (#3887) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC timvp@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: timvp@google.com,radial-bots+chrome-roll@google.com Change-Id: I143ae1774eb7378db1aa9fb8253111d06f6d42bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463175Reviewed-by:
-
Sylvain Defresne authored
Recent refactoring moved this code out of TabModel in multiple object. The navigation_item initialized here is not used. The code using it is in OmniboxGeolocationTabHelper. Bug: none Change-Id: I4ca760b95e6f5882c4783d4e65f1c1036998176b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461232Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#815556}
-
Olesia Marukhno authored
Instead of using dark/light theme coloring from MdTextButton, use colors of the omnibox. We need to do this because omnibox follows NTP "Customize" color picker. Bug: 1133851 Change-Id: I2e9bb636f6a724ee5b9ccd1887cf31bda32a70aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442537Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: Ice87171a78fdc852e073d913c87e9e0eba986a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458909Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815554}
-
