- 23 Jan, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d562545e8a23..4f81bb73311d git log d562545e8a23..4f81bb73311d --date=short --no-merges --format='%ad %ae %s' 2019-01-23 reed@google.com remove all support for drawText Created with: gclient setdep -r src/third_party/skia@4f81bb73311d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I66fb6cf8104ba5070db1f2a69d5dac1be14d5087 Reviewed-on: https://chromium-review.googlesource.com/c/1430501Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625222}
-
Anna Malova authored
Sync dynamicmodule repository. Bug: 912127 Change-Id: I738fb1a7f042f72975a4b28e5cafda9c06b23584 Reviewed-on: https://chromium-review.googlesource.com/c/1388155 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#625221}
-
Gyuyoung Kim authored
As a step to make to use IdentityManager,this CL replaces all uses of ATS with IdentityManager's ones in chrome_signin_view_controller_unittest.mm. Bug: 922800 Change-Id: I4d64e98af4ba8d4ca334d4e6d805b309758a9e08 Reviewed-on: https://chromium-review.googlesource.com/c/1429721Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#625220}
-
danakj authored
Sync visual properties is only called in response to an IPC. The close IPC drops the IPC route before removing the WebWidget so IPCs can't arrive that would SynchronizeVisualProperties() after the WebWidget is gone. The one exception is the screen metrics emulator which can call it from its destructor, but it is also destroyed in CloseWebWidget() before the WebWidget is destroyed precisely to avoid these sorts of things (with a TODO about how to make that more clear..). R=avi@chromium.org Change-Id: I0621f4e3f4a708dd209b996129b9e17a765d6296 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1427881Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#625219}
-
Tibor Goldschwendt authored
Bug: 922713 Change-Id: Ia1cbb340b050878734a5e33d52b7f6adfd6b5f7e Reviewed-on: https://chromium-review.googlesource.com/c/1428082 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#625218}
-
Denis Kuznetsov authored
Bug: 916991 Change-Id: Id978bded0e9906a3b6077ff7b00efa612593a70f Reviewed-on: https://chromium-review.googlesource.com/c/1425726 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#625217}
-
yileili authored
It is a precondition to enable warmer welcome notification. Bug: b:123077811 Test: Manual Change-Id: Iad04ba8f231e31aa969aecd4121735c94196dcfa Reviewed-on: https://chromium-review.googlesource.com/c/1422758Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Yilei Li <yileili@google.com> Cr-Commit-Position: refs/heads/master@{#625216}
-
Rayan Kanso authored
Race conditions can lead to abort/pause events after the fetch is complete, in which case they should be ignored. This CL also adds an unrelated test for aborting from the UI. Change-Id: I00a290581653c0243815a39b03340aea8899fb85 Reviewed-on: https://chromium-review.googlesource.com/c/1429987Reviewed-by:
Mugdha Lakhani <nator@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#625215}
-
Aleks Totic authored
height: <percent> sizes of flexbox could be incorrect after flexbox resize. Bug: 907911 Change-Id: I19616f7f9cda7cd55a7206b3bb379f4957fccd4c Reviewed-on: https://chromium-review.googlesource.com/c/1428579 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#625214}
-
Zakhar Voit authored
Bug: 910218 Change-Id: Ic27b7153552e8ac6cd9a8ceb67207a4004607b4c Reviewed-on: https://chromium-review.googlesource.com/c/1424847 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#625213}
-
Tommy Nyquist authored
This updates the minimum SDK version to 19 (KitKat), which in practice deprecates supports for Android Jelly Bean (SDK 16, 17, 18). //components/cronet still needs to support Jelly Bean, so those manifests are upgraded from SDK level 14 to 16, referring to the meta bug for Jelly Bean support in cronet. The WebAPK minSdkVersion will be updated in a different CL. Bug: 923477, 922656 Change-Id: Ib1b8b4269d930a8cecb3e45d6ca3ff57f7006d00 Reviewed-on: https://chromium-review.googlesource.com/c/1423117Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#625212}
-
Gabriel Charette authored
I just learned about these guidelines through https://chromium-review.googlesource.com/c/chromium/src/+/1340802/18#message-b68ecbafe6212025dd856998736431eea6a19991 and think they should be surfaced in base/OWNERS (which points to base/README.md). R=dcheng@chromium.org Change-Id: I0acf3eec7a2d4e888eac4d15e9e8fbf8ad7acf02 Reviewed-on: https://chromium-review.googlesource.com/c/1422742Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#625211}
-
Avi Drissman authored
This is a followup to http://crrev.com/366963 . That change made the '--disable-web-security' flag have no effect unless the '--user-data-dir' flag was also specified. This was done to encourage the use of the '--disable-web-security' flag only for development and not for general purpose use. However, that change (locking '--disable-web-security' to '--user-data-dir') was made only in one place in the Chromium code. There are quite a few other places in Chromium that turn off security features when '--disable-web-security' is specified, and none of them lock it to the use of the '--user-data-dir' flag. Therefore, move the lock to much earlier in Chromium startup, and if the '--user-data-dir' flag isn't specified, remove the '--disable-web-security' flag entirely from the CommandLine. That way, this correctly locks together those two flags for all of Chromium. BUG=923523,327804 Change-Id: I9000f1fbd2c236a435d8dae25870dead870ddd55 Reviewed-on: https://chromium-review.googlesource.com/c/1423342Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625210}
-
Mark Cogan authored
This CL changes the init of the main BrowserInterface in BrowserViewWrangler to be explicit, and to be done as part of creating the main Browser instance. BrowserViewWrangler's -mainInterface implementation is now a simple (synthesized) getter, and thus will return nil before -createMainBrowser is called. BrowserViewWrangler's -incognitoInterface implementation now returns nil if there's no mainInterface. This mitigates the risks around calling -mainInterface prior to the main browser being created. It does slightly change the timing of BVC creation (it's slightly earlier), but at least now it's explicit. TEST: The crash for this bug is triggered by auth service init forcing a sign-out of a managed account, which causes MainController's removeBrowsingDataForBrowserState: method to be called. The completion block in that method uses mainInterface to disable user interactions. To test this fix, I added an explicit call to SignOut() in AuthService::Initialize() and launched Chrome with a signed-in managed account. It crashes as expected before this fix, and works fine afterwards. Bug: 919932 Change-Id: Iaffb29cd7d0dfb5b54f3347755fc9e15f0aa4539 Reviewed-on: https://chromium-review.googlesource.com/c/1430239 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#625209}
-
Denis Kuznetsov authored
Bug: 916991 Change-Id: I1d22e80d3f942464a5e577210e8be3ae242565bd Reviewed-on: https://chromium-review.googlesource.com/c/1424889 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2aeeb2d0..21b1ee52 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ief63e9c080afea332a1caacfff8526e5167879bb Reviewed-on: https://chromium-review.googlesource.com/c/1430499Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625207}
-
kylechar authored
Remove usage of deprecated base::Bind, base::Callback, base::Closure, base::CancelableCallback and base::CancelableClosure types from gpu/*. Where possible convert to the corresponding once type. Otherwise replace with the repeating type which is equivalent to the deprecated type. This CL is the second of multiple to cleanup callback types in gpu/*. Bug: 714018 Change-Id: Ifc2af8ee36feed7815f053a5f53147fc983cb005 Reviewed-on: https://chromium-review.googlesource.com/c/1426010Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: I71bab32bd386f425eee3837ceb7180d6a40b26eb Reviewed-on: https://chromium-review.googlesource.com/c/1426787Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL refactors WebappSplashScreenController in preparation for not having the WebApkActivity show a splash screen if WebappInfo#isSplashProvidedByWebApk(). The code which should not run for new-style WebAPKs is moved to SameActivityWebappSplashDelegate BUG=918459 R=dominickn TBR=yfriedman (For WebappUma rename) Change-Id: Ie47b4b26590f6fa1606e0594c979591def9aaf75 Reviewed-on: https://chromium-review.googlesource.com/c/1408353 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#625204}
-
Denis Kuznetsov authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/88d06ccdd29b..e409915310e1 $ git log 88d06ccdd..e40991531 --date=short --no-merges --format='%ad %ae %s' 2019-01-07 ejcaruso cryptohome: add UnmountEx method 2019-01-21 hmchu runtime_probe: report additional information for generic battery 2019-01-21 hmchu runtime_probe: Report "path" and "size" for storage device 2019-01-22 jkardatzke vm_tools: Cleanup IsContainerRunning dead code 2019-01-16 jkardatzke vm_tools: Remove unneeded VM ip, subnet, netmask from cicerone 2019-01-15 kdlee debugd: Sanitize print URIs before calling lpadmin 2019-01-14 ljusten system_api: Add login manager go protos 2018-11-28 briannorris shill: wifi: add RxBitrate 2019-01-07 jimmyxgong smbprovider: Add PremounOptionsProto Created with: roll-dep src/third_party/cros_system_api Bug: 916991 Change-Id: I5538b70753139a3f041107cf370b4e721d080bf0 Reviewed-on: https://chromium-review.googlesource.com/c/1429988Reviewed-by:
-
Anders Hartvoll Ruud authored
This CL adds a function to get a CSSPropertyName from a CSSProperty. Change-Id: I76f0a09367a082142dd38bc48f82200a630be527 Reviewed-on: https://chromium-review.googlesource.com/c/1429643Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#625202}
-
Nektarios Paisios authored
This patch depends on https://chromium-review.googlesource.com/c/chromium/src/+/1229234 which implemented a virtual accessibility view class. I propose that we use the grid role for the table view and mark it readonly because in Views a table view is interactive like an ARIA grid. On Windows it will be exposed as a list view control and on Mac as a table view. R=dmazzoni@chromium.org, ellyjones@chromium.org, sky@chromium.org, aleventhal@chromium.org Bug: 811277 Change-Id: I9e02563f1220f300e7fd78dc4cbbf5ee5e585acb Reviewed-on: https://chromium-review.googlesource.com/c/1363793 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#625201}
-
Mikel Astiz authored
This makes the datatype less special and reduces the complexity of "core" sync, although further patches are needed to complete that. Short term, the main goal is to avoid circular dependencies across keyed services without subtle tricks to get references lazily, as it was done for SessionSyncService (and more datatypes are coming). TBR=asvitkine@chromium.org,pkasting@chromium.org,olivierrobin@chromium.org Bug: 922971 Change-Id: I944f1a74fa9b843185393d0d34bb590a6e6a27f6 Reviewed-on: https://chromium-review.googlesource.com/c/1420737Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#625200}
-
Kevin Ellis authored
* Adds MutateAynchronously method to the mutator dispatcher. * Adds tests for ansynchronous mutation. * Stubs in API for notification of mutation state (pending/complete). Note async mutations are not used outside of testing with the patch pending completion of the notification plumbing in a separate CL. Bug: 791280 Change-Id: I91545306c71899945f797a641831257247849b86 Reviewed-on: https://chromium-review.googlesource.com/c/1409600Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#625199}
-
Yuichiro Hanada authored
It's enabled by default now. Bug: 924383 Test: unit_tests --gtest_filter=ArcInputMethod* Change-Id: Idaa38371fede902b1779f2482442388dece4721b Reviewed-on: https://chromium-review.googlesource.com/c/1429322Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
Zakhar Voit authored
Policies considered risky (besides force-installed extensions and ONC, it was handled in the previous CLs): 1. Any policies marked with 'website-sharing' tag. 2. 'PacHttpsUrlStripping' policy when it's value is 'false'. Bug: 910218 Change-Id: Ieade2fc159801597a3ede3b1c115abc285ae716a Reviewed-on: https://chromium-review.googlesource.com/c/1412478 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by:
-
Olivier Robin authored
When distilling a page with media content, the media starts to play even if the webState is in the background. This cause audio playing in case of an audio, and the video player to start in case of a video. This CL blocks loading the media pages when distilling. Bug: 919326 Change-Id: I3717618ba31019fbc173cb721436a323acfbc6aa Reviewed-on: https://chromium-review.googlesource.com/c/1409514 Commit-Queue: Eric Noyau <noyau@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#625196}
-
Xida Chen authored
This CL cleans up the CrossThreadStyleValueTest, which does proper initialization for the WebThreadSupportingGC, and shut down the thread at the end of the test, just like what we do in the PaintWorkletStylePropertyMapTest. Bug: 895579 Change-Id: I7cf93fe5a192cd221a7f9490982d1a104110a232 Reviewed-on: https://chromium-review.googlesource.com/c/1427605Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
Peng Huang authored
Also convert RasterDecoderContextState from struct to class. TODO: * rename raster_decoder_context_state.h to decoder_context_state.h Bug: 919865 Change-Id: I77cb8d369c1e0c736434da6bbb144c863d9ec3f6 Reviewed-on: https://chromium-review.googlesource.com/c/1426060 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
-
Christos Froussios authored
Currently, Chrome uses the user default (umask), which may be too broad for sensitive files. We will restrict all permissions to users other than the owner. Bug: 921308 Change-Id: I9c03b57ae1392926a6f912372a8eae8e4c6b3cfb Reviewed-on: https://chromium-review.googlesource.com/c/1426678 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#625193}
-
Alan Cutter authored
This CL sets desktop-pwas-team@google.com to be the owner of the following flags: - enable-desktop-pwas - enable-desktop-pwas-custom-tab-ui - enable-desktop-pwas-link-capturing - enable-desktop-pwas-stay-in-window - enable-experimental-app-banners - pwa-improved-splash-screen - pwa-persistent-notification Change-Id: I06c9d53532e09ee8c9d0400d92457c248451fcb5 Reviewed-on: https://chromium-review.googlesource.com/c/1428139Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#625192}
-
Xi Han authored
The STARTED count in the MobileDownload.Background metrics is more than a double of total count of completed + cancelled + failed. This is due to a download task might be interrupted multiple times before it finishes. To fix it, we add a INTERRUPTED bucket in this metrics. We can roughly estimate the crash rate by using: (start - interrupted - completed - cancelled - failed) / start We can't distinguish the following cases from the crash rate though: 1) A download task has been paused by user before Chrome crashes. 2) Chrome is killed by rebooting the devices / users, rather than killed by OOM. Bug: 864625 Change-Id: Ic1f03bc665d5411c73ab16138cda259f0cab6ed1 Reviewed-on: https://chromium-review.googlesource.com/c/1427563Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625191}
-
Daniel Nicoara authored
Move the zcr_vsync_feedback interface into its own files. This change only moves code around, no functional changes. Bug: 896710 Test: Build and run exo_unittests Change-Id: I74885b5a6692306b05a1d86350f627ed7046045b Reviewed-on: https://chromium-review.googlesource.com/c/1427571 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#625190}
-
Florent Castelli authored
Some codecs don't support directly creating simulcast layers with non-optimal parameters. This proxy will detect this and create multiple encoders then, one for each layer as a fallback. Bug: 857048 Change-Id: Ib352621363cb3cdc0f73385f7f74d4e473263fc1 Reviewed-on: https://chromium-review.googlesource.com/c/1430084Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#625189}
-
David Jean authored
Bug: 907527 Change-Id: I346f28df9938f56b948c2f4fdbbbe427ca0fa52a Reviewed-on: https://chromium-review.googlesource.com/c/1429981Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#625188}
-
Anatoliy Potapchuk authored
Bug: 918101 Test: chromeos_unittest --gtest_filter=*OncParsedCertificatesTest* Change-Id: I02dd141d8a2b809a3424f453bf5c9df3ea1c1321 Reviewed-on: https://chromium-review.googlesource.com/c/1425705 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#625187}
-
Morten Stenshorne authored
TBR=eae@chromium.org Bug: 924254,915204 Change-Id: Ib551a93ce37d47c87989add7c10d22ad0499efc7 Reviewed-on: https://chromium-review.googlesource.com/c/1430005Reviewed-by:
-
Stepan Khapugin authored
Instead of erasing the text in the textfield before inserting new chars, just select the text that is displayed as selected with preedit label. This produces exactly the same result as if the selection was real, fixing a few small glitches with third party keyboards. Bug: 875918,873544 Change-Id: Ia1628f0c0207aa7db8318f60e64bc73ac27872e6 Reviewed-on: https://chromium-review.googlesource.com/c/1183495 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
David Roger authored
In certain edge cases (involving adding a GCMS observer from inside a GCMS notification) , OnGaiaAccountsInCookieUpdated() could be fired after a ListAccounts call that returns true (i.e. cookies are fresh). The reconcilor assumed that OnGaiaAccountsInCookieUpdated() could only be called after ListAccounts returns false. This CL adds support for receiving unexpected notifications while the reconciliation is in progress. The reconcilor will simply ignore them, and rely on the fact that the reconciliation will touch the cookies and trigger new ListAccounts calls at the end, triggering additional reconciliation cycles if needed. Bug: 923716 Change-Id: I89f7ed720f44b75d7a3c215fad6e06fb078f12cf Reviewed-on: https://chromium-review.googlesource.com/c/1424953 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#625184}
-
Gyuyoung Kim authored
As a step to make to use IdentityManager,this CL replaces all uses of ATS with IdentityManager's ones in authentication_flow_performer.mm. Bug: 922798 Change-Id: I732c92e96b1174537afa2273fddf984da665477e Reviewed-on: https://chromium-review.googlesource.com/c/1429326Reviewed-by:
-
