- 15 Oct, 2019 40 commits
-
-
Xing Liu authored
Currently it's failing on an Android O builder. TBR=tbansal@chromium.org Bug: 1014213 Change-Id: I4d22e177e2ffdc76040be0be623883dfd0124a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862248Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706046}
-
Ahmed Mehfooz authored
This change ensures that the message center collapses to just have the notification bar visible when there is less than kMessageCenterCollapseThreshold space available. Bug: 1002710 Change-Id: Ia0d15b0686788905fd8757366e405227851f1c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846235 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706045}
-
Lukasz Anforowicz authored
Casting a raw integer (e.g. an integer deserialized from session restore files, from a protobug, or coming from the other side of JNI boundary) to an enum class value may potentially cause the following problems: - Invalid enum values may cause Chromium code to misbehave. - It is not entirely clear if C++ spec allows such casts (i.e. if such casts may lead to undefined behavior). Because of the above, this CL replaces: static_cast<network::mojom::ReferrerPolicy>(raw_integer) casts with calls to a new content::Referrer::ConvertToPolicy static helper method, which tries to ensure that the cast is done in a safe way. Bug: 1006409 Change-Id: I2a660c4caf961ca52503b084a7c0abe93e9d5eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816134Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#706044}
-
Michael Liao authored
DevTools [Common - Flame Chart]: Making flame chart keyboard accessible in memory and javaScript profiler tool Changes: - Adding keyboard navigability to JavaScript and Memory profiling flame charts - CPUProfileNodes with source links are enter-clickable - Flamechart's focused CPUProfileNodes will turn gray (from blue) when flamechart loses focus CPUProfileNode selected (with and without focus): https://imgur.com/a/e6JkqYW Bug: 963183 Change-Id: Icb00d5b53dab6cd5f83e5602a7d3834afdb7eab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663021Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Michael Liao <michael.liao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706043}
-
Darwin Huang authored
Bug: 1013400 Change-Id: I1dcdff204890c060ea243d3be846aa211a39e468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859879Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706042}
-
dpapad authored
There are no other usages of PageManager and Page. Given that these are old WebUI UI elements that are no longer encouraged, moving them guarantees that no new dependencies to those elements will be introduced. This is also in preparation of eliminating HTML Imports from bluetooth_intarnals/. Moving these elements simplifies things, since there is no need to auto-generate JS Modules version of such elements at build time, if no other usages exist. Bug: 937747 Change-Id: I73152dab8dae65ee8ad465e5d0d018420df18f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860780 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#706041}
-
Javier Ernesto Flores Robles authored
Some modifications has been made to make all the manual fallback tests more robust. As it can be seen in the bots of the CQ these test are not failing anymore. Bug: 1007421, 1007455 Change-Id: I30b2c454a42925dc64a6226788a26db3f760ef5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859967 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#706040}
-
Deepanjan Roy authored
The script can now write out histogram set json. Currently we're using a json config file to specify details in the histogram that are not available in trace processor metric result, but this will likely change soon. No support for diagnostics yet. Bug: chromium:1012687 Change-Id: I8654bdb8ea6a596f899b919d0884bee25ed7af1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860334 Commit-Queue: Deepanjan Roy <dproy@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#706039}
-
Kai Ninomiya authored
This allows us to have our own variants list, so we can split test files into smaller parts for more fine-grained suppression. Bug: 984818 Change-Id: Id9a12491d592ddaf0899d40c89d01139396a92d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860508Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#706038}
-
Matt Mueller authored
Record debug data from net::CertVerifyProcMac, plumb it into TrialComparisonCertVerifier error reports. Bug: 991247 Change-Id: I59227f0544b4d05312eaab3df09a8121fa39c3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856625Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#706037}
-
Istiaque Ahmed authored
ExtensionFunction can appear after a worker has already stopped. Trying to execute the ExtensionFunction results in EFD::CheckPermissions failure. As the worker is stopped, we can safely ignore this extension function. Subsequent CL will add tests for this once crbug/999027 is completely fixed. related patches. Bug: 999027 Test: Locally trying UpdatePackedExtension test few thousand time with Change-Id: I6e8d8716d4bec349034502233782ada8674d1325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832465 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706036}
-
Shawn Gallea authored
Allows 4hz framerate on headless devices with kReduceHeadlessFrameRate feature Bug: b/139299756 Test: Compile cast_shell for headless device Change-Id: I13a36cbc2225c20367188375518b34baf585f2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815049 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#706035}
-
Maciek Slusarczyk authored
Fixes ChromeOS.SAML.APIUsed and ChromeOS.SAML.Scraping.PasswordCount metrics that were not populeted correctly. For PasswordCount the main case (exactly 1 password scraped) was missed whereas APIUsed did not distinguish between SAML login flow with principals API and pure GAIA-based authentication. The corresponding histograms were renamed to ChromeOS.SAML.APILogin and ChromeOS.SAML.Scraping.PasswordCountAll. Bug: 976230 Change-Id: I94a1e903664ba9d6b11e97ebd750cadba7edf82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835576Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
A Olsen <olsen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Mikhail Khokhlov authored
Bug: 981349 Change-Id: Iaeaf5ba584d6592a64226d9b57c37e6c9d5544a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863021Reviewed-by:
-
chrome://appsElly Fong-Jones authored
This change adjusts the color scheme on chrome://apps: * The webstore link is now Blue 600 and has no hover effect, to make it look like the link it is * Other text in the footer is #666 so it's readable on the background * The background is white instead of a near-white translucent gradient * The logo image is now an image without text, since the text was not contrast-y enough Bug: 957393 Change-Id: I3b3f08554222b23f63d167b54875004a4ddb5c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856541Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706032}
-
Peter Kasting authored
These should be ints per our style guide, and were both set and used as ints (via implicit and explicit casts, respectively). Bug: none Change-Id: I815879e38e5ec363a50bb2f58a0b607f716ad8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855198 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706031}
-
Xiaohan Wang authored
External Clear Key is a test key system. This CL updates the comment to explain what it is used for and how it's supported in different cases. Change-Id: I955a6bb2db039069122ecf98ebe944628526e700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863111Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#706030}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df18296f9844..fb6a1abe4567 git log df18296f9844..fb6a1abe4567 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 mtklein@google.com try un-teaching TSAN about Mac semaphores Created with: gclient setdep -r src/third_party/skia@fb6a1abe4567 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: I5b8244727d408b0cb1c5466fa74d8ee6bc8a41c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862242Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706029}
-
Jeremy Roman authored
Change-Id: I661ebde62fbe9b010d923a4948ecb942a214cb17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862625 Commit-Queue: Andreas Haas <ahaas@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706028}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8e512c1e9ab..14df22429d27 Created with: gclient setdep -r src-internal@14df22429d27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1005965,chromium:None Change-Id: I469ea22a0741a670033f0aeceb48e00549e85e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863529Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706027}
-
Yuwei Huang authored
Mojave users might have already granted a11y permission to the old helper script. In order not to unnecessarily break them, this CL implements a fallback logic in the host service executable to always delegate to the old script if the script exists and the user is on macOS 10.14. Bug: 10142116 Change-Id: I301585cf25ca3c37ac1ebedac8b4dee6c1251c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861278Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#706026}
-
Xing Liu authored
This test is failing on some Android builders. Disable it for now. TBR=ricea@chromium.org Bug: 1014556 Change-Id: Iad4dbb959199476e08c90848ebd325143d6eeb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862717Reviewed-by:
-
jonross authored
Update the example usage of --local-run for pixel tests. This is a follow-up to a change of how the argument is used: https://chromium-review.googlesource.com/c/chromium/src/+/1860677 Bug: 1013358 Change-Id: Id1ccdd5b55c89e976ff77853925c0db9c7bcd835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862624Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#706024}
-
John Budorick authored
Became very clear that this was too much noise at info level while working on pushing data deps for the emulator. Bug: 922145 Change-Id: I038c478feed4e0f3bb39d8f9e7dc3ea21a22fd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861111 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#706023}
-
liberato@chromium.org authored
Instead of using the current src URL when downloading media, use the final target after all redirects from resource selection. Additionally, do not download the media file if any cross-origin redirect is requested by the server. Bug: 990867 Change-Id: Ibcd7a7aff8959b7f5bbfdcc38290a701f06c6123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845773Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#706022}
-
Peter Boström authored
Replaces OnBoundsChanged overrides. Also removes std::unique_ptr from GetButtonHighlightPath which reduces heap allocations. Bug: chromium:1007546 Change-Id: I763d32ba39907a34ca4356979038e0f93e231d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861274Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706021}
-
Andrey Kosyakov authored
This reverts commit 3d4ab06a. Reason for revert: broke history navigation with virtual time. Original change's description: > Encapsulate WebScopedVirtualTimePauser inside Blink > > This moves history navigation virtual time pauser from > RenderViewImpl to Page, which has two benefits: > - slimming down RenderViewImpl; > - encapsulating virtual time inside Blink. > > Most of changes are moving virtual time pauser creation > from thread scheduler to page scheduler. > > Bug: none > Change-Id: I9fc2683e974e005d8cea35ced0f5f82931215b5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856929 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705679} TBR=dgozman@chromium.org,alexclarke@chromium.org,altimin@google.com,altimin@chromium.org Change-Id: Ib2ebc3ebb4710201969a24e8d63f1f022df7fa9e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862249Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706020}
-
John Budorick authored
This reverts commit 8af63978. Reason for revert: suspected of causing compile failure in https://ci.chromium.org/p/chromium/builders/ci/mac-archive-dbg/3670 Original change's description: > Roll src/third_party/dawn/ 1093c4de2..c57b18020 (2 commits) > > https://dawn.googlesource.com/dawn.git/+log/1093c4de2cfa..c57b1802088a > > $ git log 1093c4de2..c57b18020 --date=short --no-merges --format='%ad %ae %s' > 2019-10-15 cwallez Add dawnGetProcAddress. > 2019-10-15 cwallez Split the libdawn target in components with a single purpose. > > Created with: > roll-dep src/third_party/dawn > > BUG=dawn:22 > > Change-Id: Ibc6a154143d98e2c9a5d770e766388e43d05b5ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863013 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705998} TBR=kbr@chromium.org,cwallez@chromium.org Change-Id: I621465bddca007213307e862b68192953eac49ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862991Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706019}
-
Anushruth authored
This will be removed in the future once errors due to isolate corruption disappear. R=bpastene@chromium.org Bug: 1013093 Change-Id: I24976ec89c2a34900cade8e549766bb10858b45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856871Reviewed-by:
-
Mounir Lamouri authored
Bug: None Change-Id: Icc2d8edc147173bdeaf0c895a199c0a86c5b78f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863030Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#706017}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b17e79b773ba..f8e512c1e9ab Created with: gclient setdep -r src-internal@f8e512c1e9ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I278212026dad0bb47d9ac3121f151264d25f03f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862239Reviewed-by:
-
Michael Lippautz authored
Tbr: bikineev@chromium.org Bug: 1014414 Change-Id: I914c6be2723656b4c24d37f46f3e95beaf16452e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863411Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706015}
-
Maksim Moskvitin authored
This CL has two goals: 1. Prevent setting custom passphrase while we have pending keys. We can't build correct keybag otherwise. 2. Allow users with backward-compatible keystore Nigori exit pending encryption state by providing old passphrase. Bug: 922900 Change-Id: I34e62ca41c1baf48ffc66fb9a13ea1bde438a8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855965 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706014}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9b58c027..65c6e8ed Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I547b00fee905d36cfedbe8b6c459e93703752dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863229Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706013}
-
Ben Kelly authored
Bug: 1014486,1010624 Change-Id: I175e6390cb67be4acff89caebee33c86d07230c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863230Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#706012}
-
Camille Lamy authored
This CL updates test expectations for two flaky WPT layout tests. Bug: 1014327, 1014326 Change-Id: I53b47ecf81338df03eaa75e5520db56cb2c6f49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863027Reviewed-by:
-
Rohit Agarwal authored
Chrome didn't warn the users about open incognito windows that would be lost during the update. Added a general warning in the settings and a personailzed warning, indicating the count of open incognito windows in the Relaunch Chrome dialog. Bug: 810989 Change-Id: Ibd6bf11024e94b0490964f3cdf2236d10c14d998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814924Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#706010}
-
Avery Musbach authored
The present CL is similar to [1]. The rationale in the commit message of [1] does not apply to the current plan for multi-display split view, but similar code changes seem reasonable anyway. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1726310 Bug: 970013 Change-Id: I1a1572d89c2d25ac60b9ac25dc37edce7b74fce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856890 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#706009}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/61d3d4b0bd55..ba97f6065ed1 git log 61d3d4b0bd55..ba97f6065ed1 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 chrishall@google.com Trivial: Removing gendered pronouns from watchlists.py. Created with: gclient setdep -r src/third_party/depot_tools@ba97f6065ed1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:879943 Change-Id: Icd118e802cc33046b5e36f3ef73130c45b717d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862628Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d3b93d4c73b8..260e87e6956a git log d3b93d4c73b8..260e87e6956a --date=short --no-merges --format='%ad %ae %s' 2019-10-15 wbbradley@chromium.org shellcheck: look inside the chroot first for shellcheck Created with: gclient setdep -r src/third_party/chromite@260e87e6956a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I521acfbcce01fcc8c3ef77b6151d56c600405985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862627Reviewed-by:
-
