- 05 Feb, 2020 40 commits
-
-
Mason Freed authored
See crbug.com/1049126 - the origin trial system is not supported by headless clients. See [1] which does not override the implementation of GetOriginTrialPolicy(). In the meantime, we need to re-enable Web Components v0 for all headless clients to avoid site breakage. [1] https://source.chromium.org/chromium/chromium/src/+/master:headless/lib/headless_content_client.h [2] https://source.chromium.org/chromium/chromium/src/+/master:content/public/common/content_client.cc;l=104;drc=2271977bc199216d8266c8a99f8a0b4f147ae0cc Bug: 1049126 Change-Id: I9af33d03ad34d4ed23a8f5680641ff2066a02840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039601 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#738720}
-
Sergey Ulanov authored
Added --canvas-msaa-sample-count and --gpu-rasterization-msaa-sample-count in the list of switches allowed in the WebEngine config. These flags are useful to turn off MSAA, which may be required to save memory. Bug: fuchsia:43693 Change-Id: Ib519cc7bede46a5ff7879d1a9678fbf88e33de2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040200 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738719}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/47b15048a1fa..7fe6efba4ae3 git log 47b15048a1fa..7fe6efba4ae3 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 cwallez@chromium.org Add initial CMakeLists.txt files Created with: gclient setdep -r src/third_party/dawn@7fe6efba4ae3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1cb25a29d5dd77050337a177c6dd09c4ff8a8d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037983Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738718}
-
Natalie Chouinard authored
Move Search Engine settings alongside Search Engine code. Bug: 1047357 Change-Id: I97f1d8ccd4937d59aaff851db4f911b5426024e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039600Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#738717}
-
Victor Costan authored
Change-Id: Ic04ca0131da2a1fe558ffa2a5359ba1372889679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040068 Commit-Queue: Jay Harris <harrisjay@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#738716}
-
Kent Tamura authored
The behavior with kRestoreOnLoad==true caused one regression, crbug.com/1035662, and it was fixed. We think the new behavior has no major issues, and we don't need to keep the old behavior. This CL has no behavior changes. Bug: 1008708 Change-Id: I449a5d90489f9729dfd85aa9d0d229461967bc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038410Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#738715}
-
Aaron Leventhal authored
Bug: 1006767 Change-Id: I9665b2e1c935bece54e92d94a327071128f3efb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032788 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#738714}
-
Liquan (Max) Gu authored
Context: PaymentHandlerMediator does not stop the posted tasks on PH hidden. In the example of the bug, PaymentHandlerMediator has found the page to be insecure in several WebContents observer hooks. Each of them posts a hide() task. When several of such task is posted, the first task would release WebContents; the subsequent tasks who tries to access WebContents would trigger the crash. Before Change: Clank would crash when users clicking an http link in a payment app. After Change: No crash happens. Change: * In ServiceWorkerPaymentAppBridge, whenever it tries to access WebContents, check whether if it has been destroyed. * PaymentHandlerMediator stops the pending posted tasks on PH hidden. * (side) fix CCT PH UI for always closing on open. Bug: 1049262 Change-Id: I9f849854c48e92e06ada1348a80d761a0b4db744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039995 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738713}
-
Henrique Nakashima authored
Useful while I'm refactoring flags. Change-Id: I5cce35bbe1c6072b0ad20bf99fc9e34dbcb69cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040066Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#738712}
-
Sam Sebree authored
This change addresses the bug in which autofill text does not display correctly in high contrast mode with forced-colors turned on. Bug: 1046141 Change-Id: I06e1e1c9165e6d430c4df2167e69adf142665616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024032Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#738711}
-
Xiaocheng Hu authored
This patch reduces style recalc after loading a web font, by: 1. Allowing a Font object to be reused after loading a web font, by calling FontFallbackList::Invalidate() when accessing a FontFallbackList after font updates. 2. On the style and layout update after font loading: a. Traverses the document, and invalidates styles on nodes where font metrics are required for style computation: when length units 'ch' and 'ex' are used, or when 'font-size-adjust' property is set. b. Stops using IsLoadingCustomFont() related checks for style or layout invalidation. c. Traverses the layout tree to manually invalidate layout, since font changes are no longer reflected in ComputedStyle differences. Bug: 441925 Change-Id: I932b733e71a6de936f95bdff435ce177997820ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952189Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#738710}
-
Karan Bhatia authored
Add a simple perf test for SubstringSetMatcher. I plan to change a bit of the internal implementation, so this will help to measure any perf difference as well as catch future regressions. BUG=974391 Change-Id: I03ad4d2ae531c524256db095285761ea4529b270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038070Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#738709}
-
Theresa Wellington authored
Move the following classes to components/browser_ui/widget/ - FeatureHighlightProvider - InsetObserverView - MenuOrKeyboardActionController BUG=951455,1010176 Change-Id: I7eac449f45b52f243fea468554b2a9f6c4868d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040002 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#738708}
-
Peter Kotwicz authored
This reverts commit f8a4ba13. Reason for revert: GN modifications broke components_background_task_scheduler_junit_tests Original change's description: > Background task scheduler : Split code into public and internal > > This CL separates the public interfaces from the internal code of background > task scheduler's Java code. > > 1 - The public classes/interfaces are left at top level components/background_task_scheduler > while the implementation code is moved to internal/ > 2 - Internal code is moved to a separate package as well. > 3 - The factory will be a separate target that depends on public and internal. > 4 - Some classes need to be referenced from both chrome/ and internal code, > e.g. BackgroundTaskSchedulerFactory, Uma classes, SharedPref. To handle this, > have two classes, e.g. BackgroundTaskSchedulerFactory and BackgroundTaskSchedulerFactoryInternal > > We should probably move the NativeBackgroundTask as well to components/ which > will greatly help the dependent code to live in components/. Will think about it in a future CL. > > Bug: 1045765 > Change-Id: Idddb3ed33789a735e920f33b7c0f3cb40e5e844a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021857 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738560} TBR=nyquist@chromium.org,dtrainor@chromium.org,shaktisahu@chromium.org Change-Id: I33c04539e01afae186023e7e011842994d8589ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040373Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738707}
-
Marc Treib authored
Bug: 1034915 Change-Id: Ida5008f8292c1f885c18ead46a04d3c456857674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031025 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738706}
-
Gary Kacmarcik authored
Bug: 946001 Change-Id: I9131bb30d774cd38d169cb92d41fd357cdf0d71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040000 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#738705}
-
Jay Harris authored
Some users are reporting that badging stops working after several days of leaving the app open. We do not have steps to repro, so I'm speculating that it's caused by the mojo connection failing. To test this, I'm going to create a new connection each time we set the badge. If the issue continues to be seen after this CL lands, it can be reverted. Bug: 1048880 Change-Id: Idbcca7be2d08ed8011f05351482705af8f0fea92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035521Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#738704}
-
Takuto Ikuta authored
Bug: 984869 Change-Id: I1376a7ca637041c4d71bea60c6354b6a63054958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038810 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#738703}
-
Carlos Knippschild authored
This reverts commit e6780b7e. Reason for revert: seems to be breaking "browser_tests" on "linux-chromeos-chrome" Original change's description: > Add browser tests for Reader Mode omnibox icon. > > Bug: 992074 > Change-Id: I2b54639a15222d2c30cf419c606b62ebd28597e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951893 > Commit-Queue: Katie Dektar <katie@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738661} TBR=ellyjones@chromium.org,dmazzoni@chromium.org,katie@chromium.org,gilmanmh@google.com Change-Id: I96214b491da480cd85f809ddb451c48f8a358ba2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 992074, 1049350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040069Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#738702}
-
Jared Saul authored
Was set to ENABLED_BY_DEFAULT in https://chromium-review.googlesource.com/c/chromium/src/+/2017911 Change-Id: Ib93f62d678007d38043b59575cb9ee73f80f84d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036355 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738701}
-
Brian Osman authored
Picks up a minor change to stop using a to-be-deprecated Skia API Change-Id: I842ca9ddf7ff818f0ec975eb9f87ff2e461f7371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040192 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by:
Mike Klein <mtklein@google.com> Cr-Commit-Position: refs/heads/master@{#738700}
-
Fredrik Söderquist authored
Using the "max presentation time" concept we can greatly simplify the "once" animation-policy by essentially letting it define a limited window of the timeline in which the animation will be active. This allows us to drop the associated timer and other doodads, leaving just a fairly simple method that is called whenever the container's presentation time is reset. There is a small change in behavior in that the container is no longer explicitly paused, but rather just halted after 3 seconds. Replace the layout test with a set of unittests. Bug: 998526 Change-Id: I2aaa927198bc7918b5767381753a5334ebcd115d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030969Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#738699}
-
Robert Liao authored
Remove Uses of Microsoft::WRL::ComPtr<T>::GetAddressOf() in //chrome/services/util_win/util_win_impl.cc Microsoft::WRL::ComPtr<T>::GetAddressOf() is banned due to the ease of causing memory leaks. BUG=914910 TBR=pmonette@chromium.org Change-Id: Ib7f6b2a03ead757f5b7d3897c2eb788104cc15db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040004Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#738698}
-
Hesen Zhang authored
- Setup prefetch notification service, factory and client code. Bug: 1047037 Change-Id: Iccc82d8b49f63213294eb0440fc59138db756912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029293 Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738697}
-
Askar Aitzhan authored
Since Tango is being shut down & feature "Cloud Policy over FCM" is being enabled: * Enabled on ToT (M81) * Enabled 100% on Finch experiment starting from M78 Bug: 1048214 Change-Id: Ie69bf1b89d2b9c4496479374b310eae9394be1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035880 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#738696}
-
David Black authored
Bug: b:148080975 Change-Id: Iaaca31713f62f0b0ea50e77dfdc2c0e2863273f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037815 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738695}
-
Michael Thiessen authored
Bug: 783819 Change-Id: Ib1970a41bb45a31907ea91358fd27bee6c6b20a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039301Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#738694}
-
Eugene But authored
Add OverscrollActionCloseTab user action. Mark MobileTabClosed as not_user_triggered. This will help to better distinguish different ways of closing the tab. Bug: 1046223 Change-Id: I58ce36f51bb39f4d52e75633c2c6840ce4283b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032405 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738693}
-
Sam Maier authored
Bug: 1049135 Change-Id: I7e06123068b09643e9063f2df9bb04ff1b8b2884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039133 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#738692}
-
Jonah Chin authored
This CL simply sets up the finch flag for OOP-R canvas. This flag flips the bits required for OOP-R when creating the context. Bug: 1023277 Change-Id: Ic5da502ba1eaf8c01a308d1f88ec17a07e31f625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036521Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#738691}
-
rbpotter authored
This is in preparation for autogenerating tests for the Polymer 3 version of settings-subpage. Bug: 1026426 Change-Id: I32b119cf18f8b7f7f1053621a81e10f65ffcbc8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038491Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738690}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ic425480d4269f08467fffd442b891153e6039ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039296Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#738689}
-
Tommy Steimel authored
This CL updates the Global Media Controls dialog to use 7 as the minimum contrast ratio between the foreground and background colors instead of using the default of 4.5. Bug: 1049242 Change-Id: I81538040993cdd555cd1e6173554b9021018d18e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039894 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#738688}
-
Philip Rogers authored
Invalidations are needed for throttling when a frame's cross-origin-to-main status changes (see https://crrev.com/451041 and be set from javascript by modifying document.domain. We issue throttling invalidations on the frame that changes origin, but missed the case when a main frame origin change causes subframes to become non-cross-origin-to-main. This patch invalidates all descendant frames when the main frame's origin changes. LocalFrameView: :UpdateRenderThrottlingStatus). The origin of a frame can Change-Id: Ibd6b99f6666deb4f583f37cad9cfd2a823ea749e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036269Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#738687}
-
Tao Bai authored
- This patch added command line to write the minidump to log - and enable it by default for WebView. Bug: 979082 Change-Id: I9dd7fc282261356ec6d26b030333c0e86e92ea93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037083Reviewed-by:
Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#738686}
-
Javier Fernandez authored
The Baseline Content-Alignment feature is not implmemented yet, so the tests realated to that feature should be skipped. Additionally, the 'last baseline' keyword is marked as risk, so it's not implemented yet; the related tests should be skipped as well. Bug: 1047575 Change-Id: If9754ff23c111560398a37e0dd3da3f97c5fbd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039191Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#738685}
-
inglorion authored
This change makes two improvements to the distributed ThinLTO scripts: 1. When no code generation is necessary, invokes the local linker correctly even when --gomacc or --jobs options are specified. 2. Change create_file to ensure_file to only create files if they do not already exist, reducing unnecessary rebuilding. R=gbiv,hans,rnk,thakis BUG=877722 Change-Id: I29ffa028202c31f77df95d306432f726e3f7bda9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039996 Auto-Submit: Bob Haarman <inglorion@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#738684}
-
Jeff Yoon authored
iOS current writes out full_results.json, but moving forward the Chromium recipe expects an output.json file. We write the same contents of full_results.json to output.json such that the Chromium recipe can collect_task and run the noop_merge merge script. Changes to the content of output.json will be required for utilizing the standard gtest merge script. Bug: 1031338 Change-Id: Ifff558d37618afeb371944693a6b76a4be46547d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032809Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#738683}
-
Maggie Chen authored
By the time the GPU info collection is requested, the GPU vendor id and device id should be available. Something must be wrong if the device id is 0. In this case, no need to collect GPU info. This CL also renames the info collection GPU process from GPU_PROCESS_KIND_UNSANDBOXED_NO_GL to GPU_PROCESS_KIND_INFO_COLLECTION Bug: 896565 Change-Id: I00e1a70448f337f148ae7ad4f016d2308c284fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036940 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#738682}
-
Ken MacKay authored
So the name better matches the actual use. Merge-With: eureka-internal/360190 Bug: none Change-Id: Icad7d7496a67e6af96f72ccc73e41e0c2d68d935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039295Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#738681}
-