- 07 Feb, 2020 40 commits
-
-
Leon Han authored
In js, "enum_value ? x : y;" will get y if enum_value is 0, but x is what we actually want to get in such a case. The correct code should be "enum_value != null ? x : y". BUG=520391 Change-Id: Ibe3771d0dc0ece3cd6659aec298306f694a8f0e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037106 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#739339}
-
Rune Lillesveen authored
When the XML parser is paused, we temporarily store pending callbacks to call the XML parser hooks when the parser resumes. For error reporting we used the line/column number for the current position of the parser input which is not correct when handling errors for the invoked callbacks. This CL adds these source positions to the callbacks to have correct positions for error reporting. The test below will fail without this CL when the BlockHTMLParserOnStyleSheets flag is enabled. TEST=svg/hixie/error/013.xml Bug: 891767 Change-Id: Ie3e6c608253dfa355b9947433c79ef21d912cbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041443Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#739338}
-
Shakti Sahu authored
This is a reland of f8a4ba13 Original change's description: > Background task scheduler : Split code into public and internal > > This CL separates the public interfaces from the internal code of background > task scheduler's Java code. > > 1 - The public classes/interfaces are left at top level components/background_task_scheduler > while the implementation code is moved to internal/ > 2 - Internal code is moved to a separate package as well. > 3 - The factory will be a separate target that depends on public and internal. > 4 - Some classes need to be referenced from both chrome/ and internal code, > e.g. BackgroundTaskSchedulerFactory, Uma classes, SharedPref. To handle this, > have two classes, e.g. BackgroundTaskSchedulerFactory and BackgroundTaskSchedulerFactoryInternal > > We should probably move the NativeBackgroundTask as well to components/ which > will greatly help the dependent code to live in components/. Will think about it in a future CL. > > Bug: 1045765 > Change-Id: Idddb3ed33789a735e920f33b7c0f3cb40e5e844a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021857 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738560} TBR=nyquist@chromium.org,dtrainor@chromium.org,shaktisahu@chromium.org Bug: 1045765 Change-Id: I89e333ec32071458fb76af298b935eb227daac92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040433Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739337}
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-4028.0-1580726817-benchmark-81.0.4044.11-r1 to 82-4028.0-1580728925-benchmark-81.0.4044.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I429cf7be647af704ba0ac0670f0eb642f458b5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043399Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739336}
-
Wei Lee authored
This CL allows users to enable/disable performance logging in console via expert mode. Bug: b/141518806 Test: Run CCA and toggle the button in expert mode and see performance logs in console. Change-Id: I67cdc2db8151ea07282b0b5e9891d68cb51bee44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035478 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#739335}
-
Gauthier Ambard authored
Failing on iOS 12. TBR=sczs@chromium.org Bug: 1049972 Change-Id: Id88efad29ed9d8299deee541c7370614629a4212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043473Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#739334}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-4028.0-1580727432-benchmark-81.0.4044.11-r1 to 82-4028.0-1580727110-benchmark-81.0.4044.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2fc84b9ea7a1f489722e830b7fea096698f2c2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043396Reviewed-by:
-
Eric Seckler authored
To reduce flakiness on win. Bug: 1048948 Change-Id: I538a26f97f73c413b8310918db2c86523f9f6ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043570Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#739332}
-
Stephen Nusko authored
NOTRY=true TBR=crouleau@chromium.org CC=pasko@chromium.org,crouleau@chromium.org,chrome-android-perf-status@chromium.org BUG=1049984 Change-Id: I613e3807344ab7953d687db1ef905fe99a43c816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041486Reviewed-by:
-
Alexandre Courbot authored
These methods do not change the state of the V4L2Device and should thus be const. They will eventually disappear once GL imports are not required anymore, but in the meantime let's make it clear that they can be called from any thread. BUG=None TEST=Chromium builds for arm-generic. Change-Id: I51a58847083165e49f57e75a79650edeb49dc8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043530 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#739330}
-
Maksim Ivanov authored
Reenabling the ExistingUserControllerPublicSessionTest.AutoLoginNoDelay browsertest - the test didn't fail after 15'000 local executions under stress, so presumably the flakiness has been fixed elsewhere. Bug: 516015, 644205 Change-Id: I17645f1d61ffc7e4ba772e75436dd9c6e6e471be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042092Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#739329}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e02f4996c6e9..55de83afeec7 git log e02f4996c6e9..55de83afeec7 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 656650f461c8..95c414ffee64 (2 commits) Created with: gclient setdep -r src/third_party/angle@55de83afeec7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Iafd3feff737d3cf0027ae9ae2e649c86c2065f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043029Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e6a829e67854..492af9a453f4 git log e6a829e67854..492af9a453f4 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 ddrone@google.com Merge "Update devserver port in documentation" Created with: gclient setdep -r src/third_party/perfetto@492af9a453f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I62ffe7349965061ae787d694d77b3b57bf33dbee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043391Reviewed-by:
-
Alexandre Courbot authored
http://crrev.com/c/2026852 fixed a race condition when passing the visible size of the buffers we import into GL. However since I cannot do a proper copy/paste, the new code calls decoder_->GetPicSize() instead of the original decoder_->GetVisibleRect().size(). This results in a size larger than expected sometimes being passed to CreateGLImageFor(), and an EGL_BAD_ALLOC failure happening, leaving the video area entirely black. Fix this by using decoder_->GetVisibleRect().size() as it should have been in the original CL. BUG=b:149067939 BUG=b:148421581 TEST=Youtube video resolution switch on Krane without black screen. TEST=tast run video.Seek.switch_* on kevin64 TEST=tast run video.Seek.switch_h264 on krane Change-Id: I97147421ac271143b74f267bbcb7627e607a19bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043264 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6534ac6e3763..a7b3e6babed7 Created with: gclient setdep -r src-internal@a7b3e6babed7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I58b1a579096e1d496436ca51bfb9016b24f475d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043390Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739325}
-
Finnur Thorarinsson authored
This reverts commit e8b29536. Reason for revert: Fails consistently on the bots. See errors in build where CL was introduced... https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/99608 Original change's description: > Add more System Information collection via WMI > > This CL adds code to collect metrics regarding the processor that the > user is running on. > > R=rockot@chromium.org > > Bug: 1032858 > Change-Id: I38628c722849071c8d0219ce942a257fc0623424 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982237 > Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> > Auto-Submit: Rahul Chaturvedi <rkc@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#739252} TBR=rkc@chromium.org,thestig@chromium.org,isherman@chromium.org,rockot@google.com,asvitkine@chromium.org,wfh@chromium.org,sebmarchand@chromium.org Change-Id: I0e6cb122d9df1c246e1b8ff35e845d5798537104 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043472Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#739324}
-
Monica Basta authored
This CL contributes to changing the API to get the primary account from the identity manager to be consent-aware. |GetUnconsentedPrimaryAccountId| is replaced with |GetPrimaryAccountId(ConsentLevel::kNotRequired)| Bug: 1046746 Change-Id: I4c2638f57dd92f089b41eda590c3c6c2f0b4d4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041762Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#739323}
-
Finnur Thorarinsson authored
This reverts commit 78be82a7. Reason for revert: This CL looks a likely culprit in persistent failures on bot (the failures started with the build where this was checked in): https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel For example, browser_tests failed because of: ArcAppDeferredLauncherWithParamsBrowserTestInstance/ArcAppDeferredLauncherWithParamsBrowserTest.StartAppDeferred/2 [13339:13339:0206/193410.483101:ERROR:arc_app_list_prefs.cc(1348)] App instance is not connected. Delaying app list refresh. See b/70566216. ../../chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc:187: Failure Value of: app_info Actual: false Expected: true Stack trace: #0 0x5598ac547445 ArcAppLauncherBrowserTest::InstallTestApps() #1 0x5598ac547a5c ArcAppDeferredLauncherWithParamsBrowserTest_StartAppDeferred_Test::RunTestOnMainThread() #2 0x5598afd61adf content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #3 0x5598af8dcc3f ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #4 0x5598af8dbdc9 ChromeBrowserMainParts::PreMainMessageLoopRun() #5 0x5598acb81fca chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #6 0x5598add3bb44 content::BrowserMainLoop::PreMainMessageLoopRun() #7 0x5598ae10e453 content::StartupTaskRunner::RunAllTasksNow() #8 0x5598add3ab6a content::BrowserMainLoop::CreateStartupTasks() #9 0x5598add3d301 content::BrowserMainRunnerImpl::Initialize() #10 0x5598add3910d content::BrowserMain() #11 0x5598af3b30a9 content::ContentMainRunnerImpl::RunServiceManager() #12 0x5598af3b2d77 content::ContentMainRunnerImpl::Run() #13 0x5598b19ae967 service_manager::Main() #14 0x5598ae7c37a4 content::ContentMain() #15 0x5598afd61620 content::BrowserTestBase::SetUp() #16 0x5598af7b91b8 InProcessBrowserTest::SetUp() Original change's description: > Synchronize ARC a11y tree on enableFrame > > Currently, if Android app starts before ChromeVox or S2S starts, ARC > AXTrees are not recognized from these ATs. > This is because: > - AXChildTreeID is not attached to the parent surface at that moment. > - ARC AXTrees are not triggered to update on > automationInternal.enableFrame. > > This CL fixes these issues. > Android side change is http://ag/10167029. > > Bug: b:129681889 > Test: manual. Open any Android app, then enable ChromeVox. Confirm that Android app gets focus. > Change-Id: I38cb372f706817f5e305c4a10a1ac84176275397 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018624 > Reviewed-by: Sean Topping <seantopping@chromium.org> > Reviewed-by: Randy Rossi <rmrossi@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: Hiroki Sato <hirokisato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739233} TBR=jorgelo@chromium.org,oshima@chromium.org,dtseng@chromium.org,achaulk@chromium.org,hidehiko@chromium.org,seantopping@chromium.org,rmrossi@chromium.org,sarakato@chromium.org,hirokisato@chromium.org Change-Id: Ib505b1ffd8ff0b9e425a8ded1e3378493c807801 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:129681889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043471Reviewed-by:
-
Rune Lillesveen authored
In [1] we introduced pausing the XML parser for parser blocking stylesheets. The HTML parser did this by setting a flag in DidAddPendingParserBlockingStylesheet() without actually pausing the parser in order to not pause the parser for style and link elements which finishes synchronously by calling DidLoadAllPendingParserBlockingStylesheets() immediately. In addition to unnecessarily pausing the parser, this caused a problem with LocalFrame::ForceSynchronousDocumentInstall() which is not able to handle pausing of the parser. The method is used for loading SVG images via the image tag, and also for generating popup content like for select element dropdowns. The forced sychronous html parsing also works in the cases where we have external resources because external resources are being blocked so that link, style, and xml-stylesheets always finishes sychronously. Hence, the parser will not be paused with this change. The test in the TEST line below fails without this change and with the BlockHTMLParserOnStyleSheet runtime flag enabled. [1] https://crrev.com/6f828b7c947e4ef81401924cde65429d246f0225 TEST=svg/as-image/img-zoom-svg-stylesheet.html Bug: 1043944 Change-Id: I7f31fffd7da385f411d68cbc9ec77d0eb25f41c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039411 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/624f9f49..730ee40e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I05cef209af1dde00675e07c9ea4db6a796467f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042551Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739320}
-
Boris Sazonov authored
Removes unused mChromeSigninController field from SyncController. Bug: 1046412 Change-Id: Ie7f77000e075bf0dcb3c80b33533ac49a52cd52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041608 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#739319}
-
Dominik Röttsches authored
Now that we have scope helpers defined in a shared location for typical HarfBuzz types, use those in Blink. In order to be able to do that for HarfBuzzFontCache, FontGlobalContext needs to forward-declare and isolate HarfBuzzFontCache from leaking outside the header, otherwise all clients need to be made aware of HarfBuzz types. Bug: 1049527 Change-Id: Ic2e6a3fec01a4a6f22eb879d77615a986dc4b987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041471 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#739318}
-
Jan Wilken Dörrie authored
This change renames PasswordStore::CompromisedPasswordsObserver to PasswordStore::DatabaseCompromisedCredentialsObserver in order to avoid confusion with the existing CompromisedCredentialsObserver class class. Bug: 1047726 Change-Id: I0f98650ada3ba926f43eeaa5b50c11ddcfa6ade6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042095 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#739317}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I82c9d5556dd50c3e58b622be010417781f2b301f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043027Reviewed-by:
-
Eriko Kurimoto authored
This CL adds mixed-content web-platform-test coverages for xhr/fetch API/websocket requests from classic/module data: URL dedicated workers. These tests are generated by already-existing generating template but not yet added to the repository. Bug: 906850 Change-Id: I751c3e354a9ee33be3a21e6abda542d1aede89a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035527 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#739315}
-
James Cook authored
SplitSettingsSync will allow Chrome OS users to opt-out of browser sync. However, IdentityAccessor::GetPrimaryAccountInfo() assumes the user has consented to browser sync. We still need to detect cases where the refresh token is invalid, even if the user has not consented to browser sync. Switch to using the "unconsented" primary account. On Chrome OS this account always exists for the logged-in user account, whether or not the user consented to browser sync. See go/cros-sync-mock and go/cros-primary-account for details. Bug: 1042400, 760610 Test: updated existing components_unittests Test: Bug 760610 still does not repro with SplitSettingsSync enabled Change-Id: I030e45eca6bcf82381bf1be9a4e6f829b7a4a3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040531 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#739314}
-
Hirokazu Honda authored
The coded_size of input VideoFrame is always aligned by 2. For instance, in the case the dimension to be encoded is 641x361, the input VideoFrame's coded_size is 642x362 and visible_rect is 0, 0, 641x361. This is against the expectation on which crrev.com/c/1997426 was based; The coded size of input VideoFrame is the same as the dimension to be encoded. Additionally, this corrects the va surface size mismatched bugs introduced in crrev.com/c/1997426. Bug: 982201 Bug: b:148744040 Test: video.EncodeAccel.* on hatch, grunt and eve. Test: VP8 Simulcast. Test: https://appr.tc/?debug=loopback&vsc=vp8&video=maxWidth=361,maxHeight=481,minWidth=361,minHeight=481 on hatch Change-Id: I68fe77b4e4f16879d76a7e84c3b06b73b07660b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037279 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#739313}
-
Dominik Röttsches authored
Disable API based fallback by default since there have been issues found with matching style when performing API based fallback on Windows pre Windows 10, as well as issues with selection of the UI-suffixed versions of certain CJK fonts for fallback. This reverts commit https://crrev.com/ce428e0197791b318f066a9d680cd254b05148fc. This synchronises the repository with a kill-switch experiment configuration which was already disabling this feature. Bug: 976737, 1027724, 1047791, 1020454 Change-Id: Ie3d4b8a6d48fe4949db421c383bd0c0c16dd33d7 Tbr: kojii Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948429Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#739312}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1f03ac10270a..fe10239f92f4 git log 1f03ac10270a..fe10239f92f4 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 afdx@google.com spirv-fuzz: Add fuzzer passes to add loads/stores (#3176) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@fe10239f92f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I43300414eed43020f1d20dde43092af6a239398f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043028Reviewed-by:
-
Daniel Cheng authored
The goal is to split up modules_idl_files.gni into smaller .gni files that are owned by OWNERS of the corresponding module, so top-level module OWNERS don't need to review every CL that adds a new IDL file. This patch splits out the build files for IDLs in `module_idl_files`. Bug: 1048907 Change-Id: I196a7fefa0841c82df735f5f7c79125436a3a2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043103 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#739310}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1040828 Change-Id: Ibbeaf3db0c04f791d62136211a0e91a0f45b09f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043254Reviewed-by:
-
Rachel Sugrono authored
Add a delete-button, implemented with a <cr-button>, in-between the open-button and metadata-info-button. Change tab-index tests to support the delete-button. Bug: 803259 Change-Id: Ifee06c3acdb346c5b54b7a4895926cc2406f44c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043334Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Rachel Sugrono <rsugrono@google.com> Cr-Commit-Position: refs/heads/master@{#739308}
-
Jan Wilken Dörrie authored
This change adds a skeleton for the upcoming Password Check page and provides a flag guarded entry point from chrome://settings/passwords. Bug: 1047726 Change-Id: I4f4100d6f1de4021fdf6e9ddaf86bf800949849e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036176Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#739307}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<XXXXEvent> and DynamicTo<XXXXEvent> as new downcast helper 2. Use IsA<XXXXEvent>(element) in place of IsXXXXEvent(element) Following classes are ported to use new downcasting. - DragEvent - ErrorEvent - FocusEvent - UIEvent Bug: 891908 Change-Id: I46b86859b1468c2d016abc2ce21c38d10b5d5e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041376Reviewed-by:
-
Anastasiia Nikolaienko authored
Add EDU account login handler to fetch user's family members and getting ReAuthProof token for parent. Bug: 1043108 Change-Id: Icf4b2782a4e6f114f452468baf09d2478db8d58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033156 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#739305}
-
Abhijeet Kandalkar authored
Add interface |RenderFrameProxy| to frame_proxy.mojom and have class content::RenderFrameProxy implement it. Also, remove unwanted FrameMsg_EnableAutoResize and FrameMsg_DisableAutoResize. Bug: 1041061 Change-Id: Id71ad8116eec9d2d2c37c88bb5029068e4b408bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032661Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#739304}
-
Daniel Hosseinian authored
Leverage newly defined scope helpers for commonly used Harfbuzz types to remove redundant code. Change-Id: I235f0ff302d748ab5572c1db2bff45146f52dbe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041876Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
-
Kent Tamura authored
When size_ or is_multiple_ is changed, we did the following to change menulist/listbox modes: ChangeRendering(); <adjust selection state> UpdateUserAgentShadowTree(); because UpdateFromElement() in UpdateUserAgentShadowTree() depends on the adjusted selection state. However, adjusting selection state also calls UpdateFromElement(), which depends on UA shadow tree structure. This had cycle dependency. This CL moves UpdateFromElement() out from UpdateUserAgentShadowTree(). ChangeRendering(); UpdateUserAgentShadowTree(); <adjust selection state> UpdateFromElement(); is the new pattern to change menulist/listbox modes. This CL has no user-visible behavior changes. Bug: 1040828 Change-Id: Ia3c2f81e3038faaa19b3e1fa6c4c48d212a2e568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041717 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Philipp Hancke authored
BUG=1043805 Change-Id: I433b5c67f62f304e71777d33909fd026b8583a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024847Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#739301}
-
Anastasiia Nikolaienko authored
Add <edu-login-app> component and serve it from chrome://chrome-signin/edu path. Bug: 1043108 Change-Id: Ic1f9c056095fb574520309aecd491f065e6bf2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007631 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
-
