- 26 Sep, 2019 40 commits
-
-
Yoshifumi Inoue authored
This patch gets rid of false |DCHECK_LE(start_offset, item->StartOffset())| from |ReusingTextShaper::CollectReusableShapeResults()| when inserted text starts with newline character as control character, e.g. white-space:pre, <pre>, etc. This DCHECK is wrong when adding newline chracter as control character, e.g. appending "\nX" to "n". In |ReusingTextShaper|, we have two items in |reusable_items_|. * reusable_items_[0] = kText 0-1 "n", shape_result=avaiable * reusable_items_[1] = kText 1-3 "\nX", shape_result=null Shaping items are * items[0] = kText 0-1 "n", shape_result=reused * items[1] = kControl 1-2 "\n", shape_result=n/a * items[2] = kText 2-3 "X", shape_result=new When |ReusingTextShaper| to shape for "X", |DCHECK| hits for handling |reusable_items_[1]|, because |start_offset| is 2 and |item->StartOffset()| is 1. Bug: 1003666 Change-Id: I800fae637ff7a39b0e65d07699c07b204051399e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824516 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700111}
-
Miyoung Shin authored
This change converts KeyboardLockService mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I3e6e2e6cb1c50bd83d6f8ccea881c546150eae54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816073 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#700110}
-
Vlad Tsyrklevich authored
These new process sampling parameters are now in use to cut GWP-ASan's performance regression. Bug: 896019, 912286 Change-Id: Ic45921cf307036a3896536fead041097169cf65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816369 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#700109}
-
Hirokazu Honda authored
This specifies a surface usage hint in vaCreateSurfaces(). i965 driver doesn't change a behavior by this change. The alignment of a height of a created surface is changed to 64 to 1 with iHD driver. Thanks to this, the drivers' alignment rule is or equal to weaker than the minigbm alignment rule on encoding. Bug: 1006151 Test: VEA unittest, VDA unittest, JDA unittest Change-Id: I4b0d0bd58c7c7f39151bc91b164b1f5aaf7c63bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816479 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#700108}
-
Hiroki Nakagawa authored
This is a cleanup CL, and doesn't change existing behavior. The callers of the ServiceWorkerInstalledScriptsManager ctor don't have to spread WebServiceWorkerInstalledScriptsManagerParams. Instead, they should just pass the params struct to the ctor, and the ctor spreads it by itself. Bug: 938219 Change-Id: Ia00de8b16b28ba16cb9acfcddd19255642e3edc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824511 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#700107}
-
Yuzu Saijo authored
This CL blocklists shared worker from using BackForward Cache. Bug: 1003236 Change-Id: I31ec0109336ad71a8caf5cca01f2de667b9785b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810456 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#700106}
-
Gyuyoung Kim authored
As a step to remove all uses of WebLocalizedString::kFooBar, this CL replaces below ones with matched IDS_FOO. This CL replaces below ones, - kValidationValueMissingForCheckbox, - kValidationValueMissingForFile, - kValidationValueMissingForMultipleFile, - kValidationValueMissingForRadio, Bug: 995644 Change-Id: Ib25950a5f1127b5972bbd77a3d29e1f34497c8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824512Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
ssid authored
Adds process descriptor to traces. Currently only in privacy filtered mode. This will be fixed after JSON exporter handles multiple pids. Change-Id: Ie1db96d891aa3124e9704b61c546ebf5de5e48eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711085 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#700104}
-
Cathy Li authored
Also remove ExploreSites InitialCountries from fieldTrial testing config since it has been launched. Change-Id: Iac7dbe89591ebe7c091eace065b95b62c0291b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815843 Commit-Queue: Cathy Li <chili@chromium.org> Auto-Submit: Cathy Li <chili@chromium.org> Reviewed-by:
-
Johannes Henkel authored
In flat mode, messages for child sessions are identified by their session ids in the top level of the message. To make this work I'm updating the devtools client implementation a bit. Bug: 991325 Change-Id: Icc1bf677ab5b797b5877f975fe0f7375107c11ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788621 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#700102}
-
Hirokazu Honda authored
This CL changes GpuArcVideoEncodeAccelerator to use GpumemoryBuffer based VideoFrame, not DMABUF based VideoFrame on VideoEncodeAccelerator::Encode(). Bug: 1001413 Test: Record video with Nexus 7 camera app on eve and kevin Change-Id: I42824f2a7bc77075ece399a31948bc49285d68db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809041Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700101}
-
Fergal Daly authored
It's flaky. TBR=rbpotter@chromium.org Bug: 1008122 Change-Id: I56c7bbc113f0d23ddf01dd1b15e0b47bd578d358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826065Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#700100}
-
John Emau authored
The tests use dummy data simulating a performance run. Screenshot of details (aka summary) pane: https://i.imgur.com/hQXhjma.png Screenshot of bottom-up pane: https://i.imgur.com/RuUS3RM.png Screenshot of call tree pane: https://i.imgur.com/RaWp632.png Bug: 963183 Change-Id: Ie56bfe4a66bd791997d675c4013097890b61458e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733418 Commit-Queue: John Emau <johnemau@microsoft.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#700099}
-
Yun Liu authored
Bug: 1008224 Change-Id: Ia477b9a97a1b16edab554cba11ad804105354009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826032Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#700098}
-
Gyuyoung Kim authored
As a step to remove all uses of WebLocalizedString::kFooBar, this CL replaces all kAXMedia* with matched IDS_FOO. Bug: 995644 Change-Id: Icb1e2c9e73fcef443478f29f6088f28cbf20a0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820657 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts ChannelBootstrapPtr and ChannelBootstrapRequest to new Mojo types. It uses PendingRemote, PendingReceiver, and FusePipes. Bug: 955171 Change-Id: Id60c4df6e780a7c40af4f88aab9af49200944294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824503Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#700096}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d64438c0787f..38b1a95c532f Created with: gclient setdep -r src-internal@38b1a95c532f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id26899f9e23803cc2e798531fdf8f4f4b870c57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826320Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700095}
-
Hiroki Nakagawa authored
These tests are flaky: - external/wpt/service-workers/service-worker/claim-shared-worker-fetch.https.html - external/wpt/service-workers/service-worker/worker-interception-redirect.https.html Bug: 1008257 Change-Id: Iec53b29178a56a64c149e04c07a8cdf496f08ae0 Notry: true Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826303Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts AccountStatusChangeDelegatePtr and AccountStatusChangeDelegateRequest to new Mojo types using PendingRemote, Remote, and ReceiverSet. It also update SetAccountStatusChangeDelegate from multidevice_setup.mojom. Bug: 955171 Change-Id: I2493c44e041b53a76c6fe4e1f7870bd395cc69d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824724Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#700093}
-
Tsuyoshi Horo authored
To support loading bundled exchanges local files, this CL do the following changes: (1) Change ContentURLLoader::Start() and FileURLLoader::Start() to set mime_type to "application/webbundle" when BundledHTTPExchanges feature is enabled, and the extension of the file ".wbn". (2) Change NavigationRequest::OnStartChecksComplete() not to create a BundledExchangesHandle when the URL scheme is not "file:" (or "content:" on Android). This is because currently we don't support loading bundled exchanges from network. (3) Introduce |will_return_unsafe_redirect| parameter in NavigationLoaderInterceptor::MaybeCreateLoaderForResponse() which is set to true when the interceptor will return an unsafe redirect response. We need this to skip IsRedirectSafe() check in URLLoaderRequestController::OwnReceiveRedirect() while redirecting the original request to the URL which can indicate the URL in bundled exchanges file. (eg: From "content://org.example.FileProvider/wbn/test.wbn" to "content://org.example.FileProvider/wbn/test.wbn?https://example.com/") (4) Change::URLLoaderRequestController::MaybeCreateLoaderForResponse() not to early return when |default_loader_used_| is false if the response is likely to be a bundled exchanges file. This is because while loading file, |default_loader_used_| is false. But we need to call InterceptorForFile::MaybeCreateLoaderForResponse(). (5) Change BundledExchangesHandle to be able to handle bundled exchanges local files. InterceptorForFile will handle the navigation request to the bundled exchanges file. This interceptor returns a synthesized redirect to the URL which can indicate the URL in bundled exchanges file (eg: "file:///tmp/test.wbn?https://example.com/") in OnMetadataReady() and handles the redirected request in StartResponse(). InterceptorForTrustableFile will handle the navigation request to the trustable bundled exchanges file. This interceptor returns a synthesized redirect to the bundled's primary URL (eg: "https://example.com/") and handles the redirected request in CreateURLLoader(). Bug: 995177 Change-Id: I049336322bc503026699df2fe8ffd26a86309dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792220 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#700092}
-
Julie Jeongeun Kim authored
This CL converts SimpleTestDriverPtr and SimpleTestDriverRequest to new Mojo types using AssociatedRemote, AssociatedReceiver, and PendingAssociatedReceiver. It introduces AddAssociatedInterface and BindPendingAssociatedReceiver in ipc_channel.h. Bug: 955171 Change-Id: I2b75876cb27698364aff618b0c3be13dc92847e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824505Reviewed-by:
-
hyunjune authored
This patch fixes up a crash relied on line break with 'white-space'. Because After HandleOverflow is called, the current style is changed into |HandleOverflow|. So When |TextBreak|'s result is Overflow, this patch restores the current style as the old current style. Bug: 999863 Change-Id: I787d80abac66599671fd6cb19cb19eebb2110852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806616Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#700090}
-
Hirokazu Honda authored
This CL introduces a class that enables to pixel format conversion and scaling with VA-API. The interface of the class is ImageProcessor. Bug: 898423 Test: image_processor_tests on atlas Change-Id: I275b4dec50594ca6328743bb5a3532e0a8d25ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1367389Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700089}
-
Alexey Baskakov authored
Support creation and deletion of apps as a part of single update. RegisterApp, UnregisterApp and UnregisterAll methods now can be expressed within one WebAppRegistryUpdate (one transaction). Report kWriteDataFailed in InstallFinalizer if commit fails. WebAppRegistryUpdate CreateApp/UpdateApp/DeleteApp is now the only writable database API (as in Database CRUD: Create/Update/Delete). Bug: 860583 Change-Id: Ia2e23a4d4a0d47e62b815abd55803616a204e813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824043Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#700088}
-
Istiaque Ahmed authored
IPCs to WorkerThreadDispatcher arrive initially on main thread via WorkerThreadDispatcher::OnControlMessageReceived() [1]. This IPC is forwarded to worker thread, via WorkerThreadDispatcher::OnMessageReceivedOnWorkerThread() [2]. If the worker destruction (Dispatcher::WillDestroyServiceWorkerContextOnWorkerThread) happens on worker thread between [1] and [2], IPC forwarding succeeds (b/c the worker is alive at [1]), but IPC handling doesn't (as worker data is already cleared while we run [2]). Fix this by checking worker data's existence while handling the IPC on worker thread and bailing out. Bug: 1008143 Test: Locally running ServiceWorkerTest.Update*Extension thousand times. Change-Id: Id5dd1b4c3d24995228aeb0f1fdd72edc1b77f747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825169Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#700087}
-
Alexandre Courbot authored
The introduction of a sequence checker in V4L2Devices means that we need to be more careful about who destroys (i.e. who "owns") a given V4L2Device. Make sure the IP device is destroyed by the IP thread, and the decoder device by the decoder thread. Bug: 1003223 Test: vdatests passing on Kevin. Change-Id: I21d55163d5830b45afb882fcced2bd8cef069151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826300 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700086}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e00ffeb79abc..b3ae56238672 git log e00ffeb79abc..b3ae56238672 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 abennetts@google.com Skip Catapult Android Tryserver for CLs that only touch the dashboard. Created with: gclient setdep -r src/third_party/catapult@b3ae56238672 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:985223 Change-Id: I2c32bf794b1d553082e0d54f125e05b5b59b1239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700085}
-
Kenichi Ishibashi authored
It existed for on-the-main-thread script fetch. We can replace it with FailedToFetchClassicScript(). It's consistent with module script fetch callback (FailedToFetchModuleScript). Bug: N/A Change-Id: I6cf5ccba53ea73d48bfbecef42864b88484da341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826059 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Fergal Daly authored
It's flaky on those builders. TBR=droger@chromum.org Bug: 1008238 Change-Id: I090ba713404d9853df74761d4c09ac646b01507e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824055 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This change converts VibrationManager mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Iab5ad8845989ec8a1c8c885f2d347feb6f0f2de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824042 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
siyua authored
The loading indicator will be a circle throbber on top of the icon. It will be shown when a upload save is in progress. The icon will be disabled (not clickable) during the animation. If upload save succeeded, dismiss the icon and shows the avatar highlight, otherwise stop the animation and shows the failure bubble/icon (credit card icon with a failure badge). The failure bubble will be shown only once. Once the bubble is dismissed, the icon will be as well. Bug: 932818 Change-Id: I305a5998d216546c697f35ffae18ec80ded05292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808168 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#700081}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56c87856cd03..d64438c0787f Created with: gclient setdep -r src-internal@d64438c0787f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:988217 Change-Id: Icc2c3087fa91a39ea51c85ee2127ae65b8e735be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825493Reviewed-by:
-
Gyuyoung Kim authored
As a step to remove all uses of WebLocalizedString::kFooBar, this CL replaces below ones with matched IDS_FOO. - WebLocalizedString::kMediaRemotingCastText, - WebLocalizedString::kMediaRemotingCastToUnknownDeviceText, - WebLocalizedString::kMediaRemotingStopByErrorText, - WebLocalizedString::kMediaRemotingStopByPlaybackQualityText, - WebLocalizedString::kMediaRemotingStopNoText, - WebLocalizedString::kMediaRemotingStopText, This CL needs to change the argument type of MediaRemotingStopped() and Hide() functions according to the change. Lastly, this CL adds kMediaRemotingStopNoText constant to WebMediaClient because there was no matched IDS_FOO for WebLocalizedString::kMediaRemotingStopNoText. Bug: 995644 Change-Id: I6daed3fe10145290a21b5bc9d4797eb5ca5f9e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818007Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#700079}
-
John Z Wu authored
1. Use new sync and autofill APIs. 2. Introduce a sync menu. 3. Autofill data menu. 4. Consent/Unlock menu. Change-Id: I283b6087c09a2688ed7ea3fdf53d44fe72b63e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823724 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#700078}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c5bc9d6da851..d6eab9edafe8 git log c5bc9d6da851..d6eab9edafe8 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 489dde9b..1fa0f66d (699869:699974) Created with: gclient setdep -r src/third_party/webrtc@d6eab9edafe8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: If2f5077d9316b744e41c80ccb546eb867aab53e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826203Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f0faf48ddb89..9a5bb612e624 git log f0faf48ddb89..9a5bb612e624 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 ehmaldonado@chromium.org git-cl: Make Ctrl+C work again. Created with: gclient setdep -r src/third_party/depot_tools@9a5bb612e624 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:961724 Change-Id: I32dd482c3596ac91f9114a33d7841cce8d5058f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825664Reviewed-by:
-
John Z Wu authored
The intermediate "ChromeWebView" folder was never created, so writes to files in that folder just fails. Change-Id: I2d0880fd9ce600fab08f4e23ed116febdaf76b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825735 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ie75dcaff77f5ee2a7ade334b2e4f2498f38a45da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825383Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700074}
-
Jay Harris authored
In incognito and guest profiles, the BadgeManagerFactory does not create a BadgeManager. As there are no apps in incognito/guest profiles this would not normally be a problem. However, in BadgeManager::BindRequest, we were attempting to add the null BadgeManager to a mojo reciever set, causing a crash. Note: This does not affect the API exposed to the, so this cannot be used to detect incognito mode. Bug: 1004122 Change-Id: I5024665257a67aaaf28aa7f3bb8cd9cfcdef2d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824041Reviewed-by:
-
Darren Shen authored
These files are only compiled for chrome os, so no need for the checks. Bug: 1005619 Change-Id: I15cd1c3000223bf8aa1c2656389b3e32fbfaee71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811404 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#700072}
-
