GitLab

We still have one instance where ChildThreadImpl is used without
ChannelMojo (utility processes launched by a service process),
causing a nullptr dereference in ChannelProxy when trying to add
the associated interface.

This CL replaces a DCHECK with a branch to avoid the crash, since
silently ignoring the call is safe and reasonable.

In examining this bug I also realized that ChildThreadImpl was
incorrectly adding the RouteProvider interface after Channel
connection, which is only safe to do in the browser, where the
remote endpoint hasn't been launched yet. So this CL fixes that
too, and clarifies the documentation in ipc_channel_proxy.h.

BUG=647251
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2343783003
Cr-Commit-Position: refs/heads/master@{#419043}

We can remove this duplicate checked math implementation and use the one
in base (proxied by way of WTF) instead.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2339323003
Cr-Commit-Position: refs/heads/master@{#419042}

TBR=jbudorick@chromium.org, stip@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2347713002
Cr-Commit-Position: refs/heads/master@{#419041}

Currently, DirectoryBackingStore::VerifyReferenceIntegrity only verifies
that all parent ids are valid. This ignores the case of a single, corrupted
root node, which can happen during first sync. This CL adds a check that the
root node exists with the expected id("r").

R=pavely@chromium.org

BUG=642690

Review-Url: https://codereview.chromium.org/2342133002
Cr-Commit-Position: refs/heads/master@{#419040}

The original CL got reverted due to failing on a Lollipop bot. This
CL avoids Lollipops while investigations continue.

Original CL description ------------------------------------------------

This CL enables VideoCaptureDeviceTest.TakePhoto for
Android. (Note that, due to other circumstances, it'll
only be enabled for devices implementing the Camera2
API in non-legacy mode).

The only modification is that Android creates JPEGs
with APP1 JFIF header, because it includes EXIF information.

BUG=518807, 626857

TBR=emircan@chromium.org since the addec change is trivial.

Review-Url: https://codereview.chromium.org/2344683003
Cr-Commit-Position: refs/heads/master@{#419039}

This is a preliminary refactoring CL which is intended to consolidate related logic into one place, and prepare for the real change that I want to make: That is, apply git changes only once in _rebaseline after all changes are made, to fix http://crbug.com/639410.

I want to make two follow-up changes after this:
 (1) Change _rebaseline to apply git changes only once after all commands are run.
 (2) Refactor and simplify ChangeSet, _serial_commands, and _run_in_parallel.

BUG=639410

Review-Url: https://codereview.chromium.org/2347643002
Cr-Commit-Position: refs/heads/master@{#419038}

This is part of getting shutdown of displays working correctly.

BUG=none
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2347493003
Cr-Commit-Position: refs/heads/master@{#419037}

BUG=594244

Review-Url: https://codereview.chromium.org/2345013002
Cr-Commit-Position: refs/heads/master@{#419036}

Under very specific circumstances, LayoutBlockFlow::layoutBlock will
loop infinitely in this stanza:

    while (!done)
        done = layoutBlockFlow(...);

... due to fluctuations in the existence of overflow:auto scrollbars
in descendants.  Any layout type that does multi-pass layout is
especially susceptible to this, hence this bug affecting flexbox,
and another recent bug affecting tables: crbug.com/64635.

This fix supercedes the existing fix for the table bug, and it
should fix any other variations of this bug involving multi-pass
layout and overflow:auto.

BUG=644450
R=cbiesinger@chromium.org,eae@chromium.org

Review-Url: https://codereview.chromium.org/2345103002
Cr-Commit-Position: refs/heads/master@{#419035}

BUG=642059

Review-Url: https://codereview.chromium.org/2340743003
Cr-Commit-Position: refs/heads/master@{#419034}

Revert of Roll ANGLE 09cfac6..415f29e (patchset #1 id:1 of https://codereview.chromium.org/2347683002/ )

Reason for revert:
broke sizes with static initializer:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/25612/steps/sizes/logs/stdio
# Static initializers in /b/c/b/linux_clobber/src/out/Release/chrome:
# HINT: To get this list, run tools/linux/dump-static-initializers.py
# HINT: diff against the log from the last run to see what changed
# Compiler.cpp std::ios_base::Init::Init()@plt
# Compiler.cpp std::__ioinit [#includes <iostream>, use <ostream> instead]
# Compiler.cpp __cxa_atexit@plt [registers a dtor to run at exit]
# Compiler.cpp __dso_handle
# Compiler.cpp __init_array_end+0x2520

Original issue's description:
> Roll ANGLE 09cfac6..415f29e
>
> https://chromium.googlesource.com/angle/angle.git/+log/09cfac6..415f29e
>
> BUG=
>
> TBR=geofflang@chromium.org
>
> TEST=bots
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
>
> Committed: https://crrev.com/ac2a4e916123d43293eb9d47e31b469045ca068e
> Cr-Commit-Position: refs/heads/master@{#418995}

TBR=geofflang@chromium.org,cwallez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2341613005
Cr-Commit-Position: refs/heads/master@{#419033}

This matches the previous behavior with gyp (which was necessitated by
the need for a registration key). In the future we can expand this to
other platforms and to regular Chromium.

BUG=646660

Review-Url: https://codereview.chromium.org/2345783003
Cr-Commit-Position: refs/heads/master@{#419032}

https://pdfium.googlesource.com/pdfium.git/+log/0a17fafd723e..cde5101eb15b

$ git log 0a17fafd7..cde5101eb --date=short --no-merges --format='%ad %ae %s'
2016-09-15 art-snake Fix memory leaking on ClosePage. CFX_FontCache refactoring:   after this CL: Only one global CFX_FontCache used. Any cached items from it, are released, when its are not used.
2016-09-15 tsepez Add string pools to save storage.

BUG=79367,48791

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2345843002
Cr-Commit-Position: refs/heads/master@{#419031}

Regressed in recent refactoring of devtools discovery.
Added checks to existing tests.

BUG=627517

Review-Url: https://codereview.chromium.org/2332213010
Cr-Commit-Position: refs/heads/master@{#419030}

Push knowledge of FilterOperations out of GraphicsLayer and into
PaintLayer. This eliminates one dependency from platform/ code to the
FilterOperations structure. The motivation is to try and make
FilterOperation(s) a core (style) type, to make interaction with the
style system and other parts of core easier. It will also aid in
enabling a more layered structure on the various filter-related data
structures.

Also change the various generator functions to return a
CompositorFilterOperations by-value rather than through a out-variable.

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2335253002
Cr-Commit-Position: refs/heads/master@{#419029}

https://chromium.googlesource.com/skia.git/+log/7bffcd267301..262052c9261a

$ git log 7bffcd267..262052c92 --date=short --no-merges --format='%ad %ae %s'
2016-09-15 reed test/fix/tweak writePicture/readPicture

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2335343009
Cr-Commit-Position: refs/heads/master@{#419028}

BUG=chromedriver:1508
TBR=stgao@chromium.org

Review-Url: https://codereview.chromium.org/2349463002
Cr-Commit-Position: refs/heads/master@{#419027}

Grew tired of the post+wait pattern in many tests to flush a base::Thread.
Was going to need it again in https://codereview.chromium.org/2333023003/
and decided to add an API for everyone's sake instead :-).

Off the top of my head, will also be useful in
https://codereview.chromium.org/2299523003/

BUG=646443

Review-Url: https://codereview.chromium.org/2337253003
Cr-Commit-Position: refs/heads/master@{#419026}

Filter out StartupBrowserCreatorTest.ProfilesWithoutPagesNotLaunched.

https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigation%20Linux/builds/21323

BUG=504347
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2349503002
Cr-Commit-Position: refs/heads/master@{#419025}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/eb686c79229ef3cf3b39e6a0807f4c98e3e93cf9 Add BuildBucket manifest scheduling support. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:627996

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2348693002
Cr-Commit-Position: refs/heads/master@{#419024}

There are 3 types of tasks in ExecuteCodeFunction that require FILE thread:
a) Reading the file content (for non-component extension files)
b) Retrieving the file GURL of the script file from base::FilePath
c) content l10n (if the script is CSS)

This CL does all of these in on UI->FILE hop and doesn't require
additional FILE thread hop.
Previously, the most common case, i.e. chrome.tabs.executeScript()
with {file:...}, would require UI->FILE->UI->FILE->UI. With this CL
this become UI->FILE->UI.

This CL accomplishes this with adding an optional callback to FileReader,
to specify additional tasks to be run on FILE thread.

So the thread hop changes are:
Component extension's executeScript() with file:... url would stay same.
*All* other means of executing script file:... url, e.g.
chrome.tabs.executeScript(,{file:..}) would require two (UI->FILE->UI) less
thread hops, whee!

BUG=622464
Test=None, internal only change.

Review-Url: https://codereview.chromium.org/2301713002
Cr-Commit-Position: refs/heads/master@{#419023}

Splits build_applications.py into build_debug_applications.py
and build_release_applications.py

I simplified devtools BUILD.gn by symlinking/copying all
of the source code files & folders vs. previously
images, acorn, etc files were copied specifically.

Addresses refactoring suggestion from release mode CL comment:
https://crrev.com/2262743002/

BUG=none

Review-Url: https://codereview.chromium.org/2336943002
Cr-Commit-Position: refs/heads/master@{#419022}

BUG=chromedriver:1503

Review-Url: https://codereview.chromium.org/2344573004
Cr-Commit-Position: refs/heads/master@{#419021}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/48c952ad..e9b7e550

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2341193002
Cr-Commit-Position: refs/heads/master@{#419020}

Before this CL, it was possible for a web iframe with an unblessed
extension frame to exploit the renderer, create a blob: or filesystem:
URL in the extension frame context, then create a new top-level window
and navigate it to that URL, which could end up putting the new window
into a privileged extension process running attacker's code.

BUG=645028

Review-Url: https://codereview.chromium.org/2345473003
Cr-Commit-Position: refs/heads/master@{#419019}

Mark virtual/threaded/fast/scroll-behavior/smooth-scroll/main-thread-scrolling-reason-correctness.html as flaky on Linux debug.

BUG=647470
TBR=ymalik@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2344033002
Cr-Commit-Position: refs/heads/master@{#419018}

The crash is caused by not including the AIDL files from which the
WebApkServiceImpl is inherited in the webapk1.dex. In the build.gn, I move the
dependency of webapk_service_aidl from "deps" to "srcjar_deps", since the
.java files in the latter will be included in webapk1.dex.

BUG=645215

Review-Url: https://codereview.chromium.org/2340853002
Cr-Commit-Position: refs/heads/master@{#419017}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/d2845f7e87aa167cf7df78003b5768f948803d07 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/18ca30ca804679ee624a52e73017d234a8c0008f Teach bot_update to remove partially deleted git repos. (vadimsh@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=647046

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2346993002
Cr-Commit-Position: refs/heads/master@{#419016}

This CL deprecates setWallpaper call in intent_helper.mojom.

It also removes set_wallpaper_delegate.h since it's no
longer needed.

This is going to be committed only after ag/1432663/ enters
canary.

Test=Manually test setting wallpaper with OGQ Backgrounds
  app in Arc++.

Bug=642465

Review-Url: https://codereview.chromium.org/2332063004
Cr-Commit-Position: refs/heads/master@{#419015}

V4LocalDatabaseManager now tracks the same lists for updates as well as full hashes.
SafeBrowsingDatabaseManager tracks only API requests.

Also, since hash_tables.h is deprecated, moved all code from base::hash_set to std::unordered_set using sed:
$ sed -i 's/base::hash_set/std::unordered_set/g' *

BUG=543161, 576864

Review-Url: https://codereview.chromium.org/2345573002
Cr-Commit-Position: refs/heads/master@{#419014}

In this CL:
 - Move tokenize_line class method to TestExpectationLine, as suggested by FIXME.
 - Make tokenize_line non-protected, since it's used in another class, and
   would be useful in other modules, e.g. update_w3c_test_expectations.
 - Move class attributes that tokenize_line depends on.
 - Other changes suggested by linter (e.g. shorten long variable name).

This is a preliminary refactoring CL which is intended to make it easier to re-use tokenize_line in update_w3c_test_expectations.py, in order to make it easier to fix http://crbug.com/647395.

BUG=647395

Review-Url: https://codereview.chromium.org/2341173002
Cr-Commit-Position: refs/heads/master@{#419013}

Review-Url: https://codereview.chromium.org/2344813004
Cr-Commit-Position: refs/heads/master@{#419012}

Revert of Adding target to build SwiftShader (patchset #4 id:60001 of https://codereview.chromium.org/2330173002/ )

Reason for revert:
This seems to not build in our sysroot: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/5244/steps/compile/logs/stdio

Original issue's description:
> Adding target to build SwiftShader
>
> Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium.
>
> BUG=630728
>
> Committed: https://crrev.com/72ce608cb69854a0029f019e67ddf1509c274f0a
> Cr-Commit-Position: refs/heads/master@{#418934}

TBR=sugoi@google.com,sugoi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630728

Review-Url: https://codereview.chromium.org/2349473003
Cr-Commit-Position: refs/heads/master@{#419011}

As part of this I realized SetLockedToRoot and
SetDescendantsStayInSameRootWindow meant the same thing, so I nuked
the later.

In order to test this I need multiple display support, which isn't
quite working yet (in particular shutdown is currently
problematic).

BUG=615552
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2344783002
Cr-Commit-Position: refs/heads/master@{#419010}

TBR=bruening@chromium.org
BUG=647420

Review-Url: https://codereview.chromium.org/2348453003
Cr-Commit-Position: refs/heads/master@{#419009}

BUG=509735

Review-Url: https://codereview.chromium.org/2310683003
Cr-Commit-Position: refs/heads/master@{#419008}

These new tests measure performance of dispatching incoming messages on the same
thread.

Currently on Linux:
RouterDispatchCost  3.93483e+06 times/second
MultiplexRouterDispatchCost 3.39754e+06 times/second

BUG=594244

Review-Url: https://codereview.chromium.org/2340363002
Cr-Commit-Position: refs/heads/master@{#419007}

Some functions (the ones that do I/O) use this crazy three-level error
system (rv, SSL_get_error, and the error queue). Others are more
straightforward and simply use the error queue.

Using SSL_get_error here could result in state from other operations
getting in the way of things.

Since these don't actually do I/O and really can only fail on internal
error, just map to ERR_FAILED rather than try to have so many
MapOpenSSLError variants.

Also treat SSL_export_key_material's return value as a boolean. In
BoringSSL, the calling convention is simpler and documented as such.

BUG=none

Review-Url: https://codereview.chromium.org/2342123002
Cr-Commit-Position: refs/heads/master@{#419006}

This implements a new mus IPC protocol to allow inter-process drag and
drop in mus. It handles the entire lifecycle of a drag between two mus
Windows, possibly in different processes. This patch does not implement
changing the mouse cursor or showing a drag representation, which is
queued work.

This patch is mus side only; it does not implement the views sided of
this protocol, which is next. (With it, you can drag text from the
chrome omnibox to the quick launcher and vice versa. You can drag text
from the quick launcher to the content area. Etc.)

BUG=614037

Review-Url: https://codereview.chromium.org/2266603002
Cr-Commit-Position: refs/heads/master@{#419005}

Add logic to open options pages that open in tabs (embedded options
pages still to come). Add a test for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2329443004
Cr-Commit-Position: refs/heads/master@{#419004}