GitLab

Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct time.

"Extensions.ExtensionHostMonitoring.NumLoaded" UMA is now correctly recorded.

I also cleaned up ExtensionHost and its Start/Stop events a little to make it
more obvious, but in a way that my previous attempt at this (r320536) won't
cause crashes.

R=yoz@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1016473002

Cr-Commit-Position: refs/heads/master@{#320806}

This fixes some files not compiling with the proper flags for component mode.

The device_event_log target in GN is a source set in GN and a component in GYP. This difference was causing some errors. I changed this to be a static library in GYP. It only has 2 files in it so making a whole shared library for this target seems wasteful.

Review URL: https://codereview.chromium.org/1011823002

Cr-Commit-Position: refs/heads/master@{#320805}

BUG=466848

Review URL: https://codereview.chromium.org/1005683003

Cr-Commit-Position: refs/heads/master@{#320804}

browser plugins can detach before we attach again.

BUG=467614
Test=Load a <webview>
Set its style.display = 'block'.
Observer that it succeeds without <webview> going stale or
throwing any error about "attach" failing.

Review URL: https://codereview.chromium.org/1015443002

Cr-Commit-Position: refs/heads/master@{#320803}

Dependent libraries need to be passed in the reverse order that
build_utils.GetSortedTransitiveDependencies returns.

Also, a multi-library resource zip in package_libraries should be sorted
on the numeric values of the directories in the zip, not the string
values.

Review URL: https://codereview.chromium.org/1007043002

Cr-Commit-Position: refs/heads/master@{#320802}

Update the chrome://extensions page to use the developerPrivate api in order
to show the permissions prompt.
Also convert the function to a UIThreadExtensionFunction, and update it to
(if possible) use the new app info dialog.

BUG=461039

Review URL: https://codereview.chromium.org/1008973002

Cr-Commit-Position: refs/heads/master@{#320801}

In the old app-list, the key selection doesn't signal any events
to AppListItemView, so it can't update the background color at
that point.

BUG=467517
R=mgiuca@chromium.org

Review URL: https://codereview.chromium.org/1010853002

Cr-Commit-Position: refs/heads/master@{#320800}

Because ChromeTracingAgent class has global states, when any
exception was raised inside StopTracing method, the active tracing
state of this class is not set to False, making subsequent unittest that
try to StartTracing fails because of this.

Long term fix of this depends on crbug.com/317481 be fixed so that
ChromeTracingAgent no longer have global state.

BUG=459807

Review URL: https://codereview.chromium.org/997193002

Cr-Commit-Position: refs/heads/master@{#320799}

BUG=

Review URL: https://codereview.chromium.org/1018453002

Cr-Commit-Position: refs/heads/master@{#320798}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/dfdec78..d68a550

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1015523003

Cr-Commit-Position: refs/heads/master@{#320797}

//cc/base is intended to be a set of low level utilities used by the rest
of cc (and consumers of cc) and as such shouldn't contain dependencies
on other parts of //cc. This splits the //cc/base files into a separate
GN source_set so 'gn check' can examine dependencies and moves a few
types that have dependencies on other types out:

swap_promise is conceptually about swapping frames, so it goes into
cc/output

*swap_promise_monitor is dealing with swaps on trees, so it goes in
cc/trees

R=danakj@chromium.org

Review URL: https://codereview.chromium.org/1002073002

Cr-Commit-Position: refs/heads/master@{#320796}

Review URL: https://codereview.chromium.org/1004513002

Cr-Commit-Position: refs/heads/master@{#320795}

Revert of Move Extension ScriptContext creation into ScriptContextSet. (patchset #4 id:60001 of https://codereview.chromium.org/995283004/)

Reason for revert:
Memory failure in ScriptContextTest.GinRunnerLifetime.

Original issue's description:
> Move Extension ScriptContext creation into ScriptContextSet.
>
> Previously extensions::Dispatcher was responsible for creating ScriptContexts
> then Adding them to its ScriptContextSet. Now, ScriptContextSet creates them
> itself. This prepares the Extension system for later changing to lazily or
> asynchronously creating ScriptContexts.
>
> BUG=466373
> R=rockot@chromium.org
>
> Committed: https://crrev.com/75605c7fca774b95984ba67f70ba86bb5750c0f6
> Cr-Commit-Position: refs/heads/master@{#320602}
>
> Committed: https://crrev.com/52f4caf6d01302ebf42136b42fa77d1c67d93ae9
> Cr-Commit-Position: refs/heads/master@{#320770}

TBR=rockot@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466373

Review URL: https://codereview.chromium.org/1013823003

Cr-Commit-Position: refs/heads/master@{#320794}

BUG=none
TEST=more testing

Review URL: https://codereview.chromium.org/1008593004

Cr-Commit-Position: refs/heads/master@{#320793}

Some key systems aren't supported on all platforms, so don't try the
multiple playback tests in those cases.

BUG=467505
TEST=EncryptedMediaTests pass

Review URL: https://codereview.chromium.org/1016483002

Cr-Commit-Position: refs/heads/master@{#320792}

This is a temporary change to help track down the bug below, where we try to create a second RenderView with the same routing id in the same process.

BUG=464633

Review URL: https://codereview.chromium.org/1001153002

Cr-Commit-Position: refs/heads/master@{#320791}

1. Avoids overloading in a C linkage block (mostynb)
2. Only compiles ATK support if use_x11 is true
    to avoid ChromeCast issue (gunsch)
3. Updates chrome/installer/linux expectations

Original changelist: https://codereview.chromium.org/975113002/

BUG=463671
R=thestig@chromium.org
TBR=dpranke, plundblad, sky

Review URL: https://codereview.chromium.org/1005293002

Cr-Commit-Position: refs/heads/master@{#320790}

The regressing CLs have been reverted.

BUG=466690

Review URL: https://codereview.chromium.org/1014503005

Cr-Commit-Position: refs/heads/master@{#320789}

This makes it possible to refer to the platform as DRI and DRM. We need
this intermediate state so we can update the CrOS builds to use DRM
rather than DRI.

BUG=none
TEST=Build ozone with DRI & DRM platform and without to verify build
(GYP and GN)

Review URL: https://codereview.chromium.org/957253005

Cr-Commit-Position: refs/heads/master@{#320788}

BUG=

Review URL: https://codereview.chromium.org/1008543005

Cr-Commit-Position: refs/heads/master@{#320787}

BUG=

Review URL: https://codereview.chromium.org/1005413002

Cr-Commit-Position: refs/heads/master@{#320786}

Adds support for long idle times in the Blink Scheduler.
A long idle time is initiated
if there are no frames being drawn and we are not in TOUCHSTART policy. Each
long idle period will be a maximum of 50 milliseconds or the time to the next
pending delayed task (whichever is sooner). Long idle periods will continually
be scheduled until a call to EndIdlePeriod is made. If there are no pending
tasks in the idle queue then the callback used to initate the next long idle
task will be posted on the control_task_after_wakeup_runner_ task runner, thus
ensuring that it won't cause the scheduler to wake up until another task
could have posted more idle work.

Currently, the long idle tasks are not enabled due to crbug.com/467655 -
once this is fixed they will be enabled.

Long idle task design doc:
https://docs.google.com/a/chromium.org/document/d/1yBlUdYW8VTIfB-DqhvQqUeP0kf-Ap1W4cao2yQq58Do/edit

BUG=455713,467655

Review URL: https://codereview.chromium.org/968073003

Cr-Commit-Position: refs/heads/master@{#320785}

The minimum width calculations weren't always taking effect with the omnibox
and the browser actions container. Refactor it a bit to make it:
a) more reliable (min width checked at every resize)
b) clearer (less confusing back and forth with using observer methods)

BUG=463905

Review URL: https://codereview.chromium.org/1009613002

Cr-Commit-Position: refs/heads/master@{#320784}

Tweak update script:
https://codereview.chromium.org/993123002

Update libvpx:
https://codereview.chromium.org/1015483002

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/1012903002

Cr-Commit-Position: refs/heads/master@{#320783}

Passed chrome-ui-review: https://groups.google.com/a/google.com/d/msg/chrome-ui-review/FwuQ2TWc5n8/H3PSuV4L_cAJ

BUG=467165

TBR=tsepez
(comment changes only in render_messages)

NOPRESUBMIT=true
(legacy LOG messages)

Review URL: https://codereview.chromium.org/1007443004

Cr-Commit-Position: refs/heads/master@{#320782}

This class provides an interface, to be used on the IO thread, on top
of the NotificationDatabase class. It abstracts away the thread
requirements of the database class and is responsible for managing the
status and the lifetime of the database.

Right now it's only used in unit tests, but it will eventually live as
a member of StoragePartitionImpl, and will be used by the notification
message filter.

Design document:
  http://goo.gl/TciXVp

BUG=447628

Review URL: https://codereview.chromium.org/1006493005

Cr-Commit-Position: refs/heads/master@{#320781}

TBR=jam@chromium.org
BUG=417518, 448592, 458204, 458194
TEST=Site Isolation FYI bots stay green.

Review URL: https://codereview.chromium.org/1007223002

Cr-Commit-Position: refs/heads/master@{#320780}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/fdc3108..dfdec78

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1006293003

Cr-Commit-Position: refs/heads/master@{#320779}

TBR=mlamouri@chromium.org
BUG=467670

Review URL: https://codereview.chromium.org/1015493004

Cr-Commit-Position: refs/heads/master@{#320778}

It was never implemented or used; a replacement for the
principalsPrivate extension API. It's been untouched for over a year.

BUG=463335

Review URL: https://codereview.chromium.org/970043002

Cr-Commit-Position: refs/heads/master@{#320777}

This pulls the following changes:
r1434 6225882 Fix compatibility with Android NDK r10d.
r1433 ac07e58 Make breakpad compatible with Android NDK r10d.

Summary of changes available at:
https://chromium.googlesource.com/external/google-breakpad/src/+log/d1f8b74..2c37c22

BUG=breakpad:642

Review URL: https://codereview.chromium.org/1014583002

Cr-Commit-Position: refs/heads/master@{#320776}

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1007123002

Cr-Commit-Position: refs/heads/master@{#320775}

BUG=398967, 464147, 461882, 451081
TBR=jyasskin

Review URL: https://codereview.chromium.org/981723008

Cr-Commit-Position: refs/heads/master@{#320774}

Also avoid dereferencing it in OnMessageReceived after deletion.

BUG=461191
TEST=No more crashes in RenderFrameImpl::OnMessageReceived

Review URL: https://codereview.chromium.org/1007123003

Cr-Commit-Position: refs/heads/master@{#320773}

* Only call ToString() for types that require conversion to string. If the value is already of type string, we can just use that value.

* For chrome://webrtc-internals, we can now pass the correct type in most cases (not in64), in the dictionary passed to the web page.  This also lowers the overhead of the PeerConnectionTracker when no page requires this data.  (I think we can still do better there though).

BUG=webrtc:2822

Review URL: https://codereview.chromium.org/1009543003

Cr-Commit-Position: refs/heads/master@{#320772}

TBR=ncbray

Review URL: https://codereview.chromium.org/1016443002

Cr-Commit-Position: refs/heads/master@{#320771}

Previously extensions::Dispatcher was responsible for creating ScriptContexts
then Adding them to its ScriptContextSet. Now, ScriptContextSet creates them
itself. This prepares the Extension system for later changing to lazily or
asynchronously creating ScriptContexts.

BUG=466373
R=rockot@chromium.org

Committed: https://crrev.com/75605c7fca774b95984ba67f70ba86bb5750c0f6
Cr-Commit-Position: refs/heads/master@{#320602}

Review URL: https://codereview.chromium.org/995283004

Cr-Commit-Position: refs/heads/master@{#320770}

Originally this wasn't turned on as it didn't work on Windows.
This passes now.

R=dpranke@chromium.org
BUG=377980

Review URL: https://codereview.chromium.org/983913006

Cr-Commit-Position: refs/heads/master@{#320769}

Due to complex blur shader test still has timeout.
http://build.chromium.org/p/chromium.memory.fyi/waterfall?builder=Windows%20Unit%20(DrMemory%20full)%20(5)
I made test even simpler in terms of layer size and blur parameter.

R=enne

BUG=435632

Review URL: https://codereview.chromium.org/1009063002

Cr-Commit-Position: refs/heads/master@{#320768}

cc::RendererCapabilities was defined in cc/trees/layer_tree_host.h
which had a few subtle implications. First, cc/output/renderer.h needed
to #include layer_tree_host even though cc/output/ logically should not
depend on cc/trees/. Second, since layer_tree_host.h includes pretty
much the entire world, everything that was #including renderer.h was
implicitly pulling in many other headers that it may have used. In the
spirit of IWYU these files should either include or forward declare
types they use.

This puts RendererCapabilities in cc/output/renderer_capabilities and
fixes up includes in many other files.

R=danakj@chromium.org

Review URL: https://codereview.chromium.org/1007593002

Cr-Commit-Position: refs/heads/master@{#320767}