GitLab

Now when SetBounds is called, we detect the maximized state and take the window
out of this state.

BUG=69618
TEST=WidgetWinTest.SetBoundsForZoomedWindow (added)

Review URL: http://codereview.chromium.org/6268002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71499 0039d316-1c4b-4281-b951-d872f2087c98

<div>s) -- this makes the underlying page clickable where previously it may
not have been.

BUG=63695
TEST=see bug

Review URL: http://codereview.chromium.org/6114004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71498 0039d316-1c4b-4281-b951-d872f2087c98

Now these two classes are not templates, and just handle raw data.
New ProtobufMessageReader is used to parse messages.

BUG=None
TEST=Unittests.

Review URL: http://codereview.chromium.org/6277003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71497 0039d316-1c4b-4281-b951-d872f2087c98

Use WebFrame::createAssociatedURLLoader.

See https://bugs.webkit.org/show_bug.cgi?id=49764 for the
WebKit side of this change.

R=michaeln
BUG=none
TEST=none
Originally reviewed at: http://codereview.chromium.org/5139005

Review URL: http://codereview.chromium.org/5920003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71495 0039d316-1c4b-4281-b951-d872f2087c98

The fix is to keep track of the original URL.

BUG=69468
TEST=Manual test to verify.

Review URL: http://codereview.chromium.org/6131009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71494 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6281003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71493 0039d316-1c4b-4281-b951-d872f2087c98

R=ben

Review URL: http://codereview.chromium.org/6327005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71492 0039d316-1c4b-4281-b951-d872f2087c98

This avoids problems where multiple invocations of grit try to write to
the same intermediate file.

BUG=69633
TEST=Manually

Review URL: http://codereview.chromium.org/6245002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71491 0039d316-1c4b-4281-b951-d872f2087c98

1. testInstantDisabledInIncognito - instant should be disabled in incognito mode
2. testInstantOverlayNotStoredInHistory - instant overlay page not stored in history
3. testInstantDisabledForJavaScript - instant disabled for javascript urls

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6325003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71490 0039d316-1c4b-4281-b951-d872f2087c98

Move HiResTimerManager to src/chrome/common.

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/6361002

TBR=ben@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71489 0039d316-1c4b-4281-b951-d872f2087c98

1. testSharingProcess
2. testKillSharedProcess

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5322012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71488 0039d316-1c4b-4281-b951-d872f2087c98

Move HiResTimerManager to src/chrome/common.

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/6361002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71487 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581
TEST=no visible changes; all tests pass

Review URL: http://codereview.chromium.org/6322001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71485 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6320004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71484 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=senorblanco

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/6290005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71483 0039d316-1c4b-4281-b951-d872f2087c98

On Linux, also set the timeouts.

BUG=27400
TEST=Start wireshark and capture packets.  Start chrome.  Open www.facebook.com.  Let it sit idle for awhile.  Wait for TCP keep alive packets to be sent out after 45 seconds on Linux.

Review URL: http://codereview.chromium.org/6162005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71482 0039d316-1c4b-4281-b951-d872f2087c98

GetAdditionalErrorState() was being called, which stores the error state into the ClientSocketHandle.  When we preconnect, we never have a ClientSocketHandle, so don't bother tryiing to store the error state nor get the error socket.

BUG=69214
TEST=net_unittests

Review URL: http://codereview.chromium.org/6293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71481 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=senorblanco

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71480 0039d316-1c4b-4281-b951-d872f2087c98

Revert 71470 - Revert 71313 - Removed old login screen from source.
Deleted kEnableLoginImages flag.

BUG=chromium-os:7214
TEST=Old login screen should not show up even under automation tests for login.

Review URL: http://codereview.chromium.org/5809001

TBR=avayvod@chromium.org,tbroch@chromium.org

TBR=avayvod@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71478 0039d316-1c4b-4281-b951-d872f2087c98

a dumb error caused by having a local variable with the same name as that of the parameter
to a function.

BUG=none
TEST=ChromeFrame InstallFlowTest.
TBR=amit

Review URL: http://codereview.chromium.org/6303005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69294
TEST=sequetially open two incognito windows and visit pages using indexed db.

Review URL: http://codereview.chromium.org/6275001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71476 0039d316-1c4b-4281-b951-d872f2087c98

- Use Cairo double-buffering (prevents flickering when there is translucency).
- Add an API to allow JS to indicate the stacking order of layers. (Previously it was the arbitrary order of their creation!)
- Delete layer objects that have been discarded by the JS via Pack::RemoveObject().

TEST=loaded O2D and verified no significant change in perf as a result of double-buffering (~70% of a core before and ~72% of a core after)
BUG=none

Review URL: http://codereview.chromium.org/6320002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71475 0039d316-1c4b-4281-b951-d872f2087c98

Debug Chromium builds display an error if they don't find EGL, even if GLX is available. This prompts people to install the EGL packages, even though that probably isn't their issue.

Also, it looks like EGL, even if available, has some issues.

If GLX isn't available, it still falls back to EGL.

--use-gl=desktop should not be required to force use of GLX on boxes that also have EGL installed.

Changed LOG(ERROR) to VLOG(1) if a shared library fails to load since this is not necessarily an error. Report an error only if no GL implementation can be initialized. Log which GL implementation was selected.

TEST=launch chrome with various combinations of --use-gl switch and check the log output is correct.
BUG=none

Review URL: http://codereview.chromium.org/6342001

TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/6314005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71474 0039d316-1c4b-4281-b951-d872f2087c98

Refactor out of install.cc the set of functions that operate on a work item list for better testability.

Write preliminary test framework for testing these functions.

BUG=61609
TEST=setup_unittests.exe


Review URL: http://codereview.chromium.org/6153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71473 0039d316-1c4b-4281-b951-d872f2087c98

Debug Chromium builds display an error if they don't find EGL, even if GLX is available. This prompts people to install the EGL packages, even though that probably isn't their issue.

Also, it looks like EGL, even if available, has some issues.

If GLX isn't available, it still falls back to EGL.

--use-gl=desktop should not be required to force use of GLX on boxes that also have EGL installed.

Changed LOG(ERROR) to VLOG(1) if a shared library fails to load since this is not necessarily an error. Report an error only if no GL implementation can be initialized. Log which GL implementation was selected.

TEST=launch chrome with various combinations of --use-gl switch and check the log output is correct.
BUG=none

Review URL: http://codereview.chromium.org/6342001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71472 0039d316-1c4b-4281-b951-d872f2087c98

It isn't possible to have two UI threads with glib because it is not thread safe.

TEST=try
BUG=69674

Review URL: http://codereview.chromium.org/6296006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71471 0039d316-1c4b-4281-b951-d872f2087c98

Deleted kEnableLoginImages flag.

BUG=chromium-os:7214
TEST=Old login screen should not show up even under automation tests for login.

Review URL: http://codereview.chromium.org/5809001

TBR=avayvod@chromium.org,tbroch@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71470 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6287002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71469 0039d316-1c4b-4281-b951-d872f2087c98

Split functionality of check for login failures to NetworkLoginObserver from NetworkMessageObserver.
BUG=chromium-os:8251
TEST=manually make sure the login error dialog pops up when you enter bad password.
Review URL: http://codereview.chromium.org/6027012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71468 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=right click on the new textfield should show the context menu and all commands on the menu should work.

Review URL: http://codereview.chromium.org/6155011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71467 0039d316-1c4b-4281-b951-d872f2087c98

Unregister previous ChromeFrame UA strings registered under the PostPlatform key while registering a new ChromeFrame UA string.
This ensures that we don't end up with a number of duplicated chrome frame UA strings each pointing to a different version.

This should hopefully fix the InstallFlowTest.

BUG=none
TEST=Covered by existing ChromeFrame InstallFlowTest

Review URL: http://codereview.chromium.org/6355001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71466 0039d316-1c4b-4281-b951-d872f2087c98

The test failed before was fixed.
TBR=hayato
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6258005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71465 0039d316-1c4b-4281-b951-d872f2087c98

Also moves more common code into InlineEditableItem, and fixes some styling issues with inline-editable lists.

BUG=63817
TEST=Startup pages should be editable in DOMUI prefs. Also, the lead selection in an editable list should show top and bottom borders.

Review URL: http://codereview.chromium.org/6303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71464 0039d316-1c4b-4281-b951-d872f2087c98

(Previously committed r71334, reverted r71400. Added null check pointed out by
jam.)

Add some tests (for aborting calls).

BUG=none
TEST=ppapi_tests

Review URL: http://codereview.chromium.org/6280005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71463 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/6151010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71462 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68267
TEST=no visible changes; all tests pass

Review URL: http://codereview.chromium.org/6192007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71461 0039d316-1c4b-4281-b951-d872f2087c98

This change ensures that the appropriate command line flag (SetCrashReporterCommandLine())
is set for the NaCl process and read by the NaCl main process when it starts.

TEST=
0. Ensure that Native Client is DEPS'ed in at revision 4097 or higher
1. From src/ issue
    ./build/gyp_chromim -f make -dlinux_breakpad=1
2. Build Chromium (debug build)
3. With env. variable CHROME_HEADLESS=1 and NACL_CRASH_TEST=1 run
    out/Debug/chrome --enable-nacl --enable-crash-reporter
4. Visit a page that attempts to load a NaCl module, e.g.,
    http://naclports.googlecode.com/svn/trunk/src/gallery/index.html
5. Observe that a .dmp file is created in ~/.config/chromium/Crash\ Reports/

BUG= http://code.google.com/p/nativeclient/issues/detail?id=206

Review URL: http://codereview.chromium.org/6193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71459 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65189
TEST=TaskManagerBrowserTest.KillBGContents

Review URL: http://codereview.chromium.org/6226002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71458 0039d316-1c4b-4281-b951-d872f2087c98

Return NULL when  GetProfileSyncService() is called without a cros_user
argument (if not already initialized) and protect the settings code when
sync service is NULL.
A side effect of this is that sync will be disabled if chrome is not started
from the login screen in ChromeOS (e.g. when debugging), instead of being
initialized without a valid backend, so e.g. settings will not have a sync
section, and about:sync will show 'sync disabled'.

BUG=chromium-os:10777,chromium-os:10893
TEST=Test proxy settings from login screen, sync settings page, and about:sync.

Review URL: http://codereview.chromium.org/6260002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71457 0039d316-1c4b-4281-b951-d872f2087c98

The sync tests were using verbose logging in the past in order to help
debug flaky and failing tests. Now that the tests are mostly green, the
verbosity can be dialed down. This patch reduces the verbosity of sync
test logging.

In addition, a couple of bookmark tests occasionally fail due to a
mismatch, and the logs don't make it clear where the test fails. This
patch adds more detailed logging during bookmark comparison.

TBR=tim@chromium.org
BUG=none
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/6351001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71456 0039d316-1c4b-4281-b951-d872f2087c98