- 03 Dec, 2011 40 commits
-
-
rogerta@chromium.org authored
organic brand code. Also added unit tests for reactivation since none existed. BUG=b/5683002 TEST=See unit tests. Pings should only be sent out for non-organic brand codes, and not for organic brand codes. Should test will all four combinations (main is either organic or not, and reactivation is either organic or not). This only works with google chrome builds. Chromium builds never send pings regardless of brand codes. Review URL: http://codereview.chromium.org/8726041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112868 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112867 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
TBR=aa Review URL: http://codereview.chromium.org/8788007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112866 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/8736001/georgey@chromium.org authored
The difference is the phone library pulled is version 407 instead of 403, it includes fixes, including missing licenses. Original description: Pull the phone library directly. Delete old version. TEST=unit-tests BUG=105577 Review URL: http://codereview.chromium.org/8790002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112865 0039d316-1c4b-4281-b951-d872f2087c98
-
qghc36@motorola.com authored
Profiles: Fixed crash when avatar bubble is launched using ctrl+shift+m key press when there is only one default profile. Incorporated necessary condition check before launching avatar bubble. BUG=105700 TEST=None Review URL: http://codereview.chromium.org/8664028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112864 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
BUG=none TEST=none R=csilv Review URL: http://codereview.chromium.org/8771030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112863 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
BUG=chromium-os:23472 TEST=NONE Review URL: http://codereview.chromium.org/8770040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112862 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
BUG=23658 TEST=See issue Review URL: http://codereview.chromium.org/8771019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112861 0039d316-1c4b-4281-b951-d872f2087c98
-
enal@chromium.org authored
Minor Windows-only code cleanup. That also fixes broken sound on Windows Server 2003. BUG=none Review URL: http://codereview.chromium.org/8777003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112860 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Adds XInput redist DLL which is a new dependency of recently added gamepad code, and is required on Win XP. laforge has OK'd the size addition to the final package (~100K). BUG=79050 Review URL: http://codereview.chromium.org/8774023 TBR=scottmg@google.com Review URL: http://codereview.chromium.org/8788009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112859 0039d316-1c4b-4281-b951-d872f2087c98
-
jwd@chromium.org authored
BUG=87658 TEST=Have two machines with chrome, both with multiple profiles and each with one profile signed in to the same account. Change avatar/name on one, and it will change on the other. Review URL: http://codereview.chromium.org/8771024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112856 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
Add abstract GetGroupsToChange() method to ModelChangingSyncerCommand. Use that to figure out which worker threads to post work on (instead of posting on all of them). Implement GetGroupsToChange() for each ModelChangingSyncerCommand. Add GetEnabledGroups() and GetEnabledGroupsWithConflicts() functions to SyncSession. Key unapplied updates index by type for ApplyUpdatesCommand. Make the abstract methods of ModelChangingSyncerCommand protected. This patch includes a speculative fix for the perf regression introduced by the last time this was landed (112178). BUG=97832 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112178 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112743 Review URL: http://codereview.chromium.org/8637006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/8785015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112855 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112853 0039d316-1c4b-4281-b951-d872f2087c98
-
arthurhsu@chromium.org authored
BUG=90898 TEST=none Review URL: http://codereview.chromium.org/8744002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112852 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
exist. This is a regression from http://codereview.chromium.org/8759017 BUG=106238 TEST=none R=akalin@chromium.org,yfriedman@chromium.org Review URL: http://codereview.chromium.org/8790008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112851 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
TBR=sky@chromium.org BUG=106248 TEST=browser_tests on aura should cycle green Review URL: http://codereview.chromium.org/8772066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112850 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/8771046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112849 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
The preference is controlled by the command line and enterprise policy. R=mattm@chromium.org,mnissler@chromium.org BUG=106077 TEST=Existing policy unit tests are updated. Review URL: http://codereview.chromium.org/8772014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112848 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
BUG=79520 TEST= Review URL: http://codereview.chromium.org/8669014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112847 0039d316-1c4b-4281-b951-d872f2087c98
-
kushi.p@gmail.com authored
- both BookmarkBubble and BookmarkEditor now use single-line input for their names - update nib to use IBOutlet to call the NSCell off of the NSTextField BUG=100618 Review URL: http://codereview.chromium.org/8775042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112846 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
Change-Id: Ie6ee3ec84c126f46cdc34aea17bafa43cd49245c BUG=chromium-os:23709 TEST=Chrome starts + VMTests pass Review URL: http://codereview.chromium.org/8785011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112845 0039d316-1c4b-4281-b951-d872f2087c98
-
frankf@google.com authored
BUG=chromium:104530 TEST=PyAuto tests Review URL: http://codereview.chromium.org/8772068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112844 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=104360 TEST=covered by tests Review URL: http://codereview.chromium.org/8772047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112843 0039d316-1c4b-4281-b951-d872f2087c98
-
jennb@chromium.org authored
BUG=105445 TEST=PanelBrowserTest.AutoResize Review URL: http://codereview.chromium.org/8785009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112842 0039d316-1c4b-4281-b951-d872f2087c98
-
battre@chromium.org authored
We need to clear WebKit's in-memory cache after adding an event handler to be sure that when reloading a site the new event handler is active. BUG=none TEST=no Review URL: http://codereview.chromium.org/8772058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112841 0039d316-1c4b-4281-b951-d872f2087c98
-
munjal@chromium.org authored
- Call PSS::ShowLoginDialog directly from app notification code so that the dialog comes up even if the user is logged in. - Small fix to PSS to avoid infinite spinner in cases where the sync backend does not really change anything (ahd hence does not call back PSS). Review URL: http://codereview.chromium.org/8783001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112840 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
GdkGC is deprecated and will be removed in gtk3 and cairo should be faster anyway. This uses the new CairoCachedSurface in gfx::Image. BUG=79722 TEST=none Review URL: http://codereview.chromium.org/8781001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112839 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=106259 Review URL: http://codereview.chromium.org/8786011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112838 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
BUG=105220 Review URL: http://codereview.chromium.org/8727014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112837 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
* Moved parts->PostMainMessageLoopRun call from PostDestroyThreads to the right place (PostMainMessageLoopRun() method) * Renamed Shell::DeleteInstanceForTesting to DeleteInstance as this is no longer for testing. BUG=106070 TEST=browser_tests on aura will not crash as described in the bug Review URL: http://codereview.chromium.org/8774029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112836 0039d316-1c4b-4281-b951-d872f2087c98
-
yoz@chromium.org authored
Avoid a race condition in reordering of notification bubbles when canceling them. BUG=89078 TEST=none Review URL: http://codereview.chromium.org/8774027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112835 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
Shaving parallel authenticator yak to remove unnecessary dependency on this class from OAuth specific code. Moved system salt and supplemental key related methods to cryptohome and cert libraries instead. BUG=chromium-os:23301 TEST=none Review URL: http://codereview.chromium.org/8761016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112834 0039d316-1c4b-4281-b951-d872f2087c98
-
jianli@chromium.org authored
BUG=none TEST=overflow test Review URL: http://codereview.chromium.org/8776035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112833 0039d316-1c4b-4281-b951-d872f2087c98
-
mball@chromium.org authored
Tested by comparing output of ./scons -n extra_sdk_update_header both before and after. BUG=None TEST=None Review URL: http://codereview.chromium.org/8785002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112832 0039d316-1c4b-4281-b951-d872f2087c98
-
lambroslambrou@chromium.org authored
BUG=None TEST=Manual Review URL: http://codereview.chromium.org/8733014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112831 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
I recently landed a patch that defers the SelectFileDialog::Listener callback until the file picker window is closed. The test needed to be updated to simulate closing the window so that the Listener would delete itself. BUG=none TEST=unit_tests, memory waterfall Review URL: http://codereview.chromium.org/8787007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112830 0039d316-1c4b-4281-b951-d872f2087c98
-
dbeam@chromium.org authored
R=estade@chromium.org BUG=103443 TEST=Try to print tiles in a build with the PDF plugin / print preview on. Review URL: http://codereview.chromium.org/8772053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112829 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
Fixes a race on startup. See issue for details. BUG=chromium-os:20865 TEST=Ensure logging, including VLOG, works. TBR=willchen@chromium.org Review URL: http://codereview.chromium.org/8757002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112828 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
TBR=darin Review URL: http://codereview.chromium.org/8789006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112827 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
TBR=darin Review URL: http://codereview.chromium.org/8784004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112826 0039d316-1c4b-4281-b951-d872f2087c98
-