- 06 Mar, 2014 40 commits
-
-
shans@chromium.org authored
This patch introduces the Interpolation class, which represents a primitive animation between two values (expressed as InterpolableValues). This is part of an effort to refactor the animations pipeline in order to make it generic on animation value type (see linked master bug). This code is not yet used anywhere. It will be used in future patches. BUG=346495 Review URL: https://codereview.chromium.org/182383011 git-svn-id: svn://svn.chromium.org/blink/trunk@168629 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
timloh@chromium.org authored
Accessing currentTime on a Player logically doesn't mark it as outdated, although currently it does as it updates time to match the timeline. Removing this behaviour makes some of the logic in serviceAnimations and Player::update slightly nicer. We also tweak the logic somewhat so as to remove a source of rounding errors in timing calculations. BUG=334926 Review URL: https://codereview.chromium.org/172003002 git-svn-id: svn://svn.chromium.org/blink/trunk@168628 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tasak@google.com authored
This is not the same as a patch for just reverting r164153. To make a patch smaller, - Element IDL does not have webkitPseudo (not reverted). - pseudo() invokes shadowPseudoId() (the old code uses pseudo() in shadowPseudoId()). - setPseudo() also invokes setShadowPseudoId(). c.f. https://src.chromium.org/viewvc/blink?revision=164153&view=revision BUG=349144 TEST=fast/dom/shadow/pseudo-attribute-rendering.html,fast/dom/shadow/styling-pseudo-attribute.html,fast/dom/shadow/shadow-pseudo-id.html,fast/dom/shadow/pseudo-attribute.html,fast/dom/shadow/styling-pseudo-attribute-in-shadow.html,fast/dom/shadow/shadow-nested-pseudo-id.html,fast/dom/shadow/custom-pseudo-in-selector-api.html,fast/dom/shadow/pseudo-attribute-dynamic.html Review URL: https://codereview.chromium.org/187573002 git-svn-id: svn://svn.chromium.org/blink/trunk@168627 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
Revert of DevTools: Do not save split view size on show mode changes. (https://codereview.chromium.org/185943004/) Reason for revert: Split location is no longer persisted. Original issue's description: > DevTools: Do not save split view size on show mode changes. > > BUG=348887 > R=dgozman > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168608 TBR=dgozman@chromium.org,vsevik@chromium.org NOTREECHECKS=true NOTRY=true BUG=348887 Review URL: https://codereview.chromium.org/185063005 git-svn-id: svn://svn.chromium.org/blink/trunk@168626 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sanjoy.pal@samsung.com authored
BUG=128500 Review URL: https://codereview.chromium.org/70163005 git-svn-id: svn://svn.chromium.org/blink/trunk@168625 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
R=loislo@chromium.org Review URL: https://codereview.chromium.org/188293003 git-svn-id: svn://svn.chromium.org/blink/trunk@168624 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vsevik@chromium.org authored
R=dgozman@chromium.org, dgozman, pfeldman Review URL: https://codereview.chromium.org/187833006 git-svn-id: svn://svn.chromium.org/blink/trunk@168623 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vsevik@chromium.org authored
BUG=247466 R=apavlov@chromium.org TBR=apavlov Review URL: https://codereview.chromium.org/188443004 git-svn-id: svn://svn.chromium.org/blink/trunk@168622 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eustas@chromium.org authored
BUG= NOTRY=true Review URL: https://codereview.chromium.org/188473003 git-svn-id: svn://svn.chromium.org/blink/trunk@168621 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
http://src.chromium.org/viewvc/blink?view=revision&revision=168592 BUG=348682 TBR=dominik.rottsches@intel.com Review URL: https://codereview.chromium.org/188513005 git-svn-id: svn://svn.chromium.org/blink/trunk@168620 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mkwst@chromium.org authored
BUG=346642 Review URL: https://codereview.chromium.org/180523003 git-svn-id: svn://svn.chromium.org/blink/trunk@168619 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
fs@opera.com authored
Passing m_textPosition as an argument to the various helper methods allows it to be removed from SVGTextMetricsBuilder and stored on the stack of measureTextRenderer. Review URL: https://codereview.chromium.org/182733010 git-svn-id: svn://svn.chromium.org/blink/trunk@168618 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ager@chromium.org authored
R=haraken@chromium.org, oilpan-reviews@chromium.org BUG= Review URL: https://codereview.chromium.org/183923038 git-svn-id: svn://svn.chromium.org/blink/trunk@168617 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
BUG=None Review URL: https://codereview.chromium.org/180533004 git-svn-id: svn://svn.chromium.org/blink/trunk@168616 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
- SVGElement::animatedPropertyTypeForAttribute() was deprecated. |SVGElement::animatedPropertyTypeForCSSAttribute()| is provided to retrieve CSS types. - |SVGAnimateElement::determineAnimatedPropertyType()| is moved to SVGAnimationElement, and its argument is omitted. -- Its argument was always targetElement() -- This removes the need for cast in |SVGAnimationElement::currentValuesForValuesAnimation()| BUG=349370 Review URL: https://codereview.chromium.org/180113007 git-svn-id: svn://svn.chromium.org/blink/trunk@168615 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ager@chromium.org authored
TBR=haraken@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/180533008 git-svn-id: svn://svn.chromium.org/blink/trunk@168614 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
These C macros are for the old SVGAnimatedProperty implementation. We introduced new animated property implementation in crbug.com/308818 , so they are no longer used. BUG=349370 NOTRY=true Review URL: https://codereview.chromium.org/177703004 git-svn-id: svn://svn.chromium.org/blink/trunk@168613 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
This CL moves frameDetached() call outside of ~SVGImage. Oilpan disallows any heap-allocated object creation inside destructors. SVGImageChromeClient and Page to be deleted are queued to DelayedSVGImageDestructor singleton, and oneshot timer is invoked to call |frameDetached| outside of destructor scope. TESTS=svg/ (w/ enable_oilpan=1) BUG=None NOTRY=true Review URL: https://codereview.chromium.org/185613003 git-svn-id: svn://svn.chromium.org/blink/trunk@168612 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
nbarth@chromium.org authored
PLY yacc parse table creation is (obviously) expensive. Pre-caching this in a separate build step substantially improves build time. Improves build time (user time) by 45% on my Linux box: 1m 50s => 59s BUG=341748 R=haraken Review URL: https://codereview.chromium.org/184233005 git-svn-id: svn://svn.chromium.org/blink/trunk@168611 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
nbarth@chromium.org authored
This is the compute_interfaces_info.py side of the post-split cleanup. This finishes the build factoring. (Still need to add more caching for speed and some more use of Jinja for clarity, but mostly done with build.) Two notable changes: * We only need to store *inherited* extended attributes, not all extended attributes (in auxiliary variable; needed more for event interfaces, gone now). This simplifies the inheritance resolution, and reduces duplication. * Always include the same keys in the info dict, even if the value is empty. This simplifies both setting (since no test) and use: instead of having "if key in dict and dict[key]..." we can just have "if dict[key]". It also helps consistency, since we were doing it 2 ways before. BUG=341748 R=haraken Review URL: https://codereview.chromium.org/183853024 git-svn-id: svn://svn.chromium.org/blink/trunk@168610 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vsevik@chromium.org authored
The failure happened because live-edit-no-reveal.html live edited the same script and this somehow interfered with live-edit.html execution. BUG=282082 TBR=pfeldman Review URL: https://codereview.chromium.org/185683008 git-svn-id: svn://svn.chromium.org/blink/trunk@168609 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vsevik@chromium.org authored
BUG=348887 R=dgozman Review URL: https://codereview.chromium.org/185943004 git-svn-id: svn://svn.chromium.org/blink/trunk@168608 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
In order to do so, make the IDL compiler able to emit code that uses heap vectors if the types involved are of the garbage collected kind. (For the most part done by adopting the changes from https://codereview.chromium.org/173363002 ) R= BUG=340522 Review URL: https://codereview.chromium.org/185413023 git-svn-id: svn://svn.chromium.org/blink/trunk@168607 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yoav@yoav.ws authored
According to the specification, certain media queries accept a CSS length as their value (e.g. http://www.w3.org/TR/css3-mediaqueries/#width). A CSS length (http://www.w3.org/TR/css3-values/#lengths) must have a known unit, unless the value is zero. This was not properly represented in the MediaQueryExp code, where any number was accepted. So such media queries (e.g. "(max-width: 1)") were considered valid, but evaluated to false. This CL fixes that, making such MQs invalid. BUG= Review URL: https://codereview.chromium.org/186603002 git-svn-id: svn://svn.chromium.org/blink/trunk@168606 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@chromium.org authored
This reduces the amount of time spent in compositing update for Silk's toggle_drawer test case by 20%. Previously, we would update the geometry for every composited layer mapping during every compositing update, regardless of whether any of the inputs to updateGraphicsLayerGeometry had changed. This CL introduces dirty bits on CompositedLayerMapping to track which RenderLayers underwent a change that could have resulted in changes during updateGraphicsLayerGeometry. This CL takes a basic approach, which is sufficient for toggle_drawer. Specifically, if a RenderLayer changes style, we mark its CompositedLayerMapping (and any ancestors and decendants) as needing a geometry update. If we go through layout or scroll, we trigger a forced update, which updates the geometry of all graphics layers. Over time, we can improve this system to track dirtiness during layout. We might also be able to avoid marking every ancestor dirty if we removed the downward tree walks during updateGraphicsLayerGeometry. Instead, we could compute the descendant-dependant information in an earlier phase and detect whether it changed directly. R=esprehn@chromium.org, ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168554 Review URL: https://codereview.chromium.org/183763016 git-svn-id: svn://svn.chromium.org/blink/trunk@168604 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
The purpose of the funciton was to describe support differences between desktop platforms and Android. Android Chrome now supports same input types for <datalist>. We don't need the function any longer. Note for BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree: |shouldAddPickerIndicator| is always true. We can remove it. BUG=none TEST=none; no behaivor changes. Review URL: https://codereview.chromium.org/181013012 git-svn-id: svn://svn.chromium.org/blink/trunk@168603 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
The file is not being referenced from anywhere. Its functionality was moved to SVGAnimatedEnumeration.h BUG=349370 TBR=haraken,pdr,fs Review URL: https://codereview.chromium.org/188413002 git-svn-id: svn://svn.chromium.org/blink/trunk@168602 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@chromium.org authored
RenderLayerScrollableArea::updateScrollCornerStyle shouldn't do work if we're using overlay scrollbars This function showed up on a profile of updateStyle in Silk's toggle_drawer test case, but there no reason to update the scroll corner style if we're using overlay scrollbars. If the author has created a custom scrollbar, we'll realize that we don't have overlay scrollbars. R=esprehn@chromium.org BUG=335703 Review URL: https://codereview.chromium.org/178903004 git-svn-id: svn://svn.chromium.org/blink/trunk@168601 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
nbarth@chromium.org authored
Follow-up to the split CL. Just clean-up, no changes to generated EventInterfaces.in. * Rename to generate_event_interfaces (from "*_names") This is b/c: - the output file is called EventInterfaces.in - the output file is used for both EventFactory and EventNames * Remove EventInterfaces.in from run-bindings-tests This file is useless, and adds unnecessary complexity to r-b-t. The actual output file is trivial: namespace="Event" Source/bindings/tests/idls/TestInterfaceEventConstructor ...and I've never looked at it during CG changes. With it, we need to have 2 passes of compute_interfaces_info, and a separate temporary file. Without it, once Terry's CL lands, we'll have no individual files, and we can just use one temporary directory, removing lots of temp file complexity. * Compute source_dir robustly (not using getcwd) * Refactoring and renaming Follow-up to: Split generate_event_interfaces.py from compute_interfaces_info.py https://codereview.chromium.org/185303008/ BUG=341748 R=haraken Review URL: https://codereview.chromium.org/186433003 git-svn-id: svn://svn.chromium.org/blink/trunk@168599 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@chromium.org authored
This CL changes GraphicsLayer::removeAllChildren to be linear in the number of children instead of n^2. Previously, we were removing the zero-th element of the vector in a loop, which causes a shift of all the elements of the vector. Now we walk the vector from the end, which means remove is constant cost. This code is called during a compositing update if anything changes about the GraphicsLayer's children. We didn't actually see this code on our profile because we're not actually changing the GraphicsLayer tree, but it seemed worth fixing. R=ojan@chromium.org Review URL: https://codereview.chromium.org/187603011 git-svn-id: svn://svn.chromium.org/blink/trunk@168598 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
timloh@chromium.org authored
This patch makes Animations get serviced in the order specified by the spec[1]. This means that once custom effect are implemented, they will be queued up in the correct order. This also gets us closer to having the animation stack in a correct order (I'm thinking of emptying the stack after getting out the compositable values, as we traverse the animations in the correct order). [1] http://dev.w3.org/fxtf/web-animations/#the-animation-stack BUG=334936 Review URL: https://codereview.chromium.org/185593010 git-svn-id: svn://svn.chromium.org/blink/trunk@168597 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@chromium.org authored
This function turned up in one of our profiles. I'm not sure this change makes much of a difference, but we might as well not have silly code on the profile. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/187793005 git-svn-id: svn://svn.chromium.org/blink/trunk@168596 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rob.buis@samsung.com authored
Add tests for sticky and various display values, tests should show up all green. BUG=231754 Review URL: https://codereview.chromium.org/178453002 git-svn-id: svn://svn.chromium.org/blink/trunk@168595 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rob.buis@samsung.com authored
This code is not in use anymore, mostly because of bindings changes. Review URL: https://codereview.chromium.org/183973036 git-svn-id: svn://svn.chromium.org/blink/trunk@168594 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mikhail.pozdnyakov@intel.com authored
The recently added 'HashTraits::PeekInType' type allows us to remove HashMap<RefPtr..> template specialization without loosing the efficiency and without bringing any significant changes and complexity to the HashMap class. To get rid of 'RefPtrHashMap' a new 'RefPtrValuePeeker' type was created and used as 'HashTraits::PeekInType' for RefPtr. The 'RefPtrValuePeeker' class can be constructed either from RefPtr, PassRefPtr or a plain pointer, then it behaves like a plain pointer itself within HashTable methods. The proposed change brings the following benefits: 1) Removes tons of duplicated code 2) Allows avoiding ref-count churn also at HashSet<RefPtr> Review URL: https://codereview.chromium.org/184233006 git-svn-id: svn://svn.chromium.org/blink/trunk@168593 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dominik.rottsches@intel.com authored
The assertion failure in HarfBuzzShaper is triggered because the TextRun passed to paintTextWithShadows is replaced with objectReplacementCharacterTextRun which only has a length of 1. Previously, we did not have an implementation of emphasis mark drawing for complex text with HarfBuzz, so instead of running into the assertion, those paint calls were not doing anything. The indices have been wrong since the emphasis marks drawing for RenderCombineText elements was fixed in 7565e3bbdccf98450271 (in 2011). I updated the test case to be equivalent to the original fuzz testing report and so that it actually combines text that is marked as combined where no font with narrow digits exists. BUG=348682 Review URL: https://codereview.chromium.org/187783002 git-svn-id: svn://svn.chromium.org/blink/trunk@168592 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dmikurube@chromium.org authored
See the bug and http://crrev.com/255129 for the details. BUG=345554 R=haraken@chromium.org, jamesr@chromium.org Review URL: https://codereview.chromium.org/177053003 git-svn-id: svn://svn.chromium.org/blink/trunk@168591 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
http://src.chromium.org/viewvc/blink?view=revision&revision=168578 BUG=349222 TBR=qinmin@chromium.org Review URL: https://codereview.chromium.org/187813010 git-svn-id: svn://svn.chromium.org/blink/trunk@168590 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
These header files are not being referenced from anywhere. They were replaced by NewSVGAnimatedProperty.h BUG=349370 TBR=haraken,pdr,fs Review URL: https://codereview.chromium.org/188413003 git-svn-id: svn://svn.chromium.org/blink/trunk@168589 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hajimehoshi@chromium.org authored
Now TestRunner is being moved from CppBoundClass to gin::Wrappable, where it is not appropriate to use WebElements directly. This CL moves some functions which treats WebElement* from testRunner to internals. (To be exact, this CL only copies some functions, but I'll remove those ones in testRunner later.) BUG=331301 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168495 Review URL: https://codereview.chromium.org/176953009 git-svn-id: svn://svn.chromium.org/blink/trunk@168588 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-