GitLab

This CL introduces a new browser command to open the Manage Passwords bubble,
and converts the ManagePasswordsIconView class into a subclass of
BubbleIconView, which uses the new command to control the bubble's state.
This allows us to more easily test the view and the UI controller, as each
object's job is now more clearly defined (and the view is now doing a good
deal less work), and to independently verify that the command is doing the
right thing.

After this CL, we'll (finally!) have something approaching reasonable test
coverage for the core of the views code.

BUG=365678
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/246393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266859 0039d316-1c4b-4281-b951-d872f2087c98

The cloud policy protocol can also be used to fetch policy for extensions; this change makes an update to the protocol such that extension IDs are never uploaded to the server.

Note that this feature is still disabled by default behind the --enable-component-cloud-policy flag.

BUG=361156

Review URL: https://codereview.chromium.org/233423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266857 0039d316-1c4b-4281-b951-d872f2087c98

This policy is more in accord with the design doc changes. Moves to
showing the dialog upon DOMContentLoaded in source pages, and then
subsequently for user gestures.

R=leng@chromium.org
BUG=332115,364159

Review URL: https://codereview.chromium.org/243543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266855 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces a TicSettingsProvider abstraction that allows
TiclInvalidationService to retrieve configuration settings without having
to directly observe a Profile's PrefStore.

The CL completes the work on removing the Profile dependency from
TiclInvalidationService.

BUG=358696
TEST=New and updated unit tests

Review URL: https://codereview.chromium.org/255443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266853 0039d316-1c4b-4281-b951-d872f2087c98

damaging viewport area covered by newly initialized tiles.

In the current implementation, during frame draw 
and visible tile update, LTHI was setting damage 
to the entire viewport area, irrespective of the 
initialized tiled content rect.
As part of the patch we are trying to ascertain newly 
initialized tile rect from TileManager, notify LTHI about it, 
and save it as damage rect in LayerImpl.
During frame draw, when the damage for surfaces and 
layers are tracked, we query for these damaged layer rects 
and unify with the DamageTracker's damage rect.

BUG=

Review URL: https://codereview.chromium.org/219963005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266852 0039d316-1c4b-4281-b951-d872f2087c98

R=ager@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/260073010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266851 0039d316-1c4b-4281-b951-d872f2087c98

Previous CL (which caused memleaks):
https://codereview.chromium.org/225693005

BUG=165760, 140882, 141141, 141517, 142787

Review URL: https://codereview.chromium.org/246923004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266850 0039d316-1c4b-4281-b951-d872f2087c98

Test code in https://codereview.chromium.org/255753003/

BUG=345296

Review URL: https://codereview.chromium.org/197453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266849 0039d316-1c4b-4281-b951-d872f2087c98

So far, the ONC IPConfig object was only validated but not translated to or from Shill.
This adds the one direction, from Shill to ONC.

This allows exposing the current IP config state of Shill through ONC, e.g. with in the networkingPrivate API.

BUG=288288

Review URL: https://codereview.chromium.org/249193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266848 0039d316-1c4b-4281-b951-d872f2087c98

+ Updated styling.
+ Add new incognito man illustration.
+ Simplify the copy. Remove the extensions block.


BUG=356226

Review URL: https://codereview.chromium.org/208683007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266847 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/257143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266846 0039d316-1c4b-4281-b951-d872f2087c98

Historically, QTKit had the camera resolutions limited to QVGA/VGA/HD
due to some internal rescaling not respecting aspect ratio in those
systems. AVFoundation has not shown such problems, to the best
of the author's knowledge, and the limited resolutions prevent 
using all the camera's capabilities. This CL enables the use of all
resolutions listed by the camera as supported.

QTKit implementation remains untouched.

Tested: Locally using C910 and Facetime HD alternatively. This CL
solves the attached bugs 367668, 367670.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/media/video/capture/mac/video_capture_device_mac.mm&sq=package:chromium&l=189

BUG=288562, 367668, 367670

Review URL: https://codereview.chromium.org/258783007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266845 0039d316-1c4b-4281-b951-d872f2087c98

This removes unnecessary PDF dependencies from component_extension_resources.grd and browser_resources.grd.
These particular files get flattened into the HTML and so are not needed in the
grd files. 

BUG=363909

Review URL: https://codereview.chromium.org/251813008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266844 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266843 0039d316-1c4b-4281-b951-d872f2087c98

BUG=254066

Review URL: https://codereview.chromium.org/255873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266842 0039d316-1c4b-4281-b951-d872f2087c98

Update to eeff97614f65e0578529490d44d412032c3d7359.

BUG=363909
TBR=arv@chromium.org

Review URL: https://codereview.chromium.org/258253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266841 0039d316-1c4b-4281-b951-d872f2087c98

This enables file associations behind a flag in chrome://flags. This flag will be
used in future for file associations on Windows and Linux.

BUG=168080

Review URL: https://codereview.chromium.org/64803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266840 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331299
TEST=None, no functional changes. Green trybots to make sure content_shell,
content_unittests, content_browsertests still link.
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/251263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266839 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368037
TBR=bajones@chromium.org

Review URL: https://codereview.chromium.org/259173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266838 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Allow BlobDataHandles to be copied, and have their UUIDs read, on any thread. (https://codereview.chromium.org/259773006/)

Reason for revert:
Causes leaks:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2069

Original issue's description:
> Allow BlobDataHandles to be copied, and have their UUIDs read, on any thread.
> 
> BUG=108012
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266817

TBR=michaeln@chromium.org,ericu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=108012

Review URL: https://codereview.chromium.org/252163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266837 0039d316-1c4b-4281-b951-d872f2087c98

In Debug config:

$ gn gen out/Debug_gn

$ ninja -C out/Debug_gn ui_base

In Release config:

$ gn gen out/Release_gn --args='is_debug=false'

$ ninja -C out/Release_gn ui_base

BUG=None
TEST=see above
R=brettw@chromium.org
TBR=ben

Review URL: https://codereview.chromium.org/250823008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266836 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266835 0039d316-1c4b-4281-b951-d872f2087c98

r1319: Change PrintFunctions to print functions in address order.
r1320: Linux: Check the CRC32 of the debug link file in the symbol dumper.
r1321: Clean up common.gypi.

Review URL: https://codereview.chromium.org/253783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266834 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Implement argument validation for chrome.cast.channel.{open,send} (https://codereview.chromium.org/255443002/)

Reason for revert:
Causing leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2069

Original issue's description:
> Implement argument validation for chrome.cast.channel.{open,send}
> 
> TESTED=Unit test.  Manually with Cast extension
> BUG=331165
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266804

TBR=munjal@chromium.org,imcheng@chromium.org,mfoltz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=331165

Review URL: https://codereview.chromium.org/256333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266833 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Android] Reland "Provide unhandled tap event notifications" (https://codereview.chromium.org/256213002/)

Reason for revert:
The test TouchCursorInTextfieldTest is failing flakily on Linux ChromiumOS Tests (2):

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/23460

The precondition CL crrev.com/218633008 also got previously reverted.

Original issue's description:
> [Android] Reland "Provide unhandled tap event notifications"
> 
> Allow notifications of unhandled taps via the GestureStateListener. This change
> makes GestureTap events blocking, but there are several use-cases for which this
> will be necessary, e.g., WebView and contextual search.
> 
> This was landed in r26143 and reverted in r261470 due to to a failure in
> TouchEditableImplAuraTest.TouchCursorInTextfieldTest. The test has been fixed
> and reviewed previously in crrev.com/218633008.
> 
> BUG=355154
> TBR=sky@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266732

TBR=jdduke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=355154

Review URL: https://codereview.chromium.org/259073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266832 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333979

Review URL: https://codereview.chromium.org/236203018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266831 0039d316-1c4b-4281-b951-d872f2087c98

+ Keep the .h in sync with the internal source tree.
+ Moved encrypter_ and decrypter_ back to local variables in the Box and
  Unbox methods.
+ Fixed comments from wtc in https://codereview.chromium.org/213473003/

R=wtc@chromium.org

Review URL: https://codereview.chromium.org/257123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266830 0039d316-1c4b-4281-b951-d872f2087c98

Test for functionality added in https://codereview.chromium.org/231283003/.
This is done as a browser test. Previous attempt to make it a unit test was scratched in https://codereview.chromium.org/258473005/.

R=isherman@chromium.org
BUG=347927

Review URL: https://codereview.chromium.org/257803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266829 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266828 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=172802:172818&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/260073008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266827 0039d316-1c4b-4281-b951-d872f2087c98

Bug marked as fixed, suppression never seen in
http://chromium-build-logs.appspot.com/suppression_query

NOTRY=true
TBR=thestig@chromium.org
BUG=301900

Review URL: https://codereview.chromium.org/253873006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266826 0039d316-1c4b-4281-b951-d872f2087c98

This saves the BrowserContext into the ServiceWorkerContextWrapper, and uses it when no process is available. We always choose a renderer process on the UI thread and take a reference to it before asking the renderer to start the SW thread. This also fixes a race where a process might die before we have a chance to use it.

We'll probably need to thread more process IDs through in cases where there might not be a ProviderHost, but that can wait for a subsequent CL.

BUG=359811,362060, 362058

Review URL: https://codereview.chromium.org/238043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266825 0039d316-1c4b-4281-b951-d872f2087c98

PPAPI: Remove the PP_FontDescription_Dev version of GetFontFileWithFallback() from the pdf interface impl.

Review URL: https://codereview.chromium.org/260153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266824 0039d316-1c4b-4281-b951-d872f2087c98

BUG=224072

Review URL: https://codereview.chromium.org/251733006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266823 0039d316-1c4b-4281-b951-d872f2087c98

While developing VideoFrameScheduler it became apparent that we no longer need to post tasks to notify the compositor as scheduling is already being done on the compositor thread. If there are no posted tasks, it also means we don't need to track dropped frames due to missed scheduler notifications.

BUG=110814

Review URL: https://codereview.chromium.org/251733005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266822 0039d316-1c4b-4281-b951-d872f2087c98

This specifies the viewer that will be used to render documents that are
a supported MIME type for the extension.

BUG=366409

Review URL: https://codereview.chromium.org/254503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266821 0039d316-1c4b-4281-b951-d872f2087c98

R=dewittj@chromium.org
BUG=354046

Review URL: https://codereview.chromium.org/250733008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266820 0039d316-1c4b-4281-b951-d872f2087c98

This is a temporary workaround. The reason for the tab crashes should
be investigated and fixed, since if it happens the context is lost
early in a tab's lifetime, this bug will be triggered.

BUG=365904,368107
TBR=bajones@chromium.org

Review URL: https://codereview.chromium.org/252123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266819 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267773

Review URL: https://codereview.chromium.org/243403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266818 0039d316-1c4b-4281-b951-d872f2087c98

BUG=108012

Review URL: https://codereview.chromium.org/259773006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266817 0039d316-1c4b-4281-b951-d872f2087c98