- 21 Feb, 2019 40 commits
-
-
Sergio Villar Senin authored
This class will be used to obtain diagnostics about IdentityManager internals. In this CL we're adding a pure interface and an implementation backed by unit tests. It has the following methods and correspondencies: * OAuth2TokenServiceDelegate::LoadCredentialsState GetDetailedStateOfLoadingOfRefreshTokens() corresponds to OAuth2TokenServiceDelegate::load_credentials_state() * GetDelayBeforeMakingAccessTokenRequests() corresponds to ProfileOAuth2TokenService::GetDelegateBackoffEntry()::GetTimeUntilRelease() * GetDelayBeforeMakingCookieRequests() corresponds to GaiaCookieManagerService::GetBackoffEntry()::GetTimeUntilRelease() In order to make the unit test work, BackoffEntry support had to be added to FakeOAuth2TokenServiceDelegate as the current code does not need to modify it (it does not perform retries). A new API to simulate cookie merge session failures had to be added as well to IdentityTestEnvironment. Bug: 926833 Change-Id: I2f1fedccd0c69e6a8de2bd307e6c32b83f76fd84 Reviewed-on: https://chromium-review.googlesource.com/c/1461121 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#634311}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/e2381829e984..986b2bef7f47 $ git log e2381829e..986b2bef7 --date=short --no-merges --format='%ad %ae %s' 2019-02-18 jzern vpx_thread.h: remove unused sched_yield() 2019-02-19 yaowu Disable encoder builds when checking coeff ranges 2019-02-19 jianj vp9: Enable ml based partition for speed>=8 low res. 2019-01-05 aidansw added error messages in vpx_video_reader_open(). 2019-02-08 angiebird Fix compile warnings in non-greedy-mv 2019-02-08 angiebird Only discount new mv mode when tpl model is ready 2019-02-06 angiebird Check the new mv diff in discount_newmv_test() 2019-02-06 angiebird Use mv_mode_arr to decide the newmv discount place 2019-02-08 angiebird Fix the bug for feature_score computation 2019-01-30 deepa.kg Fix integer overflow issue in bits allocated Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I03b9ba8d8671f09d253780cda216ab3a25be2963 Reviewed-on: https://chromium-review.googlesource.com/c/1481579Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#634310}
-
David Bienvenu authored
Bug: 868341,869154 Change-Id: I068264b13048d55dbae0fe7f05318ffb8270230c Reviewed-on: https://chromium-review.googlesource.com/c/1478356Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#634309}
-
Sam McNally authored
Bug: 737821 Change-Id: I9ce8458b260ff1b4402923f6b8ee5f94464f340a Reviewed-on: https://chromium-review.googlesource.com/c/1480368Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#634308}
-
Etienne Bergeron authored
Adding categories for: https://cs.chromium.org/chromium/src/components/services/font/public/cpp/font_loader.cc?tl=35 https://cs.chromium.org/chromium/src/components/services/font/public/cpp/font_loader.cc?tl=42 R=oysteine@chromium.org Bug: 867931 Change-Id: Ie385b8c6034e974660c0e64a46f9df9b406918d7 Reviewed-on: https://chromium-review.googlesource.com/c/1478480Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#634307}
-
John Rummell authored
base::UnguessableToken doesn't allow serialization of Null(). So make the |origin_id| parameter of MediaDrmStorage::Initialize() optional. BUG=917527 TEST=new unit_tests pass Change-Id: I21e374b42e670220ea11166c77651f0d9c00ae12 Reviewed-on: https://chromium-review.googlesource.com/c/1475902Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634306}
-
Antoine Labour authored
Copy & Paste fail... Bug: 870116 Change-Id: I6da2195e87944f3c249acb1ac59957e5cd3fb773 Reviewed-on: https://chromium-review.googlesource.com/c/1480533 Auto-Submit: Antoine Labour <piman@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#634305}
-
Andrew Xu authored
Make the following changes: 1. SearchBoxViewBase::SetBackgroundColor is never used. So erase this function. In addition, SearchBoxViewBase::background_ color_ is modified only by SearchBoxViewBase::SetBackgroundColor. So |background_color_| is constant. Hence replace SearchBoxViewBase:: background_color() with kDefaultSearchBoxBackgroundColor, the initial value of |background_color_|. 2. SearchBoxViewBase::UpdateBackgroundColor and SearchBoxViewBase::Set SearchBoxBackgroundColor do very similar job. And the latter is only used by KsvSearchBoxView. So erase the function SetSearchBoxBackground- Color. Move that part to KsvSearchBoxView. Test: none Bug: 755219 Change-Id: I678f254dd2de9dfe2f59b5027b1f00405fbbe829 Reviewed-on: https://chromium-review.googlesource.com/c/1474380Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634304}
-
Sylvain Defresne authored
Update the implementation of JsFindinpageManager to use JSONReader::Read instead of JSONReader::ReadDeprecated. Bug: 925165 Change-Id: I3a36d9876e5a0e47975efc39b415c813601b5e60 Reviewed-on: https://chromium-review.googlesource.com/c/1477228Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#634303}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d6c6f16063b8..e11b7d2e8087 git log d6c6f16063b8..e11b7d2e8087 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 perkj@webrtc.org Replace field trials with WebRtcKeyValueConfig in RtpRtcpModule 2019-02-21 gustaf@webrtc.org AEC3: Use minimum ERLE during onsets Created with: gclient setdep -r src/third_party/webrtc@e11b7d2e8087 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:119942 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1dd6b2f6bf3379785c4abc83e14fda46da5011bb Reviewed-on: https://chromium-review.googlesource.com/c/1480978Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634302}
-
Anne Lim authored
Clears all V2 strikes in a profile's StrikeDatabase when Autofill data is wiped out from Chrome Settings (chrome://settings -> Clear Browsing Data -> Advanced -> Autofill Form Data). Bug: 884817, 933826, 933705 Change-Id: Ic6565818fc473f3bca7111bafa3a8120dcd77093 Reviewed-on: https://chromium-review.googlesource.com/c/1479630Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#634301}
-
Alex Clarke authored
The callsites were removed in crrev.com/618761. Bug: 826465 Change-Id: If1b36e9b95b83183653bf5c927d8bdd8dbee7959 Reviewed-on: https://chromium-review.googlesource.com/c/1478893Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#634300}
-
Erik Chen authored
Bug: 926987 Change-Id: If17689c69a0c3f2ada5c40a844bea60376a96b61 Reviewed-on: https://chromium-review.googlesource.com/c/1480543Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#634299}
-
Andres Calderon Jaramillo authored
This CL takes VideoFrame-independent code from VaapiJpegDecodeAccelerator's DecodeTask() and OutputPicture() methods and puts it in VaapiJpegDecoder::DoDecode(). The idea is for VaapiJpegDecoder to be responsible for dealing with the VaapiWrapper, so now part of the initialization of the VaapiJpegDecodeAccelerator is delegated to VaapiJpegDecoder. Now, VaapiJpegDecoder::DoDecode() will take encoded data. It will do the parsing, VAAPI buffer submission, decode execution, and VAImage extraction. It will then return the decoded output as a ScopedVAImage. The intent is to have a VaapiJpegDecoder member in two classes: VaapiJpegDecodeAccelerator (existing) and the eventual implementation of gpu::ImageDecodeAcceleratorWorker. In the first case, we use the ScopedVAImage to copy the decoded data into a VideoFrame. In the second case, we use it to copy the decoded data into a vector. The unit tests are modified accordingly. Additionally, ::testing::FLAGS_gtest_death_test_style = "threadsafe" is added to two of the tests due to safety issues when using EXPECT_DCHECK_DEATH when there are multiple threads. The reason for introducing the grayscale image is that before, the DecodeFail test case was using a normal image and poking at the results of the JPEG parsing so that it failed. Now, the decoder interface doesn't take a JpegParseResult, so we can't do the same poking. Instead, we give it a real unsupported image. Bug: 924310 Test: jpeg_decode_accelerator_unittest passes on nocturne and grunt. Change-Id: I52d9760d233e63b2831408f60309803984784903 Reviewed-on: https://chromium-review.googlesource.com/c/1427457 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#634298}
-
Toni Barzic authored
Removes ExitReason enum: This is used to report screen exit, and was translated to the appropriate screen exit code in OnExit. Instead pass the ScreenExitCode directly to OnExit method (also, removes unnecessary update engine client status check from OnExit - the code is moved to the calling site, which already uses the update status). Removes UpdateScree::InstanceSet: The only remaining usage was to check whether a screen bound to a callback sent to UpdateEngineClient has been removed - the same can be achieved using a weak_ptr. BUG=None Change-Id: Ic5ccb3d280c6380b10a55dccfb3143278d421497 Reviewed-on: https://chromium-review.googlesource.com/c/1478264Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#634297}
-
Nico Weber authored
TBR=danakj,avi Bug: 926235 Change-Id: I83c82ee0d408dfd7489dcc0f9b50a50b399b6008 Reviewed-on: https://chromium-review.googlesource.com/c/1479838 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634296}
-
Marijn Kruisselbrink authored
This should make onion souping slightly easier, but also gets us closer to making sure that tasks run on the correct frame associated task runners. In a follow-up CL the AppCacheFrontend mojo binding can be changed to use correct per frame task runners. Also removes AppCacheFrontendProxy (in the browser) and AppCacheFrontendImpl (in the renderer), as those layers of indirection are no longer needed. Bug: 611938 Change-Id: I4d50a0f13f0d2624071b3c1734457be02483df60 Reviewed-on: https://chromium-review.googlesource.com/c/1478009 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#634295}
-
Tom Tan authored
RegisterNonABICompliantCodeRange needs to be implemented for arm64 is necessary. Bug: 893460, 933496 Change-Id: I12cb5a66dd2a9b9bd6df50b4463ecc9d982cbdb8 Reviewed-on: https://chromium-review.googlesource.com/c/1474637Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#634294}
-
Theresa authored
Merge IncognitoNewTabPageViewMD into IncognitoNewTabPageView and rename XML file. BUG=922690 Change-Id: I21e4c886fdbcc6dc666a985174803b8ad205695b Reviewed-on: https://chromium-review.googlesource.com/c/1480690Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#634293}
-
Liquan(Max) Gu authored
This CL moves NotifyPrePaintFinished of ImagePaintTimingDetector to paint-tree end. This change also contains a list of clean-ups to give https://chromium-review.googlesource.com/c/chromium/src/+/1477348 a clean slate. Bug: 924301 Change-Id: I4639affd45cce3e044f2d22c8f518b355a72ce11 Reviewed-on: https://chromium-review.googlesource.com/c/1481532Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#634292}
-
Xiaohan Wang authored
In jumbo builds (|use_jumbo_build| is true), multiple .cc files are combined and compiled together. If we override logging, we could end up overriding logging in other .cc files as well. See Bug for details. Bug: 933757 Change-Id: If6b64e7c6782691ed002fd773aae87f91aca5490 Reviewed-on: https://chromium-review.googlesource.com/c/1481576Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#634291}
-
Xing Liu authored
This CL adds the owner for the feature flag download-home-v2. The expiration date is still 76. Bug: None Change-Id: I5b10873486b837f5352c06d45ae3a3d3a9e19eb4 Reviewed-on: https://chromium-review.googlesource.com/c/1481021Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634290}
-
Sergey Kuznetsov authored
Change-Id: I560d982827840bc17862ff1f98927d12b132afc9 Reviewed-on: https://chromium-review.googlesource.com/c/1477072Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634289}
-
Kim Paulhamus authored
Updated strings to say 'security key' instead of 'key'. Consolidated IDS_WEBAUTHN_ERROR_WRONG_KEY_REGISTER_TITLE and IDS_WEBAUTHN_ERROR_WRONG_KEY_SIGN_TITLE. Removed IDS_WEBAUTHN_BLE_OS_PIN_ENTRY_TITLE and IDS_WEBAUTHN_BLE_OS_PIN_ENTRY_DESCRIPTION entirely because they weren't being used. Bug: 933592 Change-Id: I5bf6cd462a906f4e547c55499294e5c8fc653bc4 Reviewed-on: https://chromium-review.googlesource.com/c/1481573Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Auto-Submit: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#634288}
-
Nico Weber authored
https://chromium.googlesource.com/breakpad/breakpad.git/+log/9b06049ed9fd..37a60998cade $ git log 9b06049ed..37a60998c --date=short --no-merges --format='%ad %ae %s' 2019-02-21 thakis breakpad: Remove semicolons. 2019-01-15 ahaas Delete deprecated SetFirstChanceExceptionHandler function 2019-01-30 gsvelto Always emit a 32-bit crash address for 32-bit architectures 2019-01-29 gsvelto Make the minidump processor correctly populate the CPU information string for Microsoft-style ARM64 minidumps Created with: roll-dep src/third_party/breakpad/breakpad Bug: 926235 Change-Id: I0c32e9adf5e0c3206d6b071041c522250336307c Reviewed-on: https://chromium-review.googlesource.com/c/1481590 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634287}
-
Thomas Tangl authored
Bug: 930928 Change-Id: I1ea8365874b313c41e3c42ca7bce9c06b334d579 Reviewed-on: https://chromium-review.googlesource.com/c/1481292 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#634286}
-
Hector Carmona authored
See screenshot in bug. Bug: 932045 Change-Id: I2415c714fdff78dbecf9cb48b93154404d49a84d Reviewed-on: https://chromium-review.googlesource.com/c/1480545Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#634285}
-
Sebastien Marchand authored
This CL is a response to this comment: https://chromium-review.googlesource.com/c/chromium/src/+/1349670/15/chrome/browser/performance_monitor/system_monitor.h#12 The goal is to make it easier to add a new metric to SystemMonitor and to reduce the risk of errors by reducing the number of functions that have to be updated when doing so. A follow up CL will template this class: https://chromium-review.googlesource.com/c/chromium/src/+/1474810 (this is done separately to reduce the complexity). Change-Id: I97129d6db9897af1d6e0283e5d37bea28c77ed26 Reviewed-on: https://chromium-review.googlesource.com/c/1466189Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#634284}
-
Sebastien Marchand authored
I've been working a lot in this directory lately and I own most of these files anyway, being an owner will make the code review process easier and will reduce the load on the other owners (who are already quite busy with code reviews). I'm still planning to use fdoray@ as a technical reviewer for all the significant changes, and I might use other reviewers for smaller changes that don't affect the design of the different performance monitors. Change-Id: Icd3fe6f3a1452e581f0971d00ecd226149f5cef1 Reviewed-on: https://chromium-review.googlesource.com/c/1479881Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#634283}
-
Jun Mukai authored
These tests are disabled due to the reported flakes (see the bug). However, as I tried now, they consistently succeed on my environment. I guess they are fixed meanwhile, so simply re-enable them. The previous attempt was reverted since flakiness was still observed on asan bot. I locally build the asan build and made sure it doesn't reproduce anymore. Bug: 923051 Test: browser_tests --gtest_repeat=20, both debug and asan Change-Id: I19e40f6f9ab255a8b0af1ce27caf8946d3214e9a Reviewed-on: https://chromium-review.googlesource.com/c/1479865Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#634282}
-
Aaron Leventhal authored
Make the NSAccessibility attributes we expose for each object similar to what WebKit exposes, to make debugging much easier. It's far easier to see differences when more attributes are similar. Bug: 894842, 932806 Change-Id: I8ae03ac7faaab10d863fe9697665d415140c1897 Reviewed-on: https://chromium-review.googlesource.com/c/1476133Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#634281}
-
Sergiy Belozorov authored
R=perezju@chromium.org Bug: 895891 Change-Id: I52d67ff193fce37f1637c7f22b5e14e7ebe2428b Reviewed-on: https://chromium-review.googlesource.com/c/1477608 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#634280}
-
Stephen Kyle authored
The presence of outlining seems to sacrifice a 10% performance boost in Speedometer for a 1-2% reduction in .so size. Outlining is performed by default when clang is compiling with -Oz for arm64. This CL stops this default behaviour from happening. Outlining can still be allowed by setting |arm64_allow_outlining|. This patch also works around a bug in LLVM whereby -mno-outline is not passed to the linker when ThinLTO is used, which happens when is_official_build is set. Please see https://bugs.llvm.org/show_bug.cgi?id=40348 for more information. On arm64 android, this CL will also cause 'thinlto-cache' directories to be deleted either the first time ninja is run after this CL is present in the tree, or whenever |arm64_allow_outliing| changes, to flush stale objects which may contain (or not contain) outlined functions. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1473235 which should no longer try to use -mno-outline with the iOS build that uses a version of clang that doesn't appear to support the flag, as it will only apply this to Android targets. BUG=931297 Change-Id: I530abac918d954f55955263253cd8df16aa43a1b Reviewed-on: https://chromium-review.googlesource.com/c/1481336 Commit-Queue: Stephen Kyle <stephen.kyle@arm.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#634279}
-
Dominic Mazzoni authored
Bug: none Change-Id: If84176b45b2ca8f895c370d13d6f4c5567e509f9 Reviewed-on: https://chromium-review.googlesource.com/c/1480354 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#634278}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3f48ecb3efb5..0eee33250ebb git log 3f48ecb3efb5..0eee33250ebb --date=short --no-merges --format='%ad %ae %s' 2019-02-21 headlessclayton@gmail.com Silence warnings: Ignore pedantic warnings with compiler flags Created with: gclient setdep -r src/third_party/swiftshader@0eee33250ebb The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/123933266 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ib4f62615631e29d4b76f345756c0580900b2c79c Reviewed-on: https://chromium-review.googlesource.com/c/1481552Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634277}
-
Caitlin Fischer authored
The documentation says the following--"|other_field_types| represents the rest of form"--but it is incorrect. Using the Autofill Smoke Test and a bit of printing, I manually verified that all field types are present. The below code suggests that the last argument being passed to PersonalDataManager:: GetProfileSuggestions() is all field types rather than the field types minus the ServerFieldType associated with |type|. https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_manager.cc?g=0&l=1553-1556 Change-Id: I2d3438ff1b222796f236f1484abfc7fbefd737fc Reviewed-on: https://chromium-review.googlesource.com/c/1475113Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#634276}
-
Ovidio Henriquez authored
This change officially enables support for WebUsbAllowDevicesForUrls for desktop. Android support is still pending on the appropriate UI changes to properly display the permissions. Design doc: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w Bug: 854329 Change-Id: I3b05598fe1f68960ae9c0d25902342b19c294129 Reviewed-on: https://chromium-review.googlesource.com/c/1473546 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#634275}
-
Nico Weber authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/05d12a9461dd..a51d3d9f2233 $ git log 05d12a946..a51d3d9f2 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 nicolasweber Fix -Wextra-semi warnings in headers used in Chromium 2019-02-18 baldurk Fix type recursion with EOpIndexIndirect dereferences 2019-02-20 dsinclair Fixup leak of TString 2019-02-20 dsinclair Allocate empty function name in the string pool. 2019-02-20 greg Update SPIRV-Tools known good 2019-02-19 cepheus PP: Faithfully track white-space through macro record/use, fixing bugs: 2019-02-19 cepheus PP: Non-functional: Remove the sub-tokenization of macro stream record. 2019-02-18 cepheus Build: Fix #1640: Change strcpy to snprintf. 2019-02-16 cepheus PP: Fix #1694: Rationalize errors on partially expanded macro argument. 2019-02-13 sparmar Handle resizing/error checks for mesh shader out arrays 2019-02-12 sparmar Update gtest to explicitly size gl_PrimitiveIndicesNV[] 2019-02-11 sparmar Fix resizing of gl_PrimitiveIndicesNV[] to max_primitives*geomSize 2019-02-11 baldurk Fix treatment of array input/output variables in reflection Created with: roll-dep src/third_party/glslang/src Bug: 926235 Change-Id: Ic35fae607df627c7414838565a17d684ec37e47b Reviewed-on: https://chromium-review.googlesource.com/c/1481610 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#634274}
-
Lukasz Anforowicz authored
This CL extracts a GetTrustworthyInitiator helper function to deduplicate code that used to be present in CrossOriginReadBlocking and CrossOriginResourcePolicy classes. In the short-term future, GetTrustworthyInitiator might be used for making security decisions in other NetworkService features (e.g. in Sec-Fetch-Site - see bugs 872285 and 924204 as well as the spec at https://mikewest.github.io/sec-metadata/#sec-fetch-site-header). In the long-term, we want to ensure that net::URLRequest::initiator itself is trustworthy (e.g. by terminating renderers that request a network::ResourceRequest::request_initiator that is incompatible with request_initiator_site_lock). This can't happen in the short-term, because of compatibility risks associated with HTML Imports (see https://crbug.com/871827#c9). Bug: 871827, 872285, 924204 Change-Id: I7a87fae7b44a82dbd55af448d228ffaad4f6dbb0 Reviewed-on: https://chromium-review.googlesource.com/c/1475877 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634273}
-
Robert Ogden authored
Bug: 934289 Change-Id: I8d6bf756ac11ba8b1849a8559a79262c285d33d2 Reviewed-on: https://chromium-review.googlesource.com/c/1481534 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#634272}
-