- 17 Nov, 2020 40 commits
-
-
Marijn Kruisselbrink authored
Bug: 1095379 Change-Id: Icf60c0c72ed31abbb547a13af57f12e0bbe2d74e Tbr: masonfreed@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545762Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828429}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ia4d38a04f0029bc9566043014546664c19a011e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545209Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828428}
-
Jared Saul authored
Change-Id: I7c055a216e7ce2f5aca3cda2a0fe943c20b72a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541748 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#828427}
-
Yann Dago authored
Bug: 1149989 Change-Id: If7daa7e9bb5f43b43860cc097f214755b3b75bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544370Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#828426}
-
Marijn Kruisselbrink authored
This reverts commit a4b670d5. Reason for revert: Test is flaky/failing on https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/95514? ../../chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:2470: Failure Expected equality of these values: tab_strip_width + TabStyle::GetStandardWidth() Which is: 751 tab_strip->width() Which is: 761 Original change's description: > [Tab Scrolling] Add test for tabstrip resizing when dragging. > > When the browser window is large enough, the tabstrip should expand to > accommodate tabs dragging past the last tab. This is a test for > crrev.com/c/2472577 > > Bug: 1141674 > Change-Id: Icfb4b0d6b9ebfa243a0e352b0cef68a2a6f2c263 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537068 > Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> > Commit-Queue: Charlene Yan <cyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827998} TBR=tbergquist@chromium.org,cyan@chromium.org Change-Id: Iaee8c99d3a53eb4f1031d969b01e39d86febe6a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1141674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545744Reviewed-by:
-
Xing Liu authored
This CL implements more details for bookmark bottom sheet. The contents includes: 1. Load bookmark top level data to bottom sheet. 2. Implement the click event. 3. Implement the view holder. Reuse BookmarkRow but plumb data through MVC view binder, might be good for future development. 4. A few integration tests are added to BookmarkBottomSheetTest. doc: go/chrome-bottomsheet-mvc Bug: 1133496 Change-Id: Id5ce9abb44351c3a6a350531e1622f08c725a1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537785 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828424}
-
Matt Menard authored
The `Polymer` and `html` are unused in css js files. Change-Id: Iee6a6d6df14562c769bd7723a4f35698cc8a7478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541702Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Matt Menard <mattme@google.com> Cr-Commit-Position: refs/heads/master@{#828423}
-
Alex Gough authored
Tested on hardware as part of https://chromium-review.googlesource.com/c/chromium/src/+/2494509/2/build/config/compiler/BUILD.gn Bug: 1136664 Change-Id: I7c5cf2c54259c6aa29fd1ea39a66cf3e8ae7ac4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541782Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#828422}
-
Marijn Kruisselbrink authored
These tests were timing out rather than (or in addition to?) failing, so add Timeout as one of the expected outcomes. Bug: 1149734 Change-Id: Ief7709340fe76350a210046d7cd75a0626d9c44d Tbr: tguilbert@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545249Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828421}
-
Mark Cogan authored
Adds a VoiceOver notification when the number of visible Chrome windows changes, if multiple windows are possible. This is complicated by some window manipulations causing transient changes in the number of foregrounded windows -- for example, replacing one window with another will briefly have three scenes with Foreground- Inactive states. To mitigate this, the app agent delays notifications, and coalesces multiple notifications in the delay period into a single notification. (No notification is posted if the window count doesn't change from the last notification). Bug: 1137818 Change-Id: I2a308072c92aceb3816397dae6fdf50d61d14398 Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540670 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#828420}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5035b8f92a0e..75c38f94efd6 2020-11-17 tdenniston@google.com [svg] Add SkSVGProperty class for presentation attributes 2020-11-17 bsalomon@google.com Remove deprecated DDL promise texture image factories. 2020-11-17 bungeman@google.com Remove FCLocker::Suspend. 2020-11-17 herb@google.com tighten up device bounds for glyphs 2020-11-17 johnstiles@google.com Disallow unsized array dimensions on size fields past the frontmost. 2020-11-17 johnstiles@google.com Report the correct line number when vardecls have an error. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: Ibbc773b1aaca0abd9aa26d7dd347b65ad2595458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545224Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828419}
-
Nina Satragno authored
u2f-only requests should not try to obtain a PinUvAuthToken even if the key supports CTAP 2.1 and the alwaysUv flag is on. Fixed: 1149572 Change-Id: Ib9a132b4b9fe92bc9830d87395097a2440acf2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542822 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#828418}
-
Dave Tapuska authored
Instead of two overloads move the implementation into the base class as this will facilitate the removal of the subclasses. BUG=1097816 Change-Id: I37fbd348ab028d664de85c1b41a19035d75eda55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538126 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#828417}
-
Sonny Sasaka authored
To prepare for enabling debug logs for Googlers by default, we disable the dispatcher and newblue components which are not currently used. Also leave the kernel verbose logs off since we are not ready with enabling it by default. This leaves only bluetoothd verbose logs to be configurable according to the plan go/chromeos-bluetoothd-verbose-logs. Kernel debug level can still be configured with the D-Bus command org.chromium.Bluetooth.Debug.SetLevels (implemented in CL:1725690). Bug: b:172273364 Change-Id: I0080f50f0cda270928b308fcd72458855513faad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536949 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#828416}
-
Ben Pastene authored
crrev.com/i/3411588 allocates the machines for this pool. Bug: 1140727 Change-Id: Id46bcf1917fe7eca740d1401550dd57553be337c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544862 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#828415}
-
Taylor Bergquist authored
Tab widths are cached during UpdateIdealBounds for subsequent calls to GetActiveWidth and GetInactiveWidth. If the last inactive tab in any invocation of UpdateIdealBounds() is in a collapsed group, its width of kTabOverlap will end up being recorded as the inactive tab width. This most prominently manifested as a bug in calculating tab visibility. Bug: 1140388 Change-Id: Ie9ecdbacf49ffdb829f1ff208d4f22e077457b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542769 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#828414}
-
Liquan (Max) Gu authored
Refactor triggerPaymentAppUiSkipIfApplicable to extract the main precondition to PRService. Bug: 1147092 Change-Id: I992cb5cb57047e36d845a5fb8f5b22166fac321a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543836 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828413}
-
Tanmoy Mollik authored
This is a reland of f4a2ff7e The cl was reverted because testPromoNotShownAfterBeingDismissed and testPromoImpressionCountIncrementAfterDisplayingSigninPromo were flaky. After looking into more details about why the tests are flaky it seems that SyncTestRule calls NativeLibraryTestUtils.loadNativeLibraryAndInitBrowserProcess() as part or rule set up. Other tests like BookmarkBridgeTest and BookmarkModelTest uses ChromeBrowserTestRule which also calls this method during rule setup. Changing AccountManagerTestRule to ChromeBrowserTestRule should fix it. Original change's description: > [Test] Refactor BookmarkPersonalizedSigninPromoDismissTest > > Refactor BookmarkPersonalizedSigninPromoDismissTest to use > AccountManagerTestRule and ChromeActivityTestRule instead of > SyncTestRule so that it can be batched easily. > > Bug: 1145843 > Change-Id: Ia005508ccd84c439b04b25a65af0930b5a15ee0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527021 > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Alice Wang <aliceywang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827278} Bug: 1145843 Change-Id: I261da247b78cd33d2314be6aa40668a9dcdafa98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540669Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#828412}
-
Piotr Pawliczek authored
When a port value in printer URI is not specified, the default port number assigned to the URI protocol is assumed. However, for ipps protocol the default port number in ChromeOS is 443, while in CUPS the value 631 is assumed. As a results, CUPS tries to connect to port 631 when the port 443 is specified on ChromeOS side. This patch solves this issue by enforcing presence of port number in all URI sent to CUPS. BUG=b:172961564 TEST=tested on atlas device by checking URIs in CUPS with lpstat -v Change-Id: I0a00ab2f9230a8a159483da4370df15d86f58bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538254 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#828411}
-
Ben Joyce authored
Ran check on flakiness dashboard which shows no failures on experimental sharded runner that were not also on regular runner. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_junit_tests_with_shards&result=crash&builder=chromium.android%3Aandroid-marshmallow-arm64-rel Bug: 113506 Change-Id: I3bf8e31c7db36f1be5090ea46627233087f09cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528178 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#828410}
-
Wan-Teh Chang authored
Document what kind of image decoder must override DecodeFrameCount(). Document what DecodeFrameCount() should return on failure. Document the two options for the return value: an increasing frame count as frames are received and parsed, or the total frame count in the image header (if available). Bug: 1148577 Change-Id: I2f099ccfb2c901aa415ed403d211b6bf29a8654f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544081 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#828409}
-
Maggie Chen authored
Change-Id: I54e6dc2320a3be43f5166244be0740990b991b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545723Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#828408}
-
hai007 authored
Bug: 1123167, b/171980625 Change-Id: I8f6997f03f423ad610e39e3514714fb1af1f29f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543543Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
-
danakj authored
Code using bitmaps converted with SkBitmapToN32OpaqueOrPremul() can easily assume that the pixels are one contiguous (width*4*height)-sized buffer. If it's not then out-of-bounds read/write can occur. Also adds tests for SkBitmapToN32OpaqueOrPremul(). R=fmalita@chromium.org Bug: 1147431, 1144462 Change-Id: I21f7a958a8c9231bf5f052f8ff246f2c249bd70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544032 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#828406}
-
Dave Tapuska authored
Move ApplyViewportChanges into base. It still calls WebViewImpl via a friend class private method call because this seems relatively complex code that is contained only in the view. Move RunPaintBenchmark into WebFrameWidgetBase and protect with a ForMainFrame. Move RecordManipulationTypeCounts into WebFrameWidgetBase and protect with a ForMainFrame. BUG=1097816 Change-Id: If4cd9b9cd080d244c67e9319eb512e4fe9dd6809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536901 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/autofill... Bug: 1113033 Change-Id: Ie7f1a89c698dccaf00f1745302095f89e588e958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544926Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#828404}
-
Matt Menard authored
Bug: 1148906, b:168650771 Change-Id: Ic438b2c2cecf0d2e85c3fb8d2a75f929818aede0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530251 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/omnibox... Bug: 1113033 Change-Id: Id5324c50ecc9e5a1240af15fad0c3a64be3e5959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545066Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#828402}
-
Patrick Monette authored
Bug: 971272 Change-Id: I5985ae79f67d634d58d1ab7fbd002635a4b2689b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532671 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#828401}
-
Maggie Chen authored
Change-Id: I726e5a34d7ea5d0b3d7455e1047169e72f4047e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545069Reviewed-by:
-
Liquan (Max) Gu authored
Before the CL, for the BPRService implementation methods in CPRService, they often called PRService's getters for certain values. This CL simplified this as BPRService passing the getter values to CPRService. This would make CPRService depend less on the concrete object PRService, and more on the BPRService interface. Bug: 1025619 Change-Id: I2b819fd3c31d992cbcd309fcaf23aaf7c490d1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543835 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Xiaohui Chen authored
Bug: b:114298169 Change-Id: I5793924de4e2f61f70ba1f3b9020b5aaf111ad85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543197Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#828398}
-
Yulun Wu authored
UX has indicated that icon/text shadows should be removed from launcher as they are no longer needed with upcoming theming changes. Bug: 1134433 Change-Id: I963260e1a4b4fea944d499f85392f8590f10bd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527606Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828397}
-
Brian Sheedy authored
Adds the requests module as an entry in //third_party/blink/tools/wpt_import.py's file-specific vpython spec. One of the script's dependencies (typ) is taking a dependency on the requests module, so failing to include it in the vpython spec causes import failures. Bug: 1147992 Change-Id: I42258b20373cdb4b3430c8bb01357706ccfb23da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544937 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#828396}
-
Greg Thompson authored
There was a fear that the value iterator was flaky on Win 7. If that's true, a little test coverage should expose it. BUG=1066801 R=robliao@chromium.org Change-Id: I984044243886510c9c540bc471b6a62a26212e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540447 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#828395}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/384b05891b9b..1f921f2e5070 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mek@google.com,gogerald@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040645,chromium:1139446 Tbr: mek@google.com,gogerald@google.com Change-Id: Ib46ab93bdd01d391daedc645a2b3c5f0faa6f80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545102Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828394}
-
Zhaoyang Li authored
This reverts commit 0afe240a. Reason for revert: The issue is fixed in iOS third_party code so the change is no longer needed. Original change's description: > ios: Disable -Wgnu-folding-constant for .m files. > > Bug: 1143700 > Change-Id: If1110313fda223d83d17db5600f2041c3e1f6f32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510229 > Commit-Queue: Nico Weber <thakis@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822644} TBR=thakis@chromium.org,hans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1143700 Change-Id: I3c1b2e57871b06bb21fed29fc4b4ecc6c77d9caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545025 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Kartik Hegde authored
Add the HttpsFirewall routine to the ServiceConnection. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest* 3) Applied HttpFirewall changes and successfully ran the HttpFirewall routine on a DUT (verified using cros-health-tool diag --action=run_routine --routine=https_firewall). Change-Id: I55dafa03d296c3451b40dd9720a3447259ebb5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482091 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#828392}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I346808400cf076cf40fac835c12a72a8625d90a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545202Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#828391}
-
Wan-Teh Chang authored
Handle multiple incomplete lazy decoded frames in DeferredImageDecoder::PrepareLazyDecodedFrames(). This allows blink::ImageDecoder::DecodeFrameCount() to return the true frame count even when not all frames' encoded data are available. Change blink::AVIFImageDecoder::DecodeFrameCount() to return the true frame count. Change blink::AVIFImageDecoder::FrameIsReceivedAtIndex() to actually check if the frame's encoded data has been received. Bug: 1148577 Bug: 1136922 Change-Id: I2423472b406b130fb460cbfe65b5b3890c106344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538696 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#828390}
-
