- 17 Apr, 2018 40 commits
-
-
Gabriel Charette authored
This is another scripted pass done by a slightly modified version of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which has a better notion of "scope". The script should have replaced a MessageLoop::ScopedNestableTaskAllower in the same scope as a RunLoop with a RunLoop of Type::kNestableTasksAllowed. Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=rvera@chromium.org Bug: 781352 Change-Id: I5429418614b13b654af86c4764ac1c9066a21f95 Reviewed-on: https://chromium-review.googlesource.com/1014780Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#551485}
-
btolsch authored
Bug: 828704 Change-Id: I1263e0bc2520b7b5f110ac2ae0ac92e3db8e2fd9 Reviewed-on: https://chromium-review.googlesource.com/999310Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#551484}
-
Wez authored
Bug: 832728 Change-Id: I9a2d2d330aa4d250c925b7a614780acbf40dce3f Reviewed-on: https://chromium-review.googlesource.com/1012732Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#551483}
-
rbpotter authored
Bug: 814860 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibe97fb4ccc820b72b67c8311b5ac5749ddb39d8d Reviewed-on: https://chromium-review.googlesource.com/1014275 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#551482}
-
Yuwei Huang authored
Currently we create CFString and CFData wrappers for the underlying std::string in RemotingKeychain. Even though the underlying content isn't managed or released by the wrapper, we still need to release the wrapper itself. Bug: 834021 Change-Id: I47b298dc9a06ce34de68442cddc7ff07e79c0873 Reviewed-on: https://chromium-review.googlesource.com/1015769Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#551481}
-
wutao authored
This cl makes some string changes for Keyboard Shortcuts Viewer based on TC. Bug: 833967, b/77166809, b/77861902 Test: manual Change-Id: Ib28c40c1aea1303151bf2f4a687df7f230760cfa Reviewed-on: https://chromium-review.googlesource.com/1015601Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551480}
-
Jinsuk Kim authored
This CL puts the ViewAndroidDelegate in WebContents internal to makes it accessible using |WebContents.getViewAndroidDelegate|. It helps replace ContentViewCore with WebContents where CVC is passed as a way to access WebContents and container view. The update of container view in VAD is taken care of by embedder (WebView), so we don't need ContentViewCore API |setContainerView| any more. It was deleted in this CL. There are content classes that relied on |setContainerView| to do some clean-ups (such as hiding popups). Added ViewAndroidDelegate. ContainerViewObserver for them. Bug: 598880 Change-Id: Icb824ddefc9707d9ea78cdba55615e47f2d100e7 Reviewed-on: https://chromium-review.googlesource.com/994500 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#551479}
-
wutao authored
The file internal_app_id_constants.h was not added to ash/public/cpp/build.gn. This cl fixes this. Bug: 833955 Test: manual Change-Id: Iff82b5d556ba084580640dbd73f423af67f64899 Reviewed-on: https://chromium-review.googlesource.com/1015527 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551478}
-
Florent Castelli authored
Only parameters encodings.active, encodings.maxBitrate and encodings.priority are effectively working and connected to the native layer. Due to discrepancies between the WebRTC specification and the native layers, the objects are not passed back from Javascript and converted to native directly, but instead the relevant fields are converted and patch the last result from getParameters(). If any read-only field is implemented by the native layer but not exposed yet to Javascript, they will be left as is and won't cause any InvalidModificationError. Bug: 803494 Change-Id: Ia59734e5c3eddb54e5a1448a04fdcefe5a41a279 Reviewed-on: https://chromium-review.googlesource.com/969124Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#551477}
-
Christopher Cameron authored
Add version of conversion tests with and without premultiplied alpha. Bug: 833388 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I9d269e5867fee62ed70b2f3579a4c4bf524a7103 Reviewed-on: https://chromium-review.googlesource.com/1014631Reviewed-by:
enne <enne@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#551476}
-
Dave Schuyler authored
This CL moves pieces of the OmniboxResultView Layout into the sub-views (OmniboxSuggestionView elements). The OmniboxSuggestionView now have functions to layout each style of result: Answer, Entity, TwoLine, and Split. This CL is part of a refactor of the OmniboxResultView. Bug: None Change-Id: I8cd07a4749ab68238956632b45c2bd575fb4dccc Reviewed-on: https://chromium-review.googlesource.com/1013320Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#551475}
-
Kyle Horimoto authored
This CL implements the initialization flow for the service as well as the implementation for GetSyncedDevices() and observer callbacks. Additionally, it tweaks the API for Force{Enrollment,Sync}Now() to return a boolean of whether the forced action was successfully handled by the service (it cannot be handled before the service starts up). Bug: 824568, 752273 Change-Id: I787c5ac9cb5fe6011e26e0ddb8217910b9c495f0 Reviewed-on: https://chromium-review.googlesource.com/998795 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Peter Beverloo <peter@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#551474}
-
Vasilii Sukhanov authored
All those contorls are rendered with MacViews in M66. Bug: 832676 Change-Id: I23ba5ad92fc4af46ed2e7adb3ad9607857cab443 Reviewed-on: https://chromium-review.googlesource.com/1014113Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#551473}
-
Chris Lu authored
Rotates Disclosure Accessory 90 degrees CW when showing section contents. Rotates back CCW when collapsing section. Video: https://drive.google.com/file/d/1TWXnHpHqsfbrK26PsWraC6HTvaC_EGo5/view?usp=sharing Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I84f090bcbd43d0f69d50b8f0b48da35aff7efaf8 Reviewed-on: https://chromium-review.googlesource.com/994233 Commit-Queue: Chris Lu <thegreenfrog@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#551472}
-
Matthew Jones authored
This change re-enabled the tests for the BottomSheetObserver. The BottomSheetTestRule has been modified to create a separate bottom sheet to test with instead of pulling the one from the activity. Bug: 805160 Change-Id: I363507d9a42767682dce4935c0b347de320c4b8a Reviewed-on: https://chromium-review.googlesource.com/1014252Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#551471}
-
Oksana Zhuravlova authored
This change also converts the minimum necessary amount of C++ code to pass objects of base::Value by value instead of std::unique_ptr. Bug: 646113,799482 Change-Id: I86dcd6b4cfbb061942cb73f6ffddcf9e712f355f Reviewed-on: https://chromium-review.googlesource.com/1012931 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#551470}
-
Moe Ahmadi authored
Bug: 828878 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I76115730b550c8320e05c7c9fc1a20dd129f3626 Reviewed-on: https://chromium-review.googlesource.com/1012748 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551469}
-
Xiaohan Wang authored
All players/decoders handling encrypted media should implement the logic to suspend playback when the decryption key is not available, and then resume playback when a new usable decryption key is added. Hence, there's a common need for the players/decoders to be notified when such an event (new usable key) happens. Since CdmContext is the common interface bridging players/decoders and the CDM, this CL adds RegisterNewKeyCB() to CdmContext. To facilitate the implementation of RegisterNewKeyCB() in various CDMs and CdmProxies, CallbackRegistry is also introduced, which can manage callback registration, notification and unregistration. Note that there's base::CallbackList which is similar, but that class is not as simple and is not thread-safe. This CL also updates D3D11CdmProxy to use CallbackRegistry to manage new key callbacks. D3D11VideoDecoderImpl is also updated to be able to register new key callbacks. Bug: 821288 Test: Covered by existing tests. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0380f934efb63d3b3c893d909e0d78f5f8e082f4 Reviewed-on: https://chromium-review.googlesource.com/1014245 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#551468}
-
Conley Owens authored
This change marks RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler as flaky on Android. BUG=827318 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I350f16399cf4cd389642a2e1af8a106c6c23495f Reviewed-on: https://chromium-review.googlesource.com/1015652 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551467}
-
Theresa authored
Cleanup more left-over code from Chrome Home: - Don't use BottomSheet for ViewShiftingActionBarDelegate so that copy-paste action bar pushes down top toolbar instead - Revert changes that disabled hiding the keyboard during find in page when there is a bottom sheet BUG=833606,833608,814528 Change-Id: I9f2a1262c5ffba20902e1b438cb6175a48363680 Reviewed-on: https://chromium-review.googlesource.com/1015283Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#551466}
-
Nate Chapin authored
Bug: 829119 Change-Id: Idbc1dd0294174b457989893d11e66237a04c3ea5 Reviewed-on: https://chromium-review.googlesource.com/1005367Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#551465}
-
Simeon Anfinrud authored
No more detatchWebContentsIfAny() and similar helpers. This boils the presentation of WebContents into a simple state machine compatible with Observables. This refactor includes covering the business logic of CastWebContentsSurfaceHelper in unittests. The implementation details of CastWebContentsView are still not unit-tested, but are now better isolated from other logic. Bug: Internal b/36777136 Test: cast_shell_junit_tests Change-Id: Ia555b4d3ea9ee07607bf54cc339b950fe068d220 Reviewed-on: https://chromium-review.googlesource.com/1003412Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551464}
-
Patrick Noland authored
Change-Id: Id73ec54e7a4e66f75cb7f4c294b923f851f00ae9 Reviewed-on: https://chromium-review.googlesource.com/1014406Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#551463}
-
David Reveman authored
Bug: 833986 Test: No delays when using copy-and-paste in Crostini. Change-Id: I6722dbd81548b760db8e1ae9a4e3cd1d4c6bf645 Reviewed-on: https://chromium-review.googlesource.com/1015700Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551462}
-
https://chromium.googlesource.com/angle/angle.git/+log/aa8b3982aeeb..aed1b56aac8e $ git log aa8b3982a..aed1b56aa --date=short --no-merges --format='%ad %ae %s' 2018-04-17 jmadill Prerequisite code for simpler GlslangWrapper. 2018-04-13 lucferron Vulkan: Fix issue in GlslWrapper and maxVaryingVectors calculation 2018-04-17 lucferron Vulkan: clearRegionWithScissor did not determine the region correctly 2018-04-16 lfy GLES1: gl(Enable|Disable)ClientState 2018-04-17 jmadill Vulkan: Fix build after roll. 2018-04-17 jmadill Vulkan: Suppress ClearIssue test. 2018-04-16 jmadill Vulkan: Disable warning in Mock ICD. 2018-04-16 tobine Roll (2/2) to latest LVL as of 4/16/18 Created with: roll-dep src/third_party/angle BUG=chromium:833736 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I7c7f1fb47c5cde7e4552f40d084fcd9d1af2e9ee Reviewed-on: https://chromium-review.googlesource.com/1015624Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551461}
-
Dmitry Gozman authored
These are used across processes and should be in common. It also unblocks moving public manifest files to blink/public/common and later moving manifest implementation to blink. NOPRESUBMIT=true Bug: none TBR: oshima@chromium.org, dtrainor@chromium.org Change-Id: Ief909ae1d5f42cb6f4cb58c4119b17f79b6682a8 Reviewed-on: https://chromium-review.googlesource.com/1007899 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#551460}
-
David Bokan authored
Turns out we can have a focused Element that doesn't have a LayoutObject. Just early out in this case when we try to scroll it into view. Bug: 833746 Change-Id: Ia68492bf5cd4cbb538b5e9c53a75433a48ac5463 Reviewed-on: https://chromium-review.googlesource.com/1015533Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551459}
-
Sigurdur Asgeirsson authored
R=chrisha@chromium.org Bug: 755840 Change-Id: Ife8febb03b0fb8d48b864b9987488d90893c4bbf Reviewed-on: https://chromium-review.googlesource.com/1005408 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#551458}
-
Lei Zhang authored
Also add OWNERS for components/resources/printing_resources.grdp BUG=792294 Change-Id: If488698218b7a713db961d54c7a1cf811ab94a8b Reviewed-on: https://chromium-review.googlesource.com/989426Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jianzhou Feng <jzfeng@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#551457}
-
Erik Luo authored
Adds [Affects=Nothing] to common IDL methods/attributes with return types: short, long, double, int, boolean, DOMString, USVString. Followups will whitelist ones that use DOMWrapper and update style or layout. List of some common attributes: https://goo.gl/qGd2i7 Bug: 829571 Change-Id: I4c335b7eeac449bd7454df7f829f393469d84387 Reviewed-on: https://chromium-review.googlesource.com/1013126Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#551456}
-
Artur Khachatryan authored
Change-Id: I4d720df1d47dd095a0cbfc65b774fedce244911d Reviewed-on: https://chromium-review.googlesource.com/1015085Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551455}
-
Hector Carmona authored
Bug: 821736 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I849ddd15a632309e09c8fec627832c41b0d39abb Reviewed-on: https://chromium-review.googlesource.com/1014623 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#551454}
-
Greg Thompson authored
The bg color is used in such places as the Notification Center and the start menu. This makes them look more like the Start Menu tile, which has a white background of its own. BUG=722573 Change-Id: I413b89340a34f5f2700528ff058c4432feb38883 Reviewed-on: https://chromium-review.googlesource.com/1013465Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#551453}
-
David Reveman authored
Bug: 833986 Test: No delay in arc++ when adding new gamepad. Change-Id: If314b5c7af90b7c308a13abf51bff5e5d27e9b77 Reviewed-on: https://chromium-review.googlesource.com/1015550Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551452}
-
Dan Sanders authored
This enables VdaVideoDecoder to construct VDAs for all platforms except Android. Changes to enable VdaVideoDecoder on Mac are included; pass --enable-features=MojoVideoDecoder to test. Bug: 522298 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I99a37e43f7225bc11f134743b91c307f106cf7a3 Reviewed-on: https://chromium-review.googlesource.com/1011256 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#551451}
-
https://pdfium.googlesource.com/pdfium.git/+log/8cfcb7da3735..8b4a3c7ef32b $ git log 8cfcb7da3..8b4a3c7ef --date=short --no-merges --format='%ad %ae %s' 2018-04-17 tsepez Use span in CXFA_LocaleValue::GetDoubleNum() 2018-04-17 tsepez Re-land "Return pdfium::span<char> from ByteString::GetBuffer()."" 2018-04-17 thestig Add constants for PDF 1.7 spec, table 3.4. 2018-04-17 tsepez Reland "Return pdfium::span<wchar_t> from WideString::GetBuffer()."" Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I995bfe644deef92ae2e11caff4971e1606832783 Reviewed-on: https://chromium-review.googlesource.com/1015525 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551450}
-
Devlin Cronin authored
Instead of having ExtensionBrowserTest (and everything deriving from it) allow manifest v1 extensions, make ExtensionBrowserTest only allow these when the test class opts into it (via ExtensionBrowserTest::ShouldAllowLegacyExtensionManifests()). This will make it easier to chip away at these and remove usages. Bug: 816679 TBR=gab@chromium.org (trivial change in pref_hash_browsertest.cc) Change-Id: I771d5b96b96b49104cbcdd26e7b5f377c44153be Reviewed-on: https://chromium-review.googlesource.com/1014183 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551449}
-
Jay Civelli authored
Makes services/service_manager/sandbox/switches.h the only place for sandbox related switches, removing the dupped ones in content and changing all call sites. Tbr: bradnelson@chromium.org Bug: 831846 Change-Id: I08928c664e0e2340ac5168d6fd94a07bbeb81266 Reviewed-on: https://chromium-review.googlesource.com/1012986 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#551448}
-
Veranika Liaukevich authored
Change-Id: Ie559fbf3eff5e7010b8ff0728a89a49aaa200731 Reviewed-on: https://chromium-review.googlesource.com/1015282 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#551447}
-
David Reveman authored
This is only a problem if the keymap changes while the client is running. Bug: 833986 Test: weston-eventdemo Change-Id: I239870812a9c971132c331b5f3c3f257cda72547 Reviewed-on: https://chromium-review.googlesource.com/1015507Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551446}
-