- 02 Jun, 2020 40 commits
-
-
Gil Dekel authored
This CL fixes a bug in which we do not remove PrivacyScreenToastController as an observer of PrivacyScreenController during destruction. Bug: b:157775487, 1090385 Change-Id: I97f0740a2a97493750e2f751ae2eb390b743df2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225863Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#774314}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/47a3341e07d6..3fb9c1bbfb23 2020-06-02 enga@chromium.org Add warning for non-c-typedef-for-linkage 2020-06-02 enga@chromium.org Skip creating the VkImageView if the texture usage is only Copy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1064305 Tbr: cwallez@google.com Change-Id: Ib8232e6adf2acf911b79104944eec45a6dd7b00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774313}
-
Patrick Brosset authored
The new grid overlay needs to be shown only on grid container elements. The legacy one would be displayed when hovering items too. We no longer want to do this. Here are before/after screenshots taken while hovering over an element that is both a grid item and grid container. In the Before shot, you can see the parent grid being highlighted too. Not in the After shot. Before: https://i.imgur.com/lKeakiu.jpg After: https://i.imgur.com/aCZB1cT.jpg Bug: 1047356 Change-Id: I2d12fa06d7b86d5b1c19a38560b466a00d96fb32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224985 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774312}
-
Chris Lu authored
This will allow tests to create delegates with different steps. Bug: 1071914 Change-Id: Ic0d4e5d6941f2afbea51346e92dc63874bcf37f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219085 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#774311}
-
Sammie Quon authored
Its normally set on drag start for normal windows, but for snapped and maximized windows we have to update it when the window fake restores. Test: ash_unittests WorkspaceWindowResizerTest.FlingRestoreSize Change-Id: I0fae3b03ea20508d39c256f3e1abd091cef43d96 Fixed: 1084354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220873 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#774310}
-
Tomasz Wiszkowski authored
Bug: 1072528 Change-Id: I4431c7efe5f188a0729acf61c0c3bb337515bf49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225520Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#774309}
-
Patrick Monette authored
This reverts commit 9fc3225d. Reason for revert: Top crasher on canary Original change's description: > [PM] Add service worker clients to the graph > > Bug: 993029 > Change-Id: I87e33b72d6a340c48e4a9780c21de4c8693e42f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175552 > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773049} TBR=bashi@chromium.org,pmonette@chromium.org,siggi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993029, 1088353 Change-Id: I44a27a0a47278b38287d8d545334e758f3a524e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225848Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#774308}
-
Gang Wu authored
There are crashes for gfx::CreateSkBitmapFromJavaBitmap(JavaBitmap) if the JavaBitmap does not have Build#Config info. On Android O and before, MediaStore.Images.Media.getBitmap will return a bitmap without the info if the source image is gif. This CL will regenerate a new bitmap if the bitmap has no info. Bug: 1086990 Change-Id: Icb87d78a079c981270cbe57647c579f181bec5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222548Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774307}
-
Mason Freed authored
This resource file affects many tests, most of which have changes to their expectations files simply removing the console warning about the usage of Shadow DOM v0. Other small related changes in this patchset: - fast/dom/shadow/drag-and-drop-in-shadow.html had one instance of a 'content' element replaced with 'slot'. - Many tests in virtual/web-components-v0-disabled virtual suite have their expectations change to "working" because the corresponding non-virtual suite test no longer uses web components v0. Several still fail, just differently now. - Five tests in web-components-v0-only/shadow-dom-v0 were modified to point to the web-components-v0-only local copy of shadow-dom.js, instead of referring outside the web-components-v0-only tree. - One more V0-only test (events-stopped-at-shadow-boundary.html) was moved into the web-components-v0-only folder. Bug: 937746 Change-Id: I741223e1bea30e77c0d269262d0fe394b2524040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208102 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#774306}
-
Xi Han authored
Currently, typing an URL in the fake Omnibox doesn't trigger the Start Surface to hide and navigate to a new Tab when instant start is enabled. This is because the TabModelObserver is registered before the Tab State is initialized. Thus, the observer is registered to an empty TabModel, rather than the correct one. This CL caches the pending request, and registers the observer after native/Tab State is initialized. Bug: 1086608 Change-Id: I734cd9b3622f37cf672ba54a639ab8f7085ce0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218468 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774305}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f436cf84. With Chromium commits locally applied on WPT: 7e84a0aa "[scroll-timeline] Correctly handle unresolvable cases" bb592210 "Set color-scheme-senstive initial color via cascade" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia74acad978a293c2b43c2d257bc341689330c0e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225544Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774304}
-
Joshua LeVasseur authored
The rate limit was never cleared after a reboot, causing each new crash report to trigger a new rate limit and another reboot. Bug: internal b/157741351 Test: Run cast_crash_unittests Change-Id: Ic92054f3aeb5d22e8f35dbc6d744e84e7a64b015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222966Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Joshua LeVasseur <jlevasseur@chromium.org> Cr-Commit-Position: refs/heads/master@{#774303}
-
Dominique Fauteux-Chapleau authored
Bug: 1089419 Change-Id: I329cef88842bf2117c239ecb4ae0b4c6a076308d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224828Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#774302}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1591084785-a13dc6edcaafb35c86311be7a5b625cf7a7ba201.profdata to chrome-win64-master-1591113598-d5f87d5f9419962ce85d2522c87837140ef3b02f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I789ddb6e667f6f96d76bbc8387c9293a5532d4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226952Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, the service worker payment app factory in C++ depended on the payment request delegate interface, whose concrete implementation depended on the desktop Views framework, which should not be used on Android. This patch moves the references to the delegate from the service worker payment app factory into the payment request state object, which is not used on Android at this time. After this patch, it's possible to use the service worker payment app factory on Android. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1022512 Change-Id: I649673ffdfe419708d796249c68998080efaa00f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217849 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#774300}
-
Dominic Mazzoni authored
Bug: 1090378 Change-Id: Iccd269f281f228aef508c564dad91c7f38d96d2c Tbr: jinsukkim@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224026 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#774299}
-
Min Qin authored
This is not used anywhere BUG=1088729 Change-Id: I3831bce56c5817ef619c6b040f31f87e95622135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225498Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774298}
-
Tom Anderson authored
Fixes a regression introduced after [1] where Future would call OnResponseImpl() in destruction even if it was already called. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2220524 BUG=1066670 TBR=msisov Change-Id: I6c42809ec3f5973c141eb76e52650aa560fda6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227056Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#774297}
-
Brandon Wylie authored
Bug: 1088593, 1088541, 1088542, 1089641, 1089640, 1089637, 1089636 Change-Id: I6c42e7280a4f6075122123a196263713f64feb2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224256Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4b1ab5728344..a6c70741e76f 2020-06-02 peah@webrtc.org Change to using the new Ooura constructor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If8f711b3c00df7630be82c0864fa0909c10c014f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226962Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aa9d99ff6b53..2ad3dfb46bb6 2020-06-02 brianosman@google.com For custom vector/normal/position attrs, let marker ID 0 mean CTM 2020-06-02 senorblanco@chromium.org Dawn: fix MSC build. 2020-06-02 mtklein@google.com roll clang_win 2020-06-02 johnstiles@google.com Add headers to SkSL GN file. 2020-06-02 herb@google.com Remove ineffective lazy field fMetricsAndImages 2020-06-02 mtklein@google.com add Fuchsia condition results for G3 build 2020-06-02 bsalomon@google.com Remove submit from async read pixels. User must submit. 2020-06-02 geofflang@google.com Remove ES3 context requirement to use rectangle textures with ANGLE. 2020-06-02 adlai@google.com Make GrContextThreadSafeProxy not a GrContext_Base If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087118,chromium:1090019 Tbr: tdenniston@google.com Change-Id: If34b2b069ed1a84c91a2e1cecaac49b0734eb846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226960Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4391bc111097..6380ab5a1d67 2020-06-02 bmeurer@chromium.org [wasm] Display UI locations with hexadecimal pc offsets. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1071432 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7e3c12677b6ade6201c11450997274303e2c3fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226959Reviewed-by:
-
Chris Lu authored
When a WebState is detached from a WebStateList, the Overlay Presenter removes itself as the OverlayRequestQueue's delegate. If an overlay was being presented, the queue then removes the request. However, the OverlayWasDismissed() callback of the request is still executed, causing bad behavior given that the request is now null. Two new codepaths are introduced to managed this newly discovered scenario best reproduced with using the Crash Restore Infobar: 1) The presenter remains the delegate of a queue when its WebState is detached and an overlay is being presented. That way if the queue is destroyed and the requests are cancelled, | removed_request_awaiting_dismissal_| can be used to extend its lifetime until dismissal callbacks are finished. 2) If the presenter is replaced as the queue's delegate, there is no way to guarantee the validity of |presenting_request_| from then on. This can technically also occur separately from WebState detachment. Thus, upon replacement, the presenter will do early DidHideOverlay() calls, reset |presenting_request_| and mark |detached_queue_replaced_delegate_| as true so that it knows to early return in OverlayWasDismissed since the request is likely to be invalid at that point. Bug: 1071914 Change-Id: Ie7d7d7e67849323ac482b83680f7e35853b8c284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207509 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#774292}
-
Lei Zhang authored
This reverts commit e4542cf9. Reason for revert: Broke Chrome OS. Original change's description: > Use use_x11 feature when preprocessing clipboard.mojom. > > The |kSelection| enum value is only available for systems running X11. > > Bug: 676224 > Change-Id: Icdd99c86712d6127a6ae81e74d17b189073e11ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163637 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Darwin Huang <huangdarwin@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762479} TBR=dcheng@chromium.org,thestig@chromium.org,huangdarwin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 676224,1088233 Change-Id: I7ddf3dd99e78d0e5128691d3ef310d09ed848ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225846Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#774291}
-
Sergey Abbakumov authored
It's possible that a video frame mailbox is not registered in gpu::SharedImageInterface, but will be passed to ClientSharedImageInterface::DestroySharedImage which results in DCHECK() for Android MediaPlayerRenderer code path. Bug: 1075552 Change-Id: Id24245f349e61784a407b60729f82d44033843fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165738 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#774290}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/snappy.git/+log/837f38b3e0ca..f16eda346663 $ git log 837f38b3e..f16eda346 --date=short --no-merges --format='%ad %ae %s' 2020-05-21 no-reply Correct uninitialized variable. Created with: roll-dep src/third_party/snappy/src Bug: 1090173 Change-Id: I227a3b5fb6c3aff698381c66a5f997d1138a6068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225828 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774289}
-
Robert Sesek authored
It was used in Site Isolation experiments with V8's low-memory mode, but the feature did not pan out in practice. Bug: 1089520 Change-Id: Ie28ef387d5cd0ca0a5f08a6142488355eddd958d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225272Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
François Doray authored
This reverts commit 30e4bc39. Reason for revert: Suspected culprit for crbug.com/1090427 Original change's description: > dpwa: Implement backward compatibility for Bookmark Apps. > > Implement backward compatibility of Web Apps via > shadow Bookmark Apps. > > On a web app install/update/uninstall we also install/update/uninstall > the shadow bookmark app. > > Any install/uninstall changes for the extensions registry get > propagated to the sync server (syncer::ModelType::APPS) and to all > devices where BMO is disabled. > > Design doc: go/chrome-bmo-migration. > > Bug: 1020037 > Fixed: 1086909 > Change-Id: I29c673f8eb83373f4abb1d984c91e8a436d00410 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162507 > Commit-Queue: Owen Min <zmin@chromium.org> > Auto-Submit: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774134} TBR=alancutter@chromium.org,loyso@chromium.org,zmin@chromium.org Change-Id: I8e43156b19eccc9d4dd550d946e7551ade9cc54d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1020037, 1090427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226060Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#774287}
-
Regan Hsu authored
Fixed: 1070712 Change-Id: I7f3fc2c906112d615f22b8298f093cd6c02277f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225482 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#774286}
-
Ian Kilpatrick authored
Followup to: https://chromium-review.googlesource.com/c/chromium/src/+/2222621 There should be no behaviour change. Bug: 993813 Change-Id: Ic59085a9ead856cddeec0619450bc532b6878b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225755 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#774285}
-
Bill Budge authored
Bug: 1089248, 1088961, 1088962, 1088963, 1088964 Change-Id: I1aa9118cf6ce34e5cfd5a607c4ed661c80abfa35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225354 Auto-Submit: Bill Budge <bbudge@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#774284}
-
Richard Townsend authored
Use of ambiguous !IsSynchronous() lead to state confusion where the parser incorrectly switched to the foreground, budgeted mode. This was caught by the relevant DCHECK assertions. Bug: 901056, 1087325, 1087032 Change-Id: Ic765babfd21cf084d024408740514046d9d772f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224800Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#774283}
-
Anatoliy Potapchuk authored
There is no single codepath that is running diagnostic mode for kiosk, and it has not been working for more around a year and a half. Let's remove this redundant code. Bug: 1015383,932323,1077499 Change-Id: I43050f07bc100db5ea1b3612fdd322182d1dd146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218176 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774282}
-
Brandon Wylie authored
Bug: 1090031,1083917 Change-Id: Ie4096f28387f3a9214806179de5a04af06063a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225268Reviewed-by:
-
Ana Salazar authored
Set expiration date of Ash.NavigationWidget.AnimationSmoothness metrics for one year. Bug: 1089730, 1089756, 1089757, 1089758 Change-Id: I662253a28ca968e8d3588b4065755bada917352b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226918 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/aab54fd01db6..957a2359f66b 2020-06-02 jmadill@chromium.org Skip VulkanBarriersPerfBenchmark on NV/Win. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1090139 Tbr: ynovikov@google.com Change-Id: I2c3847964a807cdd355edd72a8a8c917f70989e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226887Reviewed-by:
-
Benoit Lize authored
With some configurations, DiskDataAllocator triggers DCHECK()s: - Serializing an empty file is supported by Mojo, but discouraged - Background writes need to be explicitly annotated in blink This also adds a threading restriction exception for reads on the main thread. This wasn't hit because a write always happen before a read, but is required as well. This is expected, and is covered by metrics to ensure this is not an issue in practice. Bug: 1087862, 1029320 Change-Id: I41f5fca2b9b371a6ad7b9988ba3914543bd44d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222580 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#774278}
-
David Bokan authored
The |is_composited| was added to ScrollNodes in https://crrev.com/6ce0a16d1e0 as a way to tell which ScrollNodes are able to scroll directly on the compositor by changing the transform tree. When the scroll unification flag is turned on, scroll nodes without this bit set avoid mutating the transform tree and instead rely on a commit from the main thread for a scroll to be realized. PropertyTreeBuilder creates property trees for the UI compositor and some tests based on the layer tree. The CL above did not update this method of tree generation to set this bit. Since the nodes are built from layers, all nodes should be considered composited in this case. This change fixes tests when the scroll unification flag is turned on. Bug: 1086625 Change-Id: I3a3552a5c17f1f69e038657c1f267b2a61f7a070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222892 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#774277}
-
Jarryd authored
Change-Id: I2c7df80c038104c8c19e9d70e2b75ca0d8acedfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225837 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Mark Yacoub authored
Encapsulate {id, mode and origin} into a single struct that is passed through Mojom. The intention is to use a vector of the structs of the multiple displays that will be configured together. BUG=1082882 TEST=no changes in modesetting any device Change-Id: I932b7bae16670a3eff55f2666ce1096c8a4b8a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202876Reviewed-by:Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#774275}
-
