- 12 Jul, 2017 40 commits
-
-
Vaclav Brozek authored
Most of setting headers in the passwords seciton on iOS already use Title Case, except for the headers of the saved and blacklisted lists of passwords. This CL fixes that by creating new strings for iOS settings inside ios/chrome/app/strings/ios_strings.grd. Previously the code used shared strings from the password_manager component (components/password_manager_strings.grdp). That string was also used by the old (non-MD) desktop settings, which have already been deprecated. The MD settings on desktop use the Title Case as iOS should as well, but the MD settings strings are consistently saved in chrome/app/settings_strings.grdp, where they cannot be shared with iOS. The CL creates the new string instead of sharing the one from MD settings, because sharing has no benefit (on no build both strings are included, so no storage spared) and has the drawback of binding the style of both strings forever together. The CL does not remove the component string yet. The old desktop settings code is still in the codebase, and the shared string (used only by the old settings) should be deleted once those old settings are deleted. The CL was approved in https://chromium-review.googlesource.com/c/567181. This is a verbatim copy of that CL, but re-uploaded after Gerrit issues prevented me to actually land the original one. Hence I'm TBR-in lpromero@ who approved the original. TBR=lpromero@chromium.org Bug: 740952 Change-Id: I455b8f2a5edd1089916a7b87f20eddc3b274a2b7 Reviewed-on: https://chromium-review.googlesource.com/567930Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#485912}
-
arthursonzogni authored
This CL removes |throttles_to_register| and introduces |AddThrottle()|. This will be easier to know understand in which order the throttle are inserted into |throttle_|. Some throttle were not inserted in the right order. AncestorThrottle and MixedContentThrottle for instance. BUG=733099 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2967363002 Cr-Commit-Position: refs/heads/master@{#485911}
-
aberent authored
Revert of Fixes redirects to external apps when navigating from PWA. (patchset #9 id:280001 of https://codereview.chromium.org/2969143002/ ) Reason for revert: Test failures from new test WebappNavigationTest#testNewTabLinkToExternalApp on hromium.android/Marshmallow 64 bit Tester. BUG=741568 Original issue's description: > Fixes the redirect to external apps when navigating from PWA. > > This is done with avoiding explicit chrome package name (using > component name instead) and using > EXTRA_SEND_TO_EXTERNAL_DEFAULT_HANDLER on the intent. > > With this patch the redirect works, however it takes a long time for CCT to > consult ExternalNavigationHandler. This results in suboptimal UX. Same redirect > in ChromeTabbedActivity is almost instantaneous. Result is that > for _blank links CCT shows up briefly before redirecting to an external app. > In a follow up it should be investigated why it is the case and if it cannot > be improved, we might need to bypass CCT in such case, which would diverge > from existing navigation paths for _blank links in Clank. > > BUG=740402 > > Review-Url: https://codereview.chromium.org/2969143002 > Cr-Commit-Position: refs/heads/master@{#485831} > Committed: https://chromium.googlesource.com/chromium/src/+/727468b41b2fe48bf73983ab0c3aa2632b47d89e TBR=dominickn@chromium.org,yusufo@chromium.org,tedchoc@chromium.org,piotrs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=740402 Review-Url: https://codereview.chromium.org/2975883003 Cr-Commit-Position: refs/heads/master@{#485910}
-
lizeb authored
Also removes Context -> Application downcasts in callers. Review-Url: https://codereview.chromium.org/2966193002 Cr-Commit-Position: refs/heads/master@{#485909}
-
tzik authored
This CL refactors AtomicSequenceNumber to adopt <atomic>, and removes StaticAtomicSequenceNumber, which is no longer needed after C++11. Change-Id: Ia061cd4af76bbd630dc6fbc0e791b11013b0cd67 Reviewed-on: https://chromium-review.googlesource.com/566979Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#485908}
-
Hector Dearman authored
Part of a refactoring to split the OS dumps out of the process memory dumps. Bug: 718809 Change-Id: Ia76a5d0ba3f2d907db5bf92bac830b9e7e3223be Reviewed-on: https://chromium-review.googlesource.com/544881Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Hector Dearman <hjd@chromium.org> Cr-Commit-Position: refs/heads/master@{#485907}
-
mmenke authored
It was jumping back to the UI thread and back because the PrefProxyConfigTracker required it. Now that that's no longer the case, get rid of the extra thread hops. The same thing has already been done to chrome/'s IOThead. BUG=734199 Review-Url: https://codereview.chromium.org/2943783002 Cr-Commit-Position: refs/heads/master@{#485906}
-
David Reveman authored
Make sure overlay damage is updated correctly for fullscreen and translucent overlays. BUG=705290 TEST=cc_unittests --gtest_filter=*Overlay* Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I83c80ddb47495e185fc247c93e71aeb230504cb4 Reviewed-on: https://chromium-review.googlesource.com/558508 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#485905}
-
Daniel Bratell authored
Having two sets of templates named ToElement caused compilation failures when both templates were visible to the compiler at the same time. Since one of the templates doesn't benefit from being a template this patch renames it and makes it an ordinary function. R=fs@opera.com, tkent@chromium.org Bug: 738389 Change-Id: Ia6247ad0f794cc4094f3f73cd7492ad5d94407c2 Reviewed-on: https://chromium-review.googlesource.com/567141Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: bratell at Opera <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#485904}
-
Yoshifumi Inoue authored
This patch changes "editing/selection/select-bidi.html" to use |assert_selection()| for improving readability. Bug: 230267, 679977 Change-Id: I9d6c40660ee3c1e2c14748989e90cd6543743cf2 Reviewed-on: https://chromium-review.googlesource.com/566792Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485903}
-
Michael Achenbach authored
This reverts commit 4053f7ad. Reason for revert: V8 bot was not obsolete (obsolete name maybe). Why was it deleted? It is part of the V8 CQ. https://crbug.com/741505 Original change's description: > Clean up //testing/buildbot/*.json files to remove obsolete builders. > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I0b58757a8c56cf1ae9a5ba82fe2d485651f3c52e > Bug: 662541 > Reviewed-on: https://chromium-review.googlesource.com/558381 > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485851} TBR=phajdan.jr@chromium.org,dpranke@chromium.org,kbr@chromium.org,martiniss@chromium.org Change-Id: I056aa71fcae296adc08aa4baf7f2f465d2e1511c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 662541,741505 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/566961Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#485902}
-
Gregory Chatzinoff authored
Add edchin@ and gchatz@ as owners of the badge view files within the reading list directory. Bug: none Change-Id: I4eace37f01184d72a838c519f06cb848e50391bb Reviewed-on: https://chromium-review.googlesource.com/567798Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#485901}
-
Mythri Alle authored
After the fix to V8 (https://chromium-review.googlesource.com/c/563301/) the following tests should not fail anymore. deqp/functional/gles3/texturefiltering/* deqp/functional/gles3/textureformat/* deqp/functional/gles3/textureshadow/* deqp/functional/gles3/texturespecification/* Bug: chromium:725664 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I66255692b1c3a763a3cb1ccb087d00b7c1828328 Reviewed-on: https://chromium-review.googlesource.com/552551Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#485900}
-
yoshiki iguchi authored
Bug: none Change-Id: I48da5486779d4874a75d573b09c79b503925d992 Reviewed-on: https://chromium-review.googlesource.com/567900Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#485899}
-
Jia authored
ConsumeShorthandVia2LonghandAPIs is a modified version of Consume2Values of CSSPropertyParser. The difference between the two is that the new version expects component longhands to have API impl already as it will forward parsing logic to component longhands API via ParseLonghandViaAPI. Consume2Values will be deprecated soon, when shorthand properties are ribbonised (i.e. have their own APIs). Until then, there is a slight code duplication between the two versions, see crrev.com/c/564875 for discussions why it is necessary. In addition to ConsumeShorthandVia2LonghandAPIs, the cl also contains the following * Implement API for shorthand property scroll-padding-block as a use case of ConsumeShorthandVia2LonghandAPIs. * Change ConsumeShorthandVia4LonghandsAPI to ConsumeShorthandVia4LonghandAPIs. - Also updated "margin" API to reflect the naming change. Bug: 668012 Change-Id: I45d1f5177c5ff3f381a24085ecde0647c5e08baf Diff: https://gist.github.com/a54354ab973c928d2717251b56caeb57/revisions Reviewed-on: https://chromium-review.googlesource.com/565662Reviewed-by:
meade_UTC10 <meade@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#485898}
-
Mihai Sardarescu authored
This CL removes the usage of the Google password from sync as discussed over email. Email from zea@: "That's all legacy code really. It's only used for people with very old sync accounts that might still be based on their GAIA credentials, and should only be used once as we'll immediately transition that account. I'm fine with removing that logic." This CL also removes the usage of password from ChromeOS (and the method RefreshSpareBootstrapToken), as GoogleSigninSucceeded method is only called by SigninManager (not from SigninManagerBase) that is not used on ChromeOS. Bug: Change-Id: I43d5cdf38d5b9ff97f13e31b5c2069203a803565 Reviewed-on: https://chromium-review.googlesource.com/565512Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#485897}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f2c153fc..6c835897 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I519ce32c7724b1e98dc773e289ea405a52ae73be Reviewed-on: https://chromium-review.googlesource.com/567631Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#485896}
-
hugoh authored
Background: - When the GPU thread is *in-process* it runs inside the browser process. - GpuChildThread is a ChildThreadImpl and a IPC::Listener. - When GpuChildThread sees an error (or shutdown) of its IPC channel, it quits its message loop (= stops the thread). Problem: The browser process' IOThread calls InProcessGpuThread::StopSoon() while the in-process GPU thread destructs itself. When InProcessGpuThread::StopSoon asks for task_runner() the in-process GPU thread has - sometimes - already destructed itself and its MessageQueue. The IOThread then sees task_runner() == null and crashes: [FATAL:ref_counted.h(484)] Assert failed: ptr_ != nullptr. 0 base::debug::StackTrace::StackTrace() 1 base::debug::StackTrace::StackTrace() 2 logging::LogMessage::~LogMessage() 3 base::Thread::StopSoon() 4 base::Thread::Stop() 5 content::InProcessGpuThread::~InProcessGpuThread() 6 content::InProcessGpuThread::~InProcessGpuThread() 7 content::GpuProcessHost::~GpuProcessHost() 8 content::GpuProcessHost::~GpuProcessHost() 9 content::BrowserChildProcessHostImpl::TerminateAll() 10 content::BrowserProcessSubThread::IOThreadPreCleanUp() 11 content::BrowserProcessSubThread::CleanUp() 12 base::Thread::ThreadMain() 13 base::(anonymous namespace)::ThreadFunc() Solution: If a thread runs in the browser process, only Thread::Stop should stop its message loop. Otherwise, QuitWhenIdle could race Thread::Stop. BUG=258935 Review-Url: https://codereview.chromium.org/2973723003 Cr-Commit-Position: refs/heads/master@{#485895}
-
Christopher Cameron authored
This matches the behavior of --force-device-scale-factor. Move the checks for "is the color profile forced" from the implementation of ICCProfile::FromBestMonitor to the call sites to avoid layering violations. Bug: 740663 Change-Id: I8f37b8b5ca6300465a1e7e0132e587378805a813 Reviewed-on: https://chromium-review.googlesource.com/565763 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#485894}
-
Hiroshige Hayashizaki authored
As a result of centralizing script execution and load/error event dispatching into ScriptLoader::ExecuteScriptBlock(), ExecuteScript(), DispatchLoadEvent() and DispatchErrorEvent() are now called only from ScriptLoader. Bug: 686281 Change-Id: I47f7b1c0d79d9d7bc586cb02028d72260f20be7b Reviewed-on: https://chromium-review.googlesource.com/557383 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#485893}
-
tzik authored
This is a generated CL to rewrite base::Bind to base::BindOnce where the result of base::Bind is immediately converted to OnceCallback. E.g.: base::PostTask(FROM_HERE, base::Bind(&Foo)); is rewritten to: base::PostTask(FROM_HERE, base::BindOnce(&Foo)); An explainer of OnceCallback is available here goo.gl/YZiUL1. The rewriting tool is in //tools/clang/base_bind_rewriters. To build and run locally, follow //docs/clang_tool_refactoring.md. This conversion makes almost no behavior change except that a bound objects are passed-by-move to the target function. Bug: 554299, 714018 Change-Id: Ief819fd7850d61a377300d61fd5a317104084c77 Reviewed-on: https://chromium-review.googlesource.com/547179Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#485892}
-
Takashi Toyoshima authored
Now that ResourceLoadScheduler depends on WebFrameScheduler, and it is useful to enable ResourceLoadScheduler even on platform unit tests, let's introduce a simple mocked WebFrameScheduler that allows calling MockFetchContext::GetFrameScheduler(), and use it to call {Add|Remove}ThrottlingObserver() for testing. This also makes it possible to remove the test-only purposed GetTaskRunner() method from the MockFetchContext, and makes FetchTestingPlatformSupport consistent in terms of Blink scheduler. Bug: 729953 Change-Id: Ib5ab2ad1c5b6ce2b4267667ad0b0cacbb1cc8f17 Reviewed-on: https://chromium-review.googlesource.com/563216 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#485891}
-
kojii authored
This patch fixes two issues in NGInlineNode::ComputeMinMaxContentSize() 1. The max-content algorithm was incorrect. Fixed to compute the max of line widths when available width is infinite. 2. Negative text-indent can make min > max. CSSWG test indicates we should take min of the two values in the case. BUG=636993 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2974823004 Cr-Commit-Position: refs/heads/master@{#485890}
-
kojii authored
This patch computes baseline from fragment tree. Design doc: https://docs.google.com/a/chromium.org/document/d/1ukrQxkSKMuU1lW2XaQMzgRlsurBjkxZxAq028EbhFjo/edit?usp=sharing BUG=636993 Review-Url: https://codereview.chromium.org/2867293002 Cr-Commit-Position: refs/heads/master@{#485889}
-
Kent Tamura authored
This behavior is similar to the current behavior on macOS. Note that Windows and Linux have height and width grow animation from the center of a bubble, and Android has no animation. Bug: 739091 Change-Id: I771b1f22ba503287222e91919afa1c2853aea940 Reviewed-on: https://chromium-review.googlesource.com/567616Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#485888}
-
dougt authored
This CL switches accNavigate completely over to the AXPlatformNode code. It also moves the table handling code from BrowserAccessibility to AXPlatformNodeBase. BUG=703369 Review-Url: https://codereview.chromium.org/2964313002 Cr-Commit-Position: refs/heads/master@{#485887}
-
Sergey Ulanov authored
Updated version now builds on Fuchsia. There are no other changes. Bug: 737802 Change-Id: I134248a719aaea783349ec3f6a663bde1a82ec30 Reviewed-on: https://chromium-review.googlesource.com/567024 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#485886}
-
tzik authored
media::BindToCurrentLoop used to be unable to handle move only type, so its user needed to make custom ones, which are no longer needed since m::BTCL can handle move-only types after http://crrev.com/2b817313110d5178. Change-Id: I6287a3ac8f29a15d9d915a2b3b74e6da6de49f9b Reviewed-on: https://chromium-review.googlesource.com/567614 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#485885}
-
David Reveman authored
This reverts commit c3dec2b9. Reason for revert: Last version of patch broke ARC++ import of all buffers Original change's description: > gpu: Fix FD leak when importing DMA-bufs with multiple FDs. > > CreateFromHandle is expected to take ownership of all FDs so > when passed multiple FDs we need to make sure they are closed > if not used. > > BUG=b/63409814 > TEST=exo_unittests --gtest_also_run_disabled_tests --gtest_filter=DisplayTest.DISABLED_CreateLinuxDMABufBuffer > > Change-Id: I2a8a7b0149a08f08890a725c6ce9aff8aeaab97f > Reviewed-on: https://chromium-review.googlesource.com/566879 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Commit-Queue: David Reveman <reveman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485761} TBR=reveman@chromium.org,dcastagna@chromium.org Change-Id: Idad3a18398c1c1ce959bff646f83d607b9e3c2c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/63409814 Reviewed-on: https://chromium-review.googlesource.com/566863Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485884}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/d96ed9d0def2..c4176a2fa5aa $ git log d96ed9d0d..c4176a2fa --date=short --no-merges --format='%ad %ae %s' 2017-07-11 fmalita Always use raster pipeline for perspective 2017-07-12 fmalita Revert "Experimental blur code." Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ic1fc51b3f2a09bbcef13fc29f292722dd04915c7 Reviewed-on: https://chromium-review.googlesource.com/567864Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485883}
-
Gabriel Charette authored
And cleanup MachineIdProvider to be a free function (making it clear that this is fine to call in an unsequenced task while cleaning up issue 354882). TBR=thestig@chromium.org (chrome_browser_main.cc side-effects) Bug: 689520, 354882 Change-Id: Iac7d683c2e74c6c6b865110033b669584277f92a Reviewed-on: https://chromium-review.googlesource.com/545158 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#485882}
-
Yoshifumi Inoue authored
This patch gets rid of |SelectionTemplate::granularity_| since it is always |TextGranularity::kCharacter| since the patch[1] for improving code health. This patch also renames |SelectionTypeWithLegacyGranularity()| to |Type()| since |SelectionTemplate| doesn't have granularity any more. [1] http://crrev.com/2970043002: Simplify SelectionController::UpdateSelectionForMouseDrag() Bug: 692923 Change-Id: Ic58dfcf8eef7f7fe2121df27b5639d98da16986d Reviewed-on: https://chromium-review.googlesource.com/567781Reviewed-by:
-
Wez authored
This is a reland of 45df4f39 Original change's description: > Fix threading in FileDescriptorWatcher and MessagePumpLibevent tests. > > Changes to MessagePumpLibevent & tests: > 1. Add an explicit wait for thread start-up to TestWatchingFromBadThread, > which was not updated when the base::ThreadStart() call was changed to > not wait for the thread startup to complete. > 2. Reinstate TestWatchingFromBadThread on all libevent platforms. > 3. Add sanity-check tests for readable/writable notifications. > 4. Clean up some .get()s and add some DPLOGs. > > Changes to FileDescriptorWatcher & tests: > 1. Add a DLOG_IF() to StartWatching, to make it easier to spot > WatchFileDescriptor failures. This can't be a DCHECK or CHECK, since the > StartWatching operation is racey with file-descriptor close() on the > calling thread. > 2. Fix the test fixture to Stop() |other_thread_| to ensure it is done > working before we tear down the test file descriptors. > 3. Fix the WatchWritable test to request write notifications for the > correct end of the pipe (since pipe()s are uni-directional). > > Bug: 138845,740692 > > TBR=dcheng,fdoray > > Change-Id: I86bdd100561fbc56c1e6291216cafc3168b185dc > Reviewed-on: https://chromium-review.googlesource.com/565227 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485822} TBR: dcheng, thakis Bug: 138845, 740692 Change-Id: Ibc6e48316351b311bfa06727964bbcf4cf5e699b Reviewed-on: https://chromium-review.googlesource.com/566840Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#485880}
-
Evan Stade authored
Bug: 736539 Change-Id: I7ae1d4f48f613fb5b2526755d7282ced7f424b23 Reviewed-on: https://chromium-review.googlesource.com/567200Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#485879}
-
Jia authored
Implement parseShorthand for -webkit-border-[start|end|before|after], -webkit-text-stroke and outline. All these shorthand properties call the same helper function ConsumeShorthandGreedilyViaLonghandAPIs. Hence these properties are grouped in one cl. Bug: 668012 Change-Id: I4341dd88c9e69ef0105846094324f673adffa967 Diff: https://gist.github.com/56c80c6712e00d58983a557381f20664/revisions Reviewed-on: https://chromium-review.googlesource.com/567605Reviewed-by:
Suzy Howlett <suzyh@chromium.org> Reviewed-by:
-
Eric Roman authored
Bug: 740871 Change-Id: I8571bf9448da2a257c45da7f1943226095ab08b7 Reviewed-on: https://chromium-review.googlesource.com/567638 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485877}
-
Tsuyoshi Horo authored
I removed the UMA (ServiceWorker.NavigationHintPrecision) when we stopped "Speculatively start Service Workers on UI-events" experiment (crbug.com/616502). But we will start "Warm-up service worker on omnibox signal" experiment (crbug.com/732681). So this CL revive the UMA as ServiceWorker.StartHintPrecision. Bug: 740102 Change-Id: I84034f9a3c8edb9ff25e5644d6b94c624ae00f1c Reviewed-on: https://chromium-review.googlesource.com/566138 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#485876}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4f9afdad..f2c153fc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I1bb1a398e0422df6ab613f7de030a5a6b3d23fe5 Reviewed-on: https://chromium-review.googlesource.com/567709Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This flag will be used to develop new windowing related behavior for Desktop PWAs. Bug: 729923 Change-Id: I594eadbdf9f00928e9c1963f510e4b7c7b7788f7 Reviewed-on: https://chromium-review.googlesource.com/566263 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#485874}
-
Makoto Shimazu authored
This is 4th patch of script streaming project split off from https://chromium-review.googlesource.com/c/538477. This patch adds Mojo's interface to stream installed scripts to the renderer during launching up. This patch implements: - WebServiceWorkerInstalledScriptsManagerImpl::Internal as a receiver of streamed scripts which lives on the io thread on the renderer - ServiceWorkerInstalledScriptsSender as a sender of installed scripts on the browser process Bug: 683037 Change-Id: I6d7ae63aea670c37fe00c0c81afceb71dd70c62a Reviewed-on: https://chromium-review.googlesource.com/558529Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
