- 12 Aug, 2020 31 commits
-
-
Noel Gordon authored
Test files come from //media/test/data. Change apitest C++ to copy the files to the 'testing' Volume before starting tests. id3_png_test.mp3: audio file with embedded album artwork image 90rotation.mp4: h264 video, with 90 degree rotation, no images Add test JS helpers to read the files from the 'testing' volume / file system and convert them to Blobs before starting the tests. Add fileManagerPrivate.getContentMimeType mime sniffing tests: testGetContentMimeTypeEmpty - input is an empty blob, returns undefined mimeType result testGetContentMimeTypeImage - input is an image file blob, sniff image/gif testGetContentMimeTypeAudio - input is an audio file blob, sniff audio/mpeg testGetContentMimeTypeVideo - input is a video file blob, sniff video/mp4 testGetContentMimeTypeUnknownMimeTypeError - net::mime_sniffer fails, sets chrome.runtime.LastError Add fileManagerPrivate.getContentMetadata metadata extraction tests: testGetContentMetadataEmpty - input is an empty blob, returns undefined MediaMetadata testGetContentMetadataAudioTags - extract tags only into the MediaMetadata result - vet result with JS verifyExpectedAudioMetadata() helper testGetContentMetadataAudioTagsImages - extract tags and images into the MediaMetadata result - vet result with JS verifyExpectedAudioMetadata() helper testGetContentMetadataVideoTagsImages - extract tags and images into the MediaMetadata result - vet result with verifyExpectedVideoMetadata() helper testGetContentMetadataRetainsInputMimeType - input mime type is copied through to MediaMetadata.mimeType testGetContentMetadataVideoResetsAudioMime - audio mime is changed to video if there is width and height testGetContentMetadataUnsupportedMimetypeError - input mime not video or audio, sets chrome.runtime.LastError Bug: 1114622 Change-Id: Ic96ce7faa409ae25d6b3c956666bbfd7db362f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345936 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797078}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/398a874c9b85..48d951e22d45 2020-08-11 jmadill@chromium.org Perf Tests: Handle logError callback. 2020-08-11 ianelliott@google.com Vulkan: tell ContextVk when swapchain is re-created 2020-08-11 jmadill@chromium.org Vulkan: Optimize resource tracking in CommandBufferHelper. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: angle_perftests, *vulkan_null_index_buffer_changed_ushortTest: Test: run_angle_perftests --gtest_filter=TracePerfTest.Run/vulkan_angry*:*vulkan_candy* --verbose --local-output Change-Id: I62339c4f81491850d3cea67ad134c5eb50b62b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350489Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797077}
-
Xiaocheng Hu authored
After launching crbug.com/1040632, we disallow a 'font-display:optional' font from being used if it doesn't load before the first rendering cycle begins, so that it won't cause any relayout. This turns out to be too stringent. This patches allows using the font as long as we have never rendered fallback for it. In this way, we still guarantee no layout shifting, and the font can be used in more circumstances. Bug: 1114314 Change-Id: Id521e97b8882e2e3d1fb13c09e040c8e2fd3d47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343643 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#797076}
-
Maciej Malinowski authored
The MemoryDumpMapConverter is converting between the Chromium type MemoryDumpMap and Perfetto RawProcessMemoryNode. Using this class it is possible to process produced in Chromium MemoryDumpMap by Perfetto GraphProcessor. See crbug.com/1095982 for more details. Bug: 1095982 Change-Id: If7e852017c8efa51cd99b4f648c4a32e8fe0b8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299223 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#797075}
-
Nate Fischer authored
No change to logic. This exposes gpu_switches to Java with java_cpp_strings. Fixed: 1112006 Test: autoninja -C out/Default system_webview_apk Change-Id: I84fb22671a6ce42c288b2772f3d49722ccc79f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343776 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797074}
-
rajendrant authored
Change-Id: I4d74b36ecce4a905aa3ef922cd71080651fa7a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349987Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#797073}
-
James Hollyer authored
The capture region that held the mouse inside the chrome window was the full size of the window. This caused issues while when the invisible mouse hit the edge of the window it could fire certain events and cause strange things to happen. For example the linked bug discusses an "x" appearing when you are also in fullscreen. There are also some dual monitor setups that have consistently proven that the mouse moves just out of the window and onto the other monitor while in fullscreen. To solve this this CL is adding a 5 pixel border to the edge of the capture region to give some wiggle room for the small Windows errors and to stop events from firing when the mouse hits the edge of the window. Bug: 1107507 Change-Id: Ia2314f7726b5a18d96800a9efcd990bace564ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343005 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#797072}
-
Sophey Dong authored
Screenshots: http://dr/file/d/1IZSgjgsQ-scrCra7BLA1eM1JTpVo3YPO/view http://dr/file/d/10QwrglqYlD0dgtnhE33-43mq-cuAFFzj/view Bug: 1112882 Change-Id: I26afb6efef56d02ca19a0ea274ce2dd71d9c3331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343783Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#797071}
-
Ce Chen authored
suggest Incognito feature launch. Note we intended to share these params across non-Incognito & Incognito features, but now find out this is not supported by Finch. Bug: 925072 Change-Id: Ib43e8f4f6cc3124871beb7c68aa47b42bef1d480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346691Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#797070}
-
Jeremie Boulic authored
When a mounting operation failed for an archive, we displayed the errors in a dialog: - as part of the error message, the raw error code was included, without translation. - only one error dialog could be displayed at a time. We're now using visual signals instead. Bug: chromium:1058689 Change-Id: I789663d226c5376db0327b809d9e39af1289ca4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336096 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#797069}
-
Nate Fischer authored
No change to logic. This updates commandline-flags.md to explain switches are now autogenerated with java_cpp_strings. This is a follow-up to https://crrev.com/c/2343951. Bug: 956803 Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ic808e5301a57681246fd98910cf76c4f805b5f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350392 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
-
Toni Barzic authored
The app menu command may end up deleting the menu adapter, so it's not safe to use AppMenuModelAdapter after a context menu command execution is done. For example, if the menu is shown for app list search result, executing the command may open an app window, causing the app list to close and reset the search state. This may delete the search result that owns the adapter. In this case, attempt to record the execution histogram after ExecuteCommand will crash calling GetCommandIdForHistograms, which has been made virtual in CL:2258902. This changes AppMenuModelAdapter::ExecuteCommand to record the execute command histogram before executing the command. Also, removes RecordExecuteCommandHistogram from AppListMenuModelAdapter::ExecuteCommand - this calls into the base implementation in AppMenuModelAdapter, which records the same histogram. BUG=1115020 Change-Id: I4231f1b15404405891f392c0c2e4628ba9673efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350235Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797067}
-
Ali Juma authored
This CL initializes SafeBrowsingServiceImpl's SharedURLLoaderFactory in Initialize(), rather than two thread hops after Initialize(). This ensures that GetURLLoaderFactory() has a non-null return value when called shortly after Initialize(). This fixes crashes that occur when CreateUrlChecker() is called soon after Initialize(), resulting in the creation of a RealTimeUrlLookupService that has a null URLLoaderFactory and crashes when it tries to use it. Bug: 1114706 Change-Id: I9142c82979954a272f351c14db20246730f720db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346862 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#797066}
-
Raymond Toy authored
Move the core routine that handles the complicated case where the play back rate is not 1 or interpolation/extrapolation is needed. Then break out that routine into two new routines for computing the indices and for computing the output so that we can optimize each independently. A slight function difference occurred because we changed the interpolation formula from using (1-f)*x0+f*x1 to x0+f*(x1-x0). This is mathematically equivalent and but not in floating point. This shows up in the one test needing the threshold to be updated slightly. Bug: 1104371 Change-Id: Id299fb9471d01edad8d9c9da73084af9a53533f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342136Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#797065}
-
Marc Treib authored
Bug: 1113713 Change-Id: Ibcaf5cb39b4f7b961847219547e61adc87608083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345310 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#797064}
-
Wenhan (Han) Zhang authored
Second step in migrating to a more flexible histogram naming syntax using tokens and variants and instead of suffixes. Changed another histogram to using token instead of suffixes where the suffixes group is obsolete. Made corresponding changes and tests in the model and extract_histograms.py. Change-Id: I3dfb389633e5d90b79e64a1dfb9d46a8fce88d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334586 Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#797063}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a70445f40898..4ed6947787e7 2020-08-11 johnstiles@google.com Avoid recomputing the input texel colors in Processor tests. 2020-08-11 scroggo@google.com GrVkTypes: Change externalFormat to be uint64_t 2020-08-11 mtklein@google.com add SkRRect::readFromMemory() fuzzer 2020-08-11 mtklein@google.com robustify SkScaleToSides::AdjustRadii() 2020-08-11 johnstiles@google.com Update the inliner's variable mapper to use unordered_map. 2020-08-11 jlavrova@google.com ICU: SkShaper (bidi iterator only) 2020-08-11 elliotevans@google.com Add path rendering performance demo to demos.skia.org 2020-08-11 adlai@google.com Reland "Migrate MakeCrossContextFromPixmap to GrDirectContext" 2020-08-11 johnstiles@google.com Add `dumpTreeInfo` debug method to GrFragmentProcessor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: Iba5b49a306952acd808053089060004eedbfb186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349927Reviewed-by:
-
James Hollyer authored
Microsoft Surface Type Cover (https://www.amazon.com/Microsoft-Type-Cover-Surface-Pro/dp/B0163H1HT6) is being registered as a gamepad. This CL blocks that device. Bug: 1114707 Change-Id: Ia249af1b2e310fa45f35a8567a183ede5828473f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350307 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#797061}
-
Tommy Li authored
This is a trivial CL that just sets oft=2 for on-clobber ZeroSugest requests. I had originally thought that maybe we would want to add a feature flag that makes it still send oft=1, but now I think that would just be confusing, and it would be better to quickly update the server-side to properly handle both oft=1 and oft=2. As a first pass, they could just be treated the same. Bug: 1106096 Change-Id: Idcbfc55e164865d10a000b62a585898bbf9c20d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350308Reviewed-by:
-
Matt Menke authored
I did this in components/error_page in an earlier CL, but forgot to update this one. Change-Id: I6bfbb0b906e5a1b259ba7644c2e63abf202435e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350801Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#797059}
-
Kenichi Ishibashi authored
Resource purging logic will be moved to the Storage Service. As a preparation, this CL moves PurgeResources() call from ServiceWorkerRegistry::DidDoomUncommittedResourceIds() to ServiceWorkerStorage. This CL also make DoomUncommittedResources() private as it is only used from ServiceWorkerRegistry. Bug: 1055677 Change-Id: If62c038ab4c272d9fa28862285cdf500f7b47ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342529Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797058}
-
nancylingwang authored
When the system is migrated from the adaptive icon disable to enabled, all ARC apps request the foreground and background icon files, to generate the adaptive icons. And it might take long time to load ARC icons. Modify ArcAppIcon to temporarily load the adaptive icon from the old file path if the foreground file doesn't exist, and still call arc prefs to request the adaptive icon files. Add the test case and the default app(test app3), which has the old icon file only, to verify the icon can be loaded. BUG=1083331 Change-Id: Icb848c53f9ba36d1af62e55cfcb7b1d9565b092b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344437Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797057}
-
Carlos IL authored
Enabling kHideSteadyStateUrlPathQueryAndRefOnInteraction caused the URL to be misaligned due to a problem with how the display rectangle was calculated in OmniboxViewViews::ShowFullURLWithoutSchemeAndTrivialSubdomain, this CL fixes that issue Bug: 1114332 Change-Id: Id716ea84248f568c3fe6dc5f007631ac7c64edc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343872Reviewed-by:
-
Leonid Baraz authored
Fake implementation and unittests are provided, real implementation will follow. Bug: b:153649905 Change-Id: I00972b8a5e15b98ff21f6cc70ab4a6c31e6d9848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302881 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#797055}
-
Chris Hamilton authored
This adds a generic variant-based token accessor to the root scope for all workers. This simplifies the downstream code that measures V8 memory usage per worker, allowing it to be agnostic of the worker type. BUG=1085129 Change-Id: Iff7500d69065fe3428acea72b2323f46a785b261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341148Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#797054}
-
Thomas Guilbert authored
This CL turns on support for AAudio by default, for Q+ Android devices (SDK level 29). The UseAAudioDriver experiment has shown no noticeable differences in stability between the enabled and control groups. There have been positive reports from users experiencing better Bluetooth A/V sync when manually turning on the flag. OpenSLES is being deprecated. It's time to make the switch and give a better experience to users whose phones have stable enough support for AAudio. Bug: 1008642 Change-Id: Ibd3137aaa2b0114cb5e069421a559f3001dbc2db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350306Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#797053}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0376edf14e58..f07b5182eeda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id5ca7d0d27ac94dcd16b5d8c094991b0ef577a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350304Reviewed-by:
-
Zach Trudo authored
UploadClient handles uploading records. Bug: chromium:1078512 Change-Id: I76d3d23cabdb14c7a02b666daed094e8b57f1869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316688 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#797051}
-
Oksana Zhuravlova authored
This change implements RemoteObjectInjector#renderFrameCreated to inject all requested objects into a newly created frame. To get the RenderFrameHost from render process id and frame id, a new WebContents JNI method is exposed. Bug: 1105935,1107555 Change-Id: I3b9119deb64c75550f41a4aeab81ced245613a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337498Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
-
Peter Kasting authored
Also fix more overflow cases so these new tests pass. Also add a bit of coverage in safe_numerics that looked omitted. I think I originally found this while implementing some of the TimeDelta stuff another way but it's been several weeks and I can't recall :/ Bug: none Change-Id: I53beffb241f5f2e122ad777f576ad9f93dc62af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344816Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797049}
-
Scott Haseley authored
If a postTask task throws an error, the associated promise is rejected with the error. Previously, the error would also be propagated to the global error handler leading to errors being reported even if the promise rejection was handled. This CL suppresses that propagation, resulting in errors being reported to the global error handler only if the rejected promise is not handled. Bug: 979017 Change-Id: Ibbafaf8bd370b05a10f48cb5a122c8411305aadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350113Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#797048}
-
- 11 Aug, 2020 9 commits
-
-
Tomasz Wiszkowski authored
This change ensures that the server-supplied default visibility hint for suggestion groups is respected on Android. Suggestion groups will appear collapsed if the server hints their initial state should be hidden. The change also repurposes (and subsequently renames) AutocompleteResult's GroupHeaders as GroupsDetails. Bug: 1113931 Change-Id: Ib9214eecf8f3939bb08098a05180281ecf20f21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341822 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#797047}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/72ea2ee4650f..afbc899f2ff2 2020-08-11 capn@google.com Implement VK_EXT_depth_range_unrestricted If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie3bce052897f22bb35ed2cb378f861b573250b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350012 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Sven Zheng authored
For the last 10 jobs, two failed: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/883? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/881? Bug: 1111979 Change-Id: Ia061c5d5111f0dd77be5603c9a994f8cb5536cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350487 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#797045}
-
Daniel Rubery authored
This CL lands new strings that may be used for Advanced Protection Program users to send their downloads for deep scanning: "file.exe is unknown. Advanced Protection recommends sending this file to Google for scanning." as well as changing the button from "Send" to "Scan" Screenshot: https://screenshot.googleplex.com/Mh8PfqxvHMy.png Bug: 1115142 Change-Id: Ib43a25bd68c51bf86f3a86836c1afc6e31697d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350383Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#797044}
-
Christian Biesinger authored
Implements the spec change in https://github.com/w3c/csswg-drafts/issues/5257 This allows respecting the aspect-ratio even when we're computing the block size from an aspect ratio with a max-height specified. Bug: 1104360 Change-Id: Ibdff4bf4a67aa0897fd24416fed67bbb2f1ef9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308999 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#797043}
-
George Steel authored
Fixes flakiness due to a cause it is not supposed to be testing for. Bug: 1115277 Change-Id: I41d43339913577ef20cabf528d6d1934baab3197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350488 Commit-Queue: George Steel <gtsteel@chromium.org> Commit-Queue: Alex Russell <slightlyoff@chromium.org> Reviewed-by:
Alex Russell <slightlyoff@chromium.org> Cr-Commit-Position: refs/heads/master@{#797042}
-
Merissa Tan authored
- Add method to query device rumble capabilities in EventDeviceInfo. - Add methods to support vibration (PlayVibrationEffect, StopVibration, StoreRumbleEffect, StartOrStopEffect, etc.) in GamepadEventConverterEvdev. - Route methods to control gamepad vibration through InputController to GamepadEventConverterEvdev. BUG=b:158685462 TEST=Add tests to GamepadEventConverterEvdevTest; all tests pass. Change-Id: Ic1a2d1d1965ddd0a9321a93224a59bc9d1b681fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294560 Commit-Queue: Merissa Tan <liyingtan@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO) <oshima@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Auto-Submit: Merissa Tan <liyingtan@google.com> Cr-Commit-Position: refs/heads/master@{#797041}
-
Gary Tong authored
This is a reland of 4421e3c9 Original change's description: > Infra: Use Mac 10.15 machines for mac-arm64-rel tryjob > > Bug: 1106950 > Change-Id: I69a3a8df07f40d0cc24de3f85212e51d5945bd46 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350149 > Auto-Submit: Gary Tong <gatong@chromium.org> > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Erik Staab <estaab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796959} Bug: 1106950 Change-Id: Ia493c546714237deb751676f037224b29f02670f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350393Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Gary Tong <gatong@chromium.org> Cr-Commit-Position: refs/heads/master@{#797040}
-
David Roger authored
Screenshots: https://drive.google.com/file/d/1GHXhrzx8817R9lrl0wbwefvJ1e0Nq2nW/view?usp=sharing https://drive.google.com/file/d/1gqs3fziupgIHcYa73hx1v1sQdkwJCUu1/view?usp=sharing Bug: 1076880 Change-Id: I6ba33abaebbea45c0f5efbc13605ed5b2ec6259b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341124 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#797039}
-
