GitLab

BUG=140037

Review URL: https://chromiumcodereview.appspot.com/17465003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207859 0039d316-1c4b-4281-b951-d872f2087c98

Supports a new method {ui,views}::InputMethod::IsCandidatePopupOpen(),
which returns true if a candidate window is open.

BUG=245578
TEST=Test manually.

Review URL: https://chromiumcodereview.appspot.com/17112021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207858 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Implement WebFrameClient in RenderFrame and proxy all calls to RenderView (for now)." (r207825).

Many failures on layout tests, e.g., fast/animation/request-animation-frame-during-modal.html

BUG=245126
TBR=nasko

Review URL: https://codereview.chromium.org/17068011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207857 0039d316-1c4b-4281-b951-d872f2087c98

Applies to Open, Mkdir, Rmdir and Remove. Previously, these set errno to ENOSYS
or EIO.

BUG=252064

Review URL: https://chromiumcodereview.appspot.com/17450014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207856 0039d316-1c4b-4281-b951-d872f2087c98

BUG=249104
TEST=WebUIResourceBrowserTest

Review URL: https://chromiumcodereview.appspot.com/17450012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207855 0039d316-1c4b-4281-b951-d872f2087c98

Note that I can't reproduce the problem in the linked bug, but based on
your analysis this seems like it should fix it.

BUG=244103

Review URL: https://chromiumcodereview.appspot.com/17449017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207854 0039d316-1c4b-4281-b951-d872f2087c98

When generating/using a crypto::RSAPrivateKey with NSS,
prefer the internal software slot over other modules (such as
any TPMs [ChromeOS] or smart cards [Linux]) if the key being
generated is not marked as a permanent key.

BUG=none
R=wtc

Review URL: https://chromiumcodereview.appspot.com/17447009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207853 0039d316-1c4b-4281-b951-d872f2087c98

BUG=252588
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/17520005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207852 0039d316-1c4b-4281-b951-d872f2087c98

The change in r185359 added the pref for allowing signin to the the pref registrar
previously used only for proxy settings. (Other prefs have since been added on too.)
This, in combination with the use of the registrar's IsManaged() method rather than
the pref's own IsManaged() -- or better still, using IsUserModifiable() for the best
semantic fit -- meant that once supervised users had signin disabled, they also had
proxy changes disabled.

This fix changes the condition to use Preference::IsUserModifiable().

BUG=252426
TEST=create a supervised user; make sure the "Change proxy settings..." button is
   enabled

Review URL: https://chromiumcodereview.appspot.com/17408009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207851 0039d316-1c4b-4281-b951-d872f2087c98

Fix the problem that some stacked panels might not be brought to the top when a collapsed panel is clicked on Linux

BUG=251829
TEST=Manual test by creating stacked panels and collapsing and expanding some of them

Review URL: https://chromiumcodereview.appspot.com/17397006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207850 0039d316-1c4b-4281-b951-d872f2087c98

BUG=179669
R=ygorshenin@chromium.org
TBR=derat@chromium.org
notry=TRUE

Review URL: https://chromiumcodereview.appspot.com/17494004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207849 0039d316-1c4b-4281-b951-d872f2087c98

This CL separates the function to fetch the Translate script from TranslateManager.

TEST=browser_tests, unit_tests

Review URL: https://chromiumcodereview.appspot.com/17390018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207848 0039d316-1c4b-4281-b951-d872f2087c98

There should be no behavior change. It's just moving code
out of RequestRegistry.

BUG=164098

Review URL: https://chromiumcodereview.appspot.com/17379020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207847 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244790

Review URL: https://chromiumcodereview.appspot.com/17368005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Ran image_decoding_measurement on linux
NOTRY=True
TBR=tengs@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17413018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207845 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174296
R=dbeam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17314013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207842 0039d316-1c4b-4281-b951-d872f2087c98

Add ResourceMetadataStorage::opened_existing_db() to trigger cache file scan at appropriate timing.

BUG=234487
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/17249004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207841 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes Chrome-side changes necessary for tracking of
NPObject ownership to out-of-process NPAPI plugin instances.

Ownership information is now included whenever an NPObject
is marshalled across IPC, to be passed when instantiating
NPObjectProxy instances for objects.

In the plugin process each NPObject is tracked to its owning
plugin instance, and browser-owned objects are tracked to a dummy NPP identifier.

This depends upon crrev.com/17220002 and is a prerequisite for crrev.com/17208003.

BUG=152006

Review URL: https://chromiumcodereview.appspot.com/17208003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207840 0039d316-1c4b-4281-b951-d872f2087c98

The behavior in the PNaCl shim layer is the same if there's a struct for an
interface with no wrapper or no struct at all.

This change removes structs where no wrapping is necessary.

BUG=251460

Review URL: https://chromiumcodereview.appspot.com/17153012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207839 0039d316-1c4b-4281-b951-d872f2087c98

To chrome/browser/DEPS and content/browser/DEPS to prevent more
third_party/WebKit includes.

R=jamesr@chromium.org, sky@chromium.org
BUG=237267

Review URL: https://codereview.chromium.org/17261033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207838 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/17198010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207837 0039d316-1c4b-4281-b951-d872f2087c98

 * Add support for file content upload,
 * Fill MD5 on contents update.

Review URL: https://chromiumcodereview.appspot.com/17140009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207836 0039d316-1c4b-4281-b951-d872f2087c98

This allows enterprise-managed Kiosk Apps to mint OAuth2 access tokens
for the device-level robot account via the identity extension API.

BUG=chromium:224594

Review URL: https://chromiumcodereview.appspot.com/17009016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207835 0039d316-1c4b-4281-b951-d872f2087c98

This also changes the layout of some keys to bring the keyboard closer to the v1 spec.

BUG=248525,248226

Review URL: https://chromiumcodereview.appspot.com/16959020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207834 0039d316-1c4b-4281-b951-d872f2087c98

Fixed Profile Reset unit tests.

BUG=235037

Review URL: https://chromiumcodereview.appspot.com/17274006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207833 0039d316-1c4b-4281-b951-d872f2087c98

This adds a boolean (kAppShortcutsEnabled) to user prefs. At startup,
ShortcutManager checks the pref and sets the current value. On a
transition from false to true, ShortcutManager iterates over all
apps and creates shortcuts as if the app is being installed.

BUG=249189
TEST=Delete app shortcuts from the OS applications folder.
Start Chrome, the shortcuts should be created.
Delete the shortcuts again.
Restart Chrome, the shortcuts are not created a second time.

Review URL: https://chromiumcodereview.appspot.com/17261016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207832 0039d316-1c4b-4281-b951-d872f2087c98

BUG=241377
TBR=pkotwicz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17176014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207831 0039d316-1c4b-4281-b951-d872f2087c98

This fix adds a check for |plugin| permission
while syncing NPAPI plugins.

BUG=252034

Review URL: https://chromiumcodereview.appspot.com/16816024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207830 0039d316-1c4b-4281-b951-d872f2087c98

BUG=252425
R=cpu@chromium.org
TEST=Dr. Memory no longer reports the mismatch

Review URL: https://codereview.chromium.org/16983011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207829 0039d316-1c4b-4281-b951-d872f2087c98

BUG=247212

Review URL: https://chromiumcodereview.appspot.com/17167006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207827 0039d316-1c4b-4281-b951-d872f2087c98

Previously, it was not possible to produce unofficial builds without
DCHECKS and DLOGS.

Review URL: https://chromiumcodereview.appspot.com/17165003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207826 0039d316-1c4b-4281-b951-d872f2087c98

This is continuation of the original CL (https://codereview.chromium.org/16223006/), which didn't account for Blink tests using WebTestProxy.

BUG=245126

Review URL: https://chromiumcodereview.appspot.com/17114006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207825 0039d316-1c4b-4281-b951-d872f2087c98

BUG=251116

Review URL: https://chromiumcodereview.appspot.com/17101020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207824 0039d316-1c4b-4281-b951-d872f2087c98

Unit tests fail on Mac Dbg with this patch:
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%284%29&number=29470
and
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%284%29&number=12750

> Differential updates for components. We are adding support for delivering delta updates for Chrome components. Initial platform support for the patcher is Windows only. The update response includes both the full update and, if available, the differential update. The differential update is tried first, then the full update, if needed.
> 
> BUG=245318
> 
> Review URL: https://chromiumcodereview.appspot.com/15908002

TBR=sorin@chromium.org

Review URL: https://codereview.chromium.org/17551004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207823 0039d316-1c4b-4281-b951-d872f2087c98

> Turn on touch drag and drop and touch editing by default on chromeos.
> 
> BUG=168162
> 
> Review URL: https://chromiumcodereview.appspot.com/16268020

TBR=varunjain@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/17068008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207820 0039d316-1c4b-4281-b951-d872f2087c98

Also, adds #endif comments to make the tests more readable.

Review URL: https://chromiumcodereview.appspot.com/17198011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207817 0039d316-1c4b-4281-b951-d872f2087c98

When the flag --enable-translate-settings is on, the user can configure which language should be translated.  When so, even though the page is written in the user's locale language, the infobar should appear.

TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/17157015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207816 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163552

Review URL: https://chromiumcodereview.appspot.com/17101027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207815 0039d316-1c4b-4281-b951-d872f2087c98

This element caused an assertion failure in libjingle at xmpp/xmppengineimpl.cc:367 when used from the client-side code.

Review URL: https://chromiumcodereview.appspot.com/16975019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207814 0039d316-1c4b-4281-b951-d872f2087c98

The crash on startup in the referenced bug is very bad in part because
the corrupt index which caused it is left on disk, so all startups
until user data is cleared will crash. For maximum safety, we should
unlink the index file ASAP after finding it is corrupt.

R=rdsmith@chromium.org
BUG=251465

Review URL: https://codereview.chromium.org/17265007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207813 0039d316-1c4b-4281-b951-d872f2087c98