GitLab

When the app button is released within a timeframe, it is considered a click.
Otherwise, it is considered a gesture. Indicators appear on top of the content
quad to provide visual feedback on the recognized gesture.

BUG=692097
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2748763002
Cr-Commit-Position: refs/heads/master@{#457518}

BUG=666986

Review-Url: https://codereview.chromium.org/2747083007
Cr-Commit-Position: refs/heads/master@{#457517}

Revert of Linux UI: Switch to the Gtk3 theme (patchset #3 id:180001 of https://codereview.chromium.org/2670623002/ )

Reason for revert:
Reverting to fix component builds on systems with Mir.
Will reland (probably later today) once https://codereview.chromium.org/2756543002/ lands

Original issue's description:
> Linux UI: Switch to the Gtk3 theme
>
> Sets "use_gtk3 = true" by default.
>
> BUG=79722
> TBR=dpranke@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
>
> > > Review-Url: https://codereview.chromium.org/2670623002
> > > Cr-Commit-Position: refs/heads/master@{#452118}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d681183a3d47b
>
> > Review-Url: https://codereview.chromium.org/2670623002
> > Cr-Commit-Position: refs/heads/master@{#454491}
> > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d13fde39e73283
>
> Review-Url: https://codereview.chromium.org/2670623002
> Cr-Commit-Position: refs/heads/master@{#455596}
> Committed: https://chromium.googlesource.com/chromium/src/+/072522801041708fba94498a1844cb89f24d4590

TBR=erg@chromium.org,mmoss@chromium.org,thomasanderson@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=79722,700120

Review-Url: https://codereview.chromium.org/2754913002
Cr-Commit-Position: refs/heads/master@{#457516}

Also, removed non-MD code from tray_cast.cc.

BUG=699262,687795
TEST=manual

Review-Url: https://codereview.chromium.org/2752943002
Cr-Commit-Position: refs/heads/master@{#457515}

BUG=none
R=marq@chromium.org,rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2750003004
Cr-Commit-Position: refs/heads/master@{#457514}

Previously, command-line flags to be passed to the test had to be
passed via:
 - (gtests) --test-arguments <string>
 - (instrumentation tests) --device-flags{,-file} <file>

This CL changes it s.t. any flags not recognized by the test runner
are passed down to the binary. It also removes --device-flags and
deprecates --test-arguments.

BUG=700366

Review-Url: https://codereview.chromium.org/2752493002
Cr-Commit-Position: refs/heads/master@{#457513}

Fuzzer originally written by jsbell here:
https://codereview.chromium.org/2546233002

This introduces a libFuzzer-based fuzzer template (which can be run locally
or via ClusterFuzz) for the WTF::TextCodec implementations. It
introduces a new target for every text codec.

Fuzzer docs: https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/getting_started.md

This patch also includes a generated fuzzer corpus.

Review-Url: https://codereview.chromium.org/2731643002
Cr-Commit-Position: refs/heads/master@{#457512}

https://pdfium.googlesource.com/pdfium.git/+log/cfdb5fdd12d4..c9819a972830

$ git log cfdb5fdd1..c9819a972 --date=short --no-merges --format='%ad %ae %s'
2017-03-16 npm Use EXPECT_FLOAT_EQ in cpdf_devicecs_unittest
2017-03-16 npm Compare to epsilon instead of 0 in CFX_Matrix::SetReverse

Created with:
  roll-dep src/third_party/pdfium
BUG=702041

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2752313002
Cr-Commit-Position: refs/heads/master@{#457511}

These tests are probably still flaky on Windows, but
it's hard to tell when they are always failing on Linux.
So rebaseline to get at leat some passing results to
evaluate flakiness.

TBR=chrishtr@chromium.org
BUG=653722

Review-Url: https://codereview.chromium.org/2750913004
Cr-Commit-Position: refs/heads/master@{#457510}

HostPairingScreen (one of OOBE screens) is an observer of
BluetoothHostPairingController and remove itself as an observer
in its destructor, so it needs to be destructed before
|remora_controller_| gets deleted to avoid a nullptr dereference.

BUG=None

Review-Url: https://codereview.chromium.org/2750973005
Cr-Commit-Position: refs/heads/master@{#457509}

When the referrer was set to an empty string, the openerURL was empty
instead of set to |_documentURL|.

TEST=Ensure new windows triggered without user interaction (popups) are
displayed or blocked as expected.
BUG=none

Review-Url: https://codereview.chromium.org/2753763006
Cr-Commit-Position: refs/heads/master@{#457508}

BUG=686282

Review-Url: https://codereview.chromium.org/2750263002
Cr-Commit-Position: refs/heads/master@{#457507}

Note that this CL uses no styling, icons, or click targets. These will be done in a future CL.

BUG=672263

Review-Url: https://codereview.chromium.org/2754693002
Cr-Commit-Position: refs/heads/master@{#457506}

 1. Puts the "Enter required custom passphrase" UI at the top of the Sync page.

 2. Auto-focuses the passphrase field when the passphrase is required.

BUG=694115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2755793002
Cr-Commit-Position: refs/heads/master@{#457505}

BUG=chromedriver:1712

Review-Url: https://codereview.chromium.org/2754933002
Cr-Commit-Position: refs/heads/master@{#457504}

This provides the transitive dependency on skia which is required by
media/base/video_codecs.h.

BUG=702033

Review-Url: https://codereview.chromium.org/2750283002
Cr-Commit-Position: refs/heads/master@{#457503}

Fully support having multiple processes write information to the same breadcrumbs file.

This involves some process-specific operations plus the ability for a controlling process to clean-up after its dead children.

BUG=620813
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2680123003
Cr-Commit-Position: refs/heads/master@{#457502}

Data persisted to disk can end up with some oddities should a hard
shutdown of the machine (such as from a power failure) cause an
incomplete flush of the memory.

It's possible that the actual data gets flushed but the "free_ptr"
that indicates the end of used memory does not. The data is still
iterable but might try to go beyond what is believed to be the end.
The GetBlockData() checks against free_ptr have been removed, relying
on the fixed mem_size_ boundary and the required existence of the
header cookie to know if the block is valid.

A "Flush()" call has been added to allow for signalling when
essential changes have been made. It's an empty call except for
file-backed memory. A call to it is done after initialization to
ensure the file on disk appears initialized.

A "memory state" field has been added to the shared header to
indicate the overall state of the memory (initalized, deleted, etc.)
and accessor methods added. This allows the caller to ensure that
major changes to the memory segment get propogated. This is used
to indicate if it has been "deleted" because actually deleting the
file is prone to failure.

Unfortunately, this requires a change to the SharedMetada structure
that makes this code incompatible with previous versions. The first
version with this change will be unable to read persistent data
written by the previous version. It will find invalid data in the
header and be unable to find the written data blocks. This is
unfortunate but safe due to all the precautions against memory
corruption already in the PMA.

The PersistentHistogramAllocator has been updated to use this when
deleting a file and the FileMetricsProvider now reads it and
discards the data if it detects this.

Still to do is make use of these features in the Breadcrumbs
project.

BUG=546019,620813

Review-Url: https://codereview.chromium.org/2742193002
Cr-Commit-Position: refs/heads/master@{#457501}

https://skia.googlesource.com/skia.git/+log/9e9188f84b15..dc3c336c84db

$ git log 9e9188f84..dc3c336c8 --date=short --no-merges --format='%ad %ae %s'
2017-03-16 ethannicholas fixed missing dependency in spirv-tools/BUILD.gn
2017-03-16 bsalomon In GrClipStackClip check whether op bounds are inside RT before checking for empty clip stack.
2017-03-16 reed Revert[3] "store vertices arrays inline with object"""
2017-03-16 benjaminwagner Marker for AMD driver update.
2017-03-16 ethannicholas turned off SPIR-V validation on ASAN bots

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=borenet@chromium.org

Change-Id: I582c0134df2ae85f4aeeb25a6dcbcfbdbf498f89
Reviewed-on: https://chromium-review.googlesource.com/456398Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#457500}

This finally moves ConsoleModel out of sdk. NetworkLog is next.

BUG=none

Review-Url: https://codereview.chromium.org/2751193003
Cr-Commit-Position: refs/heads/master@{#457499}

These are only called from CSSGradientValue to adjust the points/radii
immediately after Gradient instantiation.

Refactor CSSGradientValue to perform the adjustment before constructing
the Gradient object.  No functional changes.

BUG=614368
R=schenney@chromium.org,fs@opera.com

Review-Url: https://codereview.chromium.org/2754703003
Cr-Commit-Position: refs/heads/master@{#457498}

Use CMA backend media pipeline instead of spitzer on headless cast
receiver for Android.

BUG=Internal b/36179732

Review-Url: https://codereview.chromium.org/2746243002
Cr-Commit-Position: refs/heads/master@{#457497}

Previous CL missed a few.

BUG=691029
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2748363003
Cr-Commit-Position: refs/heads/master@{#457496}

There's an issue where when we receive a PAUSE intent fired from media
notification, we still call MediaNotificationManager.onServiceStarted(),
which will update the notification and call Service.startForeground().
When the PAUSE action is executed, we then update the notification again
and call Service.stopForeground(). These two calls are called in a very
short time window so that a race condition in Android will keep the
notification foreground and unswippable.

In this CL, we distinguish start service intents so that we don't update
the notification when receiving an action.

BUG=701731
R=mlamouri@chromium.org

Review-Url: https://codereview.chromium.org/2750973004
Cr-Commit-Position: refs/heads/master@{#457495}

1. Use NativeTheme menu colors for selected rows on all platforms. This
allows us to remove platform ifdefs (only Linux did this before). This
has almost no visible effect on a classic theme as the theme menu colors
were almost identical to the colors being used in the profile chooser.
One thing that does change is that the color of the hovered text is a
smidgeon darker, improving contrast.

2. Don't draw a dashed focus rect, instead reuse selection. This matches
how menus look. Also make focus actually follow the mouse, also matching
how menus work.

BUG=696003

Review-Url: https://codereview.chromium.org/2736613008
Cr-Commit-Position: refs/heads/master@{#457494}

Reland of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (patchset #1 id:1 of https://codereview.chromium.org/2732023004/ )

Reason for revert:
With https://bugs.chromium.org/p/nativeclient/issues/detail?id=4391#c1 fixed, this might now work.

Original issue's description:
> Revert of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (patchset #2 id:20001 of https://codereview.chromium.org/2732293002/ )
>
> Reason for revert:
> https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/30394/steps/compile/logs/stdio
>
> pnacl-ld: Unrecognized option: --build-id=sha1
>
> gn args:
> goma_dir = "/b/c/goma_client"
> is_chrome_branded = true
> is_debug = false
> is_official_build = true
> target_os = "chromeos"
> use_goma = true
>
> Original issue's description:
> > build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON
> >
> > BUG=622775
> >
> > Review-Url: https://codereview.chromium.org/2732293002
> > Cr-Commit-Position: refs/heads/master@{#455154}
> > Committed: https://chromium.googlesource.com/chromium/src/+/4e5c4a1545902ab817b8d758c8b3ec4380552b5d
>
> TBR=hans@chromium.org,torne@chromium.org,mcgrathr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=622775
>
> Review-Url: https://codereview.chromium.org/2732023004
> Cr-Commit-Position: refs/heads/master@{#455172}
> Committed: https://chromium.googlesource.com/chromium/src/+/e806d46df51009e8c254727b374873bc4379b1fb

TBR=hans@chromium.org,torne@chromium.org,mcgrathr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=622775

Review-Url: https://codereview.chromium.org/2756713002
Cr-Commit-Position: refs/heads/master@{#457493}

Accelerator::type_ was an EventType, but this is overkill as the type
can only be pressed or released. So, this converts the type to an enum
with those two values.

I'm doing this as I'm going to write a mojom for Accelerator and it's
better to restrict the mojom to the actual values.

BUG=701815
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2751323002
Cr-Commit-Position: refs/heads/master@{#457492}

Limit the concept of CreditCard to PaymentRequestState (when creating
instruments) and the Credit Card editor.

BUG=702061
TEST=Existing

Review-Url: https://codereview.chromium.org/2757523002
Cr-Commit-Position: refs/heads/master@{#457491}

This CL lands the Mojo service that we intend to use for Background
Fetch. Everything but the fetch() event has been hooked up from the
renderer side, and will be received by a strongly binded service
implementation in the browser process.

The fetch() function will be implemented separately, as it will require
some plumbing to support the appropriate types for requests.

BUG=692534, 692535

Review-Url: https://codereview.chromium.org/2745243002
Cr-Commit-Position: refs/heads/master@{#457490}

The new API will be private to cast extension, and will contain
networkingPrivate methods only used/needed by cast extension and setup
app.
Method implementations are not changed, they are just copied from
networkingPrivate API to networking.cast API. The goal is to
eventually remove networkingPrivate implementation - when extensions
white-listed for the API move to the networking.cast API.

List of methods that are being moved to networking.cast API:
verifyDestination
verifyDestinationAndEncryptCredentials
verifyDestinationAndEncryptData
setWifiTDLSEnabledState
getWifiTDLSStatus

For now, the ChromeNetworkingCast just calls into the networking
private API's crypto verification delegate - the next step will be to
move this logic into ChromeNetworkingCastDelegate.

BUG=678737

Review-Url: https://codereview.chromium.org/2726223004
Cr-Commit-Position: refs/heads/master@{#457489}

The last tap in ClearHandleAfterTap was causing the HitTestResult's innerNode to
be null. This change makes it so that the tap occurs on an HTML element thus
making the innerNode not be null. This is change was necessary to for
crrev.com/2616623002.

Review-Url: https://codereview.chromium.org/2748483002
Cr-Commit-Position: refs/heads/master@{#457488}

Clearly indicate the status of the mojo interfaces as
not ready for production use.

Also, fix style violations for headers in device/bluetooth/README.md

Review-Url: https://codereview.chromium.org/2757463002
Cr-Commit-Position: refs/heads/master@{#457487}

BUG=684080

Review-Url: https://codereview.chromium.org/2753443005
Cr-Commit-Position: refs/heads/master@{#457486}

Re-enable triggering of Translate dialog for (1) zh-CN users and zh-TW pages, and (2) zh-TW users and zh-CN pages.

BUG=699370

Review-Url: https://codereview.chromium.org/2745253005
Cr-Commit-Position: refs/heads/master@{#457485}

This change makes it so that accessing the navigator.usb object does not
automatically cause Blink to connect to the browser process for an
instance of the DeviceManager service. This is useful because it makes
it easier for tests to register a Mojo service override before the
connection is made.

BUG=None

Review-Url: https://codereview.chromium.org/2751173004
Cr-Commit-Position: refs/heads/master@{#457484}

BUG=438729
TBR=bbudge@chromium.org

Review-Url: https://codereview.chromium.org/2755793005
Cr-Commit-Position: refs/heads/master@{#457483}

While all planes on rockchip support alpha, scanning out a primary
plane with an fb that was created with a format with alpha will result
in black pixels.

This patch adds an additional fb to a ScanoutBuffer to be used for the
primary plane.
When a buffer is created with a format that has alpha (e.g: RGBA),
an additional fb with a format without alpha (e.g. RGBX) will be added for
the same buffer.

In this way, when the buffer is scheduled for scanout as primary plane
we can use the fb added with a format without alpha and actually see
colors on the screen, instead of having everything black.

BUG=695296

Review-Url: https://codereview.chromium.org/2743403005
Cr-Commit-Position: refs/heads/master@{#457482}

This patch includes changes related to TODO where
it was mentioned to add BitsPerChannel as a part
of video frame class.
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2745743002
Cr-Commit-Position: refs/heads/master@{#457481}

https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer/+log/eebc6eb..a746f0e

TBR=aizatsky@chromium.org, inferno@chromium.org, ochang@chromium.org
BUG=539572

Review-Url: https://codereview.chromium.org/2753063002
Cr-Commit-Position: refs/heads/master@{#457480}

Exposes the supported card networks in PaymentRequest. Also adds a
function to add a credit card to the list of cached credit cards.

BUG=602666

Review-Url: https://codereview.chromium.org/2750363002
Cr-Commit-Position: refs/heads/master@{#457479}