- 21 Oct, 2016 40 commits
-
-
jamescook authored
This allows me to skip refactoring it for mustash. It also avoids one place where chrome calls back into ash that I would have to refactor as well. The method just looks up a chromeos command-line switch, so inline that lookup where needed. In addition, clean up some of the splash screen init logic to make it more clear how we handle primary vs. secondary displays. BUG=none TEST=run chrome with and without --first-exec-after-boot, watch background colors as displays are initialized Review-Url: https://chromiumcodereview.appspot.com/2437393002 Cr-Commit-Position: refs/heads/master@{#426854}
-
asvitkine authored
This is a re-land of: https://codereview.chromium.org/2435813002/ The reland keeps a TimesHistogramSample class in LaunchMetrics since it's still referenced in internal code. Once this lands, the clank/ code can be updated and this class can be cleaned up. Original CL description: This is general-purpose functionality that allows recording UMA metrics before the C++ native library has been loaded and is useful to have outside of the Chrome layer. In particular, I will be using it from components/variations to record information about the first run variations seed fetch. No functional changes in this CL. BUG=632199 TBR=bauerb@chromium.org, thestig@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2439113002 Cr-Commit-Position: refs/heads/master@{#426853}
-
nick authored
This fixes a bug where IsIsolateExtensionsEnabled() had been called prior to the field trials actually being initialized, so the call returned true regardless of the finch experiment state, resulting in a possible misconfiguration of security state. PreCreateThreads() seems to be the earliest place in BrowserProcessImpl where we can do this registration. BUG=657629 Review-Url: https://chromiumcodereview.appspot.com/2438823003 Cr-Commit-Position: refs/heads/master@{#426852}
-
fsamuel authored
This CL takes a few steps along the way to unify compositor code between Mus+Ash and the browser. 1. BitmapUploader uses ui::CompositorFrameSink. 2. MusBrowserCompositorOutputSurface uses ui::CompositorFrameSink. 3. Introduces ui::Window::RequestCompositorFrameSink that replaces RequestSurface 4. WindowSurface/ServerWindowSurface use MojoCompositorFrameSink interface and surface.mojom is deleted. TODO: Merge WindowSurface and WindowCompositorFrameSink. BUG=656975 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://chromiumcodereview.appspot.com/2430653002 Cr-Commit-Position: refs/heads/master@{#426851}
-
avi authored
Merge internal change: 136848647 BUG=555865 Review-Url: https://chromiumcodereview.appspot.com/2417183003 Cr-Commit-Position: refs/heads/master@{#426850}
-
fbarchard authored
Important changes included: AVX2 and NEON halffloat conversion. Add F16C cpu detection. Support for I411 removed. Side by side UV for I420 output improves memory coherency. HalfFloat AVX2 ported from SSE2 using same magic number method, which is 20% faster than vcvtps2ph method and produces identical results. HalfFloat Neon version adapted from inner loop of vectorized C, but folds shift and narrow into one instruction and uses element multiply instead of vector to save a register and dup instruction. Neon version is also full performance with -Os. This CL enables -O2 for libyuv_neon as well. ExtractAlpha ported to AVX2. ARGB4444ToI420 ported to MSA. F16C cpu detection for AVX hardware that has halffloat conversion support. Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/198bce39..550cf829 Full changes https://chromium.googlesource.com/libyuv/libyuv/+/198bce39..550cf829 TEST=TestHalfFloatPlane_denormal BUG=libyuv:560, libyuv:650, libyuv:572, libyuv:645, libyuv:649 R=hubbe@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://chromiumcodereview.appspot.com/2425423006 Cr-Commit-Position: refs/heads/master@{#426849}
-
sky authored
I'm going to need this for the aura-mus work so that what is the WindowTreeClient implementation can track capture and update the server appropriately. I didn't update the desktop client as I don't think I'll need that one. BUG=none TEST=none R=sadrul@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2436023003 Cr-Commit-Position: refs/heads/master@{#426848}
-
petewil authored
If chrome is shut down, then a user deletes a request from a notification, the scheduler callback will not be set, and we could crash trying to inform it. To fix this, when we start, set an empty scheduler callback to receive the call, so we don't try to call through a nullptr. BUG=64911 Review-Url: https://chromiumcodereview.appspot.com/2429213009 Cr-Commit-Position: refs/heads/master@{#426847}
-
johnme authored
BUG=658318 TBR=tkent@chromium.org NOTRY=true NOTREECHECKS=true Review-Url: https://chromiumcodereview.appspot.com/2438323002 Cr-Commit-Position: refs/heads/master@{#426846}
-
zqzhang authored
There is a conflict in two recent CLs: https://chromiumcodereview.appspot.com/2437963002 https://chromiumcodereview.appspot.com/2428353005, in which WebRTC does not take audio focus both for the input stream and the output stream. This CL lets WebRTC take audio focus on Android from MediaSession again to fix the issue. BUG=596516 Review-Url: https://chromiumcodereview.appspot.com/2437343002 Cr-Commit-Position: refs/heads/master@{#426845}
-
gmanikpure authored
BUG=chromedriver:1503,chromedriver:1478 Review-Url: https://chromiumcodereview.appspot.com/2431863002 Cr-Commit-Position: refs/heads/master@{#426844}
-
rouslan authored
Make PaymentOption store a Drawable instead of id for the icon. This will allow to use icons not contained in the default resources. Original patch http://crrev.com/2436883002 from rob.buis@samsung.com. BUG=620173 Review-Url: https://chromiumcodereview.appspot.com/2436363002 Cr-Commit-Position: refs/heads/master@{#426843}
-
johnme authored
BUG=658311 TBR=majidvp@chromium.org NOTRY=true NOTREECHECKS=true Review-Url: https://chromiumcodereview.appspot.com/2441063002 Cr-Commit-Position: refs/heads/master@{#426842}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM as normal. The recipe roller will *NOT* CQ the change itself, so you must CQ the change manually. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/75023e2d624be7d2535efdb683e05f1697713a1e Change archive_retry_summary step to happen also when there are new failures. (qyearsley@chromium.org) R=qyearsley@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://chromiumcodereview.appspot.com/2435803007 Cr-Commit-Position: refs/heads/master@{#426841}
-
servolk authored
Previously we would just crash due to CHECK when we detected media streams with duplicate bytestream ids. This CL adds explicit checks for duplicate stream ids in FFmpegDemuxer and skips those streams. BUG=657437 Review-Url: https://chromiumcodereview.appspot.com/2434383003 Cr-Commit-Position: refs/heads/master@{#426840}
-
johnme authored
BUG=640947 TBR=falken@chromium.org NOTRY=true NOTREECHECKS=true Review-Url: https://chromiumcodereview.appspot.com/2442043002 Cr-Commit-Position: refs/heads/master@{#426839}
-
shaktisahu authored
Currently on Blimp IME, hitting Enter only sets the text in the web page. So user has to hit Enter twice in order to see search results. This patch solves this by generating a synthetic Enter key press event and sending it to the renderer. BUG=611132 Review-Url: https://chromiumcodereview.appspot.com/2393043004 Cr-Commit-Position: refs/heads/master@{#426838}
-
qyearsley authored
In the preliminary CL http://crrev.com/2406153003, I changed Rietveld.latest_try_jobs to Rietveld.latest_try_job_results and made it return a dict of Builds (named tuple objects with builder_name and build_number) to result info dicts. The purpose of this was to make it so that rebaseline-cl could look through the result info dicts to see whether each build is completed or just started, to avoid starting extra builds. After looking at it some more, I see that in the Rietveld response, builds that are just started but not completed have no build number information. To avoid having to pass around the result dict information from Rietveld, it's possible to just have a list of Build objects with build_number set to None when the build is just pending or started but not completed. So, in summary, this CL makes it so that when one runs rebaseline-cl twice in a row, it now prints out: $ ./webkit-patch rebaseline-cl Triggering try jobs for: android_blink_rel linux_precise_blink_rel linux_trusty_blink_rel mac10.10_blink_rel mac10.11_blink_rel mac10.11_retina_blink_rel mac10.9_blink_rel win10_blink_rel win7_blink_rel Please re-run webkit-patch rebaseline-cl once all pending try jobs have finished. $ ./webkit-patch rebaseline-cl There are existing pending builds for: android_blink_rel linux_precise_blink_rel linux_trusty_blink_rel mac10.10_blink_rel mac10.11_blink_rel mac10.11_retina_blink_rel mac10.9_blink_rel win10_blink_rel win7_blink_rel Please re-run webkit-patch rebaseline-cl once all pending try jobs have finished. And this CL undoes some of the changes made in http://crrev.com/2406153003 in order to simplify the code, because now I think passing full result info dicts is unnecessary. BUG=654919 Review-Url: https://chromiumcodereview.appspot.com/2439693003 Cr-Commit-Position: refs/heads/master@{#426837}
-
foolip authored
This makes WebRTCConfiguration into a data struct instead of wrapping a RTCConfiguration. The motivation for this is to introduce RTCConfiguration as an IDL dictionary, at which point the extra layer starts to look unnecessary. BUG=649343 Review-Url: https://chromiumcodereview.appspot.com/2415673003 Cr-Commit-Position: refs/heads/master@{#426836}
-
lfg authored
This change makes sure that we gracefully handle the case where a pending pointer lock request is still active while destroying the RenderWidgetHost. BUG=655592 Review-Url: https://chromiumcodereview.appspot.com/2437213002 Cr-Commit-Position: refs/heads/master@{#426835}
-
johnme authored
BUG=658305 TBR=senorblanco@chromium.org NOTRY=true NOTREECHECKS=true Review-Url: https://chromiumcodereview.appspot.com/2439143002 Cr-Commit-Position: refs/heads/master@{#426834}
-
dtseng authored
This cl makes div output the same way as classic: - when a div receives either ChromeVox or page focus, read its text content or its aria label - this cleans up output and retains the previously hardened behavior in Classic. TEST=browse on a variety of sites like Gmail, Groups. Verify that despite bad markup, ChromeVox performs well and provides a smooth experience. BUG=619279 TBR=dtseng@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0026818d58dc22ebea46fe8ff31456aa0ac7bf65 Cr-Commit-Position: refs/heads/master@{#426497} patch from issue 2433823003 at patchset 20001 (http://crrev.com/2433823003#ps20001) Review-Url: https://chromiumcodereview.appspot.com/2441033002 Cr-Commit-Position: refs/heads/master@{#426833}
-
avi authored
BUG=555865 Review-Url: https://chromiumcodereview.appspot.com/2435863004 Cr-Commit-Position: refs/heads/master@{#426832}
-
rdsmith authored
THROTTLED is used when the consumer is expecting that low priority requests will soon be followed by higher priority ones. It directs the network stack to reserve resources to handle the coming requests. In practice this will mean that only a very small number of THROTTLED requests may be outstanding at any given time. BUG=600839 Review-Url: https://chromiumcodereview.appspot.com/1866483002 Cr-Commit-Position: refs/heads/master@{#426831}
-
kylechar authored
Big CL that fixes many small things related to display information being propagated when a display is modified. The primary change is that ws::DisplayManager now handles OnDisplayModified() calls. This entails the following steps: 1. The PlatformDisplay corresponding to the display is updated. 2. Mus sends an IPC to WM clients telling them the display has changed. This requires a new message in mojom::WindowManager and new method in WindowManagerDelegate. 3. Update the root ServerWindow for the display. 4. Mus sends an IPC to any other clients telling them the display has changed. The ViewportMetrics class is moved from src/services/ui/ws/ to src/services/ui/display so that it can be used in PlatformScreenDelegate. PlatformScreen now implements ui::DisplayController::StateController so it can pick the display size. A message is added to mojom::TestDisplayController to trigger changing the display size. This allows developers to try the functionality. An unused ash developer keyboard shortcut is used to trigger changing the display size. This shortcut is only temporary until settings are working. Another small part of this change is the display insets are sent from ash to PlatformScreen. This is tangentially related as it relies on DisplayManager::OnDisplayModified() working. BUG=641012 Review-Url: https://chromiumcodereview.appspot.com/2434923002 Cr-Commit-Position: refs/heads/master@{#426830}
-
tsergeant authored
This element is no longer used, and was included in this file by mistake. Removing it reduces the size of the element bundle by about 7KB. BUG=425625 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://chromiumcodereview.appspot.com/2436323002 Cr-Commit-Position: refs/heads/master@{#426829}
-
estade authored
the "show all" button. BUG=657935 Review-Url: https://chromiumcodereview.appspot.com/2439873002 Cr-Commit-Position: refs/heads/master@{#426828}
-
shaktisahu authored
This CL adds support on the Blimp to propagate loading status and page load status to Tab. This enables the UI to display the loading spinner on the tablets and page load progress bar on phones. The page load progress was set to 50 percent for now. BUG=651473 Review-Url: https://chromiumcodereview.appspot.com/2394663002 Cr-Commit-Position: refs/heads/master@{#426827}
-
johnme authored
BUG=658304 TBR=bokan@chromium.org NOTRY=true NOTREECHECKS=true Review-Url: https://chromiumcodereview.appspot.com/2442803002 Cr-Commit-Position: refs/heads/master@{#426826}
-
lpz authored
Added Set and Exists methods to safe_browsing_prefs and updated callers. BUG=653122 Review-Url: https://chromiumcodereview.appspot.com/2435933003 Cr-Commit-Position: refs/heads/master@{#426825}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7d2ac2e7..580029a7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2439103002 Cr-Commit-Position: refs/heads/master@{#426824}
-
wnwen authored
On Android N the constructor results in a StrictMode violation due to WebappRegistry#openSharedPreferences. Use initialization on demand holder idiom to avoid synchronization issues. BUG=656035 Review-Url: https://chromiumcodereview.appspot.com/2421833003 Cr-Commit-Position: refs/heads/master@{#426823}
-
erikchen authored
I also updated the comment to better reflect the relationship between Chrome and its dependencies. Several Chrome dependencies require a different min sdk and/or deployment target from Chrome. BUG=622481 Committed: https://crrev.com/3dade40fe88881864a42134f92238a6d292d8505 Review-Url: https://chromiumcodereview.appspot.com/2420233002 Cr-Original-Commit-Position: refs/heads/master@{#425870} Cr-Commit-Position: refs/heads/master@{#426822}
-
kraush authored
RTL is not supported in SDK level 16. This test that relies on native RTL support should therefore be disabled. BUG=657927 Review-Url: https://chromiumcodereview.appspot.com/2434293002 Cr-Commit-Position: refs/heads/master@{#426821}
-
braveyao authored
switches::kEnableWebRtcHWH264Encoding was added for extensions and can be used before SW fallback is in place. Now it's time to remove it since SW fallback is already ready for all desktop platforms. BTW: Another reason is after cl https://codereview.chromium.org/2358683002/ has landed, the checking to switches::kDisableWebRtcHWEncoding is having the same effect. BUG=651981 Review-Url: https://chromiumcodereview.appspot.com/2428383005 Cr-Commit-Position: refs/heads/master@{#426820}
-
jam authored
Also fix NavigationRequest not handling blocked requests. This fixes WebViewTests/WebViewTest.Shim_TestNestedSubframes/* WebViewTests/WebViewTest.Shim_TestWebViewInsideFrame/* with PlzNavigate. BUG=504347 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://chromiumcodereview.appspot.com/2441843002 Cr-Commit-Position: refs/heads/master@{#426819}
-
olka authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/9c4cafa..5a1b3fe $ git log 9c4cafaa..5a1b3fe --date=short --no-merges --format=%ad %ae %s 2016-10-21 magjed@webrtc.org Android VideoFileRenderer: Wait for posted frames in release() 2016-10-21 ivoc@webrtc.org Add a placeholder stat for logging the estimated residual echo likelihood. 2016-10-21 henrika@chromium.org Avoids invalid copy of audio buffer to task queue. 2016-10-21 nisse@webrtc.org Delete DataLog abstraction, which was almost unused. 2016-10-20 nisse@webrtc.org Reland of Delete unused file mediacommon.h. (patchset #1 id:1 of https://codereview.webrtc.org/2441493003/ ) 2016-10-20 zijiehe@chromium.org SUCCEEDED macro is misused 2016-10-20 zijiehe@chromium.org BringSelectedWindowToFront should bring the window to front instead of only focusing it 2016-10-20 danilchap@webrtc.org Use variadic templates instead of pump for RefCountedObject 2016-10-20 aleloi@webrtc.org Move audio frame memory handling inside AudioMixer. 2016-10-20 aleloi@webrtc.org Replaced thread checker with race checker in AudioMixer. 2016-10-20 honghaiz@webrtc.org Fix some flaky tests by using longer timeout and/or fake clock. Also use const variables for timeout values. 2016-10-20 jbroman@chromium.org Return nullptr from RTCCertificate::FromPEM on failure. 2016-10-20 sergeyu@chromium.org Move shared_desktop_frame.cc to webrtc/modules/desktop_capture:primitives TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://chromiumcodereview.appspot.com/2437373002 Cr-Commit-Position: refs/heads/master@{#426818}
-
lukasza authored
r426336 intended to add a data dependency for site-per-process.content_browsertests.filter on Android builds. The CL missed the fact that the modified line (where "|| is_android" was added) is nested in a long if that says "if (!is_android)". Doh... This CL tries to ensure that the dependency is *really* there. The CL also refactors away nested ifs and ifs with negative conditions. Hopefully this will help avoid similar confusion in the future. BUG=654569 Review-Url: https://chromiumcodereview.appspot.com/2434983003 Cr-Commit-Position: refs/heads/master@{#426817}
-
bnc authored
Rename enum identifiers: * s/kProtoQUIC1SPDY3/kProtoQUIC/ in enum NextProto; * s/CONNECTION_INFO_QUIC1_SPDY3/CONNECTION_INFO_QUIC/ in enum HttpResponseInfo. This CL means no functional change. A follow-up CL might change the "quic/1+spdy/3" string literal in HttpResponseInfo::ConnectionInfoToString() and SSLClientSocket::NextProtoToString(). Review-Url: https://chromiumcodereview.appspot.com/2365243004 Cr-Commit-Position: refs/heads/master@{#426816}
-
jonross authored
We would like to share the event handling logic of RenderWidgetHostViewAura with RenderWidgetHostViewMus. As a first step this change refactors the EventHandler code out of RenderWidgetHostViewAura into its own class TEST=manually run browser, dry-run of CQ to verify all existing tests. BUG=631270 Review-Url: https://chromiumcodereview.appspot.com/2317333002 Cr-Commit-Position: refs/heads/master@{#426815}
-