- 19 Aug, 2020 40 commits
-
-
Nicolas Ouellet-Payeur authored
Following the change that adds the grouping.xml check: https://chromium-review.googlesource.com/c/chromium/src/+/2303313 Also updates grouping.xml to make sure the test passes on CQ. Bug: 1107860 Change-Id: Icb4eea6540c6ddeb95dcd5efa9ea86ccec2afc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362988Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#799619}
-
Fred Mello authored
The Clank team is reviewing the ownership of all `/android` directories and adding/updating OWNERS as part of an effort to normalize code health metrics across different data sources. https://docs.google.com/document/d/1IYe0TIGAsJl-gZL39l31a2zUa_YasmcyfOIC-zllU_s Bug: 1112872 Change-Id: I71fedd33bb14cb4a449db71c253bd48f23c20097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362632 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#799618}
-
Marijn Kruisselbrink authored
Implements the changes from https://github.com/WICG/native-file-system/pull/219. Change-Id: Ic785f0362b5c73a843145c5384f063cf24770b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360597 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799617}
-
Peter Kasting authored
* Shorten code * Use const more * Inline temps * Use safe conversions for float -> int * TimeDelta::InMicrosecondsF() returns a double Bug: none Change-Id: I798ee7107bcbda863f95ee7921c4ddfd76768183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359008 Commit-Queue: Cait Phillips <caitkp@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#799616}
-
Elly Fong-Jones authored
This infobar will be used (via field trials) to display updated info about current OS support and provide users with a link to more info. The infobar receives both activation info (which configs to show for) and the actual strings to display via field trials, so it can be updated for deployed Chrome instances without an update cycle. This change adds: * The infobar itself * A feature MacSystemInfobar that controls whether the feature is enabled and if so which configs (Arm or Rosetta) it's enabled in * A switch --force-mac-system-infobar which causes the infobar to act as though it was running on a specified system, for both manual and automatic tests * A variety of IDS_MAC_SYSTEM_INFOBAR_* constants to customize the infobar's message, link, and link text * Unit tests for the logic to interpret the feature and the enable/disable configs Bug: 1116578 Change-Id: Ie7fd6e772a0112a17e794d1b8fcb009c57ebed4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360479 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#799615}
-
Matthias Körber authored
Although not rolled out yet, some tests fail when structured names are globally enabled. This CL proactively fixes most remaining issues. Change-Id: I0f0a54612be8118cf472987cd022b702416b21be Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362734 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#799614}
-
Alexander Dunaev authored
The functionality had been available for non-Ozone path. This CL moves the necessary enum and utility function to the component so Ozone can use it. Bug: 1097007 Change-Id: Id7070dc7a87e4efc36d3611f072b89c4ce9e4da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359040Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#799613}
-
Dominique Fauteux-Chapleau authored
Turns out the fix in https://crrev.com/c/2346914 doesn't work. This adresses the problem at the root cause: RenderWidgetHostViewAura::OnWindowFocused only ignores gaining focus but not losing it, meaning clicking on the page while the scanning dialog is open loses focus but the page doesn't get it back from calling Focus() in WebContentsImpl::IsClipboardPasteAllowedWrapperCallback since host()->IsIgnoringInputEvents() still returns true at that point. The fix is to not lose focus in the first place by moving the IsIgnoringInputEvents call at the top of OnWindowFocused. Bug: 1100902 Change-Id: I0cfc0d79436514eac50a81df803abac10f71f430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363692Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#799612}
-
Stephen Lin authored
R=pkasting@chromium.org Bug: 1117548 Change-Id: I9cf42b1e3c866f51a36feceb6186929c92a36ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362975 Auto-Submit: Stephen Lin <stephenlin@chromium.org> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I855f54afdbf00736904f83fdba074473f0b7b057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362346Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799610}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/876a3dc88ac4..bcdfc8975ea2 2020-08-19 terelius@webrtc.org Group decoded frame events by SSRC when compressing RTC event log. 2020-08-19 nisse@webrtc.org Delete CodecInfo::is_hardware_accelerated If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic41a19e53710c7432d7d68416ce1be8304b7f1a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364265Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799609}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597795195-73a3893f6ac2e232e6f2551f9490f3476218900c.profdata to chrome-mac-master-1597838234-9c863d7c9dc15ae374a8358c943ba78053f4a35c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie54f324eea4a0c4b3c89e47ff911fbfab55114f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363378Reviewed-by:
-
Adithya Srinivasan authored
Uses a longer timeout when waiting as video capture device enumeration seems to take longer on the Marshmallow tablet testers. Bug: 1115888 Change-Id: I7145fd957571094d149ef928f83c92d682512b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363355Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#799607}
-
Xi Han authored
This CL fixes the issue of "Tab title is missing on the single Tab when Instant Start is enabled". When missing the creation of TabAttributeCache, SingleTabSwitcherCoordinator won't have a TabModelSelectorTabObserver, thus will miss the TabModelSelectorTabObserver#onTitleUpdated(Tab tab) etc. events. Bug: 1097789 Change-Id: If7037519e4f48292828c390a89cc4cb79fd966a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363715 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799606}
-
Christian Dullweber authored
Change-Id: I4b309c8a1538d0e65761b283410176cfbcd60dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362612 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799605}
-
chrome://managementAndreea Costinas authored
Change the wording and location of the proxy server disclosure in the transparency panel. Bug: 1116961 Test: unittests Change-Id: Id394511a6357329e629a37f19a4f83a4d49ea0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360073Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Greg Levin <glevin@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#799604}
-
Etienne Pierre-Doray authored
Manual reland take 2: Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2029609 Revert 1: https://chromium-review.googlesource.com/c/chromium/src/+/2109970 Revert 2: https://chromium-review.googlesource.com/c/chromium/src/+/2254470 Reason for revert: flaky DCHECK in AssertExpectedConcurrency Fix: DCHECK ended being removed in https://chromium-review.googlesource.com/c/chromium/src/+/2363074 Additional changes: the impl now uses exposed worker_count and IsCompleted() instead of available_concurrent_marking_task_ids_/ active_markers_, thus reducing complexity and removing need for concurrent_marker_bootstrapping_lock_. Original Description: Note: This CL enables feature BlinkHeapConcurrentMarking to get the desired behavior. However, we should land enabling BlinkHeapConcurrentMarking on its own first. active_markers + GlobalPoolSize() is used to determine the desired number of workers. NotifyConcurrencyIncrease() is called periodically from ConcurrentMarkingStep() if GlobalPoolSize() > 0, to make sure enough workers are scheduled. Bug: 1046343 Change-Id: Iac4941d804714745545314eec1e1b33d1734a4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261352 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799603}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f3714abe. With Chromium commits locally applied on WPT: ed257e2b "[CORS] Set preflight request mode correctly" 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I81507019ee1f0ffcaa52453f037d0685a1c40f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362345Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799602}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/fdc636b4ce09..3fd2db22eef9 $ git log fdc636b4c..3fd2db22e --date=short --no-merges --format='%ad %ae %s' 2020-08-13 jdrago Remove range and sample position from avifImageStealPlanes(), transfer alphaRange manually 2020-08-13 jdrago Revert "Decouple CICP parsing/overriding from decoder->image; ensure CICP is valid and set at the end of Parse and NextImage" 2020-08-13 jdrago Decouple CICP parsing/overriding from decoder->image; ensure CICP is valid and set at the end of Parse and NextImage 2020-08-13 jdrago Remove recent change as it confuses MS' static analysis Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org Change-Id: I097aa9e4b01cb484fcd1fe54bec0b545aa465b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363658Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#799601}
-
Scott Violet authored
Android-R adds an attribution tag to Context. This tag can be used to identify what parts of an application are requesting/using services. Chrome code assumes a single Context, and for WebLayer that Context is the application context. WebLayer calls getApplicationContext() on the Context supplied to it. This means the attribution tag set on the Context supplied to WebLayer is lost. This patch changes WebLayer so that the attribution tag of the supplied Context is propagated to the Context used by Chrome/WebLayer. This gives the user of WebLayer a way to attribute usage of system services to WebLayer. BUG=1085041 TEST=none Change-Id: I65eeea60289e57d563875754231658466c37dddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361022Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#799600}
-
Mohamed Amir Yosef authored
It's similar to PasswordStore::::Observer::OnLoginsChanged() but captures the originating store too. Bug: 1108422 Change-Id: I30ce80beec9d7a38bd4d148fe80b8efba722437d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362610 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#799599}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e60f72f6801e..72e31331da03 2020-08-19 fmayer@google.com Merge changes Icbb2ec8e,I6981cc7a,I14af99be 2020-08-19 lalitm@google.com Merge "tp: rework thread state in prep for parsing blocked reason" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1e470b50294bdc02742358810ee51d2b65d8c583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364263Reviewed-by:
-
David Bokan authored
The scheduler prioritizes commits when we're in a scroll and there's a scroll handler. Today this is done by checking for scroll event handlers in scroll begin and storing that state. It seems like we could simply apply the scheduling strategy dynamically after scroll begin, which allows us to remove some connections between LayerTreeHostImpl and the ThreadedInputHandler. Bug: 915926 Change-Id: Ic7b0c7b388f77c2f708e5f73c235a9a0e5511d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363724 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799597}
-
Milica Selakovic authored
This CL adds check for scripts availability only if kPasswordChageInSettings flag is enabled. This CL also changes PasswordScriptsFetcherBridge so it does not use Profile information and can be used in SafetyCheck to prewarm cache. Bug: 1086114, 1092444 Change-Id: I87021c2e65c7886ad90ee80844b9a2e46fb4b626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351994 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#799596}
-
Christian Dullweber authored
mMaxPermissionOrder was not updated correctly. Avoid this problem by not storing it globally. Bug: 1117422 Change-Id: Ic200c7f6130347cec6635e4d09fa460c99a3a7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364533 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Chris Hamilton authored
Further CLs will migrate blink code to use these bit by bit. BUG=1096617 Change-Id: Iceb0090a4ea835cf5a524a7333da65068ee7afb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363552Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#799594}
-
David Bokan authored
This CL adds an interface through which LayerTreeHostImpl and the "graphics" side of the compositor can talk to the input handler. For now, LTHI keeps the concrete object and still owns it but eventually this will be moved out and LTHI will only have a reference to the interface. A followup will add an interface for the other direction so that the input system doesn't have to have a concrete reference to LTHI. Bug: 915926 Change-Id: Ieb4c0642e6674b6f09e8c7d8b6ff366cc8179bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359190Reviewed-by:
-
Victor Hugo Vianna Silva authored
Bug: 1062344 Change-Id: I45a3ef9f01e234c342bd442ff9b38d802db5a9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362756Reviewed-by:
-
Alexander Surkov authored
Bug: 1115489 AX-Relnotes: n/a Change-Id: I9271c6325b6d32d3150e53617851ef4f009084d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360218Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#799591}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6a992541..b1eb63de Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9bac8c2d2464e07103f347fe6acf43a16bb20458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362344Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799590}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/050fece535f6..e90094abdc0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dullweber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: dullweber@google.com Change-Id: I39c5285fb231db998a38e1706034a88aaf9bfaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364256Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799589}
-
Mark Mentovai authored
Change-Id: I795e424390afb6c9c6e77995e21f008e0be15d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363800 Auto-Submit: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799588}
-
Oleh Lamzin authored
Move a bit down comment about when closure compiler knows that input is {!Object}. Change-Id: Ia424d3ecce01e544c44f6e2728dca01e46dcde4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362924 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#799587}
-
Andreea Costinas authored
Currently, System-proxy requests proxy authentication credentials from the Network Service. This means the user has to first to login into the Browser and then use the Play Store for navigation. This CL creates a proxy authentication dialogue for System-proxy to request credentials for a remote proxy without going trough the Browser. Bug:1112722 TEST=unittests Change-Id: I263a38c8be4cbbdf0891e515500cd9e5584c63fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352828 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#799586}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/680531a67036..6177a5ec5b8b 2020-08-19 sigurds@chromium.org Fix bug where requests where shown twice 2020-08-19 sigurds@chromium.org Create new icon for blocked frame If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1051466,chromium:1093247 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iec1a32fd5822a3a960ce3dd0a358e36d3641d266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364258Reviewed-by:
-
Boris Sazonov authored
Reason: flaky. Builder links: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/33134 https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/33135 TBR=wychen@chromium.org Bug: 1119322 Change-Id: Icf1cd4dcd2424c3aadf24b508ed25f3f02c406fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362926Reviewed-by:
-
Mugdha Lakhani authored
With this change: https://chromium-review.googlesource.com/c/chromium/src/+/2274888 WebLayerShellActivity exercised the newly added setTextClickListener() method on UrlBarOptions. This set the clicklistener passed in to the UrlBarView's TextView only, which is working as intended. However, the test team would like to retain the ability to click anywhere on the UrlBarView other than the security button and be able to show the editable text view. This change adds that back. I have removed the setTextClickListener() call since two click listeners doing the same thing on the non editable text view is rendundant. Before this change: https://drive.google.com/file/d/16ttRlvh-AqObs4_pA9TiDSRUKVf6bcO-/view?usp=sharing After this change: https://drive.google.com/file/d/1y1vFCd4eObMs8C84862V7zQ53siMMKqJ/view?usp=sharing Bug: 1114238 Change-Id: I98eb4314436dbf7d6509a77e4890d0f348b2eebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362817Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#799583}
-
Mark Mentovai authored
The baseline CPU for macOS on arm64 is the Apple A12 (Vortex/Tempest), and clang should default to this when building for this OS/CPU combination. Apple clang embedded in Xcode 12 does, but trunk clang does not, instead targeting the Apple A7 (Cyclone), the proper baseline CPU for iOS on arm64. https://reviews.llvm.org/D82699 would fix it, but it hasn't gained any traction. Specify the baseline CPU explicitly here. Bug: 1107587, 1119249 Change-Id: I2a132b00ef9b5c8262aa24f27a7519d83a3df41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363772 Auto-Submit: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Sreeja Kamishetty authored
This CL disables non-compatible render_frame_host_manager_browsertests with BackForwardCache. BUG=1102629 Change-Id: Ie62ef1a5bc76ef0877edbd2d9745a9d58004d244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354243 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#799581}
-
Mihai Sardarescu authored
This flag is used to enable using the Multilogin endpoint on desktop platforms. Bug: None Change-Id: If7add4d0adb85904fe61c782c65b480b7cc606dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362899Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#799580}
-
