- 28 Jun, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f5a4989c..5d13106e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic61d58161495aef0af7fcdb75e8e5d6dc41f64c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681421Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673330}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f51c389d79a4..6d47875c4c50 git log f51c389d79a4..6d47875c4c50 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 taylori@google.com systrace: Update traceconv version Created with: gclient setdep -r src/third_party/catapult@6d47875c4c50 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@google.com Change-Id: Ic10575628169ac2b5c58cafc0f1e43f0733c42ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681364Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673329}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iea4dbe7cce88e05a8f066a9c65c4c49be508f579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681365Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673328}
-
Xianzhu Wang authored
Bug: 524134, 931486, 923429, 962191, 979369 Change-Id: Ibc32e3816b23cc18acd54952469b5c88b989c2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680512 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#673327}
-
Bryan McQuade authored
We return early in cases where an element doesn't move in its parent's coordinate space, however it's possible that an element moves within the parent space but stays in the same position within the viewport. To address this, we check to see if the element moved in viewport space, as well. Bug: 976920 Change-Id: I98175e3cbf2c551cdf6ed2de599e84da454439e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673132Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#673326}
-
Fredrik Söderquist authored
Creating this object for each call represents a significant part of the entire function. Using a singleton instead reduces the runtime of the testcase "usingSetAttribute" from the referenced bug's comment #5 by around 20% locally. Bug: 978513 Change-Id: I5d3447baf04706e2c23da4ed07cb0197d0349ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681766Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#673325}
-
Alex Khouderchah authored
Bug: 974973 Change-Id: Ie6cb88130e7ceddaafed59419e030443454c9671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680864 Auto-Submit: Alex Khouderchah <akhouderchah@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#673324}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c272b7eda7b3..30c1bb6efcde Created with: gclient setdep -r src-internal@30c1bb6efcde The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=peria@google.com,poromov@google.com,eirage@google.com Change-Id: Ib778840fa4e0717a467f5fb93b3a19a6718584a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681928Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673323}
-
Alex Khouderchah authored
Bug: 974953 Change-Id: Ic4d76253d3cf5144a1352704c6df0330fc869245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680103 Auto-Submit: Alex Khouderchah <akhouderchah@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#673322}
-
Eric Stevenson authored
This reverts commit 5a2cccc8. Reason for revert: Broke webrtc roller. Original change's description: > Reland #2: "Trichrome Proguard: Fix locale pak selection." > > This is a reland of 8209b4f7. > > In the reland: Fixed webview_instrumentation_apk not setting available > locale paks. > > Original change's description: > > Reland "Trichrome Proguard: Fix locale pak selection." > > > > This is a reland of beea44ce > > > > Fixed the package name of the generated file being incorrect for Webview in > > chrome_public_apk_tmpl.gni. > > > > Original change's description: > > > Trichrome Proguard: Fix locale pak selection. > > > > > > This CL moves the arrays of locale pak files out of BuildConfig.java > > > into a new file, LocaleConfig.java. > > > > > > This file is generated with a unique package which allows Chrome > > > and Webview to have different versions in Trichrome. > > > > > > Bug: 960025 > > > Change-Id: I906d0c7e6c1540bfaa5f89e7bd9adbd9f97c8262 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610255 > > > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > > Reviewed-by: Richard Coles <torne@chromium.org> > > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#662209} > > > > TBR: dtrainor@chromium.org, torne@chromium.org > > Bug: 960025 > > Change-Id: Id8ffe2e02c461ccff1b23d5328972c893415f05b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625375 > > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > > Auto-Submit: Eric Stevenson <estevenson@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#662324} > > Tbr: torne@chromium.org # //android_webview/ unchanged from original CL > Bug: 960025 > Change-Id: Id11873246c7ee10198fbe625717a1364fbe0a5fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627638 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672538} TBR=dtrainor@chromium.org,torne@chromium.org,agrieve@chromium.org,estevenson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 960025 Change-Id: I931c15d8bc1571fd6d8c29a4127001957c09d7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681868Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#673321}
-
Sean Gilhuly authored
Some of the masks tests pass by making the pixel comparator slightly fuzzier. Also run the masks test suite with more raster modes for Skia GL. Bug: 948128 Change-Id: I18063107f306743da91a38963d9de98ab4ccd15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680291Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#673320}
-
Miyoung Shin authored
This CL replaces the use of std::vector and std::set of std containers and std::string with WTF::Vector, blink::WebVector, blink::HashSet and WTF::String in graphics/*. Bug: 952716 Change-Id: Ic0fcc03bce54f5490ceda2596206c243b339e155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681720Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#673319}
-
Miyoung Shin authored
This CL replaces the use of std::vector and std::queue of std containers and std::string with WTF::Vector, blink::WebVector and WTF::String in loader/*. Bug: 952716 Change-Id: I2f93adcf4cdce37b7fdcc4cf3bc3e43fd37bac5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681718Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#673318}
-
Mohamed Amir Yosef authored
This reverts commit e877970f. Reason for revert: I will land it again after splitting into two patches since one of them should be merged to M76 Original change's description: > [Sync::USS] Fix USS Bookmarks deletions > > Before this CL: > The ModelTypeWorker were unconditionally setting the title in the > BookmarkSpecifics, if the SyncEntity.name isn't empty. > However, the production server sets the name to "tombstone" for > tombstones and hence the worker would actually set the title in > the specifics. > As a result the specifics are never empty. Empty specifics are used > further in the pipeline to identify remote deletions, and hence > remote deletions are always ignored. > > After this CL: > The ModelTypeWorker would only assign the title for non-tombstones. > It would also adjust the Loopback server behavior to be more aligned > with the production server. > > Bug: 979150 > Change-Id: I3ddebcfb8989b53cd6ddd2e2d3f6f0c7d2020463 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680400 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672936} TBR=mastiz@chromium.org,mamir@chromium.org Change-Id: I0ef0dc733a6e2eef52d01e99e51d479d2e79f6a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 979150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681772Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#673317}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It adds RefreshToken{Available,Revoked}Callback to DeviceOAuth2TokenService and DeviceIdentityProvider registers them instead of adding observer. DeviceOAuth2TokenService observers the refresh token status as it inherits from OAuth2TokenService and DeviceIdentityProvider gets the status through the callback. It eliminates DeviceIdentityProvider inheriting from OAuth2TokenServiceObserver. Bug: 967598 Change-Id: I786d82d26db942f03c5bf907d6aa4f83cc00c6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681440 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#673316}
-
Colin Blundell authored
This CL is part of setting up the reorganization of //components/signin. It moves account_info_util.* into the "internals" target as it's used only by the files in that target. Bug: 952788 Change-Id: I197a010d3c4dfef7da5ad17f8754a60a406a1c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681582 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#673315}
-
chrome://flagsJustin Cohen authored
This reverts commit 5f5495bb. Reason for revert: Don't wait for keyboard animation. Original change's description: > Revert "[ios] Dismiss keyboard when navigating to chrome://flags in test." > > This reverts commit 99473df8. > > Reason for revert: Not always working. > > Original change's description: > > [ios] Dismiss keyboard when navigating to chrome://flags in test. > > > > On iOS 13 chrome://flags presents the keyboard which does not allow > > tapping on back button. > > > > Bug: 977707 > > Change-Id: Ia0da9e063b894da4fbfccfb12d7d839774c3b230 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666731 > > Commit-Queue: Eugene But <eugenebut@chromium.org> > > Auto-Submit: Justin Cohen <justincohen@chromium.org> > > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#673082} > > TBR=justincohen@chromium.org,eugenebut@chromium.org,michaeldo@chromium.org > > Change-Id: Ia4a2f62f4bbd3a9ab46f314b209d09d0f0cb5b61 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 977707 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681438 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#673179} TBR=justincohen@chromium.org,eugenebut@chromium.org,michaeldo@chromium.org Change-Id: I6fe54aa0a434fa9d837a04df7ed6853e4f62a1c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681442 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#673314}
-
Sebastien Marchand authored
Bug: 961336 Change-Id: I91c40d8d6a603ab6ea7fdef31b2fb76a01ee28b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659468 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#673313}
-
Chris Hamilton authored
BUG=910288 Change-Id: I7bfee2737ef37ff344a76a5d3f5dafcf8bd2541c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665552 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#673312}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/923c30fba116..625f5b2fbd89 git log 923c30fba116..625f5b2fbd89 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 jmadill@chromium.org Cleanup angle_libs_suffix in BUILD.gn. Created with: gclient setdep -r src/third_party/angle@625f5b2fbd89 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I6b55444c19af2b6d7d38f2d86cc99b571874e86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681927Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673311}
-
Boris Sazonov authored
Change-Id: I789945c4befe43d2a44bbc6959e2873528f6ca4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680619Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#673310}
-
Kurt Horimoto authored
BrowserViewController.currentWebState is not guaranteed to be non-nil, so the OverscrollActionsTabHelper should not be accessed without checking the WebState first. Bug: 978008 Change-Id: Ic0fd90219c130d704d21d49debf7584982fc9afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674884 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#673309}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It adds OAuth2AccessTokenManager::Delegate::OnAccessTokenInvalidated() and ProfileOAuth2TokenService that inherits from OAuth2AccessTokenManager::Delegate implements it. Bug: 967598 Change-Id: Ifb1b27ff9d1c798223fa03cb48f5f4d293acaa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680269Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#673308}
-
Sergey Poromov authored
TBR=miu@chromium.org Bug: 974427 Change-Id: I6494184be2bca254d5cf240572cf7e1d33978142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681888Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#673307}
-
Colin Blundell authored
In preparation for the code restructuring of //components/signin, this CL moves mutable_profile_oauth2_token_service_delegate* from the //components/signin/core/browser target to the //components/signin/core/browser:internals target where it belongs. This change has the ripple effect of requiring //components/signin/core/browser/webdata to be separated out of //components/signin/core/browser in GN, as MutablePO2TS depends on the webdata. That change is also conceptually correct as webdata is conceptually layered below all of the rest of //components/signin. Bug: 952788 Change-Id: I309512f4904157b1881ec9860bdec2c17f371245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681701Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#673306}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b851469b8e96..afd2c10c989c git log b851469b8e96..afd2c10c989c --date=short --no-merges --format='%ad %ae %s' 2019-06-28 fmalita@chromium.org [skottie] Use hybrid bounds for custom Shaper VAlign modes 2019-06-28 fmalita@chromium.org [skottie] Use explicit font ascent in Shaper Created with: gclient setdep -r src/third_party/skia@afd2c10c989c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@google.com Change-Id: I97e1ee26d55385a96bd00bf00a5e1978eab774c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680836Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673305}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It adds OAuth2AccessTokenManager::Delegate with CreateAccessTokenFetcher(), FixRequestErrorIfPossible(), and GetURLLoaderFactory() moved from OAuth2TokenServiceDelegate. OAuth2TokenService implements OAuth2AccessTokenManager::Delegate and be passed to OAuth2AccessTokenManager. OAuth2AccessTokenManager keeps still OAuth2TokenServiceDelegate as it's in the middle of moving the APIs from OAuth2TokenServiceDelegate to OAuth2AccessTokenManager::Delegate. Bug: 967598 Change-Id: I93ca88e49ab6b60a3812e953cd07eb3343762038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677425 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#673304}
-
Johannes Kron authored
WebRTC stats PR: https://github.com/w3c/webrtc-stats/pull/450 Bug: webrtc:10775 Change-Id: I9513f99d2f04ed5b876c4298bac923be31ce2f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681704Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#673303}
-
Yuki Shiino authored
Minor refactoring of IdentifierIRMap.find_by_kind. Bug: 839389 Change-Id: I60269a84db28d921d6a0ce8d537e37a623f884d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681721Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#673302}
-
Yutaka Hirano authored
In preparation to removing AddChannelRequest, rename AddChannelResponse to OnConnectionEstablished. OnFinishOpeningHandshake has been confusing because it doesn't mean successful handshake finish (i.e., connection establishment). Rename it to OnResponseReceived. Rename OnStartOpeningHandshake to OnOpeningHandshakeStarted for consistency. Bug: 967524 Change-Id: I629fb5d144c3abe49bfb0fdc3c25ba62b4d26520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680676Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#673301}
-
Alex Ilin authored
The ReachedCodeProfiler feature is controlled by the finch experiment but the feature is in practice enabled with a lag. To track the sessions in which the profiler is actually enabled, we register a synthetic field trial. The one disadvantage of this approach is that the synthetic trial was recorded for 100% of users, making hard the comparison between control and enabled groups. This CL modifies recording of the synthetic trial so that it records the exact finch trial group that was selected in a previous session. Bug: 916263 Change-Id: I7a7668667861175cdc0b2068a99b1fe619dd7c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543398 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#673300}
-
Eugene But authored
Starting from iOS 13, document.write() can change the origin or the URL without calling didStartProvisionalNavigation didFinishNavigation: WKNavigationDelegate callbacks if page is about:blank. This executes code path which changes URL without document change. That code path has DCHECK to verify that origin does not change. This CL relaxes DCHECK to allow origin change on iOS13 if current document URL is about:blank. Bug: 978969 Change-Id: I1435d43e008f9f03c6352b0c39f3acaa941282a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681078 Commit-Queue: Ali Juma <ajuma@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#673299}
-
Eric Stevenson authored
This reverts commit 632c08d1. Reason for revert: Depends on 5a2cccc8, which broke the webrtc roller. Original change's description: > Fix locales for ChromeBrowserTestsActivity. > > Other test activities call setNoAvailableLocalePaks() and the > ChromeBrowserTestsActivity was missed since it is not in the CQ or > waterfall yet. > > This fixes the problem introduced by > https://chromium-review.googlesource.com/c/chromium/src/+/1627638 > > R=sky@chromium.org > > Bug: 961849 > Change-Id: I13f1046068326fc27a1b71410427a73ffdbdd40b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680511 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#673166} TBR=sky@chromium.org,danakj@chromium.org,estevenson@chromium.org Change-Id: Ic718d4ba741caf82d0a78a1597b25e8bdbbfd432 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 961849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681947Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#673298}
-
Edward Jung authored
config Bug: 978002 Change-Id: I5e0500ff1ba385bef86fa19a239c3c2b5a66d96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672862Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#673297}
-
Rayan Kanso authored
Bug: 979235 Change-Id: I7f9ddf6c80f0e13707beec1f8827357cf2b21daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680469 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#673296}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b91d18594fa..c272b7eda7b3 Created with: gclient setdep -r src-internal@c272b7eda7b3 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=peria@google.com,poromov@google.com,eirage@google.com Change-Id: Ifc422b619fec5f71bb9afad87f0b7d150843748e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681867Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673295}
-
Robbie Gibson authored
This CL adds dark mode support for all the settings submenus except for the collection view cell catalog. It also removes all references to non-dark mode UIColors ios/chrome/browser/ui/table_view/cells except for a few different blues, which will be removed soon. Bug: 976668 Change-Id: Ie2c954dd824cb6739a254cfae9a86d0079285293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672861 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#673294}
-
Alex Clarke authored
(Fix was to make SingleRejectPrerequisitePolicyALLModified not use RunUntilIdle) Original patch: https://crrev.com/c/1640639 The idea (thanks Etienne) is to not retain any prerequisites (including curried ones) until they've settled. This fixes ref counting cycles while ensuring results are retained for dependencies. This patch also changes the way curried promises are handled which was necessary to break refcounting cycles. Now when a promise resolves or rejects with a promise, its dependents are modified to use the curried promise as their prerequisite instead. TBR=fdoray@chromium.org Bug: 968302, 906125 Change-Id: I1532faff6fe4f55dc236210389db62eb6a03212f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680264Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#673293}
-
Alex Chau authored
- This caused EncryptMessage to be called with empty string - Added test to ensure payload in SendWebPushMessage can be decrypted Bug: 966037 Change-Id: Ibb1e3ee41c92ca81c67008878714c4f76f6d2cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679766 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#673292}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/50d40acd7be1..f51c389d79a4 git log 50d40acd7be1..f51c389d79a4 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 khokhlov@google.com Output traces recorded as artifacts in chartjson format Created with: gclient setdep -r src/third_party/catapult@f51c389d79a4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:972025 TBR=crouleau@google.com Change-Id: Ife54f33a72acae76e01fa673cd7525c357158fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681277Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673291}
-