GitLab

To avoid the complexity of caching and restoring still-loading pages,
for now simply don't cache pages that haven't finished loading.

Long term this logic will probably need to be extended to be more
complicated/permissive, to increase back-forward cache coverage.

Change-Id: Ic06d9b3d425d3df95b8d09bea1561c000a96acc4
Bug: 976697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692414Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680383}

HasPendingActivity is called during blink unified heap marking phase and
GC allocation is not allowed during this phase.
There is a DCHECK in ThreadHeap::AllocateOnArenaIndex that checks this.

TimeRanges member functions allocate using MakeGarbageCollected.
This change moves TimeRanges logic to WebTimeRanges to allow use
of it without GC and TimeRanges now uses WebTimeRanges.

Bug: 970150
Change-Id: Idcceb61cb4506e50f0839c87be9b9d803e04b947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663133
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680382}

This adds a user policy (VmManagementCliAllowed), a corresponding
preference (crostini.vm_management_cli_allowed_by_policy) and wires
them.

The policy will be used for an experimental feature that limits access
to vmc and vsh (potentially other commands as well).

Test: compile, run unit tests
Bug: 983996
Change-Id: Ib53e4f180f3436da86cfe04ec5bd14f7337c58ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702262Reviewed-by: Alex Oldemeier <aoldemeier@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Fergus Dall <sidereal@google.com>
Commit-Queue: Ilya Bizyaev <ilyabiz@google.com>
Cr-Commit-Position: refs/heads/master@{#680381}

Bug: 959650
Change-Id: Iddaddd4de70a3fb80ca6b21a9d9e0a7238e06162
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715369Reviewed-by: Martin Robinson <mrobinson@igalia.com>
Commit-Queue: Jessica Tallon <jtallon@igalia.com>
Cr-Commit-Position: refs/heads/master@{#680380}

https://android.googlesource.com/platform/external/perfetto.git/+log/0cf661b2a81d..fd3e53d52cec


git log 0cf661b2a81d..fd3e53d52cec --date=short --no-merges --format='%ad %ae %s'
2019-07-24 treehugger-gerrit@google.com Merge "protozero: Add post-increment operator for repeated fields"


Created with:
  gclient setdep -r src/third_party/perfetto@fd3e53d52cec

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Ic351719e8e107623420424780a8342140f7f3858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715334Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#680379}

The largest is that all 3 dialogs are now modal -
this gives them a black background and makes it hard to mess
with things behind it (although ChromeOS doesn't seem to be
perfect at modal dialogs).

And, 2 of the dialogs no longer have a title bar / x button.
These 2 are the urgent password expiry notification,
and the confirm password change dialog.

Both of these dialogs are also changed in line with the latest
UI spec.

The other dialog, the hosted password change dialog,
still needs more work.

The screenshots of these changes are visible internally here:
http://go/insessionpwchange-screenshots

Bug: 930109
Change-Id: I1712e93a1fa924e7729cd837606398662c2067ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715344
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680378}

From an email discussion:

marcuskoehler: May I ask you to add ppkfnjlimknmjoaemnpidmdlfchhehel to
the MGS whitelist so that it doesn't cause the full warning?

TBR=mnissler@chromium.org

Change-Id: I1c98cdc3318475a04c7e342897dd1009bd595079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716744
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680377}

Change-Id: Iedf6401d6017d2d8d04749ef5f58f27f84cdfcf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702261
Auto-Submit: Rafał Godlewski <rgod@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Rafał Godlewski <rgod@google.com>
Cr-Commit-Position: refs/heads/master@{#680376}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/40355312..098b545f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ic59f9b234302d59195cfaa3b157b9c755046aba9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715890Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#680375}

https://chromium.googlesource.com/catapult.git/+log/fbd94ccd66ee..9f89d086a26b


git log fbd94ccd66ee..9f89d086a26b --date=short --no-merges --format='%ad %ae %s'
2019-07-24 dberris@chromium.org PinpointScheduler: Allow cancellation in job page
2019-07-24 dberris@chromium.org PinpointScheduler: Support cancelling running jobs


Created with:
  gclient setdep -r src/third_party/catapult@9f89d086a26b

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=skyostil@google.com

Bug: chromium:977488,chromium:977488
Change-Id: I7ac0df176ce59d14a42e9c7527552af923d2b7fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716240Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#680374}

Following WebGPU spec change at https://github.com/gpuweb/gpuweb/issues/283,
this CL makes sure *loadOp and clear* are consolidated into an unioned
field in GPURenderPassColorAttachmentDescriptor and
GPURenderPassDepthStencilAttachmentDescriptor.

Bug: 877147
Change-Id: I4a676e8cfa52844f2df54b6201e6db453c1d9e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715267Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#680373}

Specifically:
 - Replace var with let/const (using lebab)
 - Fix missing/extra semicolon violations
 - Fix missing curly braces violations
 - Fix double quotes violations
 - Fix JS naming violations
 - clang-format
 - Add PRESUBMIT to catch these automatically moving forward.

Bug: 986001,792774
Change-Id: I1d180fd3557243e08b0009c4fdc122ffa742b505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716094
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680372}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/532f86826d5c..93c16af35dfb


Created with:
  gclient setdep -r src-internal@93c16af35dfb

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com

Bug: chromium:None
Change-Id: Ib56716af9669443d219d172ab8c330df20b757e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716197Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#680371}

Also stores the domains of the deleted cookies for later use in removing
additional storage for these domains.

Bug: 987177
Change-Id: I600be2dcdbe4fdacd52cf6cdba65de049f9d4bbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699668
Commit-Queue: Jenny Blessing <jblessing@google.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680370}

Previously ServiceWorkerNewScriptLoader returns kErrorExists when the main
worker script was just truncated because it calls CommitCompleted() when the
Mojo data pipe is closed. However, it's a problem because it doesn't tell the
cache writer about the end of the body so that the cache writer isn't aware of
the truncation.

This CL is to trigger MaybeWriteData() at connection close for the cache writer
to give a chance to run script comparison at the end of the body.

Bug: 986688
Change-Id: I8a816ab1ab1a2e236c1a21c1f0950437cd1e50ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714584Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680369}

Previously, https://crrev.com/c/1681768 added migration logic from the
old "SyncSuppressed" pref to a new "SyncRequested" pref (which better
matches what it means, and has the correct default value). However, the
migration code was only triggered on non-iOS platforms, leaving iOS Sync
users in a bad state (new pref is used, but has no value).
The fix is simply to trigger the migration logic also in iOS's version
of browser_prefs. This also bring users back into a good state.

Bug: 906034
Change-Id: Ib52ea658bf616ca47e947980d2ddc1fb50f02b5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715285Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680368}

This merges signin_manager_android_wrapper.* into
signin_manager_android.* and updates the factory accordingly.

This is in the scope of a change of strategy regarding the
identityManager implementation on Android, using a layering strategy
similar to what was done on iOS. Due to this, the wrapper is no longer
required.

Change-Id: Ic4ecd68b07c07c77fb1d8a2756dd30103eeb4434
Bug: 985256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703410Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680367}

This reverts commit 68335421.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 680135 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjgzMzU0MjEzMGQyODg4YzMxNDQ2ZjI0MGQxNjkwOGY0NWFiNjhjYQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/13542

Sample Failed Step: browser_tests

Sample Flaky Test: PromiseResolverModuleTest.All

Original change's description:
> Web UI Polymer 3: Port tests for shared JS Modules
> 
> Port tests for the shared JS resources migrated to modules in
> https://crrev.com/c/1682889.
> 
> Note: Tests only run if optimize_webui is false, since these
> resources only exist in this case.
> 
> Bug: 965770
> Change-Id: Ia45584f59617165b3d230d551351ea51f3385add
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703424
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#680135}


Change-Id: I90be6d4a72a24e15a0bbf7f7004aed32153b65a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 965770
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716636
Cr-Commit-Position: refs/heads/master@{#680366}

To reach devices in doze mode, we need to send sharing messages with
high urgency.

Bug: 966037
Change-Id: I5521a2bb97727b9b1077e82e4ec3e6167c5e789c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710318
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680365}

We only need to map and unmap the JPEG buffers when the video capture
stack uses GpuMemoryBuffer-based buffers from the buffer pool.

BUG=b:138274061
TEST=Manually on device

Change-Id: I64a2bf8a7fc26bab684a28e8a5ddd971a393cbab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716449Reviewed-by: Wei Lee <wtlee@chromium.org>
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680364}

https://android.googlesource.com/platform/external/perfetto.git/+log/67440068b934..0cf661b2a81d


git log 67440068b934..0cf661b2a81d --date=short --no-merges --format='%ad %ae %s'
2019-07-24 primiano@google.com Merge "Client API: Expose Flush() method"
2019-07-24 treehugger-gerrit@google.com Merge "client api: Support data sources across translation units"
2019-07-24 treehugger-gerrit@google.com Merge "client api: Select a tracing backing automatically"


Created with:
  gclient setdep -r src/third_party/perfetto@0cf661b2a81d

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I1131acc82f1a3c6bc3ee6dbf57aabe89887a7f8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716593Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#680363}

Before this patch, we would wait for AA to be shown before invoking the espresso check. This would sometimes fail on slower devices, because asynchronous events on the native side might not have finished processing at that point.

This CL instead continuously polls the UI thread until the specified condition is matched or the default timeout is reached.

Bug: b/986026
Change-Id: I311f94dd8fd4383dfcce35656299bddce366b7bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712564
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680362}

TBR=rockot@google.com

Bug: 987155
Change-Id: I72c9a3d235acbc76012d6dee78832ce8ca89f678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715368Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680361}

Bug: 980542
Change-Id: I02a499fc4c1878be3ad25ff62d5f9b437988e510
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715345Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680360}

Change running check from VM to container.

Bug: 968060
Change-Id: I8340931a4cdfea205b52ef40162e6e99120ec8b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715760
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680359}

Also rsorokin@ takes over ownership.

Bug: 969925
Change-Id: I18d8885b5ea0db420095dcc346969e5e28de389b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713509
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680358}

This reverts commit 69753f33.

Reason for revert: crashes reported https://crbug.com/987045 and https://crbug.com/987007

Original change's description:
> Reland "Refactor Smart Dim, making it a D-Bus service"
>
> This is a reland of 1b42c60c
>
> Fix the failure of the reverted CL on the chromeos-amd64-generic-rel trybot.
> The reason of failure is that in chromeos-amd64-generic-rel vm, DEVICETYPE is
> empty, which fails the constructor of UserActivityController.
> Add an if statement to MachineLearningDecisionServiceProvider::ShouldDeferScreenDim
> to get around this.
>
> Original change's description:
> > Refactor Smart Dim, making it a D-Bus service
> >
> > Add a Chrome D-Bus service, export ShouldDeferScreenDim method for
> > powerd to call
> >
> > Bug: 933199
> > Change-Id: I275f4eb5f406d6ecdd1fca3590a00c2a0618eb4d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598921
> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> > Reviewed-by: Mattias Nissler <mnissler@chromium.org>
> > Reviewed-by: Dan Erat <derat@chromium.org>
> > Reviewed-by: Andrew Moylan <amoylan@chromium.org>
> > Commit-Queue: Xinglong Luan <alanlxl@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#671533}
>
> Bug: 933199, 977830
> Test: Tested on local vm and trybots.
> Change-Id: Icff1edda1c81a655ad99fc717625914af1dae6bb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675364
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Andrew Moylan <amoylan@chromium.org>
> Reviewed-by: Mattias Nissler <mnissler@chromium.org>
> Commit-Queue: Xinglong Luan <alanlxl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#675470}

TBR=derat@chromium.org,stevenjb@chromium.org,achuith@chromium.org,mnissler@chromium.org,amoylan@chromium.org,jiameng@chromium.org,alanlxl@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 933199, 977830
Change-Id: Icae53c14e913d0ae7abd9e7cef763ef2a41730f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715507Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: Xinglong Luan <alanlxl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680357}

Follows https://github.com/WICG/kv-storage/pull/71.

Bug: 931263
Change-Id: I19abd6bc26ef29870a4ed45e7a65ddbc724d5584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712950Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680356}

https://skia.googlesource.com/skia.git/+log/0f9c660aa939..3ae30cc2e6e0


git log 0f9c660aa939..3ae30cc2e6e0 --date=short --no-merges --format='%ad %ae %s'
2019-07-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 02407743bd72..8bb46c5b9ffc (3 commits)


Created with:
  gclient setdep -r src/third_party/skia@3ae30cc2e6e0

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=borenet@google.com

Bug: chromium:None
Change-Id: Iff7dc2ff04d4904d35294f3850914d97a201d6c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716587Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#680355}

install-build-deps requires lsb_release, add a note for Crostini
to install lsb-release before running install-build-deps

Bug: None
Test: sudo apt install lsb-release; install-build-deps.sh --no-arm
Change-Id: I642275a4aa6ac22ff9c71733a4b4911db23bc392
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716605
Auto-Submit: David Munro <davidmunro@google.com>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680354}

We realized in a conversation around issue 951540 that we don't have settings UI
that allows users to reconsider decisions they've made around external protocol
support. Until we work that out, and make longer-term decisions about the
permission model around the feature generally, we should stop making the problem
worse by removing that checkbox from the UI.

Based on existing telemetry (`BrowserDialogs.ExternalProtocol.HandleState`),
this will affect ~8% of users who interact with the dialog, which itself is a
fairly small group of Chrome's users overall.

Bug: 982341, 987149
Change-Id: I723979aab9606d1c2337a36a8f5a0686b95bb9be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708070
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680353}

This reverts commit d3cda01a.

Reason for revert:
This causes compile failures on multiple bots:
https://ci.chromium.org/p/chromium/builders/ci/Win%20Builder/77590

Original change's description:
> Show Click to Call dialog if sync is disabled.
> 
> We want to show the Click to Call dialog even if sync is disabled to
> show the user some help text on how to enable sync.
> 
> Bug: 986273
> Change-Id: I5f920822f21761ee5f167af0622b11304140cda4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713533
> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
> Commit-Queue: Richard Knoll <knollr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#680351}

TBR=mvanouwerkerk@chromium.org,alexchau@chromium.org,knollr@chromium.org

Change-Id: Icd69f58275aea8ca1655b560f3b41d186a2a7847
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 986273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716704Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680352}

We want to show the Click to Call dialog even if sync is disabled to
show the user some help text on how to enable sync.

Bug: 986273
Change-Id: I5f920822f21761ee5f167af0622b11304140cda4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713533Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680351}

The test was flaky because it depended on the state of Android master
sync. If a test device had the master sync off, the test would fail.

This CL mocks the state of the master sync in the test.

Bug: 984582
Change-Id: I48c362dec631c8fdb484d16ba836e4c7fa027391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715284Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680350}

This is a reland of 475fb228

TBR=haraken@chromium.org,mkwst@chromium.org

Original change's description:
> Move histogram(_test).[cc|h] to platform/instrumentation
>
> They're much better placed there than directly under platform/
>
> Bug: 919385
> Change-Id: I9583741da31e28217a9f331322ca8246984b94eb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713190
> Commit-Queue: Sergio Villar <svillar@igalia.com>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#679926}

Bug: 919385
Change-Id: Ib6757d24b090ff6b64ba37cbf80d3b0e61ede913
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715347Reviewed-by: Sergio Villar <svillar@igalia.com>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#680349}

autofill_attribute=*password.

Change-Id: I98c70ff7cc4f3f64777a1e46a67c5491d4fe3f4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712679Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#680348}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/886321015e1d..1fee49ba988e


git log 886321015e1d..1fee49ba988e --date=short --no-merges --format='%ad %ae %s'
2019-07-24 miahsanchez@google.com vm_unittest: testSystemQemuPath fixed after failing.
2019-07-24 vapier@chromium.org bootstrap: clean up scripts subdir
2019-07-24 gchenchen@google.com Mark Mistral Important


Created with:
  gclient setdep -r src/third_party/chromite@1fee49ba988e

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel

TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I6f9e08a5cb97f1634da2dfc0187e63de7ac321b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716586Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#680347}

Now that we have blink::SurroundingText inside Blink and implemented
using internal Blink types like WTF::String and LocalFrame, we can
finally migrate blink::SurroundingTextImpl away from WebLocalFrame
and remove the DEPS exception rule we previously introduced during
this process of Onion Soup'ing the SurroundingText API.

Additionally, we move the instantiation of blink::SurroundingTextImpl
from WebLocalFrame to LocalFrame as well and, with that, we remove any
reference to public Blink classes from SurroundingText-related code.

Bug: 980151
Change-Id: I1a1014dbf6671b9327a068ceca4f62d873cb5fb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698413
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680346}

The bug crbug.com/970153 has identified an issue which is present in the
way unplugged default and communications devices are handled. In fact,
due to the way the IDs for such devices are stored, Chromium was not
notifying that such devices were unplugged.

This CL addresses the issue by making sure that the event is triggered
on both the actual device as well as the virtual default or
communications device associated to it

BUG=970153

Change-Id: I30949cb8ca6f1d904dbdf94c4002c4c86d6cafc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708136Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680345}

This reverts commit 5531d748.

Reason for revert: Some issues still persist after the CL was re-landed with
fixes. Currently all binary video decoder (perf) Tast tests are broken.

The test launcher spawns a new process to run the tests, passing arguments to
the new process. Unfortunately positional arguments are not passed, causing the
test to be run without a video file. This can be circumvented by specifying
"--single-process-tests" on the command line, but this would complicate manual
usage of the video decoder tests.

crrev.com/c/1708621 moved the test-launcher-specifc arguments to the video
encoder tests, so it's no longer required to use a test-launcher here.

Original change's description:
> Reland "media/gpu: VDA tests and perf tests uses base::TestLauncher."
>
> This CL relands commit 372610a8, which broke the
> test when enabling DCHECK. The breakage has now been fixed.
>
> Original change's description:
> > media/gpu: VDA tests and perf tests uses base::TestLauncher.
> >
> > In CL:1679774 we added a TestLauncher specific argument for each
> > Chrome test binary at Tast framework. However, currently VDA test and
> > VDA perf test doesn't use base::TestLauncher, so they failed at
> > parsing arguments.
> > In this CL, we use base::TestLauncher at both VDA tests and perf
> > tests.
> >
> > BUG=chromium:985179
> > TEST=./video_decode_accelerator_tests --test-launcher-timeout=3600000
> >
> > Change-Id: I8155aae78be81bedcb252bfbdb534760e788d3be
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708150
> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
> > Reviewed-by: David Staessens <dstaessens@chromium.org>
> > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#678603}
>
> BUG=chromium:985179
>
> Change-Id: Iae3a514972498f2f51f0a087662f009fdec72ab1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710071
> Commit-Queue: David Staessens <dstaessens@chromium.org>
> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#679032}

TBR=akahuang@chromium.org,hiroh@chromium.org,dstaessens@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:985179
Change-Id: I22f15d4185cccbdd702be1b2ef2e8d111ea1b002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716366Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680344}