- 31 Oct, 2017 40 commits
-
-
Matt Falkenhagen authored
* Add //static annotation for some static functions. * "WebEmbeddedWorkerInstance" doesn't exist, replace with WebEmbeddedWorker or delete. * Clarify ServiceWorkerNetworkProvider documentation. Change-Id: Id540473565059c1c5aadeffd3bb0ee136fd9e5b1 Reviewed-on: https://chromium-review.googlesource.com/746508Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#513015}
-
khmel authored
This modifies ChromeOS settings for metrics instead of lower level metrics preferences. ChromeOS settings change has mapping to lower level metrics but not the opposite way. That is why change in metrics mode from ARC OptIn page was not propogated to Chrome settings. Test: Manually on device Bug: 755716 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I81ce5d38d34ade6d6f2737804eee5c1e7fa0822e Reviewed-on: https://chromium-review.googlesource.com/736145Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#513014}
-
Kevin Bailey authored
There is a large piece of code within |HQP::DoAutocomplete()| that can be on its own trivially. This change moves it to another method, and should not change behavior. This is to facilitate a downstream change. Bug: Change-Id: Ifdbbac697aee1efd0f42068f2e0825bb176a8076 Reviewed-on: https://chromium-review.googlesource.com/747064 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#513013}
-
Lei Zhang authored
Change-Id: Ic6489f81849456c7ce225cda73c5c08ec41e8e29 Reviewed-on: https://chromium-review.googlesource.com/747161 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#513012}
-
Peter Boström authored
Removes IDS_IMPORTER_LOCK_CANCEL as the dialog is no longer intended to be distinguished from other Cancel button labels. This specialized label caused translation confusion as it looks like it is intended to be specialized for the import dialog but is not "Cancel import" or similarly specialized content. Bug: b:68235708, chromium:754034 Change-Id: I15e35d90eafb621ce6a5d90a0e573edceae99ef1 Reviewed-on: https://chromium-review.googlesource.com/747633Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#513011}
-
Xiaocheng Hu authored
This patch changes the API to take Position parameters to better support mapping non-text anchored positions to LayoutNG canonical text. After this patch, NGOffsetMapping is fully converted to take Position parameters. Bug: 699017 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iee9956dc59c1ab34fe03f9f0f11fe890ddf9e568 Reviewed-on: https://chromium-review.googlesource.com/744733 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#513010}
-
Matt Reynolds authored
A GamepadDataFetcher represents a host interface for receiving gamepad state and communicating commands to a gamepad connected over a particular host interface. This CL modifies GamepadDataFetcher to support haptics commands. Haptics commands received by GamepadService are routed to the fetcher corresponding to the gamepad's host interface. BUG=749295 Change-Id: I82629d34494871ed59c574a9846c0b4ff088f229 Reviewed-on: https://chromium-review.googlesource.com/739926 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#513009}
-
Eric Karl authored
In preperation for adding the OOP Transfer Cache, I'm splitting ClientDiscardableManager into two classes: - ClientDiscardableManager - manages DiscardableHandles only - ClientDiscardableTextureManager - manages GL textures and uses a ClientDiscardableManager. This will allow the ClientTransferCache to also use a ClientDiscardableManager to manage its own DiscardableHandles. Eventually I plan to merge the transfer cache and discardable texture systems, but while the TransferCache and OOP raster is in flux, I'd like to keep them seperate. Bug: 777622 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iebfbdc31d9676d98abf7f422204d65c503df2d33 Reviewed-on: https://chromium-review.googlesource.com/745539 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#513008}
-
Stanislav Chiknavaryan authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9d2153a6a7be53b8a6fcc1ce837a1ba1f7b9239d TBR=kbr@chromium.org Change-Id: I9d2153a6a7be53b8a6fcc1ce837a1ba1f7b9239d Reviewed-on: https://chromium-review.googlesource.com/744381 Commit-Queue: Stanislav Chiknavaryan <stanisc@chromium.org> Reviewed-by:
Stanislav Chiknavaryan <stanisc@chromium.org> Cr-Commit-Position: refs/heads/master@{#513007}
-
Lei Zhang authored
Change-Id: Ie24494686e8a054aed8280320f27090e2703b974 Reviewed-on: https://chromium-review.googlesource.com/746150 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#513006}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ab816ce8ff61..47b67c426b1d $ git log ab816ce8f..47b67c426 --date=short --no-merges --format='%ad %ae %s' 2017-10-31 hinoka Reland "bot_update recipe: Upload source manifest" 2017-10-31 thomasanderson Add vs_files.ciopfs to gitignore Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Id4a1a05212fa00660d9a7a749f3ffd1987b98c36 Reviewed-on: https://chromium-review.googlesource.com/747893Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513005}
-
Kenichi Ishibashi authored
This CL adds OomInterventionTabHelper which is attached to a WebContent when the "OomIntervention" feature flag is enabled. When the WebContent is a foreground tab, the helper tries to detect near-OOM situation by using NearOomMonitor. Currently the helper doesn't initiate any intervention (e.g. pause JavaScript execution) but records some metrics. Metrics include: 1) Elapsed time between near-OOM detection and a crash/process termination/page navigation. 2) The number of crashes of OOM protected renderers without near-OOM detection. 3) The number of renderer termination without near-OOM detection. 4) The number of navigations without near-OOM detection. 1 will be used to examine true/false positives (near-OOM is detected, is it a success estimation or not?) 2, 3, 4 will be used to examine true/false negatives (near-OOM is not detected, isn't it overlooked?) TBR=isherman@chromium.org Bug: 776665 Change-Id: I439ef7abeb90ba09df41e7fbb7a61e1599d2edc7 Reviewed-on: https://chromium-review.googlesource.com/743039 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#513004}
-
danakj authored
Makes a CompositingModeReporter mojo API that is implemented in the viz process (which is the browser in this CL). The API allows registering a CompositingModeWatcher which hears about compositing mode fallback from gpu to software. Tracks the compositing mode in GpuProcessTransportFactory and ensures that decisions to use software compositing are sticky and global. Gives the current compositing state to new renderers on the command line. Tracks the compositing mode in RenderThreadImpl, based on the command line and from being a CompositingModeWatcher, and ensures that the compositing mode there is also sticky and global. Exposes the real compositing mode to blink via the Platform API instead of just exposing the state at startup (ie the command line flag). No longer tries to fall back to software compositing in the renderer process as a local decision. Tries gpu compositing indefinitely until hearing otherwise from being a CompositingModeWatcher. Reland of https://chromium-review.googlesource.com/c/chromium/src/+/714365 In that version, the renderer would crash with LOG(FATAL) if it could not connect to the browser process RenderProcessHostImpl to make a gpu channel. This causes a lot of test and canary crash reports, as the browser side seems to disappear before the renderer does. So instead report back to the caller if the channel failed because of a connection error. And in that case since the browser side is gone, don't bother to retry making a compositor context at all, and just await the renderer's apocalypse. R=boliu@chromium.org, kenrb@chromium.org, pdr@chromium.org, piman@chromium.org, sadrul@chromium.org TBR=boliu@chromium.org, kenrb@chromium.org, pdr@chromium.org Bug: 772574 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2305c8bf83afeadb057e8ee4f4401bf0518a77e5 Reviewed-on: https://chromium-review.googlesource.com/747382 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#513003}
-
Caleb Rouleau authored
Currently these tests only provide audio_time_to_play and video_time_to_play media metrics (along with generic cpu and memory metrics). Adding new metrics after these tests are committed simply means adding trace events to the product code and turning those into metrics in media_metric.html. In this way, the code I have added is just the scenarios. These scenarios are meant to be working examples that can be edited significantly in the future. That said, once this is committed, we're probably fine dropping the legacy mse_cases (since they are really flaky and haven't been finding any bugs.) These tests will be enough to cover them. Bug: 772971,713335 Change-Id: Ib2c32e4ab97738cc8d8e4b745b11820761213ad3 Reviewed-on: https://chromium-review.googlesource.com/733985 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#513002}
-
Mike Dougherty authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I64bf009972f035a8c7fbc5d2abf12209fee69ffb Reviewed-on: https://chromium-review.googlesource.com/746963 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#513001}
-
Dan Sanders authored
Before this change, BoxReader could read syntax elements outside of a box in cases where the MP4 was invalid. This isn't a security concern, since the reads were still bounded by the buffer size, but it did make it hard to interpret the later failures. This CL shrinks |buf_size_| to match |box_size_| when the box size is read. OOB reads will now result in Parse failures immediately. Bug: 779321 Change-Id: I54be6ba3815d1502233b5e95d099ce9d9a54b3cc Reviewed-on: https://chromium-review.googlesource.com/747080Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#513000}
-
sczs authored
Creates animations for expanding and contracting the location bar/omnibox using entirely UIViewPropertyAnimators. The feature is behind a new flag that is disabled by default. Real time video: https://drive.google.com/open?id=0Byo6-Nuda2jgVE1yTjBPRU9ybjg Slow Animations video: https://drive.google.com/open?id=0Byo6-Nuda2jgR21YM3k0amEwUEE Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib3a4f8f7aac9e72b674b881af2f463fabf76393a Reviewed-on: https://chromium-review.googlesource.com/729839 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#512999}
-
Muyuan Li authored
BUG=b:65588340 BUG=779815 TEST=test via local chrome variation server. Change-Id: Ieb791cab0b84bcf8e8525a11d085e20ad99128bb Reviewed-on: https://chromium-review.googlesource.com/747764Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#512998}
-
Lucas Garron authored
TBR=palmer@chromium.org Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic03627a7b7af205989503b8c444ddc4be45641a1 Reviewed-on: https://chromium-review.googlesource.com/747880 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#512997}
-
kylechar authored
This CL fixes the ash add/remove display accelerators when running with --mus. When the accelerator is pressed it needs to call TestDisplayController::AddRemoveDisplay(). The TestDisplayControllerPtr is moved into DisplayManager to simplify things. This allows removing the special case for the DEV_ADD_REMOVE_DISPLAY accelerator. Both --mus and --mash will set TestDisplayControllerPtr on startup if they are running on Linux desktop. It would be possible to do something similar with classic ash in the future. Bug: 779845 Change-Id: I70b058777944217e55ef105b9d1ac65f05e28b3a Reviewed-on: https://chromium-review.googlesource.com/746375Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#512996}
-
Boris Sazonov authored
https://crrev.com/2772203004 introduced a crash as dialogs can't be dismissed when container activity has been destroyed. This CL fixes this crash by storing an instance of ConfirmSyncDataStateMachine in AccountSigninView and calling cancel() when the view becomes invisible. This CL also reimplements ConfirmSyncDataStateMachineDelegate dialogs as DialogFragments. Bug: 774421 Change-Id: I2af2a8571921d7b7587b1f25ab771df14af5dbc3 Reviewed-on: https://chromium-review.googlesource.com/730708 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#512995}
-
gogerald authored
This CL parses and stores 'basic-card' specific capabilities, and uses them to filter service worker payment apps. The capabilities will also be used to filter modifiers. Bug: 777470 Change-Id: Ifab1054ec3bccd4f279cde5348cc68abf504a88d Reviewed-on: https://chromium-review.googlesource.com/730845 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#512994}
-
rbpotter authored
Bug: None Change-Id: I3441a7a704df305fcb4379ee46cc00b5d3b3619d Reviewed-on: https://chromium-review.googlesource.com/740704 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#512993}
-
Chris Blume authored
Zlib's fuzzer (and other tests) should all be close to the code it is related to. Move zlib_uncompress_fuzzer into third_party/zlib. BUG=779823 Change-Id: I960561b5cd83a629e9d296f56c75c7bfcec2663a Reviewed-on: https://chromium-review.googlesource.com/744597Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#512992}
-
Jay Civelli authored
Updating the doc of TestConnectionFactory, which I forgot to do when I changed the API in a previous CL. Bug: None Tbr: rockot@chromium.org Change-Id: I5b3e6d968b686a8a44f2c0d1561351fec394c5af Reviewed-on: https://chromium-review.googlesource.com/747888Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#512991}
-
Dimitri Glazkov authored
Add Daniel, Yoav, and Ojan to the API_OWNERS file. TBR=philipj,rbyers Bug: Change-Id: Ia87e64c3c57a4c8beb7626604002b5937a6962fb Reviewed-on: https://chromium-review.googlesource.com/747818Reviewed-by:
Dimitri Glazkov <dglazkov@chromium.org> Commit-Queue: Dimitri Glazkov <dglazkov@chromium.org> Cr-Commit-Position: refs/heads/master@{#512990}
-
dpapad authored
During initial population of the extensions and apps lists, addItem() was called N times, which internally performs a linear search N times, as well as triggres splice() notifications that are unnecessary. As revealed by DevTools (for a total of 30 extensions and apps): - before: the N calls to addItem() were taking ~22ms total - after: The initialization of the lists takes ~5ms total Bug: 764126 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If66d752cd3e7ac4b4ecd01ea4964ca6fd8d8f0db Reviewed-on: https://chromium-review.googlesource.com/746967Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#512989}
-
Xianzhu Wang authored
We should use IntRect instead of FloatRect for the bounds of bitmap. Previously the loop variables in BitmapEquals() exceeded the actual bounds of the bitmap if the given FloatRect was not integral. Bug: 779949 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib814cc8d3dcdcd9404654cd1f6352fb98d1e15f9 Reviewed-on: https://chromium-review.googlesource.com/746988Reviewed-by:
Walter Korman <wkorman@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#512988}
-
Tarun Bansal authored
The struct would be used to store different network properties related to data saver proxy. The properties include (but are not limited to) state of different proxy server schemes. Bug: 779219 Change-Id: Idd82c2035cf047feaa8134e57a1bacda2eafb1b0 Reviewed-on: https://chromium-review.googlesource.com/742485Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#512987}
-
Jamie Madill authored
The new cards were replaced in the old machines already, this change should get the tests running again with upgraded hardware. BUG=780296 NOTRY=true Change-Id: I4cffcee857e80c6e6742e2c507aa971a7b0bdd26 Reviewed-on: https://chromium-review.googlesource.com/747942 Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#512986}
-
rajendrant authored
ofcl directive in chrome-proxy header indicates the original full content length of the responses. This should be used as an alternative to XOCL to calculate compression ratio, especially for range responses. Bug: 745989 Change-Id: Id7050736e2c7c7a4f8f1de36e909441122181331 Reviewed-on: https://chromium-review.googlesource.com/747683Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#512985}
-
Jonathan Metzman authored
Bug: 771641 Change-Id: Ia075b8ffe5b8ddeeab3549c9ed782d058a27733d Reviewed-on: https://chromium-review.googlesource.com/746049Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#512984}
-
Peter Qiu authored
Currently, the video capture service would create a separate DeviceFactoryProvider and DeviceFactory for each client. This could potentially causes undefined behaviors when there are multiple clients, since each DeviceFactory manage devices independent of each other, the DeviceFactory might not have the up-to-date information on all devices. So fix it by only creating only one instance of DeviceFactoryProvider for the service, and all clients can bind to the same instance. Bug: None Test: manual Test: services_unittests Change-Id: I4629b3c80c11cab0a7274b07080ccb2b86ac0e86 Reviewed-on: https://chromium-review.googlesource.com/737955 Commit-Queue: Peter Qiu <zqiu@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#512983}
-
spqchan authored
Bug:779858 Change-Id: I29c4a1c883076b668b62f2e8a96fe7cfe94cc9ae Reviewed-on: https://chromium-review.googlesource.com/729259 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#512982}
-
Quinten Yearsley authored
Bug: 777582 Change-Id: I76bdb88f6e7941ce67c474a9bf600a46bac96896 Reviewed-on: https://chromium-review.googlesource.com/738795 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#512981}
-
bsheedy authored
Re-lands a prior patch that made VR Telemetry tests exit VR and navigate to a blank page after each story to reduce heat output, with a few differences: 1. The issue that caused the original patch's revert has been fixed by cycling the device's screen off then on instead of just ensuring that it is on. 2. Instead of running JavaScript code to exit VR then navigate, we simply navigate away since there doesn't seem to be any impact to stability or results by navigating without first exiting VR. Bug: 779837 Change-Id: Ia030b52d2cb87026f073eda2e7d37209c0992dae Reviewed-on: https://chromium-review.googlesource.com/747278 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#512980}
-
Sadrul Habib Chowdhury authored
BUG=780118 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I58ae9e17241637331c4e0ae47fb3eeaac9761342 Reviewed-on: https://chromium-review.googlesource.com/747523Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#512979}
-
Joy Ming authored
There was a bug where notifications for failed downloads (specifically offline pages) were not dismissable on Android O. This is because the foreground service was accidentally being turned on as the download was failed, leaving the summary notification pinned to the foreground. Bug: 776998 Change-Id: I8780e6e0002939bfc186e38d18608a5845bb65a9 Reviewed-on: https://chromium-review.googlesource.com/742486Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#512978}
-
Daniel Murphy authored
Bug: 779314 Change-Id: I74612639d20544e4c12230569c7b88fbe669ec03 Reviewed-on: https://chromium-review.googlesource.com/747725Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#512977}
-
Zijie He authored
This reverts commit cf3aebae. Reason for revert: The new API breaks on X11 and Mac OSX. Original change's description: > [Desktop Capturer] Use new DesktopAndCursorComposer constructor > > After several changes, we finally removed the dependency of SourceId in > MouseCursorMonitor. Now DesktopAndCursorComposer provides a clearer > constructor for its clients. > > Bug: webrtc:7950 > Change-Id: I8716d736897637412e712fcc2b2d17ef0acf3eab > Reviewed-on: https://chromium-review.googlesource.com/651147 > Commit-Queue: Zijie He <zijiehe@chromium.org> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500761} TBR=jamiewalch@chromium.org,braveyao@chromium.org,zijiehe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:7950, chromium:778035, chromium:778049 Change-Id: I45fbc68ae52194164828bc34207fe849850a98bf Reviewed-on: https://chromium-review.googlesource.com/746947Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Zijie He <zijiehe@chromium.org> Commit-Queue: Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#512976}
-