GitLab

Also, fix it so it works on linux with a broader range of download sites.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7762010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98952 0039d316-1c4b-4281-b951-d872f2087c98

testing interface.

BUG=none
TEST=bots
Review URL: http://codereview.chromium.org/7740062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98949 0039d316-1c4b-4281-b951-d872f2087c98

- experimental.accessibility.onVolumeChange

I run chrome/common/extensions/docs/build/build.py, but no documents about a11y was changed. So this CL doesn't include any changes of documents.

BUG=chromium-os:16592
TEST=call the APIs manually on chromium-os

Review URL: http://codereview.chromium.org/7708025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98948 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:15192
TEST=manually done(x86-generic, qemu)


Review URL: http://codereview.chromium.org/7791022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98947 0039d316-1c4b-4281-b951-d872f2087c98

have an empty name. 

BUG=88129
TEST=InProcessRenderViewBrowserTest::*


Review URL: http://codereview.chromium.org/7497058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98946 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98945 0039d316-1c4b-4281-b951-d872f2087c98

(retrying http://codereview.chromium.org/7540022)

BUG=91328
TEST='PPAPITest.FileRef,ObfuscatedFileSystemFileUtilTest.*'


Review URL: http://codereview.chromium.org/7608018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98943 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7671039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98942 0039d316-1c4b-4281-b951-d872f2087c98

Revert 98938 - Migrate Obsolete NotificationsSettings and remove content_settings::NotificationsProvider.

BUG=63656
TEST=host_content_settings_map_unittest.cc,
     content_settings_pref_provider.cc,
     desktop_notifications_service_unittest.cc

Review URL: http://codereview.chromium.org/7655019

TBR=markusheintz@chromium.org
Review URL: http://codereview.chromium.org/7810017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98941 0039d316-1c4b-4281-b951-d872f2087c98

** Use IAccPropServices::SetHwndPropStr == no more BSTR
* Change for cpplint.py

Caller owns BSTR on call:
http://www.codeguru.com/forum/showthread.php?t=364511

BUG=n/a
TEST=Use Task Manager for monitoring memory usage after setting long title with document.title


Review URL: http://codereview.chromium.org/7806010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98940 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94864
TEST=PrintDialogCloudTest.HandlerRegistered

Review URL: http://codereview.chromium.org/7740075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98939 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63656
TEST=host_content_settings_map_unittest.cc,
     content_settings_pref_provider.cc,
     desktop_notifications_service_unittest.cc

Review URL: http://codereview.chromium.org/7655019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98938 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98937 0039d316-1c4b-4281-b951-d872f2087c98

The last goal of this series of patches is to unexpose WindowOpenDisposition in ui and base modules.

This patch introduces the platform independent (key or mouse) events for mac. It provides a conversion function from mac event to the platform independent events.

After this patch is landed, I will upload the main patch of this series. It will remove the code where WindowOpenDisposition is exposed to ui/base level, and will introduce (context menu) handlers with platform independent event flags.

See also http://codereview.chromium.org/6893046/

BUG=93700
TEST=EventUtilsTest


Review URL: http://codereview.chromium.org/7792048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98936 0039d316-1c4b-4281-b951-d872f2087c98

TBR=apavlov@chromium.org

Review URL: http://codereview.chromium.org/7740074

TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/7778040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98935 0039d316-1c4b-4281-b951-d872f2087c98

Fixed the location where the saved screenshots are picked from. Also fixed the issue with saved screenshots blocking the UI.

R=zelidrag@chromium.org,derat@chromium.org
BUG=chromium-os:18227,chromium:73180
TEST=Tested with sending feedback using a saved screenshot.

Review URL: http://codereview.chromium.org/7635017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98934 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98933 0039d316-1c4b-4281-b951-d872f2087c98

TBR=apavlov@chromium.org

Review URL: http://codereview.chromium.org/7740074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98932 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Observed the leak and its remediation by inserting debug counter for CandidateView constructor/destructor. Verified no crash to happen by (1.Focus Omnibox 2.Enable Japanese IME 3.type "henkan" and press space key two times 4.press enter 5.type "a").
BUG=chromium-os:18893

Review URL: http://codereview.chromium.org/7741038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18999
TEST=make sure file browser web app icon shows up on NTP page
Review URL: http://codereview.chromium.org/7790002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98930 0039d316-1c4b-4281-b951-d872f2087c98

TEST=make sure --test-auth-email and --test-auth-password values are propagated to test auth extension content script while automating login process
BUG=chromium-os:19866
Review URL: http://codereview.chromium.org/7809015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98929 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94217,2685
TEST=view a page that uses CSS property --webkit-locale and verify that the font is the desired default


Review URL: http://codereview.chromium.org/7748014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98928 0039d316-1c4b-4281-b951-d872f2087c98

It had been marked FAILS for all platforms.

BUG=89961
TEST=OutOfProcessPPAPITest.URLLoader
TBR=jar,dtseng

Review URL: http://codereview.chromium.org/7812021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98927 0039d316-1c4b-4281-b951-d872f2087c98

On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them.

Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|.

BUG=84383
TEST=print preview works after code changes.

Review URL: http://codereview.chromium.org/7647010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98926 0039d316-1c4b-4281-b951-d872f2087c98

Mac does not accept printer ids with special characters (space, dot, etc), so when we saved the printer used by name instead of id, subsequent prints would fail.

BUG=91895
TEST=Print twice to a printer with a special character, like space in the name.


Review URL: http://codereview.chromium.org/7812001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98925 0039d316-1c4b-4281-b951-d872f2087c98

The code prior to this CL invoked a copy constructor during static initialization.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7785016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98924 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87171
TEST=none


Review URL: http://codereview.chromium.org/7776025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98923 0039d316-1c4b-4281-b951-d872f2087c98

omnibox in some cases. I suspect the call to the IME code is
triggering a window to show, resulting in losing focus, closing the
omnbox and crashing. But this will verify that's happening.

BUG=92497
TEST=none
R=pkasting@chromium.org

Review URL: http://codereview.chromium.org/7806015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98922 0039d316-1c4b-4281-b951-d872f2087c98

accessibility state changes


BUG=chromium-os:19647
TEST=Manual


Review URL: http://codereview.chromium.org/7781004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98921 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7740066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98920 0039d316-1c4b-4281-b951-d872f2087c98

there are any and check to see whether the current URL matches any of
these whitelisted expressions.

BUG=
TEST=ClientSideDetectionServiceTest


Review URL: http://codereview.chromium.org/7792004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98919 0039d316-1c4b-4281-b951-d872f2087c98

This test is breaking for the NaCl buildbots.
Disable it until Polina has time to investigate.

BUG= http://code.google.com/p/chromium/issues/detail?id=94790
TEST= none

R=polina@google.com


Review URL: http://codereview.chromium.org/7812003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98918 0039d316-1c4b-4281-b951-d872f2087c98

Revert 98885 - Third attempt at the following.  Unreviewed, this was originally reviewed in http://codereview.chromium.org/7550002 .

Clean up SSL false start blacklist code. Numerous changes, including:
* Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
* Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them.
* Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
* Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
* Avoid #define and "using".
* Use standard algorithms for similar reasons as using string ops.
* Use file_util functions to significantly abbreviate file reading/writing code.
* Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
* Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
* Convert non-error uses of stderr to the chrome-standard VLOG(1).
* Correctly handle hostnames with trailing dots in the input file.
* In general, shorten code where possible.

Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7804001

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7778035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98917 0039d316-1c4b-4281-b951-d872f2087c98

Put all tests that are exclude for 28439 back. Only valgrind bot(1) is failing and this must be something else.

TBR=timurrr@chromium.org
BUG=28439
TEST=none

Review URL: http://codereview.chromium.org/7810014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98914 0039d316-1c4b-4281-b951-d872f2087c98

The file manager code depends on the prepareSort method to fetch required sort fields from the filesystem before a sort happens, but the ArrayDataModel doesn't always call it.  This makes for unsorted file lists in certain situations.

BUG=chromium-os:19834
TEST=manual testing


Review URL: http://codereview.chromium.org/7799034

TBR=rginda@chromium.org
Review URL: http://codereview.chromium.org/7812018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98913 0039d316-1c4b-4281-b951-d872f2087c98

Now we use localized string for "platform", we should not
assume the text is encoded in ASCII.

To test this, manually change the UI to a non-latin language
(e.g. Japanese) and see if any irregular font is not displayed.

Webui login screen is also affected.

BUG=chromium-os:19822
TEST=manually

Review URL: http://codereview.chromium.org/7791020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98911 0039d316-1c4b-4281-b951-d872f2087c98

This replaces the nacl_helper_bootstrap program, dynamically-linked against
nacl_helper.so, with a standalone, statically-linked nacl_helper_bootstrap
program that loads the dynamic linker, instructing it in turn to load the
nacl_helper program (now a PIE rather than a DSO).

This avoids two problems with the old scheme:
1. The nacl_helper_bootstrap program remained in the dynamic linker's
   list of loaded objects, as the main executable, even though the
   memory where its .dynamic section had been was overwritten with
   the NaCl untrusted address space.  Code that traverses the list of
   all loaded objects could thus attempt to look at pointers into this
   part of memory, and be led astray.
2. nacl_helper_bootstrap's large (~1G) bss segment could cause the kernel
   to refuse to load the program because it didn't think there was enough
   free memory in the system for so large an allocation of anonymous memory.

The bootstrap program is kept very small by avoiding all use of libc
(except for memset and integer division routines needed on ARM).  It has
its own custom start-up code hand-written in assembly and its own custom
system call stubs done with hand-written GCC inline asm statements.

To avoid the second problem, the bootstrap program no longer has a large
bss.  Instead, it has a special ELF segment (i.e. PT_LOAD header) that
specifies no memory access, and a large (~1G) mapping size from the file.
This mapping is way off the end of the file, but the kernel doesn't mind
that, and since it's all a file mapping, the kernel does not do its normal
memory accounting for consuming a large amount of anonymous memory.

Unfortunately, it's impossible to get the linker to produce exactly the
right PT_LOAD header by itself.  Using a custom linker script, we get the
layout exactly how we want it and a PT_LOAD header that is almost right.
We then use a build-time helper program to munge one field of the PT_LOAD
to make it exactly what we need.

BUG= http://code.google.com/p/chromium/issues/detail?id=94147
TEST= hand-tested chromium build, invoked with --nacl-linux-helper

R=bradchen@google.com,mseaborn@chromium.org


Review URL: http://codereview.chromium.org/7795010

TBR=mcgrathr@chromium.org
Review URL: http://codereview.chromium.org/7811013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98910 0039d316-1c4b-4281-b951-d872f2087c98

This replaces the nacl_helper_bootstrap program, dynamically-linked against
nacl_helper.so, with a standalone, statically-linked nacl_helper_bootstrap
program that loads the dynamic linker, instructing it in turn to load the
nacl_helper program (now a PIE rather than a DSO).

This avoids two problems with the old scheme:
1. The nacl_helper_bootstrap program remained in the dynamic linker's
   list of loaded objects, as the main executable, even though the
   memory where its .dynamic section had been was overwritten with
   the NaCl untrusted address space.  Code that traverses the list of
   all loaded objects could thus attempt to look at pointers into this
   part of memory, and be led astray.
2. nacl_helper_bootstrap's large (~1G) bss segment could cause the kernel
   to refuse to load the program because it didn't think there was enough
   free memory in the system for so large an allocation of anonymous memory.

The bootstrap program is kept very small by avoiding all use of libc
(except for memset and integer division routines needed on ARM).  It has
its own custom start-up code hand-written in assembly and its own custom
system call stubs done with hand-written GCC inline asm statements.

To avoid the second problem, the bootstrap program no longer has a large
bss.  Instead, it has a special ELF segment (i.e. PT_LOAD header) that
specifies no memory access, and a large (~1G) mapping size from the file.
This mapping is way off the end of the file, but the kernel doesn't mind
that, and since it's all a file mapping, the kernel does not do its normal
memory accounting for consuming a large amount of anonymous memory.

Unfortunately, it's impossible to get the linker to produce exactly the
right PT_LOAD header by itself.  Using a custom linker script, we get the
layout exactly how we want it and a PT_LOAD header that is almost right.
We then use a build-time helper program to munge one field of the PT_LOAD
to make it exactly what we need.

BUG= http://code.google.com/p/chromium/issues/detail?id=94147
TEST= hand-tested chromium build, invoked with --nacl-linux-helper

R=bradchen@google.com,mseaborn@chromium.org


Review URL: http://codereview.chromium.org/7795010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98909 0039d316-1c4b-4281-b951-d872f2087c98

Refactor to put the logic for NTP app grayscaling in Javascript.
Disabled and terminated apps don't disappear from the NTP.
Update the NTP apps when offline status changes.

Caveat: the webstore icon doesn't get desaturated.

BUG=89655,94322,90433
TEST=Open NTP with packaged apps in disabled/enabled state; observe them changing
color when disabled/enabled via chrome://extensions page. Observe color changes
when network interface is unplugged.

Review URL: http://codereview.chromium.org/7792024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98908 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

R=mpcomplete@chromium.org,darin@chromium.org

Review URL: http://codereview.chromium.org/7774012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98907 0039d316-1c4b-4281-b951-d872f2087c98