- 09 May, 2018 40 commits
-
-
Moe Ahmadi authored
Currently, infobars provide little flexibility in the type, number, and layout of the items they display. Furthermore, user interactions with the infobars are handled in a generic context of InfoBarIOS class requiring multiple if/else statements to detect the type of the InfoBar and the interacted element. This is an effort to refactor infobars to have more flexibility in their layout and functionality (more info in the reference bugs). This CL primarily makes the following changes: 1) Moves the logic in InfoBarIOS (chrome/browser/ui/ios/infobar.mm) related to the confirm infobar and translate infobar to their respective infobar controller (e.g., ConfirmInfoBarController) 2) Introduces a new protocol InfoBarViewSizing adopted by the infobar views. It contains a target height property used by the infobar container for animation purposes and properly setting the infobar view's frame. 3) Introduces a new protocol InfoBarViewSizingDelegate adopted by the infobar controller that gets notified of infobar view's size changes and relays it to the InfoBarIOS. 4) Introduces a new interface InfoBarControllerDelegate implemented by InfoBarIOS which gets notified of infobar view's size changes and when the infobar needs to be closed. Bug: 838698, 307552 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7b8f9cc258d531ed99e84ffc02edcb323561bb8c Reviewed-on: https://chromium-review.googlesource.com/1037640Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#557188}
-
gogerald authored
Baug: 840759 Change-Id: Ibade40328413f8dbd9a7518f7af692322d172b49 Reviewed-on: https://chromium-review.googlesource.com/1048982 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#557187}
-
Yuichiro Hanada authored
according to wayland conding style described in https://github.com/wayland-project/wayland/blob/0e6ac72288f884ba0321c285a65578492c706534/doc/Contributing#L117 Bug: None Change-Id: I28df5661002e209dfb8debe48e6a3b2557ab613d Reviewed-on: https://chromium-review.googlesource.com/1050051Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#557186}
-
Calder Kitagawa authored
This is part of a series of Fuzzers to be added to Zucchini for security review. This tests the raw data patch application logic exercising the patch reader and apply process. It only covers ~20% of code in 100000 executions as the bulk of the remaining code is associated with the much more complex and expensive to fuzz reference related code. With the supplied seed corpus the fuzzer reaches approximately 11000 execs/s. This found a couple bugs which are fixed in: https://chromium-review.googlesource.com/c/chromium/src/+/1028575 Bug: 835341 Change-Id: Idc1d862bfaa6eb6313f39e10536f4750c05ab863 Reviewed-on: https://chromium-review.googlesource.com/1028570 Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557185}
-
Navid Zolghadr authored
If pointerup implicitly releases the pointer capture this change sends the boundary events rightaway after that without waiting for the next event. Bug: 834824 Change-Id: I538e0b35d1420574f964666aac394c0bde00f4fb Reviewed-on: https://chromium-review.googlesource.com/1019347 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#557184}
-
Yoav Weiss authored
Following a #whatwg discussion, I want to add a use counter for the `initiatorType` attribute on PerformanceResourceTimingEntry. The current values are not helpful and not well-specified, so it would be great if we could deprecate that attribute and start anew. Change-Id: I018a27d64d57b1e7c88544f66ae85758a1395dfa Reviewed-on: https://chromium-review.googlesource.com/1043750 Commit-Queue: Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#557183}
-
Tommy Martino authored
This introduces a new, modern icon to be used for credit cards whose type is unknown. It replaces the existing icon, but is the same size and is semantically similar, so risk is low. Known instances of this icon include both the "old" (canvas) and "new" (native) Autofill dropdowns, and the PaymentRequest UI. Bug: 768881 Change-Id: Ic19ee458d989a26e0bb222187284dafe0c4ea497 Reviewed-on: https://chromium-review.googlesource.com/1026049Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
-
vitaliii authored
Disable org.chromium.chrome.browser.vr_shell.WebVrTransitionTest testControlsVisibleAfterExitingVr_WebXr, because it is flaky. TBR=bsheedy@chromium.org Bug: 841103 Change-Id: I55651a634cfd81b43fd3668660cc3d59eda008a1 Reviewed-on: https://chromium-review.googlesource.com/1052012Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557181}
-
vitaliii authored
Disabling org.chromium.chrome.browser.search_engines.TemplateUrlServiceTest testSortandGetCustomSearchEngine, because flaky. TBR=mariakhomenko@chromium.org Bug: 841098 Change-Id: Ibae44f030880f59690d3f84114c1586d1b826d06 Reviewed-on: https://chromium-review.googlesource.com/1051769Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/d6f86e8fca21..c6c44268bcb5 $ git log d6f86e8fc..c6c44268b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6f6bd3b03e76c4397e2ad35c4715fb8997af3117 Reviewed-on: https://chromium-review.googlesource.com/1051869Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557179}
-
Johann authored
Support for the latest SDK is incomplete. Mention the required version when prompting the developer. R=brucedawson@chromium.org Bug: 773476 Change-Id: I01010f0db251e11617fb879845940fa2aee19f7b Reviewed-on: https://chromium-review.googlesource.com/1050691 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#557178}
-
Biao She authored
After this change, ContentElement should only be used for the main web content. PlatformUiElement can be used to host platform UIs (such as View on Android). Bug: NONE Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: If068d52d3134b5e1f70392523fdbfa4c047d1081 Reviewed-on: https://chromium-review.googlesource.com/1049961 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#557177}
-
Eugene But authored
Also added a test to verify the argument. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5655f92b64251a89b1bea9eb1e42b146ff4a7e73 Reviewed-on: https://chromium-review.googlesource.com/1050413Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#557176}
-
David 'Digit' Turner authored
This CL slightly modifies the crazy linker to extract the DT_SONAME of a given shared library. The goal is to use the soname as the unique identifier for a library during dependency resolution, as this matches the behaviour of the system linker. More precisely: - Before this CL, each library loaded by the linker is identified by a "name" that was the library path (with any directory sub-path) used to load the library. This prevents properly resolving DT_NEEDED entries, which explains one of the reasons why the crazy linker doesn't support the component build at the moment. - After this CL, system libraries are identified by their basename only (which was already the case when they were loaded through DT_NEEDED entries, but changes what happens when they are loaded through the dlopen() wrapper). Ideally, non-system libraries should be identified by the soname, but this currently doesn't work, because it breaks RELRO sharing. The reason for this is that, when loading libraries directly from a zip file, the current client code (chromium_android_linker) passes and relies on the path to the host APK directly (e.g. something like /data/data/<package-name>-<number>/base.apk and a file offset. This will be addressed in a future CL. BUG=802068 R=lizeb@chromium.org, pasko@chromium.org, agrieve@chromium.org Change-Id: Ia282c29e80e8729c4079a80de7acf66975b7d1ee Reviewed-on: https://chromium-review.googlesource.com/1042406 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#557175}
-
Gauthier Ambard authored
This CL adds the images for the activity service, the add/edit bookmarks and the ReadLater images. Bug: 834299, 829718 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I03b9d19f04f7cfd2558ecf8ac468a14c14984b13 Reviewed-on: https://chromium-review.googlesource.com/1052107Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 5268 5272 5279 5284 5292 5295 5298 5302 5305 3 lines were removed and 2 lines were deflaked by consecutive results since 5218. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5a967922b2921fef4663b9f950ac90f04177b835 Reviewed-on: https://chromium-review.googlesource.com/1050045 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557173}
-
Robert Phillips authored
Bug: skia:7765 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I2147e4450f134473b059399b67d58633d277e5bd Reviewed-on: https://chromium-review.googlesource.com/1044787Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#557172}
-
Sahel Sharify authored
This cl decouples the fling controller client for sending events from the fling controller client for scheduling and progressing the fling. The FlingScheduler implements the fling controller scheduling client. It schedules fling by either adding the FlingController as an animation observer to ui::Compositor or by Calling SetNeedsBeginFrame if the compositor is not available. BrowserSideFlingBrowserTest.TouchpadFling TBR=nasko@chromium.org Bug: 823310,249063 Test: BrowserSideFlingBrowserTest.TouchscreenFling, Change-Id: I8c104daf41f87abdf0a78f3cb3d51274f279424b Reviewed-on: https://chromium-review.googlesource.com/994181 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
Ryan Harrison authored
Currently Chromium will build the related fuzzer for an image codec when the codec has been disabled. This hasn't been an issue so far, since the PDFium BUILD.gn is still building the codec code even when it is disabled. It is just building it with a macro that disables the logic. This behaviour is going to soon change in PDFium, to having the codec code not being built at all when it is disabled. This will break the Chromium fuzzer builds. This CL turns off building the fuzzer when the related fuzzer is disabled. BUG=pdfium:1080 Change-Id: I6b1ff78c5b379fac9c29ca38b79c133c3d1367bb Reviewed-on: https://chromium-review.googlesource.com/1050702Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#557170}
-
Gauthier Ambard authored
This CL fixes the testWebViewIsFirstResponderUponKeyPress test which was failing for iOS 11.3+. The changes in iOS 11.3+ is that the WKWebView is the first responder instead of the WKContentView. Bug: 830124, 837564 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9b5c343579657c5db9d3973820e5c67ae495bcb4 Reviewed-on: https://chromium-review.googlesource.com/1052008Reviewed-by:
-
Mikel Astiz authored
A recent bug surfaced the fact that old clients (prior to USS) don't handle well the case where invalid tab specifics are received over the sync protocol (namely, with an invalid tab ID). In the particular case of orphaned foreign tabs, i.e. tabs that have been overriden -same tab ID- by a different sync entity -different tab node ID-, the situation is problematic. AFAIK, these entities would only be submitted by a USS client when custom passphrase is enabled, leading to crashes in all devices a user is syncing with. Fortunately, the USS implementation is behind a feature toggle and has never been enabled or experimented with. Bug: 840876 Change-Id: I20c9272b735f0515f4bf8c0e9fd15ca31c2113a0 Reviewed-on: https://chromium-review.googlesource.com/1051234 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#557168}
-
Christian Dullweber authored
If the user deletes urls from history for a specific day we only delete navigations if there are no additional visits outside this time range because url are not reported as being deleted to history observers unless all visits have been removed. To fix the issue, the restrict_urls parameter is passed through HistoryServiceObserver to NavigationEntryRemover in order perform a deletion for specific urls within the time range correctly. Bug: 838086 Change-Id: I22226924b3ca9a3d0880aa62548c87d33b093d13 Reviewed-on: https://chromium-review.googlesource.com/1041956 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#557167}
-
Greg Kraynov authored
Split into separate test fixtures to make it more straightforward. Bug: 783309 Change-Id: Ife5353fa61a07936c3ccf8c8255f253206038df8 Reviewed-on: https://chromium-review.googlesource.com/1052007Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#557166}
-
Hajime Hoshi authored
This changes a behavior slightly: the task runner is change from unthrottleable to throttleable. However, there should not be a strong reason why the task runner should be unthrottled there. We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Task type guideline: https://bit.ly/2vMAsQ4 Bug: 830489 Change-Id: I55519cb83aa40cbf4fd98bcd18a9424aa9a7b882 Reviewed-on: https://chromium-review.googlesource.com/1051308 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557165}
-
Daniel Bratell authored
There is a ::i18n::phonenumbers::PhoneNumber and a ::autofill::PhoneNumber. To avoid ambiguity (especially in jumbo builds where more types are known to more code), refer to ::i18n::phonenumbers::PhoneNumber with the full name inside autofill code. Also refer to PhoneNumberUtils from the same namespace the same way for consistency. Change-Id: Ic36cae9a8df0ceb07f3494fa34d8b08531cd46e4 Reviewed-on: https://chromium-review.googlesource.com/1050288 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#557164}
-
Ben Wagner authored
This flag is holding out a Skia change which fixes a number of shadows. This removes the flag added in https://chromium-review.googlesource.com/c/chromium/src/+/1050466 to keep https://review.skia.org/126615 from requiring rebaselines when rolling. Change-Id: Ibb3af277be20e70e146e805fe1a2e4171742eabc Reviewed-on: https://chromium-review.googlesource.com/1050203 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#557163}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8fd4e46f. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17183 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=danyao No-Export: true Change-Id: I34de3cc2a8864e7f115241e98de3a1c958a92a28 Reviewed-on: https://chromium-review.googlesource.com/1051667 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557162}
-
Fergal Daly authored
Change-Id: Iba6fc2f6d60830a8c745a4355cb4ec1677273435 Reviewed-on: https://chromium-review.googlesource.com/1051134Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#557161}
-
Pavol Marko authored
To check for initial enrollment on OOBE, the system will first perform a |DeviceInitialEnrollmentCheckRequest| exchange with the device management server. If the result of this exchange is that the device should be force-enrolled, it will use |DeviceInitialEnrollmentStateRequest| to query which domain it should enroll into. Bug: 839353 Test: compile. Actual test will be added in a follow-up CL that uses these protos. Change-Id: Iaa83065f339f9c49cb7af25c9e1e34bbdd1ad176 Reviewed-on: https://chromium-review.googlesource.com/1042186 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#557160}
-
Brian White authored
This is a temporary change that will be reverted once crashes can be analyzed to confirm the working theory. Bug: 836875 Change-Id: Iaeffbd6c78b604af66b33991392990d71648d4a9 Reviewed-on: https://chromium-review.googlesource.com/1050071 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#557159}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I58e94995d48d4493f5c3bb91ab7e2c7f241b9aa6 Reviewed-on: https://chromium-review.googlesource.com/1051867 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557158}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=sammiequon@google.com Change-Id: I427347e23b428da6344f13de9c826e2858ffb975 Reviewed-on: https://chromium-review.googlesource.com/1051947 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#557157}
-
Hans Wennborg authored
Bug: 837440 Change-Id: I216c457b53e795d229228e03df8dad42ac78dc07 Reviewed-on: https://chromium-review.googlesource.com/1049654Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#557156}
-
Pavol Marko authored
The TabUnderProtectionEnabled policy was renamed to TabUnderAllowed in CL:995632. Rename the value in enums.xml too. Bug: b/77374536 Change-Id: I0eede70c436b4e5260cb02e19838f2d22528594c Reviewed-on: https://chromium-review.googlesource.com/1035322Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#557155}
-
Mohamed Amir Yosef authored
This CL implements the remote creation of bookmarks on the server. It take many shortcuts that will be addressed in later patches such as a naive ordering algorithm that assumes all bookmarks are created under the bookmarks bar directly. Bug: 516866 Change-Id: I10059fd3b7521927fb4db6b9ce0284f33fadead8 Reviewed-on: https://chromium-review.googlesource.com/1017201 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557154}
-
kylechar authored
EmbeddedFrameSinkImpl enforced that it only created a CompositorFrameSink one time. This doesn't work well with OOP-D and isn't the approach taken for CompositorFrameSinks, so just remove that condition. This will destroy the old CompositorFrameSinkImpl and create a new CompositorFrameSinkImpl. Bug: 768565 Change-Id: I7dcfdc35bd33fcb20544c22baa7417eaf84011b7 Reviewed-on: https://chromium-review.googlesource.com/1050436Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#557153}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I30970fd51dd869abd73b1b16109e44178fbcee2e Reviewed-on: https://chromium-review.googlesource.com/1051688 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557152}
-
Yoshifumi Inoue authored
This patch changes |CharacterIterator::CurrentContainer()| to return |const Node&| instead of |const Node*| since it always non-null for improving code health. This patch is a follow-up of the patch[1]. [1] http://crrev.com/c/1050053 Make TextIterator::CurrentContainer() to return const Node&. Change-Id: If2dc187244e4e8a489b56f9855b786c191579d9b Reviewed-on: https://chromium-review.googlesource.com/1051138 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#557151}
-
Yoshifumi Inoue authored
This patch changes |DocumentMarkerController::AddMarkerToNode()| to take |const Node&| instead of |const Node*| since it always non-null for improving code health. This patch is a follow-up of the patch[1]. [1] http://crrev.com/c/1050053 Make TextIterator::CurrentContainer() to return const Node&. Change-Id: I7041a969f730d07fcccaa8d745b6f2cb02ecbaab Reviewed-on: https://chromium-review.googlesource.com/1051068 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#557150}
-
Maksim Sisov authored
This cl adds an initial support for Ozone (Linux) builds by utilizing DekstopWindowTreeHostPlatform design. Actually, it looks very similar to DesktopWindowTreeHostX11 with a difference that this design in this CL uses Ozone abstraction layer to communicate with Wayland and other backends. In overall, BrowserDesktopWindowTreeHostPlatform, which is actually DesktopWindowTreeHostPlatform, is created and initialized, which triggers creation of a PlatformWindow, which can be either Wayland, or X11, or other ozone platform. Also, DesktopScreenOzone class is added. This object inherits ScreenBase and is meant to fetch displays data from underlaying ozone backends and provide aura with necessary data. Bug: 578890 Change-Id: I2d203cd6d1a6ddea0afe062059c6c1f9eecdafd3 Reviewed-on: https://chromium-review.googlesource.com/1039567 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
