GitLab

BUG=415964
TEST=Install an extension like "Webcam" and make sure it doesn't work when policy is enabled.

Review URL: https://codereview.chromium.org/599903002

Cr-Commit-Position: refs/heads/master@{#297383}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8cc0503..d441820

TBR=zmo@chromium.org,eustas@chromium.org

Review URL: https://codereview.chromium.org/616803002

Cr-Commit-Position: refs/heads/master@{#297382}

Previously DirectoryModel#partialUpdate ignores changes if the function is
called multiple times during the previous request is being procecced.

BUG=417163
TEST=Repo steps of the bug.

Review URL: https://codereview.chromium.org/611193002

Cr-Commit-Position: refs/heads/master@{#297381}

As part of the masterplan of the bug, this CL
removes the explicit android.hardware.Camera
classes manipulations, asking instead classes
VideoCapture{,Android,Tango} for this info.

Some other minor cleanup goes along with it:
VideoCaptureFactory.CamParams is only used inside
VideoCaptureTango and to retrieve the name of the
special Tango camera, that's refactored to hide the
CamParams inside VideoCaptureTango.

Other methods are further simplified in the
VideoCaptureFactory so their use from C++
is more evident.

BUG=418052

Review URL: https://codereview.chromium.org/602063002

Cr-Commit-Position: refs/heads/master@{#297380}

Revert of Refactor FakeAttachmentStore (patchset #3 id:40001 of https://codereview.chromium.org/601553004/)

Reason for revert:
Speculative revert:
looks like it causes failures on the Linux asan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/8113

Original issue's description:
> Refactor FakeAttachmentStore
>
> Refactor FakeAttachmentStore into AttachmentStoreProxy and
> InMemoryAttachmentStore backend. Break AttachmentStore interface into
> AttachmentStoreBase (common interface for backends) and AttachmentStore
> (referenced by datatype and AttachmentService).
>
> BUG=
> R=maniscalco@chromium.org
>
> Committed: https://crrev.com/6ae2b341c73909cf902078446346d6c900273409
> Cr-Commit-Position: refs/heads/master@{#297339}

TBR=maniscalco@chromium.org,pavely@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/619563002

Cr-Commit-Position: refs/heads/master@{#297379}

BUG=361855
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/606063002

Cr-Commit-Position: refs/heads/master@{#297378}

BUG=417113
TEST=manually tested.

Review URL: https://codereview.chromium.org/609293002

Cr-Commit-Position: refs/heads/master@{#297377}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/22c3c2e..8cc0503

TBR=zmo@chromium.org,eustas@chromium.org

Review URL: https://codereview.chromium.org/616783002

Cr-Commit-Position: refs/heads/master@{#297376}

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708

Review URL: https://codereview.chromium.org/605123003

Cr-Commit-Position: refs/heads/master@{#297375}

Revert of Revert of Enabling audio quality test on mac. (patchset #1 id:1 of https://codereview.chromium.org/613833002/)

Reason for revert:
Relanding: bots are now configured.

Original issue's description:
> Revert of Enabling audio quality test on mac. (patchset #1 id:1 of https://codereview.chromium.org/599103006/)
>
> Reason for revert:
> There is one stubborn bot that is unreachable from VNC; reverting until we can sort that out.
>
> Original issue's description:
> > Enabling audio quality test on mac.
> >
> > Note: will land on Monday; need to watch bots so that they execute the
> > test right.
> >
> > TBR=vrk@chromium.org
> > BUG=418034
> >
> > Committed: https://crrev.com/c4e4aaaf43c0da2a01c0f32be737dcbbd5f13e92
> > Cr-Commit-Position: refs/heads/master@{#297166}
>
> TBR=vrk@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=418034
>
> Committed: https://crrev.com/18efcd361beccd5eca81b1a046c30fde72a88953
> Cr-Commit-Position: refs/heads/master@{#297257}

TBR=vrk@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=418034

Review URL: https://codereview.chromium.org/612333002

Cr-Commit-Position: refs/heads/master@{#297374}

This CL moves the --custom-launcher-page switch into app_list_switches.h
because it probably belongs there with the other app list related
switches.

BUG=416756

Review URL: https://codereview.chromium.org/598463002

Cr-Commit-Position: refs/heads/master@{#297373}

Revert of Swarm debug Windows 7 tests on main waterfall. (patchset #1 id:1 of https://codereview.chromium.org/618533002/)

Reason for revert:
There are some failures in browser_tests and sync_integration_tests.

Original issue's description:
> Swarm debug Windows 7 tests on main waterfall.
>
> I moved all tests to Win Tests (dbg)(1) in preparation for removing 2, 3, 4, 5, & and Interactive Tests (dbg).
>
> BUG=414808
> R=maruel@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5f7ee2f338c9d7c5616c18e594ec8ef834d718c6

TBR=maruel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=414808

Review URL: https://codereview.chromium.org/615833002

Cr-Commit-Position: refs/heads/master@{#297372}

R=lcwu@chromium.org,maclellant@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/613093002

Cr-Commit-Position: refs/heads/master@{#297371}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f5b92e7..22c3c2e

TBR=zmo@chromium.org,eustas@chromium.org

Review URL: https://codereview.chromium.org/614823003

Cr-Commit-Position: refs/heads/master@{#297370}

We need to begin animation frames in the WebPagePopup to trigger resize events so we let WebTestProxy call animation on the page popup as well.

BUG=409503

Review URL: https://codereview.chromium.org/603873002

Cr-Commit-Position: refs/heads/master@{#297369}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c0363f0..f5b92e7

TBR=zmo@chromium.org,eustas@chromium.org

Review URL: https://codereview.chromium.org/616753002

Cr-Commit-Position: refs/heads/master@{#297368}

An earlier CL enabled file_handlers and chrome.app.runtime to be used
by whitelisted extensions:
https://codereview.chromium.org/265503003

This updates the Files app to show these extensions as handlers.

BUG=329587

Review URL: https://codereview.chromium.org/609643002

Cr-Commit-Position: refs/heads/master@{#297367}

messages.

BUG=397019

Review URL: https://codereview.chromium.org/601123002

Cr-Commit-Position: refs/heads/master@{#297366}

Changed the size in the App Info dialog to always display in MB, no
matter the size of the app. If the app is less than 1 MB, display
'< 1 MB' instead of the size.

BUG=398717

Review URL: https://codereview.chromium.org/615453002

Cr-Commit-Position: refs/heads/master@{#297365}

(Every subdirectory except aura/, examples/, services/, and views/.)

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/619493002

Cr-Commit-Position: refs/heads/master@{#297364}

I moved all tests to Win Tests (dbg)(1) in preparation for removing 2, 3, 4, 5, & and Interactive Tests (dbg).

BUG=414808
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/618533002

Cr-Commit-Position: refs/heads/master@{#297363}

Move InitializeOnCurrentThread down from WebGraphicsContext3DImpl to WebGraphicsContext3DCommandBufferImpl and WebGraphicsContext3DInProcessCommandBufferImpl

in preparation for dis-inheriting these classes

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/609973002

Cr-Commit-Position: refs/heads/master@{#297362}

Priviously in the external file protocol handler, for accessing files via file
system API, we uses file system URLs having externalfile:// scheme origin
internally.  And we added special check to pass the origin in IsAccessAllowed
check.

This CL removes the special check. Instead the CL generated isolated file system
URL to access files.

BUG=367027
TEST=unit_tests --gtest_filter=*ExternalFileURL*

Review URL: https://codereview.chromium.org/615523002

Cr-Commit-Position: refs/heads/master@{#297361}

Current efforts are aimed at harmonizing our UI code. #ifdefs work
against this and have a lot of downsides besides.

This is a follow-up to http://crrev.com/351683002 -- a long-running CL
which added ShowLinkDisambiguationPopup to Aura -- and
http://crrev.com/596373002 which fixed some build problems with that.
However, toolkit_views=1 use_aura=0 which is in use on Mac still has
problems.

This CL adds default method definitions to WebContentsViewDelegate and
RenderWidgetHostViewBase. Essentially moving a NOTIMPLEMENTED() guarded
by #ifdefs into a base class method, and removing some unnecessary
boilerplate.

BUG=385249, 399191

Review URL: https://codereview.chromium.org/610893003

Cr-Commit-Position: refs/heads/master@{#297360}

Becuase base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/593023002

Cr-Commit-Position: refs/heads/master@{#297359}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c44ff58..c0363f0

TBR=zmo@chromium.org,eustas@chromium.org

Review URL: https://codereview.chromium.org/615763003

Cr-Commit-Position: refs/heads/master@{#297358}

Move all white-listed input method indicator text from InputMethodUtil to manifests of IME extensions.

BUG=232260
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/608183002

Cr-Commit-Position: refs/heads/master@{#297357}

Fixes a potential crash if an app gets duplicated in the app list, and
the user tries to drop it onto itself. (There is no known way to repro
this currently, but there was recently; see http://crbug.com/415530.)
That situation will now result in a very descriptive DCHECK, rather than
a confusing low-level CHECK fail.

AppListModel::MergeItems:
- returns "" instead of crashing if the source and target IDs are equal.
- returns "" instead of crashing if the target ID is inside a folder (no
  longer needs to explicitly CHECK whether it is in a folder.)

Added plenty of new tests for the various corner cases in
AppListModel::MergeItems which would have caught these crashes.

AppsGridView::MoveItemToFolder:
- DCHECKs for a NULL result of GetViewAtSlotOnCurrentPage.
- DCHECKs that you aren't dropping an item onto itself (this should
  never happen).

BUG=417482

Review URL: https://codereview.chromium.org/600393002

Cr-Commit-Position: refs/heads/master@{#297356}

It's empty, except for a DEPS file.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/606403004

Cr-Commit-Position: refs/heads/master@{#297355}

BUG=418014
TEST=manually
1. Open Files.app. Put a file name "test.txt" under /Downloads.
2. Start dragging the file, and drop to the blank area of the same
   directory (/Downloads).
3. Confirm to not start move operation.

Review URL: https://codereview.chromium.org/609223002

Cr-Commit-Position: refs/heads/master@{#297354}

The type causes an exception and it prevent the app from running
progressCenter.removePanel.

So the disposed ProgressCenterPanel remains in the ProgressCenter and it causes
another bug.

BUG=418517
TEST=repo steps of the bug.

Review URL: https://codereview.chromium.org/618563002

Cr-Commit-Position: refs/heads/master@{#297353}

BUG=407997
TEST=N/A

Review URL: https://codereview.chromium.org/604193002

Cr-Commit-Position: refs/heads/master@{#297352}

These translations were accidentally missed.

BUG=414468
TBR=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/612553003

Cr-Commit-Position: refs/heads/master@{#297351}

BUG=416665

Review URL: https://codereview.chromium.org/603243005

Cr-Commit-Position: refs/heads/master@{#297350}

I profiled Bookmark Sync association code on a Windows workstation with about 16K folders and bookmarks. This was for the scenario when bookmarks had been already synced and and BookmarkModelAssociator::BuildAssociations needed to match sync data to the already existing bookmark model.

While it was fairly fast in absolute terms (less than 1 sec on my rather powerful workstation), I verified that 59% of samples for the UI thread were in BookmarkModelAssociator::BuildAssociations.

The top 3 functions called from BuildAssociations and their costs in terms of UI thread sample counts are:

browser_sync::BookmarkNodeFinder::FindBookmarkNode	- 20.7%
browser_sync::BookmarkChangeProcessor::UpdateBookmarkWithSyncData	- 14.6%
browser_sync::BookmarkNodeFinder::BookmarkNodeFinder - 13.9%

Altogether BookmarkNodeFinder was responsible for almost 35% of all UI thread samples.
Furthermore UTF16ToUTF8 function alone was responsible for 24% of UI thread samples.

The reason UTF16ToUTF8 is so expensive is because it is used in custom comparator used with multiset which is a part of BookmarkNodeFinder implementation.
Each bookmark node gets added and searched to BookmarkNodeFinder once.
Altogether that results in approx 2*2*(N*logN/2) calls of UTF16ToUTF8 (and
also N calls of UTF8ToUTF16). Each conversion involves an allocation.
On a mobile platform the relative cost of this should be even higher because
memory tends to be slower and CPU caches smaller.

The fix replaces multiset with a hash_multimap where the key is the converted
bookmark title. Therefore UTF16ToUTF8 ends up being called only once for each node and due to different lookup (by title vs. by node) UTF8ToUTF16 calls are eliminated.
Also hashing should work more efficiently for long bookmark/folder titles than the binary search.

Measurement showed that improved combined cost of BookmarkNodeFinder::BookmarkNodeFinder and BookmarkNodeFinder::FindBookmarkNode - close to 5x. And the overall cost of bookmark association - improved by 1.5-2x (when measured on my windows dev workstation).

There is also an opportunity to optimize UpdateBookmarkWithSyncData which blindly applies data even when it guaranteed to be exactly the same, but I didn't touch it in this change.

BUG=238621

Review URL: https://codereview.chromium.org/603153005

Cr-Commit-Position: refs/heads/master@{#297349}

If someone wants to disable a page, the right way to
do it is comment out the "self.AddPage(...)" in page_set.__init__().

BUG=

Review URL: https://codereview.chromium.org/616693002

Cr-Commit-Position: refs/heads/master@{#297348}

BUG=None
R=cmasone@chromium.org, fukino@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/607413005

Cr-Commit-Position: refs/heads/master@{#297347}

PrintingControllerTest was faking being in org.chromium.printing package.
Move to org.chromium.chrome.browser.printing package where it actually lives.

BUG=None

Review URL: https://codereview.chromium.org/618553002

Cr-Commit-Position: refs/heads/master@{#297346}

Several spurious NotifyObserver calls have been removed, in addition to
removing the configuration retry code (which was not doing anything anymore).

BUG=418140

Review URL: https://codereview.chromium.org/612573005

Cr-Commit-Position: refs/heads/master@{#297345}

BUG=393873
R=estade@chromium.org

Review URL: https://codereview.chromium.org/617673002

Cr-Commit-Position: refs/heads/master@{#297344}