- 27 Jun, 2018 40 commits
-
-
Mounir Lamouri authored
This will allow actions such as "loop", "show controls" or the new "Picture-in-Picture" to work on OOPIF. Bug: 851502 Change-Id: Ie2937e908866511c5dbdd0bbf31cf90b3704b859 Reviewed-on: https://chromium-review.googlesource.com/1115582 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#570911}
-
Justin Cohen authored
Remove the injected toolbar in the NTP, and shows the real toolbar when not in split toolbar mode (e.g. landscape iPhone). Bug: 808431, 828887, 852443 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib8cfe87702d7a94b66b9622be1e8bc3049e4c392 Reviewed-on: https://chromium-review.googlesource.com/1113543 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#570910}
-
Mustafa Çamurcu authored
Ozone Fuchsia platform built on top of Zircon. This platform will enable Chrome to run on Fuchsia using Chrome's own Display Compositor and event handling, independent from Scenic. This is a stub implementation of the platform. The parts that connect to Zircon will be implemented in future cls. Change-Id: Ie6e43946e5a38b58220f5455a2a7b89fcd8ba15a Reviewed-on: https://chromium-review.googlesource.com/1091178 Commit-Queue: Mustafa Çamurcu <camurcu@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#570909}
-
Adithya Srinivasan authored
The test was rewritten in https://crrev.com/c/1111910 and now uses a mock speech recognizer written in js. The previous mock recognizer was removed and the test was using the actual speech recognition service. Bug: 855873 Change-Id: I89a902092ee26c16f3624bd359c0cbf55b74e1d8 Tbr: shend@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1117620Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#570908}
-
Eric Stevenson authored
Recently asserts stopped working when we switched to D8 for dexing. This CL adds a test that ensures: * asserts fire when DCHECK is on * asserts are removed when DCHECK is off Bug: 856575 Change-Id: I148e4225fd90709f7738150a73636a3d9f298230 Reviewed-on: https://chromium-review.googlesource.com/1117570Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#570907}
-
Ian Clelland authored
The documentation in the Feature Policy spec repository was moved to the 'master' branch from the 'gh-pages' branch. This updates several references in the Chromium codebase with the new locations. TBR=kinuko To-be-reviewed-by: kinuko@chromium.org Bug: 857055 Change-Id: I10b4c55608a218b1767a4990832d86e460cd37d5 Reviewed-on: https://chromium-review.googlesource.com/1116868 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#570906}
-
Ahmed Fakhry authored
In tablet mode, to prevent accidental clicks on the browser's window controls and to give more horizontal space for tabs and the new tab button in split screen, we hide the caption buttons container. We only do this for non-app browser windows and only when the Home Launcher feature is enabled. This is part of the Touch MLP project. BUG=822455 TEST=Added test coverage. Change-Id: Idda77cf5b87afdd32cca586cbfb39b49c398a520 Reviewed-on: https://chromium-review.googlesource.com/1115460Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#570905}
-
Shakti Sahu authored
Bug: 857161 Change-Id: I2e9b78fad243612aefddfbd4b6dcce1bb4f1736e Reviewed-on: https://chromium-review.googlesource.com/1117370Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570904}
-
Leonard Grey authored
This change is a 15% resize speedup in a release build on my machine. Bug: 850128 Change-Id: Icbcd79b7ea5a8a5f06fc20595f67092b8bd12c42 Reviewed-on: https://chromium-review.googlesource.com/1110700Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#570903}
-
Boris Sazonov authored
This CL fixes the issue when TintedImageButton: 1. Ignores chrometint specified in XML. 2. Ignores calls to setTint with the same ColorStateList. This was happening because ImageViewTinter.updateTintColor doesn't actually set color filter if current Drawable is null, while still remembering ColorStateList instance and ignoring calls with the same instance afterwards. See https://crbug.com/853640#c10 for more details. Bug: 853640 Change-Id: Ie930a401802d10e2b804b38f7a7d3917f21a7b37 Reviewed-on: https://chromium-review.googlesource.com/1117197Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#570902}
-
ccameron authored
This reverts commit 2673cbdb. Reason for revert: Blank tabs: crbug.com/856617 Original change's description: > Surface synchronization: Don't call repaint on Show on Mac > > Mac was calling RequestRepaintForTesting() in production code on > Show. This is just wrong. The reason this code existed is no longer relevant > as far as I can tell. Delete it. > > Bug: 840545 > Change-Id: I17ebbcbd430860e568223a39d865ed14710ac503 > Reviewed-on: https://chromium-review.googlesource.com/1112497 > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570116} TBR=ccameron@chromium.org,fsamuel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 840545 Change-Id: Ic86a3fbc740b104e7f07196bee36e39a033fcca9 Reviewed-on: https://chromium-review.googlesource.com/1117520Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#570901}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/059a9ab4bcd0..54d7b314c84a git log 059a9ab4bcd0..54d7b314c84a --date=short --no-merges --format='%ad %ae %s' 2018-06-27 mtklein@chromium.org rename Chromecast bots to Clang 2018-06-27 robertphillips@google.com Switch createAlphaClipMask to use kTopLeft Created with: gclient setdep -r src/third_party/skia@54d7b314c84a The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:854875 TBR=jcgregorio@chromium.org Change-Id: Idc7a2b571f474490bdb8a1564a4bf13d80a96257 Reviewed-on: https://chromium-review.googlesource.com/1117478Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570900}
-
Brian Osman authored
Change-Id: Ic7acfad8d039172f858ca4b74f8ed3101e719afe Reviewed-on: https://chromium-review.googlesource.com/1117318Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#570899}
-
Bo Liu authored
If a draw is skipped, these values do not change, and should just be ignored. Bug: 854520 Bug: 687695 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1e9582043116f0a5acb7f9217a73a8379b7ac46f Reviewed-on: https://chromium-review.googlesource.com/1115762Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570898}
-
Qiang Xu authored
changes: We don't need to explicitly clear focus on search result tile item view's container. This belongs to "pseudo-focus" but we can remove it now, since it should be handled by focus manager. As a result, this CL also avoids passing parent container view to it. Bug: 795994 Test: manual and test coverage Change-Id: I97e54ca53e0fce7db72dc8856f1a3c9e3e2c875e Reviewed-on: https://chromium-review.googlesource.com/1116798Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#570897}
-
Yuly Novikov authored
deqp/functional/gles3/transformfeedback/random_separate_points.html on Mac Retina Nvidia TBR=kbr@chromium.org Bug: 857112 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I260fe3a05bf4f68cd9cb154e9a265fe58eada288 Reviewed-on: https://chromium-review.googlesource.com/1117037Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#570896}
-
Ryan Sturm authored
Bug: 842346 Change-Id: I7ed7cd5ab42a97ce0bb10d644a7904a191f2547a Reviewed-on: https://chromium-review.googlesource.com/1117302Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#570895}
-
Ken Rockot authored
Gets rid of Channel::Message::RewriteHandles in favor of inlining DuplicateHandle calls where needed; this is because it was only called in a few places, and each place had slightly different preconditions. Makes Channel aware of the remote process handle when possible, allowing handle rewriting to take place implicitly on send and receive with no action on the part of the Channel consumer. This all ultimately makes the handle rewriting logic a bit easier to follow, and is done in preparation for introducing a new PlatformHandleInTransit type to capture PlatformHandle + ScopedProcessHandle and get rid of ScopedInternalPlatformHandles usage for handle passing. Bug: 753541 Change-Id: Ib7914121b448b23209e1eef5286a808fb4f835f2 Reviewed-on: https://chromium-review.googlesource.com/1112951Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#570894}
-
Jonathan Backer authored
Missed an "} else {" when copy and pasting. We should only GrContext::abandonContext if the GPU is inaccessible. Otherwise we may leak GL resources. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8fccc9597068678a4044b0c15e7c29cffb3cf33c Reviewed-on: https://chromium-review.googlesource.com/1117377Reviewed-by:Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#570893}
-
Henrik Grunell authored
Handle case when a piece of data is split up in several buffers, with same device position. Bug: 830624, 826664 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib9daba9277d62af9b8aa39ef2f4a15548c1275da Reviewed-on: https://chromium-review.googlesource.com/1116782Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#570892}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a991ac69eb05..b3853afe341f git log a991ac69eb05..b3853afe341f --date=short --no-merges --format='%ad %ae %s' 2018-06-27 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@b3853afe341f The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I88418b3b3e35eced305b6db3a51b1a9fe5beb1c1 Reviewed-on: https://chromium-review.googlesource.com/1117147Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570891}
-
Raymond Toy authored
These tests basically pass on Firefox. If they don't, it's because Firefox is incorrect and issues have been filed for these. During the testing, we discovered that an incorrect assumption was made that calling start() would always work. Because of test failures in Firefox, this assumption is incorrect. Updated audit.js to latest Chrome version (to get loadFileFromURL) and add wpt lint exception for a console message in audit.js. Needed to update audiocontext-getoutputtimestamp.html to make bots happy because the AudioContext is running now on the bots, so time is progressing, so the time stamps aren't always zero. Bug: 745778 Change-Id: I5f9ee01498678db0feb57051f682772ca7bd9fbb Reviewed-on: https://chromium-review.googlesource.com/1040865Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#570890}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2d7cb9267899..8444b6a1bf03 git log 2d7cb9267899..8444b6a1bf03 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 tsepez@chromium.org Remove unused m_bGif* fields from CFX_DIBAttribute 2018-06-27 art-snake@yandex-team.ru Rework of loading of CPDF_Document. 2018-06-27 tsepez@chromium.org Use spans and UnownedPtrs in cjpx_decoder.h 2018-06-27 tsepez@chromium.org Remove CXFA_FField::UnloadWidget(). 2018-06-27 art-snake@yandex-team.ru Implement CPDF_CrossRefTable Created with: gclient setdep -r src/third_party/pdfium@8444b6a1bf03 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I03bed8a92e12e5eb934357c167b7df92fb111d62 Reviewed-on: https://chromium-review.googlesource.com/1117143Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570889}
-
Mikel Astiz authored
This reverts commit 661767b9. Reason for revert: tests still flaky. Original change's description: > Revert "[iOS] Disabling flaky sync tests" > > This reverts commit fb745f66. > > Reason for revert: underlying issue no longer reproduces on > other platforms after recent improvements, so optimistically > assuming it was also fixed for iOS. > > Original change's description: > > [iOS] Disabling flaky sync tests > > > > Disabling EarlGrey tests from SigninInteractionControllerTestCase: > > + testSignInSwitchAccountsAndKeepDataSeparate > > + testSignInSwitchAccountsAndImportData > > + testSignInSwitchManagedAccount > > > > Those tests seem to trigger an issue in the sync code when doing enable > > disable enable too fast. > > > > Bug: 854446 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > > Change-Id: I76d10d272297e91650dbe91ef7acee500eac6c75 > > Reviewed-on: https://chromium-review.googlesource.com/1107881 > > Reviewed-by: Justin Cohen <justincohen@chromium.org> > > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#568843} > > TBR=justincohen@chromium.org,jlebel@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 854446 > Change-Id: Ic809289ce4662d099250668d6f23100e52de9587 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1114719 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570374} TBR=justincohen@chromium.org,jlebel@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 854446 Change-Id: I2a0a2e9d60988783fca93ef8313594d57b7ab906 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1117578Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570888}
-
Shahriar Rostami Dovom authored
Bug: 841836 TBR=tsepez@chromium.org Change-Id: I443affb8c929525df4c9c08bb00969414bd711d8 Reviewed-on: https://chromium-review.googlesource.com/1091956 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#570887}
-
Sigurdur Asgeirsson authored
Also maintain a map of WebContents to the latest navigation ID in the PageSignalReceiver. This allows observers to filter out late notifications. Update a couple of observers that were mis-processing late notifications. Bug: 854598 Change-Id: Idac49a675e306ae6d79c74b7c658c8393d8aefad Reviewed-on: https://chromium-review.googlesource.com/1117128 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#570886}
-
Ryan Hamilton authored
Merge internal change: 202011580 Relands https://chromium-review.googlesource.com/c/chromium/src/+/1114143 Change-Id: I636d472909a65c8d1237b12513cbcc041f40e4b9 Reviewed-on: https://chromium-review.googlesource.com/1117438Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#570885}
-
Jeremy Roman authored
This may enable us to remove support for recursive mutexes in the near future. Bugs in this CL are likely to manifest as threads hanging while trying to acquire this mutex recursively (while manipulating GC objects). Bug: 856641 Change-Id: Icfc3982f7489fb53ddd4df319c405002ee1c3ea8 Reviewed-on: https://chromium-review.googlesource.com/1112197Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570884}
-
danakj authored
While trying to remove WebLayerTreeView this file confused me greatly so try to simplify and clarify things a bit. TestWebViewWidgetClient was-a TestWebWidgetClient, but you can get a WebWidgetClient from a WebView directly by calling WidgetClient(), so no need for this adapter. AllowsBrokenNullLayerTreeView() is for when InitializeLayerTreeView() returns null, which these classes don't do, so remove it. R=dcheng@chromium.org Bug: 838693 Change-Id: I65c258d0eaedb55de70edecffa134f5bf050cb76 Reviewed-on: https://chromium-review.googlesource.com/1115901Reviewed-by:
-
Mike Dougherty authored
TBR=eugenebut@chromium.org Bug: 857129 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I407a6464e71296cc15eef43bf7ed2a8ca8181909 Reviewed-on: https://chromium-review.googlesource.com/1117300 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#570882}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/32dc063f6647..3f423e75215c git log 32dc063f6647..3f423e75215c --date=short --no-merges --format='%ad %ae %s' 2018-06-27 hjd@google.com Merge "perfetto-ui: Temporarily disable browser tests on Travis" 2018-06-27 hjd@google.com perfetto-ui: Temporarily disable browser tests on Travis Created with: gclient setdep -r src/third_party/perfetto@3f423e75215c The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If5a14daf322982a18ba585cbe136b30e5ad67da4 Reviewed-on: https://chromium-review.googlesource.com/1117142 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570881}
-
Eric Karl authored
Many of our current issues turned out to be due to missing shutdown logic which caused the GPU thread to shutdown before the compositor, leading to a number of DCHECKs, and a hang if those were removed. This change allows the CompositorImpl to tear down before the GPU proc. Bug: 851643 Change-Id: Ieb96da9b7132e4ccf8ebf71dc0ee920bfbeb4217 Reviewed-on: https://chromium-review.googlesource.com/1115875Reviewed-by:
-
Adithya Srinivasan authored
Using double to represent time is error prone as the units are unclear. Change-Id: Id3a6ce23e684643f424dcbc84e2cca708faeda3c Reviewed-on: https://chromium-review.googlesource.com/1115904Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#570879}
-
Mark Pearson authored
These are requests to delete a personalized query suggestion that came from Google's servers. Tested by looking for X-Chrome-Data header using about:net-internals before and after this change on the delete request. Bug: 848992 Change-Id: I900b80891fde655d87c88d2de060728d976688b2 Reviewed-on: https://chromium-review.googlesource.com/1105463Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#570878}
-
Clark DuVall authored
This was suggested in crbug.com/789636 so this logic can run in production before the launch of the network service. Had to keep the tab notification logic in each delegate, since the way NetworkServiceNetworkDelegate maps the request back to the original tab (using the URLLoader set as user data on the request) does not work if network service is disabled. Bug: 789636, 789632 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I22395f914639d8ce83457a63062927e876caeaa9 Reviewed-on: https://chromium-review.googlesource.com/1113903Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#570877}
-
Tom Anderson authored
Clusterfuzz has marked bug 821704 as fixed, though it's possible adding the logging perturbed the timing just right so that this bug is no longer triggered. Or the bug may actually be fixed. Either way, we should remove the logging to make sure the bug doesn't resurface. Bug: 821704 Change-Id: I4fb5a1394162e814ef28b2a5834af2bc13304ce0 R: gab Reviewed-on: https://chromium-review.googlesource.com/1117304Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#570876}
-
Tarun Bansal authored
This reverts commit 69c98ffc. Reason for revert: The field trial experiment was turned down since it did not show any improvement (see http://shortn/_3N4YH2mKyq). Besides, the perf bots showed a regression. Original change's description: > Add ThrottleDelayable 4G params to fieldtrial_testing_config.json > > Bug: 746640 > Change-Id: Ie312a7756f5e6917a4d7c2bd107951f4928e97d0 > Reviewed-on: https://chromium-review.googlesource.com/1024054 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552765} TBR=jwd@chromium.org,tbansal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 746640, 838443 Change-Id: I349ed4bdafedeadb8e80af332472937babb7b820 Reviewed-on: https://chromium-review.googlesource.com/1117220Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570875}
-
Joshua Bell authored
Chrome supports a non-standard "priority" option for cookies, which is used to prioritize eviction when the cookie jar is full. Since the document.cookie setter just passes the cookie string through IPC to RenderFrameMessageFilter::SetCookie and, after various hops, into the net::CookieStore, the option is implicitly supported even though it was intended primarily for use by the Set-Cookie HTTP header. Add test coverage so we don't unintentionally regress support for this if, for example, we change the way document.cookie passes cookies into net::CookieStore. Change-Id: I0084d2f177ca7dac88a3f20603198c689351c4a2 Reviewed-on: https://chromium-review.googlesource.com/1116059Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
Pre-Refresh a maximized window had a very condensed tabstrip, so it made sense to set Windows 10's caption button height to (slightly less than) the tabstrip height. Refresh tabs are much taller though, so now they look way too big. This patch caps their height at the restored height, since that's what Windows does in the same case. Bug: 855802 Change-Id: I305491442462a8979388cb78e0be3975d9f1c88f Reviewed-on: https://chromium-review.googlesource.com/1116188 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Mark Pilgrim authored
Bug: 844933 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0f23e77a0907b8def0c4f962cea7910fbc75469f Reviewed-on: https://chromium-review.googlesource.com/1113669 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
