- 09 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e5fef85222ed..2a9754b30e90 2020-06-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1b37ea9126ea20d6551bfa08a08f911b4eabe3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237204Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776529}
-
Shengfa Lin authored
This reverts commit 68c28c5c. Reason for revert: Test flakiness Original change's description: > [chromium] Re-enable testGetSessions > > Retried locally on Mac and Linux, the test seems fine. > > Bug: chromium:899919 > Change-Id: I48d50f2f25a7111d4713b1b826eca36893e03289 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236886 > Auto-Submit: Shengfa Lin <shengfa@google.com> > Commit-Queue: Shengfa Lin <shengfa@google.com> > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776318} TBR=johnchen@chromium.org,shengfa@google.com Change-Id: Idcfbd0cbf2f46210e4c81752c693fccab5dbdecc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:899919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237648 Auto-Submit: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776528}
-
Tobias Sargeant authored
* Add comment to C++ enum indicating persitence in UMA * kCount -> kMaxValue, per UMA guidelines. * Remove lock and DCHECK that RecordMetrics is called on the UI thread. * Fix enums.xml, which listed enum values in the wrong order. Bug: 1083005 Change-Id: I4faf67d5614358d19e93df69128bba0fa68b561b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236136Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#776527}
-
Alex Rudenko authored
Disabling CL: https://chromium-review.googlesource.com/c/chromium/src/+/2235718 DevTools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2236400 Bug: 946975 Change-Id: Ib0b84bda186ed009b36f587ecfd540f2310e61bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236138 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#776526}
-
Xiaocheng Hu authored
The histogram is not under active monitoring, and we didn't receive any related alerts in ~20 milestones. Hence, this CL deprecates it. Bug: 1089650 Change-Id: If86e90c52095ab27ed419e6c618888733560d428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236230Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#776525}
-
Ella Ge authored
This CL adds the java part of InstalledWebappGeolocationBridge that pass start/stop location updates to the TWAClient, and also pass the location data that received from TrustedWebActivityCallback, to the native part. This also adds the InstalledWebappGeolocationBridge::SetOverride, which is the same as GeolocationImpl::SetOverride. Bug: 1069506 Change-Id: I4d561227a0ecadb52a41c19341044fe8488ab4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212455 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#776524}
-
Xida Chen authored
This CL disables the test on Cast Audio Linux. TBR=treib@chromium.org NOTRY=true Bug: 810690 Change-Id: I76214c00dd73a0874abf0afa5fff6a3a8d039fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237710Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776523}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. This CL also updates the call sites in ApplyConstraintsProcessor class, and also removes some uses of WebMediaStreamSource::Type, in favor of MediaStreamSource::Type. BUG=704136 R=guidou@chromium.org Change-Id: I8507cea20ef0a1171809444ec74f1163f30d5d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236233 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#776522}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cc23d95f5f85..7910a8f76121 2020-06-09 michaelludwig@google.com Account for surface origin in Dawn scissor rect If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1091734 Tbr: bungeman@google.com Change-Id: I92518d29446488f9c28d35e2fee199dcdba05c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237202Reviewed-by:
-
Mugdha Lakhani authored
Bug: 1091795 Change-Id: Iabf8e6d3dc83c071e1427c965c95ca4320d74fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235838 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#776520}
-
Marc Treib authored
https://crrev.com/c/2235075 disabled these tests on all platforms, when in fact they were only failing on ChromeOS. So this CL re-enables them on other platforms. TBR=rdevlin.cronin@chromium.org Bug: 1092345 Change-Id: I7c00e74ed21bf1db18ac7c346e7d02513aa15f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236140Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#776519}
-
Asanka Herath authored
Move the privacy_budget related source definitions into separate BUILD.gn files in the respective source directories. Doing so eases the logistical burden of the fairly heavy code churn in these directories. R=haraken@chromium.org Bug: 973801 Change-Id: I2d6520d8453ea4f48bf9717315436d90a8c293e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231507Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#776518}
-
Adam Langley authored
This change implements the getPublicKey(), getPublicKeyAlgorithm(), and getAuthenticatorData() functions described in the editor's draft of WebAuthn level two[1]. [1] https://w3c.github.io/webauthn/#sctn-public-key-easy BUG=1083301 Change-Id: I3a03279d5239a9f8df50a78f2166f30d01d38d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204087Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alex Russell <slightlyoff@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#776517}
-
Andrew Grieve authored
This runs our existing espresso .jars through jetify so that they no longer need enable_jetify = true. Mechanically updates all source references to the new package name. Bug: 896775 Change-Id: I1fb688421d3703c211279ba9ae0d29edef77d718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233692 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#776516}
-
Eric Seckler authored
Moves the stop-gap implementation of typed trace events from //services/tracing/public/cpp/perfetto into //base/trace_event and extends //base's stub implementation to cover typed event macros, too. This adds a dependency on //third_party/perfetto to //base in the case when the enable_base_tracing gn flag is set to true. Base embedders can set this arg to false to disable tracing support and avoid the dependency on //third_party/perfetto. Design doc: https://docs.google.com/document/d/1f7tt4cb-JcA5bQFR1oXk60ncJPpkL02_Hi_Bc6MfTQk/edit Test: add a new typed event to //base (not submitted), run services_unittests, base_unittests (the latter also with enable_base_tracing = false). Change-Id: I1f54b9e6b4b9f26aff5b85d2e3d18aaceb752936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203380Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#776515}
-
sandromaggi authored
This test has been disabled for failing on tablet. Looking at other sources testing the new tab button, they set a restriction to only enable it for phones. This CL does the same to that test. Bug: 1070272 Change-Id: I1c108391f0f4b5b31e2b8271392a998ed5266109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236440 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#776514}
-
Marc Treib authored
According to webkit_lint, "virtual/*/"-prefixed test expectations are implied by the non-prefixed ones, so no need to list both of them. This CL removes two such cases (for external/wpt/webrtc/RTCPeerConnection-getStats.https.html). TBR=hta@chromium.org No-Try: true Bug: 1092835 Change-Id: Ia5e841194e3ca673245fd6956369d23c67b4774f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235848Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f19675c75eab..a7e60fe18677 2020-06-09 ddrone@google.com Update a comment in proto_library.gni If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4eacd81c0997eacc66654b2c1134621e82237625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237201Reviewed-by:
-
Ewann authored
This is a reland of 62ef43a9 Broken tests have been fixed here: https://chromium-review.googlesource.com/c/chromium/src/+/2230496 Original change's description: > Adds ChangeTabSwitcherPosition to Field Trial Testing Configuration > > > Bug: 1073826 > Change-Id: I378c67f926df54bd4bd75d0a64f7b241534238a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208971 > Commit-Queue: Ewann Pellé <ewannpv@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775055} Bug: 1073826 Change-Id: I2b4e824f024b3d1994eb6bbe9f8081e5b5a1e0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232343Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Chris Blume authored
The Renderer4.ImageDecodeTaskDurationUs* histograms will be expiring soon. These track the cache hit rate for the software decode cache. This CL changes the expiry to 1 year from now, as suggested in [1] for a histogram which will be useful indefinitely. It also adds me as an owner of the histogram since I plan to be doing a lot of image decoder work. [1] https://chromium.googlesource.com/chromium/src/+/master/tools/metrics/histograms/README.md#how-to-choose-expiry-for-histograms Bug: 1089796 Change-Id: I66aea8522635ecf2f86f07e6254e95136c9a213e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236733Reviewed-by:
-
Aya ElAttar authored
Added another PolicyMap::Entry::set_value to override the old one to switch from passing value as unique_ptr to base::Value. Bug: 1092471 Change-Id: Ibe38a8cbb022d951495c2b2d03a3b40d70e54f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237251Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Auto-Submit: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#776509}
-
Rohit Rao authored
-[NSInvocation getArgument:atIndex:] fills its argument into a void* and therefore doesn't trigger an ARC-synthesized retain. If the argument is stored into a strong pointer, release is called when the pointer goes out of scope, which causes the object to be overreleased. Annotating the pointer as __unsafe_unretained avoids this problem. BUG=1092875 Change-Id: I990c3878b9ab7d828ff17f3a3cf530059f7f5c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235656 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776508}
-
Alexandre Courbot authored
The stateless V4L2 decoder, which was the only V4L2 decoder supported so far, allowed both queues to be started and stopped at the same time. This is not the case for the stateful decoder, which need to start the input queue first, and to keep it running when changing resolution. Add a parameter to the streaming control methods of the V4L2VD to allow this behavior to take place, as well as an extra method in the backend interface to let the VD know whether it should stop the input queue or not during resolution changes. This decoupling of the queues means that the input queue may now have buffers queued when we change resolution. So remove the DCHECK() that checked against this since it is obsolete. BUG=b:149663704 TEST=VDAtest --use_vd passes on Krane. Change-Id: I038b61ced2f09f7d390be1716117c65c245a10bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235581Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#776507}
-
Andrew Grieve authored
These methods are removed in androidx. Bug: 896775 Change-Id: I553a80f90d0b16946935cad7d1dbb590e79626a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235741Reviewed-by:
-
Henrique Nakashima authored
ChromeTabModelFilterFactory is the implementation passed in, and provides either TabGroupModelFilter or EmptyTabModelFilter, depending on flags and DFM availability. This breaks the dependency from TabModelFilterProvider and allows it to be moved to the tabmodel modules. Bug: 1090033 Change-Id: Ibb19abca6b4224e7c24f23c4e187d20f268bd3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231743Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#776505}
-
Saurabh Nijhara authored
This CL introduces the handling of showing in-session notifications when update is required as per the policy but the device is not connected to a network for the updates to download. The notification is to be shown when the policy is received and on the last day of the deadline. A new WallClockTimer is introduced to keep track of the last day for showing the notification. A new test is also included to verify this behavior. The subsequent CLs will introduce the handling for notifications in case of end-of-life devices and metered network. Bug: 1048607 Change-Id: Idecb0f976ad96af537e2ffe4faf9936b7ddfc407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218020 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/09eb6e249d4e..a48dd43fe185 2020-06-09 danilchap@webrtc.org Add builder setters for ScalableVideoStructure::LayerFrameConfig 2020-06-09 terelius@webrtc.org Move NetEq and ANA plotting to a separate file. 2020-06-09 terelius@webrtc.org Fix nondeterministic behavior in rtc_event_log_visualizer caused by uninitialized variables. 2020-06-09 mflodman@webrtc.org Adding brandtr as api/video owner 2020-06-09 mbonadei@webrtc.org Trigger bots. 2020-06-09 tommi@webrtc.org Revert "Remove dead code from ModuleRtpRtcpImpl2" 2020-06-09 tommi@webrtc.org Remove dead code from ModuleRtpRtcpImpl2 2020-06-08 tommi@webrtc.org Add diagnostic printout to RTC_DCHECK_RUN_ON. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8f005bdf029097a778bbae839e2c0733626085a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237200Reviewed-by:
-
Bartek Nowierski authored
Bug: 1086388 Change-Id: Ic73b32ee9b49cbb6fd1901e5340af1ce4274b2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215538 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0a79bee135cd..83faf15d21b6 2020-06-09 cwallez@chromium.org infra: Migrate builders to Goma RBE If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:950413 Tbr: cwallez@google.com Change-Id: Ib5b437a7fc1e4cdc14cfbb3494f3e66681225196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237414Reviewed-by:
-
Dave Tapuska authored
In order to move some of the input handling into blink from content we need these additional helper classes inside blink. BUG=1073560 Change-Id: I9cf5bebc0a37d39d93d371d6c97bcccb9d957bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235936Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#776500}
-
Boris Sazonov authored
Extends mobile-identity-consitency flag and updates the list of owners. Bug: None Change-Id: I315eb17cf9a23f11221329e0ec2339b42cb58fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237466 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#776499}
-
Monica Basta authored
This CL creates |SigninManager| for desktop platforms. The signin manager will be responsbile for managing the primary account for desktop platforms.This CL also moves all the logic of computing the unconsented primary account to the sign in manager. Bug: 1046746 Change-Id: I8e9e55234e2b5bbc13f0e3d497eaf5389921172d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090428 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#776498}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b137479bdc69..e5fef85222ed 2020-06-09 jacktfranklin@chromium.org Add global TypeScript type support to ts_library 2020-06-09 alexrudenko@chromium.org Ignore internal css keywords If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1092826 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I946a4c7955afa6618dabe555895d640774dc567a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237413Reviewed-by:
-
Liviu Tinta authored
Split the test into two subtests. testdriver cannot click on an element in another iframe for Firefox. Remove pointerevent_pointermove_in_pointerlock test from expectation files. Add expectation file for infrastructure testdriver. Bug: 1086154 Change-Id: I3d3cd9c020c9c3d17d53dfa06175e01ea549a740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233579Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#776496}
-
Juanmi Huertas authored
Removing as well all the msaa_sample_count infrastructure to remove this flag completely from Chrome. This CL also removes the |resource_dispatcher| parameter from the CanvasResourceProviderSharedImage, as it was not used. Bug: 1078518, 1054797 Change-Id: I32e19323c4f4fe4f8adda662cd656c6e57ed5ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225528Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#776495}
-
Jose Magana authored
Follow adapted version of: crbug/1051776 and https://chromium-review.googlesource.com/c/chromium/src/+/2182702 as migration plan: Step 1: (This CL) - add .gitignore entry for new path - add entry to src/DEPS for MediaApp - point references to app to the new entry Step 2: (CL internal: https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/3089141) - remove entry for app in src-internal/DEPS Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Bug: 1080473 Change-Id: I942c3f24382b6c1c9ad0688364e932090ea3e5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230559 Auto-Submit: Jose Magana <jomag@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/37e562110fa5..a2e91dbb6195 2020-06-09 tikuta@chromium.org apply yapf for ninjalog*.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:992282 Tbr: agable@chromium.org Change-Id: I1f73ad81bc4c0ab022d1b6e250990bc60c8ce871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237408Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Bug: 1084759 Change-Id: I14f2a85ee6e880313f74f2933887a5ad54c558da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235872Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#776492}
-
Marc Treib authored
This reverts commit bb3eba33. Reason for revert: New tests are failing on Mac, see e.g.: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/51174 All failing bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests Original change's description: > Add browser test for permission prompt. > > Bug: 1019129 > Change-Id: I08a2c1d038f353b0f84264d0a3ddf26f601347a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214536 > Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776457} TBR=bsep@chromium.org,olesiamarukhno@google.com Change-Id: I071939c3e57947489513b14ef49f9ff1037c5617 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235847Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGInlineItemsBuilder| to hold |LayoutBlockFlow| to allow member functions to use |LayoutBlockFlow| during collecting inline items for preparation of the CL[1], e.g. - Use LayutBlockFlow in CollectInlinesInternal() - Use LayutBlockFlow::HasLineIfEmpty() in ExitBlock()[1] [1] http://crrev.com/c/2139612 EditingNG All-In-One Bug: 707656 Change-Id: Ie5a43f97e8ee7f2aa18e7024841fe9f4f48dfe54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237426 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776490}
-
