- 20 Jan, 2021 40 commits
-
-
Sylvain Defresne authored
The code to deal with multi-window enabled/disabled was duplicated in CrashRestoreHelper where calling the multi-window enabled code with a session with an empty name was the same as calling code for single window. Refactor the code to avoid the duplication. Change the backup directory used for the saved session when restore is in progress as the single directory approach would not work with multi-profile. Bug: 1165798 Change-Id: Ifa6efe051999b77688a8a6ffdb8b9ed3b185e60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632677 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845174}
-
danakj authored
When enrollment completes, WizardController may restart chrome. Part of that restart does a fast shutdown on every RenderProcessHost, killing all renderers. However there may be tasks waiting to run that are IPC replies from the webui renderer. Once such task is EnrollmentScreenHandler::DoShowWithPartition(). The OobeConfigurationRollbackTest.TestEnterpriseRollbackRecover test causes this restart to happen. Then as the test is ending, it runs the message loop a number of times. If the renderer's reply happens to be sent before being killed, and then arrives in the browser, the test will run DoShowWithPartition(). This attempts to run JS in the renderer which has been destroyed already. This becomes a crash when we tear down the mojo connection with the renderer-process frame in https://chromium-review.googlesource.com/c/chromium/src/+/2593750. Rather than have CallJS() or some high-level object check if the RenderFrame exists, which would hide logic errors, we inform the EnrollmentScreen from WizardController when it is restarting chrome. Then the EnrollmentScreenHandler can stop trying to talk to non- existent renderer processes. We do this from WizardController because EnrollmentScreen does not know this is happening on its own, as the decision making about this is done up in WizardController. R=achuith@chromium.org Bug: 1158869 Change-Id: I83b6af31a463fa94869035f960b27bd8195a89fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629576Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#845173}
-
Sami Kyostila authored
Perfetto doesn't use a flags or scope parameter with typed trace points, so remove these parameters from the compatibility shim in Chrome too. Bug: 1006541 Change-Id: I7b184de3a0cacba975446da6be8b4ea5316496b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633994 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#845172}
-
Marc Treib authored
aka ButterForPayments stage 1 Bug: 1081749 Change-Id: Iac065ddff2dec907639dc088209c167abe94c50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631489 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#845171}
-
Mitsuru Oshima authored
Bug: 1155308 Change-Id: I129ec6179e1e1c394c47109979421b15b877356b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638423Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#845170}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f24f9c44a65..7be5f12445fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC cfroussios@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: cfroussios@google.com Change-Id: I277d0fe6e3c55f81833c008dc9a60290d5cd0209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640154Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845169}
-
James Cook authored
We now use SkBitmap and its mojo serializer for image transport. This class is now unused. This CL deletes everything but the bitmap.mojom file itself. I can't delete that because there are [Stable] mojo APIs that have optional Bitmap? deprecated fields. Bug: 1166395 Change-Id: I7ed76babb7e59101a041d97bfd5221da6cd09792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633202Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#845168}
-
Hiroki Nakagawa authored
prerender::mojom::PrerenderMode enum was widely used over processes, but it's now only used in a few classes in the browser process. For code simplification, this CL replaces it with a simple boolean. - PrerenderContents::prerender_mode() always returned kPrefetchOnly, so it's removed. - ChromeNavigationUIData::prerender_mode() is replaced with is_no_state_prefetching() that returns a boolean. Bug: 755921 Change-Id: Ia40856aa57117771a53055f9e9ffbaf51029f42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635543Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#845167}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0c46f3e0..710f03fa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4e352ecd18d515692affdd55cf75e61c39faa6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639799Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845166}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6eb610f75cad..26fdcbb38b7d 2021-01-20 johnstiles@google.com Implement constant folding for (bool == bool) and (bool != bool). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I8822c81a4bcdf6adfd8d5e2f3d156adc7a797d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639515Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845165}
-
Nicolas Ouellet-Payeur authored
go/win-annotator-rel and go/linux-annotator-rel have been failing for a week or so, due to invalid "chrome_policy" values in network annotations. Fix the annotations directly to make the bots green again. Bug: 1166676 Change-Id: Ib383e109d7a00a62b365d058938f2db1b71362d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633706Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#845164}
-
Hazem Ashmawy authored
This histograms are still relevant and useful to mentor the service performance and to make sure it's running as expected. Thus, I am extending it by 6 months per the public docs: https://chromium.googlesource.com/chromium/src/+/master/tools/metrics/histograms/README.md#how-to-choose-expiry-for-histograms Fixed: 1156193 Test: N/A Change-Id: I1a3fbe5dd39b2eefc8576acce59296cf87ed36fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637707 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#845163}
-
Emircan Uysaler authored
This CL sets the soft limit at 0 when we are in CRITICAL memory pressure. This enforces sync and cleanup in every submit call to reduce memory usage spikes. This CL only affects platforms that have soft limit. That happens if --vulkan-sync-cpu-memory-limit-mb flag is set, which is only enabled on fuchsia. Bug: 1166839 Change-Id: I9d38cba2479a8c912d6b1e1624e9f893be8188de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629573 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#845162}
-
Tibor Goldschwendt authored
Specifically, this CL extends: * NewTabPage.ShoppingTasks.ProductDownloadCount * NewTabPage.RecipeTasks.RecipeDownloadCount * NewTabPage.RecipeTasks.RelatedSearchDownloadCount Fixed: 1167846, 1167845 Change-Id: I38641726241e1522ffd04f6cc6efaf93fce49167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638937 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Luke Zielinski authored
This rolls up to 79d2debce531d115566192dccf70f5d8fb9ced53. Only one change is pulled in to support Shadow Root in webdriver. Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Iccc7e81c85b3f387e1cca1e2dfd588ec230c61a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636692 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#845160}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611122392-25e28eb139aeca4757479341148e7dbfa12d9c66.profdata to chrome-mac-master-1611142151-b9d265a27dc1ef032fcc18909cf95e9a04349e8f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia3617db9dc1d9c2f405457718a1e1ab06c7e6b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640279Reviewed-by:
-
Caroline Rising authored
Track two sets of read/unread counts, one when the reading list model has loaded and one when building a log for the current session using the DesktopPlatformFeaturesMetricsProvider. Bug: 1163938 Change-Id: I1b23847e7f209cc2a77b57f0e344d7c9b04c546b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621914Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#845158}
-
James Vecore authored
Adds some additional logging for the Bluetooth mac address when sending a file to understand what is causing nearby connections to skip a BT classic connection attempt. Bug: b:177697070 Change-Id: Ife98ad3a60680f22620186049c917781dc0596b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639296 Auto-Submit: James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#845157}
-
James Cook authored
It should be "_mojom_traits" not ".mojom_traits". The latter does not match any files. Bug: None Change-Id: I039826848ad264a9437a22ec6bd314cc37aec67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639397 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
-
Vincent Boisselle authored
The NTP feed-related tests are in FeedV2NewTabPageTest, which has its own control functions. Bug: 1167893, 1091640 Change-Id: I9498d1ce753d0a95ed357ea9f5f707022df8ad29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635346Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#845155}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611122392-3fa54c599d014435b3d566bb93ac7e4c3fcf93dd.profdata to chrome-linux-master-1611142151-f3b642624b7e7391f296111a04b779942697c546.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I712a8b82dfa1ed0766f2ac68280d8f056845ef1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640275Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611122392-e8f247e0fcfff108ca1c2d87a3238278081efa89.profdata to chrome-win32-master-1611132884-698d50ded477bbf68b51ffca48f766bfc0d51fdd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib28c68c846530c61c04a843ce5a434c8c27c9c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639299Reviewed-by:
-
Alice Wang authored
This CL cleans up the parameter SigninFirstRunFragment.FORCE_SIGNIN_ACCOUNT_TO used for FRE with child account, since this parameter is available in SigninFirstRunFragment, we don't need to save it in bundle and pass it down to the fragment. Bug: 1045473 Change-Id: I6b783f30630885d37d4aa8656307cd85d19554a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628297 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#845152}
-
Wez authored
Bug: 1162433 Change-Id: I7b40969219f46c39b3be550724f53b2e544f4d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640493 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#845151}
-
Sebastien Marchand authored
Bug: 1168512 Change-Id: I312ad1f704621be356202b83273317f41d386986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639807 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#845150}
-
Alice Wang authored
This CL moves the method openAccountPickerBottomSheet() from SigninUtils to SigninBridge to facilitate modularization. Bug: 1165772 Change-Id: Ifc47512cdb0c8b680e16a4fedd49c010a25a7359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631491 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845149}
-
Christian Dullweber authored
Also remove obsolete feature. Bug: 1146211 Change-Id: Ia99d008c78adc374c563b27d75147d62ff07554d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632960 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#845148}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a709974a868b..540f809f11e2 2021-01-20 aerotwist@chromium.org [boot perf] Fix value sorting 2021-01-20 tvanderlippe@chromium.org Empty several modules keys in module.json files 2021-01-20 bmeurer@chromium.org [cleanup] Remove unnecessary Promise.resolve()s in DebuggerModel.js 2021-01-20 sadym@chromium.org Respect DeviceScaleFactor in fullscreen screenshots If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1131500,chromium:1161501,chromium:1164757 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I08f677f466789a34cc4d0cf5062d30dbebf5f598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640274Reviewed-by:
-
Andy Paicu authored
This reverts commit f3c62799. Reason for revert: Final PS did not make it in Original change's description: > Reland "Disconnect bluetooth device when the user revokes permission" > > This is a reland of 6ef36937 > > Original CL broke the build: > https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/b8861845414785298224 > > Original change's description: > > Disconnect bluetooth device when the user revokes permission > > > > Bug: 1128494 > > Change-Id: I394e97f61268869557df5c64017504745a8fcd71 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412331 > > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#833671} > > Bug: 1128494 > Change-Id: I4480bb33f2df1ad9e9302ec94b27da9195170373 > Fixed: 1155527 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573102 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845142} TBR=reillyg@chromium.org,alexmos@chromium.org,jochen@chromium.org,andypaicu@chromium.org,dougt@chromium.org,odejesush@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ib2147c7d4f76207ae1a6119496cc5e327db6478c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1128494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640613Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845146}
-
Anatoliy Potapchuk authored
Previously, we were never allowing guest users to configure global display settings, but since it became common to have cases where we have one single user always using managed guest session, we decided them to be able to configure device-wide display setting. Bug: 1166412, b/150002447 Change-Id: I09a372dd9878a01cb9d2f99f52e6e9e85d822b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628288 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#845145}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I4aaefe4249b157582bf59d0b6e051c3fd9a2059a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640163Reviewed-by:
-
Owen Min authored
Add getter function of PolicyCache that reads from the SharedPreferences https://source.chromium.org/chromium/chromium/src/+/master:components/policy/core/common/policy_service_impl.cc;l=146?q=IDS_POLICY_MIGRATED_NEW_POLICY&ss=chromium%2Fchromium%2Fsrc Bug: 1127469 Change-Id: If6f8103e55625439a0607e358449ffddfe2949cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633927 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#845143}
-
Andy Paicu authored
This is a reland of 6ef36937 Original CL broke the build: https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/b8861845414785298224 Original change's description: > Disconnect bluetooth device when the user revokes permission > > Bug: 1128494 > Change-Id: I394e97f61268869557df5c64017504745a8fcd71 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412331 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833671} Bug: 1128494 Change-Id: I4480bb33f2df1ad9e9302ec94b27da9195170373 Fixed: 1155527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573102Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845142}
-
Aaron Leventhal authored
R=aboxhall@chromium.org Bug: 1167269 Change-Id: I5bb0f5fac139dcf16631482e4a21a85e41bd92c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636892 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#845141}
-
David Van Cleve authored
This change adds a space where one was missing. Bug: None Change-Id: I310ac3ec640a3d289db5a540db2959ede646bf2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638371 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#845140}
-
Sébastien Marchand authored
This reverts commit 7ec49ce5. Reason for revert: Causes deps failures, see crbug.com/1168512 Original change's description: > Delete //c/b/profiles/DEPS > > Per http://crrev.com/c/2542933/10/chrome/browser/profiles/DEPS#5 > This DEPS file had just one include rule, which explicitly allowed a > single include in a file with ~200 includes. Seems odd and not useful. > > Change-Id: Ic655d0c446671703f119223e47b6f8d54ae9a512 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636820 > Auto-Submit: Glen Robertson <glenrob@chromium.org> > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845114} TBR=droger@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,glenrob@chromium.org Change-Id: Iec68e19770867d63c707cb37800938833f819fa0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639806Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#845139}
-
chrome://policyIgor Ruvinov authored
To future-proof adding status messages to policies, the existing statuses (`AddError`, `AddWarning`) are combined into a single generic status method `AddMessage` which accepts the type of status message as an argument. This simplifies addition of new statuses, such as the status "Info" which will be used in a following CL. Bug: 1104043 Change-Id: I09196dc98ac78bc8c29131e303a68304069aa6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625895 Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#845138}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611089910-6a1c1563417281aed9ef8f312b971a0aa6f126b5.profdata to chrome-win32-master-1611122392-e8f247e0fcfff108ca1c2d87a3238278081efa89.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibac40abcf3f438326b866614a902eb4672d0bc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640158Reviewed-by:
-
Mirko Bonadei authored
This reverts commit 22e354b4. Reason for revert: usrsctp has rolled again so this can be relanded. Original change's description: > Revert "Add fuzzer targets for usrsctp." > > This reverts commit 36efcfc8. > > Reason for revert: Need to revert this in order to revert the last > usrsctp update: https://chromium-review.googlesource.com/c/chromium/src/+/2586379 > > Original change's description: > > Add fuzzer targets for usrsctp. > > > > Bug: chromium:1025302 > > Change-Id: Iadbcb87f0f3f3a1845e925aed8f52685d78e740e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108066 > > Reviewed-by: Harald Alvestrand <hta@chromium.org> > > Reviewed-by: Florent Castelli <orphis@chromium.org> > > Commit-Queue: Taylor <deadbeef@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816872} > > TBR=hta@chromium.org,deadbeef@chromium.org,orphis@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:1025302 > Change-Id: Ib984dc975c5802ad52d07b96d91e8fb1367bc4ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586282 > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Commit-Queue: Taylor <deadbeef@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836877} TBR=hta@chromium.org,deadbeef@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1025302 Change-Id: I6c07d1b0bbbb3be404f1c0f3370e39fa854055bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611102Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#845136}
-
Aaron Leventhal authored
This fix ensures that detached objects are never considered as included in the tree. Explanation: Sometimes a node is detached in the middle of the tree. For example, this can occur when a combobox popup closes its popup. Currently, when a node is detached in the middle of the tree, the parent hierarchy may not be immediately repaired, to skip over the old detached object, which can cause anything using ParentObjectIncludedInTree() to reach a detached object, which is not actually included in the tree. Normally the parent hierarchy will be repaired the next time the detached object's parent's children are requested. An alternate fix would be to, immediately when a node is detached, ensure that the parent hierarchy is always repaired when nodes are detached in the middle of the hierarchy. However, care would need to be taken to avoid extra work when an entire document or subtree is being removed. Bug: 1167459 Change-Id: If374617f451992c1f68607dc9b3c56bc0f0908c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638395Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#845135}
-
