GitLab

BUG=none
TEST=chrome://kill and javascript: URLs still work.
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/160743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250871 0039d316-1c4b-4281-b951-d872f2087c98

Althought the software renderer *could* support much larger sizes than
the hardware renderer, there's no reason to allow them.  This will
create a little bit more consistency between platforms and will prevent
security issues caused by gigantic allocations.

BUG=337882

Review URL: https://codereview.chromium.org/137703014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250870 0039d316-1c4b-4281-b951-d872f2087c98

* ensuring that "goog." and "google" are case-insensitive
* adding "collapse_key" (case-sensitive)
* fixing a typo in error messages in gcm_api.cc and tests: occured -> occurred.

BUG=316683

Review URL: https://codereview.chromium.org/141433030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250868 0039d316-1c4b-4281-b951-d872f2087c98

Crashes are still occurring in WebstoreInstaller::StartDownload(),
even after several attempts to fix them.

Diagnosis:
The installer holds a pointer to contents::NavigationController.
This object is owned by contents::WebContents, which can be deleted
before the StartDownload() callback is invoked.

Fix:
Store a pointer to contents::WebContents. Inherit from 
content::WebContentsObserver, which will clear the pointer when
the WebContents are destroyed.

BUG=165634

Review URL: https://codereview.chromium.org/138803012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250865 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250862 0039d316-1c4b-4281-b951-d872f2087c98

tough_scheduling_cases have several cases touch_handler_scrolling.html?*
that use touch move handler to scroll the page. This CL adds the touch
scroll latency collection for those cases.

BUG=246034
TEST=smoothness test on touch_scheduling_cases.touch_handler_scrolling.html?*
     now show mean_touch_scroll_latency.

Review URL: https://codereview.chromium.org/160683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250861 0039d316-1c4b-4281-b951-d872f2087c98

Just picks up one commit:

r250757 torne Fix license description in README.chromium.

BUG=

Review URL: https://codereview.chromium.org/152583009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250860 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342839
TEST=Manually tested with a User Policy file running on an Android build.

Review URL: https://codereview.chromium.org/136003008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250859 0039d316-1c4b-4281-b951-d872f2087c98

- rename to test_object.h
- put in content namespace
- CamelCase for function names.

minimal changes for now.

BUG=342118
TEST=None
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/151543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250857 0039d316-1c4b-4281-b951-d872f2087c98

This changes depends on r166988, and that hasn't actually rolled yet :(.

TBR=jamesr@chromium.org
BUG=327471

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250856 0039d316-1c4b-4281-b951-d872f2087c98

If the install verification signature we have stored in our prefs is
older than the install time of an extension, we don't want to
immediately disable it. Instead, we want to do another server request to
update our signature, and then disable if appropriate.

BUG=342165
R=finnur@chromium.org

Review URL: https://codereview.chromium.org/160313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250855 0039d316-1c4b-4281-b951-d872f2087c98

BUG=340859

Review URL: https://codereview.chromium.org/150203014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250854 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326023

Review URL: https://codereview.chromium.org/160693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250853 0039d316-1c4b-4281-b951-d872f2087c98

Land the patch on behalf of Ye Liu <cbakgly@gmail.com>

The original CL is:
https://codereview.chromium.org/137893002/
(All the three reviewers on the TBR line have LG-ed that CL.)

TBR=piman@chromium.org,jschuh@chromium.org,yzshen@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/161263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250852 0039d316-1c4b-4281-b951-d872f2087c98

R=jamesr@chromium.org, piman@chromium.org
BUG=327471

Review URL: https://codereview.chromium.org/155453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250851 0039d316-1c4b-4281-b951-d872f2087c98

A sync data migration request is signalled by the server during a normal
GetUpdates or Commit request.  The signal is then forwarded to the UI thread,
which actually performs the migration.

Traditionally, the signal has been sent through the SyncSessionSnapshot, which
is delivered to the UI thread at the end of the current sync cycle.  This CL
introduces new code to pass the signal through the SyncSession::Delegate and
SyncManagerObserverInterfaces.

This CL should not change the syncer's behavior.

BUG=339984

Review URL: https://codereview.chromium.org/158953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250849 0039d316-1c4b-4281-b951-d872f2087c98

Revert of cc: Disable "activate to low res" optimization (https://codereview.chromium.org/150403007/)

Reason for revert:
Reverting temporary patch merged to m33.

Original issue's description:
> cc: Disable "activate to low res" optimization
> 
> This optimization is broken on m33 and causes flashing to tabs.  Turning
> off the optimization fixes the problem.  This is an intentionally small
> patch meant for merging to m33 and then immediately reverting on trunk.
> 
> BUG=335289
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250332

TBR=danakj@chromium.org
BUG=335289

Review URL: https://codereview.chromium.org/161023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250848 0039d316-1c4b-4281-b951-d872f2087c98

Also included in this CL are:
- Removed task_runner in constructor of RawEventSubscriber impls
- Minor fixes in unittests

Review URL: https://codereview.chromium.org/145873007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250847 0039d316-1c4b-4281-b951-d872f2087c98

Add ability to read data without parsing it as JSON to PrivetURLFetcher. In
addition, add the ability to send range requests.

BUG=332182

Review URL: https://codereview.chromium.org/156143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250846 0039d316-1c4b-4281-b951-d872f2087c98

R=jliebrand@chromium.org, zork@chromium.org
BUG=342707
TEST=manual
NOTRY=true

Review URL: https://codereview.chromium.org/160223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250845 0039d316-1c4b-4281-b951-d872f2087c98

When enabled, this causes Chrome to open the default communication device instead of the "regular" default device (eConsole).

At the moment this only works for the default device (i.e. when getUserMedia is called _without_ a sourceId constraint).  But it is possible to implement this for other audio devices and I'll do so in a followup CL.

While doing this I also fixed a few other things that I ran into:

* Added support for the 'AudioParameters::DUCKING' effect in the WASAPI audio implementation.
* Refactored WASAPIAudioInputStream:
  Removed HardwareSampleRate and HardwareChannelCount since they duplicate work and added GetInputStreamParameters instead.
* Fixed AudioManager::GetInputStream to return format == linear AudioParameters on XP (previously it would always return 'low latency').
* Fixed AudioManager::GetInputStream to return a 10ms default buffer size for the low latency path instead of a fixed buffer size of 2048.
* Fixed a race issue with how CoreAudio::IsSupported was being used.  Also added documentation/warning about the implementation properties of that function.
   - This race has been causing tests to be flaky (for example the InputVolumeTest has been red for weeks on the Windows audio bot: http://build.chromium.org/p/chromium.gpu.fyi/waterfall?builder=Win7%20Audio).
* Removed the InvalidPacketSize test since it doesn't make sense anymore.  The code that InvalidPacketSize has been testing, has been gone for 6 weeks now and the Windows audio bot has been red that entire time.

BUG=340377, 314654, 295751
TEST=Manually run the "WASAPIAudioInputStreamRecordToFile" test while playing out audio in another application (or a youtube clip).  The playing audio should lower in volume while the test runs.

Review URL: https://codereview.chromium.org/155863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250844 0039d316-1c4b-4281-b951-d872f2087c98

BUG=169960
TEST=none
R=gavinp@chromium.org

Review URL: https://codereview.chromium.org/148293016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250843 0039d316-1c4b-4281-b951-d872f2087c98

In the standard HTML5 audio path we simply skip over these errors after
throwing out the current packet.  We should do the same thing in WebAudio.

BUG=170147
TEST=test case on bug works correctly.

Review URL: https://codereview.chromium.org/132373013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250842 0039d316-1c4b-4281-b951-d872f2087c98

Removed the product name placeholder due to presumbit warning http://goo.gl/6614MQ.

BUG=326023

Review URL: https://codereview.chromium.org/159723009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250841 0039d316-1c4b-4281-b951-d872f2087c98

This change counts all cards indiscriminately for explanatory link
purposes. Previously, we only counted location cards.

BUG=340838

Review URL: https://codereview.chromium.org/154653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250838 0039d316-1c4b-4281-b951-d872f2087c98

This will allow us, in a follow-up CL, to add a new Accessibility mode: AccessibilityModeExtension, which may co-exist with the previously existing modes.

BUG=

Review URL: https://codereview.chromium.org/145283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250837 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342872

Review URL: https://codereview.chromium.org/149303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250836 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the way we implement event callbacks on the sync
internals debug page.  We plan to rely more on this framwork in the
future.  This CL ensures we'll be building on a solid foundation.

It replaces chrome_sync.js's custom event listener implementation with
EventTarget from Chrome's internal JavaScript libraries.  Sync doesn't
require anything special in its implementation of event callbacks, so it
makes sense to use shared code for this.

Rather than defining a set of event listener callbacks, all events are
now routed through a single chrome.sync.events EventTarget.  From the
listener's point of view, this doesn't change much, since they still
need to register for a specific event type.  However, it does mean that
chrome_sync.js no longer needs to be aware of all the possible event
types.  Many of the event definitions have been moved into sync_log.js.

This change also introduces a new chrome.sync.handleEvent function to be
called from the C++ layer.  This new scheme will fail a bit more
gracefully than the old system would if the C++ and JavaScript list of
event definitions ever got out of sync.

Finally, this CL adds some more tests for the 'event log' tab of
about:sync.  This helps to ensure that the new system doesn't break
any existing functionality.

BUG=328606

Review URL: https://codereview.chromium.org/160083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250835 0039d316-1c4b-4281-b951-d872f2087c98

MagnificationControllerImpl::OnMouseEvent() should not update
point of interest for mouse events of type ET_MOUSE_CAPTURE_CHANGED
because they do not contain valid coordinates.

BUG=312496
TEST=verified cursor no longer jumps
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/160953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250832 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326023
NOTRY=true

Review URL: https://codereview.chromium.org/160183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250831 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326023

Review URL: https://codereview.chromium.org/160113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250830 0039d316-1c4b-4281-b951-d872f2087c98

This shouldn't be happening, but we got some crash reports suggesting it
does. Unable to repo locally so this stat will verify it does occur and
then can be used to verify our fixes actually fix it.

BUG=329023

Review URL: https://codereview.chromium.org/140763008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342439, 304927
R=kbr@chromium.org, zmo@chromium.org

Review URL: https://codereview.chromium.org/157033009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250827 0039d316-1c4b-4281-b951-d872f2087c98

Part of the effort to remove src/chrome dependencies from src/{apps, extensions}

BUG=341690
TBR=tapted@chromium.org,stevenjb@chromium.org

Review URL: https://codereview.chromium.org/157813007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250826 0039d316-1c4b-4281-b951-d872f2087c98

(the embedded view is wider than the fixed size of the bubble)

BUG=334761

Review URL: https://codereview.chromium.org/137193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250825 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/160603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250824 0039d316-1c4b-4281-b951-d872f2087c98

We need to clear out the children of any nodes that are affected by the
crash, not the entire FrameTree.

BUG=338508
TEST=Killing an iframe process with --site-per-process shows a green rectangle.
R=ajwong@chromium.org, nasko@chromium.org

Review URL: https://codereview.chromium.org/156303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250823 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168518

Review URL: https://codereview.chromium.org/159853010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250822 0039d316-1c4b-4281-b951-d872f2087c98

By default, this trial is disabled.

BUG=309216

Review URL: https://codereview.chromium.org/151183006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250821 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332115

Review URL: https://codereview.chromium.org/156173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250820 0039d316-1c4b-4281-b951-d872f2087c98