- 30 Aug, 2018 40 commits
-
-
Jun Choi authored
Implement BleAdapterPowerManager that handles 1) Observing BluetoothAdapter for power state change and notifying FidoRequestHandlerBase::TransportAvailabilityObserver. 2) If BluetoothAdapter has been powered on programmatically, turning off bluetooth adapter power on destructor. 3) Exposing API to FidoRequestHandlerBase to power on bluetooth adapter. TBR: jam@chromium.org Bug: 877344 Change-Id: I3a99782186e232f1242937867c5091a4ee1ec338 Reviewed-on: https://chromium-review.googlesource.com/1195150 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587475}
-
Yi Su authored
Now that ImageFetchTabHelper supports both fetching image data by JavaScript and by downloading via image_fetcher::IOSImageDataFetcherWrapper, we can use that to improve ImageCopier. Bug: 163201 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8f3c1ad411f74f23b31948f851a1226e9bbe30a6 Reviewed-on: https://chromium-review.googlesource.com/1188581 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#587474}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9e90e7987de1..e70aff80976e git log 9e90e7987de1..e70aff80976e --date=short --no-merges --format='%ad %ae %s' 2018-08-30 thestig@chromium.org Stop using deprecated V8 APIs in CFXJSE_Context. 2018-08-29 tsepez@chromium.org Use pdfium::span<>/UnownedPtr in CFX_Font. 2018-08-29 thestig@chromium.org Stop using deprecated V8 APIs in CFXJSE_Class. 2018-08-29 wfh@chromium.org Change explicit suppression of warning 4267 to a config based suppression. 2018-08-29 thestig@chromium.org Stop using deprecated V8 APIs in CJS_Runtime. Created with: gclient setdep -r src/third_party/pdfium@e70aff80976e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:588506 TBR=dsinclair@chromium.org Change-Id: I222380ad175fc75988083d249fff38f9bc0cdf4a Reviewed-on: https://chromium-review.googlesource.com/1195877Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587473}
-
Theresa authored
BUG=876051 Change-Id: I4ffb79237e3a60abb4ffd4e63ee3f7f3cc353671 Reviewed-on: https://chromium-review.googlesource.com/1195435 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#587472}
-
Victor Costan authored
The net::DrainableIOBuffer constructors currently take in a net::IOBuffer base as a raw pointer, then assign it to a scoped_refptr<net::IOBuffer> member, thus taking a reference. This CL turns the raw pointer parameter into a scoped_refptr, and uses std::move() during the member assignment. So, the reference-increment operation is pushed from the constructors to the construction callsites. No new increments are introduced. The CL also modifies the DrainableIOBuffer construction sites, using std::move() where possible to remove reference increments. Bug: 479898 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I95cd0973d5e25c2565ddecfa0e06a3fc15e1f7b9 Reviewed-on: https://chromium-review.googlesource.com/1188955 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#587471}
-
Lei Zhang authored
Fix some nits as well. BUG=537099 Change-Id: Ie9e13059ca2171db19c1c0e5428bd86f4c8dcbe4 Reviewed-on: https://chromium-review.googlesource.com/1188635Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#587470}
-
Michael Giuffrida authored
This will allow identifying these extensions from //ash when recording Chrome and ARC++ app window usage for Demo Mode. Bug: 827380 Change-Id: I8eff3642c24ba6b1741499254711558643de4646 Reviewed-on: https://chromium-review.googlesource.com/1189168Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#587469}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I01caf114ded7b89aaa23bd9be7325a358c1eabe6 Reviewed-on: https://chromium-review.googlesource.com/1196266 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#587468}
-
Noel Gordon authored
When Drive is offline, files that are 'available offline' are rendered with 'online' CSS style. Verify that those files have the expected CSS 'online' style (opacity 1). Also add a new Drive 'online' test case to check that all files render with the CSS 'online' style (opacity 1). Test: browser_tests --gtest_filter="FileDisplay/FilesApp*" Bug: 878260 Change-Id: I2d97a414fc477acce0af877cf490944e4a087cfb Reviewed-on: https://chromium-review.googlesource.com/1195172Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#587467}
-
Kenichi Ishibashi authored
The renderer's default network loader can't handle non-network URLs such as chrome-extension://. This means that fetch() for extension resources from an extension service worker wouldn't work when we use the default network loader. To make such requests work, pass a URLLoaderFactoryBundle from browser in a similar manner to shared worker. Bug: 848628 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia356a668a75efec9de854828dadc69cea0294e09 Reviewed-on: https://chromium-review.googlesource.com/1187856Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#587466}
-
Lei Zhang authored
So if the input starts out as UTF8, just pass it in as is. base: :Value and subclasses will take UTF16 input and convert it to UTF8. Change-Id: Ia738e78f9b3197a68e94eb006465ee75797e3bee Reviewed-on: https://chromium-review.googlesource.com/1195941Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#587465}
-
David Staessens authored
A build rule for this test was not added when moving to gn build files, so this tests hasn't been running for quite some time. It's still functional, so this change will re-enable it. Changes made: * Fixed compilation issues caused by a function that was made private and a missing include.s. * Made this test part of the 'jpeg_decode_accelerator_unittest' target. * Fixed a warning by changing constexpr char* to constexpr const char*, as constexpr forces the pointer to be const rather then the contents. * Changed the testcase to first look into the local directly for testfiles, as this makes it a bit easier to run the tests standalone while developing. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8dc64f9596a4dcd393410983eab39cfd34bd3b5e Reviewed-on: https://chromium-review.googlesource.com/1116509Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#587464}
-
Vaclav Brozek authored
The _CheckUniquePtr presubmit check has the following false-positive: it flags auto p = std::unique_ptr<T, D>(new T(), D()); as needing a rewrite using std::make_unique. However, there seems to be no way to pass the second template argument to std::make_unique, so cases like this need to be exempt from the presubmit check. Note that the check still needs to capture cases with count the nesting of the angle brackets. Hence, this check cannot be captured by a regular expression and needs just a counting loop. std: :unique_ptr<T<U, V>>, so when looking for the comma, one has to Bug: 867823 Change-Id: Ie21067fa83aae17dd6701b0f69b902605c797e67 Reviewed-on: https://chromium-review.googlesource.com/1193945 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#587463}
-
Eric Aleshire authored
Adds automation_action_egtest.mm, which is responsible for unit testing individual Autofill automation actions. It does so by hosting a test web page (I reuse credit_card_upload_form_address_and_cc.html, which is already used for autofill), performing a minimal amount of automation actions, and using JS to verify result. I also add a little functionality to credit_card_upload_form_address_and_cc.html to make the waitFor test more substantial. I confirmed both tests pass before uploading the CL. so I will make one for this one in the morning Bug: None, but I said I would make an umbrella bug for the first CL, and didn't, Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I1ce3a185fc9b10ab3b8f352c8c22a092ae877eff Reviewed-on: https://chromium-review.googlesource.com/1195144 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#587462}
-
Matt Falkenhagen authored
It looks like ServiceWorkerURLJobWrapper can be destroyed while ServiceWorkerNavigationLoader is in the middle of a fetch event, probably because the outer NavigationURLLoaderImpl/ ServiceWorkerControlleeRequestHandler are destroyed/aborted. Bug: 878717 Change-Id: Ia1cd5f5e77ab860a5031729820620a2c91e71104 Reviewed-on: https://chromium-review.googlesource.com/1195180Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#587461}
-
Marc Treib authored
SyncAuthManager::GetActiveAccountInfo used to contain a DCHECK that its currently cached active account matches the desired one. Unfortunately, there are some edge cases where it doesn't match, e.g. if a different identity observer gets notified of a change before SyncAuthManager. Therefore this CL removes the invalid DCHECK. Bug: 871221 Change-Id: Ie458365416c5d63f33cebf5bfc9832f1cdec5a68 Reviewed-on: https://chromium-review.googlesource.com/1193827Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#587460}
-
Marc Treib authored
The feature itself was added in https://chromium-review.googlesource.com/c/chromium/src/+/1162174 Bug: 871221 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0cc3527eb25a2e015fa3e6ae458028680f069815 Reviewed-on: https://chromium-review.googlesource.com/1195507Reviewed-by:
-
Donna Wu authored
This CL eliminates PermissionProvider interface and merges permission checking to WebUsbServiceImpl. BUG=699790 Change-Id: Ic690ad807b582dde7c14c442b8973fc5da121bd1 Reviewed-on: https://chromium-review.googlesource.com/1181163Reviewed-by:
-
Dominic Farolino authored
This CL preserves the priorities of requests that go through a Service Worker's onfetch event and are fetch()ed from there. Before this CL, these priorities were lost and re-generated later in ResourceFetcher::ComputeLoadPriority with the priority we naturally assign fetch()es (kHigh). This meant that requests for things like render-blocking CSS were downgraded from kVeryHigh => kHigh, possibly causing loading regressions. After this CL, the priorities of these requests are preserved and communicated to the ResourceRequest for the corresponding fetch(). ResourceFetcher::ComputeLoadPriority is still entered, and takes the maximum of the following two priorities: - The one we would naturally generate (kHigh, due to fetch()) - The one _already on_ the ResourceRequest. This fixes priority regressions from kVeryHigh => kHigh, however what it does not do is stop desired low-priority requests from being upgraded to kHigh. For example, if a SW's onfetch event.request is for an image, with kLow priority, ResourceFetcher::ComputeLoadPriority will "upgrade" this request to kHigh. This is probably undesirable, and will need a follow-up CL. R=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org, yoav@yoav.ws Bug: 872776 Change-Id: Iaa6b5420b65bc6004b5b7a2d1f8d0eb5453df872 Reviewed-on: https://chromium-review.googlesource.com/1192353 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#587457}
-
Hajime Hoshi authored
This logic dates back 2009 https://codereview.chromium.org/460062. Now RenderThreadImpl::IdleHandler does just ReleaseFreeMemory, I think calling this handle more often is no longer required. Change-Id: Iee99f8f855d2686a53ae85f75ce08cae8e5188e1 Reviewed-on: https://chromium-review.googlesource.com/1193625Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Heng-Ruey Hsu authored
Camera app needs system property to know GCA migration is done or not. BUG=b:73056417 TEST=manually test to see connection is built Change-Id: Ie82a40f08a4fc61c789d6966a8688a33cc5550fe Reviewed-on: https://chromium-review.googlesource.com/1174146 Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#587455}
-
Raymes Khoury authored
This adds a test to PermissionManager to verify that subscribing to permission status changes for child frames works correctly with permission delegation enabled. Specifically child frames that are impacted by permission changes in parent frames should receive updates. Bug: 802945 Change-Id: Ic6ec9bfffe5b6c5f0935c6e857dd162af84a0a14 Reviewed-on: https://chromium-review.googlesource.com/1195252Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#587454}
-
Ramin Halavati authored
The following preferences are removed from the persistent storage list for incognito mode. - kAllowJavascriptAppleEvents - kAlternateErrorPagesEnabled - kCrashReportingEnabled - kConfirmToQuitEnabled - kDataSaverEnabled - kDnsPrefetchingHostReferralList - kDnsPrefetchingStartupList - kMdHistoryMenuPromoShown - kNewTabPageLocationOverride - kNetworkPredictionOptions - kNetworkQualities - kRecurrentSSLInterstitial - kRlzPingDelaySeconds - kSessionExitedCleanly - kSessionExitType - kShowMissingSdCardErrorAndroid - kSpeechRecognitionFilterProfanities - kSSLErrorOverrideAllowed - kURLsToRestoreOnStartup These preferences are either never changed from incognito mode, or the changed value is not supposed to be written to user profile. Bug: 861722 Change-Id: Iaf271281d29964a763db0c78f2cc34407bf4b681 Reviewed-on: https://chromium-review.googlesource.com/1194007 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#587453}
-
Yuta Kitamura authored
TBR=nednguyen@chromium.org Bug: 878995 Change-Id: I604ab51326ff718066c592d2de42ed4af82b2e4a No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1196302Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#587452}
-
Raymes Khoury authored
This change prevents extensions and enterprise settings from setting embedded exceptions for content setting types that don't support them. Namely, with permission delegation enabled, permission types don't support embedded patterns. In practice this only impacts the geolocation content setting when it is set through the chrome.contentSettings API. An additional scoping type is introduced to reflect content settings which can set embedded patterns and those which cannot. More details are included in the design doc: https://docs.google.com/document/d/1x5QejvpyQ71LPWhMLsaM1lWCfSsBsSQ8Dap9kJ6uLv0/edit#heading=h.bwzi3w3lx8nz Change-Id: I4384fd26d01862f477ba18fe7d87915ddae15446 Bug: 802945 Reviewed-on: https://chromium-review.googlesource.com/1173192 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#587451}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cb813c8803b2..d539d9382241 git log cb813c8803b2..d539d9382241 --date=short --no-merges --format='%ad %ae %s' 2018-08-30 benjhayden@chromium.org Add Material radio for V2SPA. Created with: gclient setdep -r src/third_party/catapult@d539d9382241 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia2651b14c1efe943b4cc8acd602cd450869d39e1 Reviewed-on: https://chromium-review.googlesource.com/1195919Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587450}
-
Istiaque Ahmed authored
ServiceWorkerTest* had race conditions around promises that set up workers to run tests. It was possible for those workers to start replying (postMessage) to extension background script before the script was ready to receive them. Fix this by running the promise a bit later in time, after background script is set up correctly. This CL fixes a known flakiness: ServiceWorkerTest.TabsCreate and enables the test. In addition to that, this CL also fixes similar potential race conditions, throughout extension service worker tests. Bug: 810397, 810227 Change-Id: I0ecbd0e915113ca12e37d33b5fae097ccfac76aa Reviewed-on: https://chromium-review.googlesource.com/967412 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
To be aligned with the server side configurations, this patch mechanically changes the trial group name. This should not make any actual behavior change, and affect nothing. Bug: 729954 Change-Id: Ia8657e849e3339756deda3c57e85cdab2f62bc99 Reviewed-on: https://chromium-review.googlesource.com/1195249Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#587448}
-
wutao authored
This patch implements the decoding service for streaming data. The underlining decoding method has been changed, therefore the decoded output are in interleaved data format, not as AudioBuffer. Bug: b/113131759, b/80315134 Test: manual. Change-Id: I5b382caa33a1bd60a8b262847b76498280c3ed90 Reviewed-on: https://chromium-review.googlesource.com/1192685Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#587447}
-
Mark Pearson authored
The current names are confusing and overlapping. Clarify the comments and revise the variable names appropriately. It's probably best to start this review by looking at components/search_engines/template_url.h All the changes stem from that. TBR=bauerb for mechanical change to chrome/browser/android/provider/chrome_browser_provider.cc Change-Id: I311ed56691f22402ff746f57471fd3efb729ecb8 Reviewed-on: https://chromium-review.googlesource.com/1191237Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#587446}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c6ec355c. With Chromium commits locally applied on WPT: b4c81942 "Upstream image_capture tests to WPT" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23612 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie0e49a26b2a7e8b3dce5a659dc85ac1a55beefe4 Reviewed-on: https://chromium-review.googlesource.com/1195735 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#587445}
-
Yue Li authored
Bug: b/79879673 Test: Local compile Change-Id: I9203ec274bfa369ecd78c3351cdaa270a3fec7a6 Reviewed-on: https://chromium-review.googlesource.com/1194575 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
-
Yuta Kitamura authored
I forgot to include this test in crrev.com/c/1195127. TBR=foolip@chromium.org Bug: 877104 Change-Id: Ic0195561d01ff5f9983f623ba2097e13f5a71734 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1195305Reviewed-by:
-
Hitoshi Yoshida authored
An IDL extended attribute `[Unforgeable]` is not applicable on interfaces, but we have it on Location interface. This CL removes it from interface definition and applies it on its members (operations and attributes) to follow Web IDL spec and HTML spec. Bug: 674593 Change-Id: I295d7c80a39304d7ec497c0492ca6061c153036a Reviewed-on: https://chromium-review.googlesource.com/1194528Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#587442}
-
Aga Wronska authored
Test: Run demo setup and wizard controller browser tests. Manually test that auto enrollment and device disabled screens show up. Change-Id: I91f7a02932463d84104edd37d102ce0931dce3b3 Reviewed-on: https://chromium-review.googlesource.com/1195733Reviewed-by:Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#587441}
-
Ella Ge authored
Bug: 737777 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia63a2a249c99c7c82e33f18720d7ae31fcd26536 Reviewed-on: https://chromium-review.googlesource.com/1195888 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587440}
-
Ilya Sherman authored
R=mpearson@chromium.org Bug: None Change-Id: Ibbb7378bb04f1239afa9dd307db596ab48b32323 Reviewed-on: https://chromium-review.googlesource.com/1196035 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Daniel Cheng authored
At least one caller of ClipboardUtil::GetFilenames() expects the output vector to be non-empty when the method returns true. Ensure that's always the case. Unfortunately, there's no repro case so this fix is based on wild conjecture... Bug: 878583 Change-Id: Idb97f34c804a8b3cb4a2d80a23bff862ebd168f0 Reviewed-on: https://chromium-review.googlesource.com/1195112Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#587438}
-
Matt Giuca authored
This reverts commit 3304d8fe. Reason for revert: Compile failure (see crbug.com/879034). Original change's description: > [Video Capture Service] Inject GPU dependencies when starting service via extension > > The video capture service requires GPU dependencies to be injected after startup > in order to enable accelerated MJPEG decoding. This CL adds this injection call > where the service is started from the media_perception_private extension. > > The injected dependencies use classes that used to live in > content/browser/renderer_host/media. To be able to reuse them for the > extension, this CL moves them to a location that is accessible to both > usage sites, i.e. to content/browser/gpu with a public interface in > content/public/browser. > > Bug: 877690 > Change-Id: If43ff7ff3f24a0aa17d441af5f5f605a894f374e > Reviewed-on: https://chromium-review.googlesource.com/1195657 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587377} TBR=jam@chromium.org,chfremer@chromium.org,lasoren@chromium.org Change-Id: If23d44ff678a7b4a1b42ce5aa176f7f314c033e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877690, 879034 Reviewed-on: https://chromium-review.googlesource.com/1195304Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#587437}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ia2ce9db8e89af7ba989acaa8ba49ed0b889915f9 Reviewed-on: https://chromium-review.googlesource.com/1196263Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#587436}
-
