- 17 Jun, 2018 11 commits
-
-
Dirk Pranke authored
This last set of tweaks fixes the swarming configs for a couple of builders. It looks like things should be back to working now. TBR=hinoka@chromium.org NOTRY=true BUG=853040 Change-Id: Id485754a30a8a22cef5e39e5ea601c78e23cd7d8 Reviewed-on: https://chromium-review.googlesource.com/1103781Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567912}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7675b369322e..0242b59c0aaf git log 7675b369322e..0242b59c0aaf --date=short --no-merges --format='%ad %ae %s' 2018-06-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@0242b59c0aaf The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Ic89101457e08ff607f3c9ab37210d664d51aee86 Reviewed-on: https://chromium-review.googlesource.com/1103797Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567911}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=alemate@chromium.org Change-Id: Idc4910a620ea1f7a5ebbe89b94668f9c570ea64b Reviewed-on: https://chromium-review.googlesource.com/1103769Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567910}
-
Aleks Totic authored
Reland of 1101826. Was reverted in 1102517 because of WebKit Win10 test failure. Cause of failure is that Win10 expectations were not there. This test has Win7 specific expectations, and no Win10 expectations. non-virtual version is skipped on Win10. Bug: 849751 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I57b74eab41848db28fa0b19b0e2f3fcfc210d8fa Reviewed-on: https://chromium-review.googlesource.com/1102889Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#567909}
-
Han Leon authored
To follow the spec, this CL lets ServiceWorkerRegistration#update() resolve to a registration object (actually the ServiceWorkerRegistration object itself) rather than undefined before. Entry on the feature dashboard: https://www.chromestatus.com/feature/5436747060084736 BUG=836217 Change-Id: I090d896e541e76143baa29d0b9d175a54e04ef2e Reviewed-on: https://chromium-review.googlesource.com/1100736Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#567908}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ia276782a03e233698c3cd82d8d0b03b447dc9ac1 Reviewed-on: https://chromium-review.googlesource.com/1103765Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567907}
-
Marc-Antoine Ruel authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/281c390193ec..9a518d097dca $ git log 281c39019..9a518d097 --date=short --no-merges --format='%ad %ae %s' 2018-06-16 maruel [swarming] Implement NamedCache.cleanup() 2018-06-16 maruel [client] Fix 3 issues for the cost of one CL 2018-06-15 maruel [client] Fix cache LRU coherency 2018-06-15 maruel [client] Fix Memory CAC to be LRU, internal cleanups 2018-06-14 maruel [client] cache the named cache size; stop keeping empty caches 2018-06-14 maruel [client] Update lru.py and test 2018-06-13 maruel [client] Refactor the caches to stop using context manager 2018-06-13 iannucci [swarming] Actually apply pool based TaskTemplates. Created with: roll-dep src/tools/swarming_client TBR=qyearsley@chromium.org Bug: 801046, 824832 Change-Id: Id2dd2bc2b0295d96726eb200f6e9a0cc8aea1eb7 Reviewed-on: https://chromium-review.googlesource.com/1103534Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#567906}
-
Chris Harrelson authored
For CPU traces of intersection-observer/deep-layers.html, this avoids > 4% of runtime. Bug: 831762 Change-Id: If7e3cf6b37b7e9e724856c2c2e0b0f7ec33739e1 Reviewed-on: https://chromium-review.googlesource.com/1102024 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#567905}
-
Dirk Pranke authored
Revert "Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element" This reverts commit a65d8a04. Reason for revert: I think this broken the layout tests on 32-bit Win10, see https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/36552 Original change's description: > Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element > > R=nektar@chromium.org,dmazzoni@chromium.org > > Bug: 844149 > Change-Id: I7e92097761057c8fb795582098f54daeb00ef204 > Reviewed-on: https://chromium-review.googlesource.com/1099434 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567899} TBR=dmazzoni@chromium.org,nektar@chromium.org,suproteem@chromium.org Change-Id: I0efca59b219cc9432d14e68f340c3dff12f4ef76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844149 Reviewed-on: https://chromium-review.googlesource.com/1103502Reviewed-by:
-
Dirk Pranke authored
This removes three more entries I missed in my last two go-rounds. TBR=hinoka@chromium.org NOTRY=true BUG=853040 Change-Id: I89e2397d8f0ce8b307281b0eccfae826611a8676 Reviewed-on: https://chromium-review.googlesource.com/1103715 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Dirk Pranke authored
I missed these in the previous cleanup, and I apparently also missed one entry for one of the compile-only trybots that I removed. TBR=hinoka@chromium.org BUG=853040 NOTRY=true Change-Id: I10b5f968fab5c4f065df921eabb68ceec73feb94 Reviewed-on: https://chromium-review.googlesource.com/1103713Reviewed-by:
-
- 16 Jun, 2018 29 commits
-
-
David Bokan authored
This patch implements basic functionality for the visual viewport in blink-gen-property-trees mode. This patch does several related things: - Create PaintPropertyNodes in the VisualViewport during Blink's PrePaint walk. - Ensure PaintArtifactCompositor propagates these new nodes to CC - Setup and add viewport layers to PaintArtifactCompositor's foreign layers so they get correctly hooked into the layer tree in CC Bug: 840017 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idcba9cdf90a9cde7534e5bff4ff37fe55bdc16e7 Reviewed-on: https://chromium-review.googlesource.com/1083012 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Dirk Pranke authored
The following builders are redundant with builders on the chromium.mac and chromium.win waterfalls, and so we can remove them instead of migrating them to LUCI: - linux_trusty_blink_compile_dbg - linux_trusty_blink_compile_rel - linux_trusty_blink_dbg - win7_blink_compile_dbg - win7_blink_compile_rel - win7_blink_dbg - WebKit Linux Trusty - WebKit Linux Trusty (dbg) - WebKit Mac Builder (dbg) - WebKit Mac10.10 - WebKit Mac10.11 - WebKit Mac10.11 (dbg) - WebKit Mac10.12 - WebKit Win Builder (dbg) - WebKit Win7 - WebKit Win7 (dbg) - WebKit Win x64 Builder - WebKit Win x64 Builder (dbg) They were all either already just placeholder bots that were basically not doing anything interesting or trybots that basically weren't needed. BUG=853040 NOTRY=true Change-Id: Ifca05f1a570d660bb573cfffe124f2128a84623c Reviewed-on: https://chromium-review.googlesource.com/1096548 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#567900}
-
Suproteem Sarkar authored
Added relational propertyvalues to GetPropertyValue, which allows UI Automation to access relations from an automation element R=nektar@chromium.org,dmazzoni@chromium.org Bug: 844149 Change-Id: I7e92097761057c8fb795582098f54daeb00ef204 Reviewed-on: https://chromium-review.googlesource.com/1099434 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#567899}
-
Dirk Pranke authored
This reverts commit 083b6f26. Reason for revert: I think this is causing crashes on Mac 10.13 (dbg). See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/3362. Original change's description: > Roll SwiftShader 88482c3..700a1a6 > > https://swiftshader.googlesource.com/SwiftShader.git/+log/88482c3..700a1a6 > > BUG=chromium:845700, chromium:852641, chromium:851707 > > TBR=kbr@chromium.org > > TEST=bots > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel > > Change-Id: Ic36ddc1988cd83970a4a53b52a1ce1b229d17137 > Reviewed-on: https://chromium-review.googlesource.com/1102886 > Commit-Queue: Nicolas Capens <capn@chromium.org> > Reviewed-by: Alexis Hétu <sugoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567894} TBR=sugoi@chromium.org,capn@chromium.org Change-Id: I96e96329f4de1581ca11fca443fa943e58ce8f4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845700, chromium:852641, chromium:851707 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1103398Reviewed-by:
-
Chris Harrelson authored
Now that RLS exists, the LayoutView has a different ClipPaintPropertyNode than every other node. Therefore PLC::CalculateRects will need to calculate a clip across this node difference for every PaintLayer. We don't need this clip at all, since the IOv1 parts of IO already handle such clipping. For CPU traces of intersection-observer/deep-layers.html, this avoids about 4% of runtime. Bug: 831762 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2faa6761edc15854d35cd4a18a466383b6c9d5d8 Reviewed-on: https://chromium-review.googlesource.com/1101970Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ad910ae2. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 1db32e09 "OffscreenCanvas Text rendering tests" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19736 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes TBR=robertma No-Export: true Change-Id: I0591819530aa6198f37f4244cded0f714bf9cee4 Reviewed-on: https://chromium-review.googlesource.com/1103702 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#567896}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3a51f2a80a38..ae92f3c98fbe git log 3a51f2a80a38..ae92f3c98fbe --date=short --no-merges --format='%ad %ae %s' 2018-06-16 chrome-bot@chromium.org Update config settings by config-updater. 2018-06-16 dgarrett@google.com chromeos_config: Require all non-slaves to be important. 2018-06-15 lannm@chromium.org Annotate ScheduleSlavesStage with scheduled build links 2018-06-15 dgarrett@google.com generic_stages: Stop tagging skipped stages. 2018-06-15 dgarrett@google.com chromeos_config: Switch full builders to manifest_version. 2018-06-15 manojgupta@chromium.org Revert "chrome-sdk: Remove absolute path from simple chrome build using goma" 2018-06-15 xixuan@chromium.org SkylabHWTest: Swtich to use nyan_blaze release image to test. 2018-06-15 vapier@chromium.org cros lint: ignore initial UTF-8 BOM in JSON files 2018-06-15 ayatane@chromium.org chromeos-infra-go: Disable tests 2018-06-15 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@ae92f3c98fbe The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:852600,chromium:852916,chromium:851183,chromium:824548,chromium:846610,chromium:845314,chromium:None,chromium:852633 TBR=chrome-os-gardeners@chromium.org Change-Id: Id646fa70fc50cd3fd10506b67812fb6782bfdf36 Reviewed-on: https://chromium-review.googlesource.com/1103501Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567895}
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/88482c3..700a1a6 BUG=chromium:845700, chromium:852641, chromium:851707 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic36ddc1988cd83970a4a53b52a1ce1b229d17137 Reviewed-on: https://chromium-review.googlesource.com/1102886 Commit-Queue: Nicolas Capens <capn@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567894}
-
Boris Sazonov authored
This CL replaces getMarginStart/setMarginStart and getMarginEnd/setMarginEnd from ApiCompatibilityUtils with their equivalents from MarginLayoutParamsCompat. Bug: 852891 Change-Id: Ibb1e357a054b339c411a793ce64e85c70298e813 Reviewed-on: https://chromium-review.googlesource.com/1102462Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#567893}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d683d7ced42d..79d42dfb1174 git log d683d7ced42d..79d42dfb1174 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 iannucci@chromium.org Third whitespace change to test builder. 2018-06-15 iannucci@chromium.org More testing whitespace. 2018-06-15 iannucci@chromium.org Whitespace change to test new builder. Created with: gclient setdep -r src/third_party/depot_tools@79d42dfb1174 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:790434,chromium:790434,chromium:790434 TBR=agable@chromium.org Change-Id: I6d781e278eb7a31efdf9072b14959b83adddd9b9 Reviewed-on: https://chromium-review.googlesource.com/1103500Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567892}
-
Cheng-Yu Lee authored
LogMemory() calls memory::OomMemoryDetails::Log(), which is an async call and may take a long time (only 60% returns < 1s, 10% returns > 5s). When we're running out of memory, we need to discard tab faster. BUG=850545 Change-Id: Ia652b2a80f968b0e437904bb6bc2c7c131c1958d Reviewed-on: https://chromium-review.googlesource.com/1097038Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Cheng-Yu Lee <cylee@chromium.org> Cr-Commit-Position: refs/heads/master@{#567891}
-
Iker Jamardo authored
This reverts commit 91a0deb0. Reason for revert: Added conditional checks for strings. Original change's description: > Revert "Check if ARCore is installed or needs update." > > This reverts commit 703de90c. > > Reason for revert: lint errors (http://crbug.com/852189) > > Original change's description: > > Check if ARCore is installed or needs update. > > > > When requesting a session and after the camera permission is confirmed > > to have been granted, check if ARCore is installed and if the version > > used in Chromium is compatible with it. If ARCore is not installed > > or an update is required, a prompt will be shown. > > > > Bug: 838954 > > Change-Id: I35ae39041e7958743bba9cc1c71f5af817bf4240 > > Reviewed-on: https://chromium-review.googlesource.com/1074494 > > Reviewed-by: Theresa <twellington@chromium.org> > > Reviewed-by: agrieve <agrieve@chromium.org> > > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > > Reviewed-by: Peter Kasting <pkasting@chromium.org> > > Reviewed-by: Evan Stade <estade@chromium.org> > > Reviewed-by: Klaus Weidner <klausw@chromium.org> > > Commit-Queue: Iker Jamardo <ijamardo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#566589} > > TBR=ddorwin@chromium.org,vollick@chromium.org,pkasting@chromium.org,yfriedman@chromium.org,bshe@chromium.org,mthiesse@chromium.org,estade@chromium.org,twellington@chromium.org,agrieve@chromium.org,klausw@chromium.org,billorr@chromium.org,lincolnfrog@chromium.org,ijamardo@chromium.org > > Change-Id: I1f88a1de68d4929a842a4c7bf95aa90a7f48bcba > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 838954 > Bug: 852189 > Reviewed-on: https://chromium-review.googlesource.com/1098335 > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Nate Fischer <ntfschr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566635} Bug: 838954, 852189 Change-Id: I33fd3d06d749e3f522e3eb4403462112f67295f3 Reviewed-on: https://chromium-review.googlesource.com/1100487Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Iker Jamardo <ijamardo@chromium.org> Cr-Commit-Position: refs/heads/master@{#567890}
-
Devlin Cronin authored
With runtime host permissions, the webRequest API only delivers events for the requests that an extension has access to. As the user grants the extension access (either through the activeTab-like mechanism or through allowing the extension to always run a site), the extension should be able to run on that page. However, the webRequest API traditionally requires access to the URL that is being requested. This means that if the user allows the extension to always run on example.com, but example.com includes a script from chromium.org, that script request will not be visible to the extension. This is a pretty significant breakage for any extension using webRequest with activeTab or runtime host permissions. Instead, relax the restriction so that the extension has access to the request if it a) would normally have access, but it was withheld (via runtime host permissions) and b) it has access to the initiator of the request. This will allow the extension to intercept a request made by example.com to chromium.org. Note that this won't apply to requests made by cross-origin subframes, since the initiator won't be the same as the top-level frame's origin. Bug: 851722 Change-Id: Ibd4dab7e69672782cae2c63f5d4f7d156cd05e0b Reviewed-on: https://chromium-review.googlesource.com/1103003 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#567889}
-
Tomasz Śniatowski authored
https://chromium-review.googlesource.com/959446 broke the ability to reliably override mojo_media_services or mojo_media_host with gn args. Fix by calculating the default values before declare_args in helper variables, having args overrides apply, and asserting the constraints on defaults only. Fixes gn gen with args such as target_os="android" mojo_media_services=["cdm"] which would fail with a "Replacing nonempty list" gn error. Change-Id: Ia6aeaedfb4c40ba681e9c1500545ddd55cbdb0f1 Reviewed-on: https://chromium-review.googlesource.com/1092731 Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#567888}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6ae5d74e8671..7675b369322e git log 6ae5d74e8671..7675b369322e --date=short --no-merges --format='%ad %ae %s' 2018-06-15 halcanary@google.com SkPDF: Annotations should be indirect objects 2018-06-15 bungeman@google.com Work around signed-unsigned comparison warning. 2018-06-15 fmalita@chromium.org [skjson] Detect end-of-input for unbalanced strings 2018-06-15 egdaniel@google.com Add include/config to vulkan memory allocator build. 2018-06-15 bungeman@google.com Work around signed-unsigned comparison warning. 2018-06-15 bungeman@google.com Remove string.h from SkTypes.h 2018-06-15 brianosman@google.com Include sRGB -> Linear in the cached "from sRGB" xform 2018-06-15 bungeman@google.com Work around signed-unsigned comparison warning. 2018-06-15 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 06a2262078b2..50cf2be0758b (3 commits) 2018-06-15 bungeman@google.com Work around signed-unsigned comparison warning. Created with: gclient setdep -r src/third_party/skia@7675b369322e The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I26b81e67115fd19c49e4fdb86d56273f285d6008 Reviewed-on: https://chromium-review.googlesource.com/1103498Reviewed-by:
-
Ned Nguyen authored
Forgot to remove this story in https://chromium-review.googlesource.com/c/chromium/src/+/1101922 TBR=kouhei@chromium.org Change-Id: I72b38dcbb165b29e446b75ba02351d5a1afcab69 Reviewed-on: https://chromium-review.googlesource.com/1103698Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#567886}
-
Joel Einbinder authored
The behavior of `contain: layout` changed, and now it seems to prevent scrollbars from appearing. See https://crbug.com/843320 A follow up patch will fix this for old frontends. Bug: 851622 Change-Id: I91534d8b9f42d37766147ff31ce941916c8ed713 Reviewed-on: https://chromium-review.googlesource.com/1101404Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#567885}
-
Peter Collingbourne authored
The NDK include path is implied by the --sysroot flag, which we're already passing everywhere. Change-Id: I1fefe343e680e899723e05fcd22c2229d8a06f38 Reviewed-on: https://chromium-review.googlesource.com/1103585 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#567884}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=stevenjb@chromium.org Change-Id: I0707f7b2a65a28f94b3010f96c8957ff95f99e9b Reviewed-on: https://chromium-review.googlesource.com/1103532Reviewed-by:
-
Morten Stenshorne authored
Floats and out-of-flow objects need to be true layout siblings of the inlines, or rendering will be wrong. This means that such objects should never be siblings of anonymous blocks, but rather inside them. This already works correctly for initial layout tree building, and also for many DOM manipulations. However, code was missing to satisfy this requirement if we removed a regular block that was a sibling of an anonymous block and either a float or out-of-flow positioned object. This even caused a crash triggered by ruby code, which ended up mixing inline and block children within the same container. That is not allowed. This happened in the MoveAllChildrenIncludingFloatsTo() call inside LayoutRubyBase::MoveBlockChildren(). Added a DCHECK to MoveAllChildrenIncludingFloatsTo() (which could fail prior to this fix); When moving children from one container to another, either both or none of the containers must have inline children. Bug: 852640 Change-Id: I51d3de12c73ddd07d6b4c1aa55221b4f92359ca7 Reviewed-on: https://chromium-review.googlesource.com/1102690Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#567882}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/31767de5cf0a..f3ce003c2baa git log 31767de5cf0a..f3ce003c2baa --date=short --no-merges --format='%ad %ae %s' 2018-06-15 benjhayden@chromium.org Translate between test paths and descriptors. 2018-06-15 benjhayden@chromium.org Support timestamps with microseconds. Created with: gclient setdep -r src/third_party/catapult@f3ce003c2baa The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9acc766b5c015a9d319744e8969e85ee92d97aad Reviewed-on: https://chromium-review.googlesource.com/1103497Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567881}
-
Kevin Marshall authored
This functionality will be used by the ContextProvider service to bind an arbitrary, client-supplied directory handle to the "/data" directory of the child Context processes. * Adds a helper function for extracting file handles from File objects. * Adds unit tests. * Migrates some uses of ScopedZxHandle to zx::handle. Bug: 850743, 852541 Change-Id: Iada1775485745124822e32b9ac81aefaff6b9059 Reviewed-on: https://chromium-review.googlesource.com/1091803 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Matt Menke authored
The old code hooked up things to the URLRequestContext that hadn't been ported over to work with the NetworkService yet, when the NetworkService was enabled. This CL just does the minimum setup that's needed to not crash. It also makes requests made with the in-process URLRequestContext fail when the network service is enabled. These changes will help identify code that still depends on the legacy path, and allow for some cleanup of URLRequestContextBuilderMojo and NetworkContext. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I4c3f40e6dc3c235844846bff7d1d43d0b1c986d0 Bug: 825242 Reviewed-on: https://chromium-review.googlesource.com/1096075 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#567879}
-
Malay Keshav authored
This patch performs multiple tasks: - Modify the protocol that generates a ManagedDisplayInfo to use zoom factor instead of ui scale. When display zoom feature is disabled, it reverts back to the old string format. - Add a DCHECK in computing the effective Ui scale to ensure that it is 1 when display zoom is enabled. - Update all tests that fail due to this assertion. This is done mostly by creating a new test class with the display zoom feature disabled. OTOH, the tests that we want to keep in display zoom mode are modified to fit the assertion. We want to make sure that both ui scale and display zoom works for a few milestones before we completely deprecate and remove ui scale. Bug: 823922 Change-Id: I9bab4f6cb0884242d5f9427ba004f4c677835b64 Component: Managed Display Info, ui scale, display zoom Reviewed-on: https://chromium-review.googlesource.com/1099476Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#567878}
-
Robert Sesek authored
The renderers need to talk to the CVMS server (OpenCL compiler), which then outputs codesigned blobs that can be loaded in to the process. This is required for drawing the form controls. In addition, another Metal bundle location (in /Library) is permitted. Bug: 850021, 847518 Change-Id: I67106972baf5fc55fccd8f7deff3f47cbea076b5 Reviewed-on: https://chromium-review.googlesource.com/1103127Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#567877}
-
Jared Saul authored
For Milestone 4 of the Partial Data Project, Chrome should explicitly request that the user confirms their cardholder name (prepopulated with the name from their Google Account) when name is missing and the user does not have a Google Payments account. This CL is actually going to be extremely similar to the original CVC fix flow, which was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1034103. Feel free to cross-reference these CLs, as most everything I took out in that CL is simply getting put back in this one, except this time it's name instead of CVC. Surprise! Bug: 848955 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I08e94c1a16b7b1da403ea5a8f26d1e2d423c210e Reviewed-on: https://chromium-review.googlesource.com/1083880 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#567876}
-
Joel Einbinder authored
Bug: 835492 Change-Id: I172ab5075523f86eca85b4013dc0b77a82650dad Reviewed-on: https://chromium-review.googlesource.com/1103543Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#567875}
-
Krzysztof Olczyk authored
Promise for MediaCapabilities::decodingInfo() is resolved by blink::WebMediaCapabilitiesQueryCallbacks which is passed to WebMediaCapabilitiesClientImpl::DecodingInfo in //media/blink, which, in some cases, means to resolve it in the callback of an async mojo call. However, if the connections is lost meanwhile, neither OnSuccess nor OnError is called and, in the result, the promise resolver remains in pending state. This patch makes sure the OnError is called when mojo connection gets dropped. Bug: 847211 Change-Id: I018792c56a3d3074b042e4318d9a8b85b3c16360 Reviewed-on: https://chromium-review.googlesource.com/1075308Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#567874}
-
Ken Rockot authored
Suppresses log spam about "native service" failures when the service in question is content_renderer. This is because, unlike for any other service in the system, hitting the native service launcher codepath for content_renderer is simply an innocuous side effect of some raciness between browser features and renderer termination. Bug: None Change-Id: I8f73c7ecbe167c160e9df0f3aac3214063997d39 Reviewed-on: https://chromium-review.googlesource.com/1103155Reviewed-by:
-
