GitLab

Apps or extensions with the identity.email permission will be able to
query for the email addresses of accounts signed into a Chrome profile.

BUG=368343

Review URL: https://codereview.chromium.org/328013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276891 0039d316-1c4b-4281-b951-d872f2087c98

Now the same export+encrypt / decrypt+import codepath is used as for other wrapping algorithms.

The new code is less efficient (creates a temporary raw key), however simplifies things, and allows wrapping to be done on non-raw keys (however because of size constraints is likely to fail).

BUG=373544,245025

Review URL: https://codereview.chromium.org/335463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276890 0039d316-1c4b-4281-b951-d872f2087c98

This avoids errors from Clang about a conflicting typedef for
uintptr_t, which should really be unsigned int instead of unsigned
long.  We already had a local patch to suppress MSVC's warning here.
Rather than trying to get the right definition, just include stdint.h,
which has been available since VS2010.

R=thakis@chromium.org
TBR=brettw@chromium.org
BUG=82385

Review URL: https://codereview.chromium.org/224883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276887 0039d316-1c4b-4281-b951-d872f2087c98

This function will be componentized, and hence cannot reference
g_browser_process.

BUG=373203
TBR=thakis

Review URL: https://codereview.chromium.org/327793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276886 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE

Review URL: https://codereview.chromium.org/323093007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365189

Review URL: https://codereview.chromium.org/332553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276883 0039d316-1c4b-4281-b951-d872f2087c98

On Android, the browser compositor lies to CC about the
device_scale_factor (always setting it to 1), because it places its
layers in physical pixel space.  Because of that, the delegated device
scale inversion added in https://codereview.chromium.org/311253004 does
the wrong thing.  Rather than cancelling the inversion with other
transforms, the simplest fix is to lie about the frame_data
device_scale_factor as well.

BUG=383572,383436,384134
NOTRY=true

Review URL: https://codereview.chromium.org/336433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276882 0039d316-1c4b-4281-b951-d872f2087c98

Tell `powermetrics` to print a summary instead of telling it to sample and summing ourselves.

Aim is to try to get more accurate measurements.

BUG=None

Review URL: https://codereview.chromium.org/330543008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=nome
TEST=none
NOTRY=true
R=ananta@chromium.org

Review URL: https://codereview.chromium.org/335463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276880 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Use the updated AMD switchable info collection code. (https://codereview.chromium.org/332843003/)

Reason for revert:
The patch appears to have broken windows perf bot:

http://build.chromium.org/p/chromium.perf/builders/Win%20Builder/builds/69732

Original issue's description:
> Use the updated AMD switchable info collection code.
> 
> BUG=376562
> TEST=
> R=kbr@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276865

TBR=kbr@chromium.org,zmo@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=376562

Review URL: https://codereview.chromium.org/333683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276879 0039d316-1c4b-4281-b951-d872f2087c98

FLAG_CREATE_AWLAYS doesn't make sense with FLAG_APPEND.

BUG=383997

Review URL: https://codereview.chromium.org/330083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276878 0039d316-1c4b-4281-b951-d872f2087c98

When calculating draw properties, we attempt to skip subtrees whenever
we can, but we missed a corner case: even though we don't necessarily
draw a layer with a wheel or touch handler, it will participate in hit
testing and must therefore have up-to-date transforms, targets, etc.
In the same way that we've added logic to prevent skipping subtrees
containing layers with copy requests, this CL prevents skipping subtrees
with handlers.

R=danakj@chromium.org
BUG=377738

Review URL: https://codereview.chromium.org/335633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276877 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383310

Review URL: https://codereview.chromium.org/334633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276876 0039d316-1c4b-4281-b951-d872f2087c98

  A bubble should disappear when we right mouse click on a blank
  space. Add event monitor for NSRightMouseDownMask, and change
  not to use performSelector, for sometimes when  rightmouse  down
  happens, a menu comes out. This menu  might be a Modal Dialogue Box.
  So we can't perform the windowDidResignKey until the menu is  closed.

  BUG=378186
  TEST="--gtest_filter=BaseBubbleControllerTest.*"
  R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/300113009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276875 0039d316-1c4b-4281-b951-d872f2087c98

This includes a new URL path /_/contextualsearch and a /search parameter specifying the contextual search version, if any.
BUG=379196

Review URL: https://codereview.chromium.org/308053009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276874 0039d316-1c4b-4281-b951-d872f2087c98

The check for CanProcessEventsWithinSubtree() needs
to be made on |this| before the loop (along with
HitTestRect()) instead of inside the loop on the
children. Otherwise it would be possible to return
a view for which CanProcessEventsWithinSubtree()
returns false.

BUG=382873, 378530
TEST=Added coverage in ViewTest.CanProcessEventsWithinSubtree

Review URL: https://codereview.chromium.org/327843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276873 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/330053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276872 0039d316-1c4b-4281-b951-d872f2087c98

BUG=276723

Review URL: https://codereview.chromium.org/317993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276871 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342983
R=ben@chromium.org

Review URL: https://codereview.chromium.org/247903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276870 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367677

Review URL: https://codereview.chromium.org/270203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276869 0039d316-1c4b-4281-b951-d872f2087c98

There's a rare crash in ChromeLauncherController that looks
like a user is switching into Ash with no profile and a
read-only profile directory. Add a CHECK to figure out how
common this problem is.

BUG=383019
TEST=none

Review URL: https://codereview.chromium.org/336603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276868 0039d316-1c4b-4281-b951-d872f2087c98

Currently a URLRequestJobFactory is optional, as the global
URLRequestJobManager passes jobs on to the URLRequestFilter and
global http/https/ws/wss factories.  In order to be able to
eliminate the global URLRequestJobManager object, first have to
give all contexts their own URLRequestJobFactory.

BUG=81979
TBR=ajwong@chromium.org (Who actually signed off on this, but Rietveld ignored his email).

Review URL: https://codereview.chromium.org/311393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276867 0039d316-1c4b-4281-b951-d872f2087c98

Also remove the option -w to only wipe without provisioning. This was temporary
functionality to recover from INSUFFICIENT_STORAGE on device error. With the
default wiping, this should be unnecessary. For bots that skip wiping, we can
still manually fix by manually running without --skip-wipe.

BUG=383106
TBR=craigdh@chromium.org

Review URL: https://codereview.chromium.org/334503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276866 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376562
TEST=
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/332843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276865 0039d316-1c4b-4281-b951-d872f2087c98

Hit testing is done directly on the layer tree, it doesn't use the
render surface layer list, but it does require draw properties. So,
remove EnsureRenderSurfaceLayerList and have the FindLayer* public
methods on LayerTreeImpl just do UpdateDrawProperties() if it is needed.

Since we update draw properties there, we only need to update them in
PrepareToDraw when they are dirty as well.

R=enne, vollick@chromium.org

Review URL: https://codereview.chromium.org/332433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276864 0039d316-1c4b-4281-b951-d872f2087c98

The color needs to come from the menu's own native theme.

BUG=347832

Review URL: https://codereview.chromium.org/245863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276862 0039d316-1c4b-4281-b951-d872f2087c98

content_area_in_dpi send to browser process should cover entire page. This fixed shifting of content for system dialog printing.

BUG=379961
NOTRY=true

Review URL: https://codereview.chromium.org/327393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276861 0039d316-1c4b-4281-b951-d872f2087c98

This is to get ready to split ServiceProvider into Shell and Application. It makes the existing Application no longer subclass internal::ServiceConnectorBase::Owner. Instead it puts that functionality in the new class internal::ServiceRegistry and Application uses that by composition.

The validation in this cl is meant to be consistent with what's currently in the tree. I'll redo the cl that adds the ability to add a service with a specific validator after the split is done.

BUG=

Review URL: https://codereview.chromium.org/337533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276859 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add tests for session cache and false start behavior. (https://codereview.chromium.org/301283004/)

Reason for revert:
This patch may have broken http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/24391, but we're not confident. The failure is in libjingle_unittests, e.g. ChromeAsyncSocketTest.DoubleSSLConnect. Sorry for the inconvenience. 

Original issue's description:
> Add tests for session cache and false start behavior.
> 
> False start should not disable the session cache, but if we never process the
> server Finished message, the session cannot be resumed.
> 
> BUG=none
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276815

TBR=davidben@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/332523008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276857 0039d316-1c4b-4281-b951-d872f2087c98

This can be used to construct nested CFRunLoops that are restricted to
the MessageLoop tasks.

BUG=314190

Review URL: https://codereview.chromium.org/333473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276856 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380229
TEST=as in bug

Review URL: https://codereview.chromium.org/329793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276855 0039d316-1c4b-4281-b951-d872f2087c98

R=rsesek@chromium.org
BUG=378916

Review URL: https://codereview.chromium.org/327853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276854 0039d316-1c4b-4281-b951-d872f2087c98

r232828 removed the touch device check in the delegate execute handler.
It should be removed from the "You're almost done" dialog and the
process singleton as well.

BUG=314818,374360

Review URL: https://codereview.chromium.org/329393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276853 0039d316-1c4b-4281-b951-d872f2087c98

Committed https://src.chromium.org/viewvc/chrome?view=rev&revision=276728.
Broke gn build.
Reverted: https://codereview.chromium.org/330613003

Ensure the screenPosition of touches is never truncated to an integer.

Check if the unified gesture detector is enabled before disabling
the inclusive slop region.

BUG=381174
TEST=RenderWidgetHostViewAuraTest.TouchEventPositionsArentRounded

TBR=sadrul@chromium.org

Review URL: https://codereview.chromium.org/334753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276852 0039d316-1c4b-4281-b951-d872f2087c98

The change to combine NetworkState and FavoriteState broke
FirstNetworkByType for VPN since it doesn't appear with the "visible"
networks. We don't use that method a lot, so the easy fix is to remove
the early exit and continue instead of break.

BUG=375955
TBR=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/332713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276851 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276850 0039d316-1c4b-4281-b951-d872f2087c98

$ git log ae8085b09..aea50658a --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-06-12 maruel Remove --working-dir, it's not supported anymore.
2014-06-04 maruel Update swarming.py query for the new Bot attributes.
2014-06-03 maruel Update swarming_load_test_bot.py for new server code.
2014-05-29 maruel Add load test regexp to new key format.
2014-05-15 vadimsh Make 'swarming.py collect' return exit code 1 on task failure.
2014-05-14 vadimsh Collect output files only when child processes terminate (Windows only).
2014-05-14 vadimsh Correctly handle negative process exit codes.
2014-05-12 vadimsh Manage test sharding on a client side.
2014-05-08 maruel Make swarming_load_test_client.py more versatile.
2014-05-07 vadimsh Fix directory_to_metadata on Windows.
2014-05-07 maruel Fix swarming_load_test_client.py after ae8085b09e.
2014-05-07 maruel Update examples.

R=maruel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/335463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276849 0039d316-1c4b-4281-b951-d872f2087c98

The PasswordAutofillAgent::SendPasswordForms method is called
both when HTML forms are just parsed, and also when they are rendered.
The former is the moment when the password manager first hears about
forms, and notes their presence not only for autofill, but also
for matching against credentials submitted later.

However, I missed the second use-case (matching submitted credentials)
when I put logging there for the internals page, and so currently
the progress is only logged when the forms are rendered.

This CL should change this: logs are now also sent when the forms have just been parsed.

I already saw issues (e.g., http://crbug.com/367768) where such additional logging would have sped up the investigation.

There are no tests, because we don't which logs are generated when.

BUG=347927

Review URL: https://codereview.chromium.org/323423006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276848 0039d316-1c4b-4281-b951-d872f2087c98

R=enne
BUG=342848

Review URL: https://codereview.chromium.org/338453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276847 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Mac] Use a native MessagePump instead of a MessagePumpDefault (https://codereview.chromium.org/331513002/)

Reason for revert:
Broke Jingle unit tests on the bots.

Original issue's description:
> [Mac] Use a native MessagePump instead of a MessagePumpDefault
> 
> Many message loops in Chrome are backed by MessagePumpDefault which uses a WaitableEvent object to sleep, this is ultimately implemented as a pthread condition variable on POSIX.
> 
> In order to support timer coalescing in MessageLoops we need to sleep using a primitive which supports timer coalescing at the OS level (support for timer coalescing goes down into the kernel on Android/Linux/OSX/Win).  The current change achieves this and should provide a way to gauge the effect of timer coalescing.
> 
> An alternate approach to this patch would be to implement MessagePumpDefault using a primitive which supports timer coalescing.
> 
> Local performance tests didn't uncover any regressions from this change.
> 
> BUG=356804
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276808

TBR=darin@chromium.org,mark@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=356804

Review URL: https://codereview.chromium.org/336603005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276846 0039d316-1c4b-4281-b951-d872f2087c98