- 01 Jun, 2017 40 commits
-
-
Daniel Cheng authored
- It's not necessary to passthe LocalFrame argument and convert it back and forth from a WebLocalFrame. These functions only apply to the main frame, so just check that the frame is a main frame before calling in. - ResizeAfterLayout() was passing the size parameter by value. Change-Id: I68c76503679ee90be7cd7ee8a9566f9ba43e09ac Reviewed-on: https://chromium-review.googlesource.com/517300 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#476260}
-
ossu authored
BUG=chromium:714119 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2902823005 Cr-Commit-Position: refs/heads/master@{#476259}
-
fhorschig authored
This CL adds an HomePageClient for Android that is only set if the kChromeHome feature is enabled because the normal NTP has a working home button. If either kChromeHome or kPinHomePageAsTileFeature is not enabled, the MostVisited tiles will not contain the home tile. Special case: The home tile can be removed as every tile and will be blacklisted then. By explicitly enabling (or reenabling) the Homepage, the blacklisting will be undone and the tile will reappear as first tile. Removing the home tile does not disable the Homepage setting (because this setting also controls the start-up page and the home tile is not visually linked to the home page .... besides having the same URL). BUG=703994 Review-Url: https://codereview.chromium.org/2897293002 Cr-Commit-Position: refs/heads/master@{#476258}
-
ossu authored
BUG=chromium:714119 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2900043002 Cr-Commit-Position: refs/heads/master@{#476257}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/60074560..35b77a36 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2919763002 Cr-Commit-Position: refs/heads/master@{#476256}
-
Nicholas Verne authored
Replaced by static methods in WebAXObject. Bug: 71532 Change-Id: I30468a08cd0383f84461915bb087a5e0a198f1bb Reviewed-on: https://chromium-review.googlesource.com/520904 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#476255}
-
Sylvain Defresne authored
If multiple call to -saveSession:directory:immediately: are made in quick succession, the SessionIOS objects are created to be immediately destroyed when the scheduled save is cancelled. Change the SessionServiceIOS API to instead take a block creating the SessionIOS instance and invoke it on the main thread, before requesting that the data be serialised to the disk (by sending a task on IO thread). BUG=725539 Change-Id: I82b42d2b46baf03a7280e60185973c635dc164a2 Reviewed-on: https://chromium-review.googlesource.com/513929 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#476254}
-
Nicholas Verne authored
A WebAXObject static function does the job now. Bug: 71532 Change-Id: I4ca95eeee1bb9481fbf3713f759d9366f83de750 Reviewed-on: https://chromium-review.googlesource.com/520363 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#476253}
-
vasilii authored
BUG=616627 Review-Url: https://codereview.chromium.org/2913193002 Cr-Commit-Position: refs/heads/master@{#476252}
-
Sylvain Defresne authored
The state of "Always translate" should only be saved if the user validate the change by using the "Done" button, so use a variable to store the interaction and update the model when user taps on the "Done" button. BUG=724030 Change-Id: I421b274d3f067e569923731f7359348ab1948063 Reviewed-on: https://chromium-review.googlesource.com/519149Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#476251}
-
Kinuko Yasuda authored
Platform::LoadResource is confusing as it sounds like it's for resource loading, while it is actually for getting bundled resource data. This CL renames LoadResource to GetDataResource to unconfuse these. BUG=n/a Change-Id: I1c479c147f5aba7e9dbd919bb11f95d4c069c7f6 Reviewed-on: https://chromium-review.googlesource.com/517589Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#476250}
-
Philip Jägenstedt authored
Using wpt-import in Chromium b28a6524. Reason for manual import: want my fullscreen/ tests ASAP. BUG=571531,728522,728527 TBR=qyearsley@chromium.org NOEXPORT=true Change-Id: I106230f7927f4a23a61d93ec3543cb900ea7ba24 Reviewed-on: https://chromium-review.googlesource.com/520384Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#476249}
-
rsorokin authored
AuthPolicyCredentialsManager KeyedService service is created for every Active Directory user profile. It calls GetUserStatus at the start of service, each hour and on every network connection. Tests are coming... BUG=662400 Review-Url: https://codereview.chromium.org/2860443002 Cr-Commit-Position: refs/heads/master@{#476248}
-
Juan A. Navarro Perez authored
Story gets stuck while trying to scroll. TBR=nednguyen@google.com,ulan@chromium.org Bug: 728528 Change-Id: I19fbbab253bd0dce5a2c48a4a739b6b8474e01df Reviewed-on: https://chromium-review.googlesource.com/520765 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#476247}
-
Hiroki Nakagawa authored
This is a preparation CL for module loading for threaded worklets that is going to be implemented on the off-main-thread-fetch feature. This change provides WorkerFetchContext that is necessary for the off-main-thread-fetch to worklet global scopes. The context is created on the main thread before starting a worklet global scope and passed to worklet's thread as WorkerThreadStartupData. Note that this CL does not change the current script loading mechanism for worklets yet. Bug: 727194 Change-Id: I695bf8f64a583ac845a2d0a13076fda0667d8604 Reviewed-on: https://chromium-review.googlesource.com/519022Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#476246}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/908a6304..60074560 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2916563004 Cr-Commit-Position: refs/heads/master@{#476245}
-
nednguyen authored
TBR=perezju@chromium.org, ulan@chromium.org BUG=728464 Review-Url: https://codereview.chromium.org/2919753002 Cr-Commit-Position: refs/heads/master@{#476244}
-
Raphael Kubo da Costa authored
Follow what's already done in bindings/core/v8 and add a "bindings_modules_impl" target to bindings/modules/v8 to aggregate all the .cpp/.h files generated by the other targets in the same BUILD.gn (the ones processing the modules IDL files). By declaring the target in the same GN file, we can use get_target_outputs() to obtain some output names, which then allows us to get rid of |bindings_modules_generated_interface_files| as well as |bindings_modules_generated_partial_interface_files|. This cleanup is also being done in preparation for getting rid of the hardcoded list of generated dictionary impl files we currently maintain in GN, as Source/modules:modules would not be able to retrieve any similar list of generated files that it needs. Bug: 725996 Change-Id: Ia53de40ef394af197351f218050af6d8a10f2c3a Reviewed-on: https://chromium-review.googlesource.com/517955Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#476243}
-
aboxhall authored
Check whether a text node may be about to be redistributed in ShouldUpdateLayoutByReattaching(). Prevents use-after-free when SetTextWithOffset is called with dirty distribution. BUG=726716 Review-Url: https://codereview.chromium.org/2913133002 Cr-Commit-Position: refs/heads/master@{#476242}
-
erikchen authored
Bytes were being converted to kilobytes without a division. BUG=707022 Review-Url: https://codereview.chromium.org/2914903002 Cr-Commit-Position: refs/heads/master@{#476241}
-
Kent Tamura authored
Firefox and Safari already shipped it. This CL fixes 256 failing tests in external/wpt/. Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/0P4_WvNr1xY Bug: 724906 Change-Id: Ic55ead1509afd3e631ed0251fa312bd5b4a7001f Reviewed-on: https://chromium-review.googlesource.com/521002Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#476240}
-
tnagel authored
Use PolicyData::management_mode to determine whether the device has a local owner and only fall back to DM token in case management_mode is unset. That way, the correct determination is guaranteed for both cloud and Active Directory management. (Currently, the code is not broken because AD policy doesn't include a user name, but that might change in the future.) Also update the PolicyData::management_mode documentation to include Active Directory. BUG=722799 Review-Url: https://codereview.chromium.org/2902183002 Cr-Commit-Position: refs/heads/master@{#476239}
-
sashab authored
BUG=712963 Review-Url: https://codereview.chromium.org/2919593004 Cr-Commit-Position: refs/heads/master@{#476238}
-
Dominic Cooney authored
Bug: 710184 Change-Id: I3d1d506888657c5bd60a114609247c5f92c0edd7 Reviewed-on: https://chromium-review.googlesource.com/520443 Commit-Queue: Dominic Cooney <dominicc@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#476237}
-
dullweber authored
Replace the raw ptr returned by ContentSettingsPattern::CreateBuilder with a unique_ptr. Remove legacy_validate parameter and function because it isn't used anywhere. BUG= TBR=msarda@chromium.org,finnur@chromium.org,stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2909273003 Cr-Commit-Position: refs/heads/master@{#476236}
-
yoshiki authored
Defer deleting view after calling OnAllNotificationsCleared(). Views are deleted before OnAllNotificationsCleared(), but it causes crash. This CL moves the deletion as a temporary solution. We need to refactor the code around more in near feature. BUG=725299 TEST=none Review-Url: https://codereview.chromium.org/2913993002 Cr-Commit-Position: refs/heads/master@{#476235}
-
yoichio authored
This CL introduces CalcSelectionPaintRange() and minimize Commit(). BUG=708453 Review-Url: https://codereview.chromium.org/2916803003 Cr-Commit-Position: refs/heads/master@{#476234}
-
Nicholas Verne authored
The users of WebNode::AccessiblityObject should all be outside of core/ Bug: 71532 Change-Id: I5ff7e8bb28657408394a529ac8fe77e400d26472 Reviewed-on: https://chromium-review.googlesource.com/520542 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#476233}
-
Peter E Conn authored
BUG=728086 Change-Id: Ib15f1714abb30b029b6e89facb51343fbfaa96e3 Reviewed-on: https://chromium-review.googlesource.com/519247Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#476232}
-
yukishiino authored
static attributes must not be "keep_alive_gc". keep_alive_gc is a mechanism to associate a returned object with the receiver object, however static attributes must not use the receiver object. BUG= Review-Url: https://codereview.chromium.org/2913403003 Cr-Commit-Position: refs/heads/master@{#476231}
-
yuzus authored
This CL aims to drop the context menu feature entirely. <menuitem> tag can be no longer used and <menu type='context'>, <menu label='...'> are no longer supported. BUG=87553 Review-Url: https://codereview.chromium.org/2905763003 Cr-Commit-Position: refs/heads/master@{#476230}
-
yoichio authored
This CL changes the operator returning appropriate string. This is homework from: [Make SelectionState enum class] https://codereview.chromium.org/2916493002/ BUG= Review-Url: https://codereview.chromium.org/2919713002 Cr-Commit-Position: refs/heads/master@{#476229}
-
tetsui authored
Several background classes needs file metadata to perform their tasks. However, Metadata cache was only available to foreground classes. Also, lifetime of foreground metadata cache is tied to windows, so we have to maintain separate Least Recently Used cache in the background. As having separate cache for several background classes is inefficient, we are going to have global cache class that is shared among them. This has huge performance impact on slow storage devices such as MTP conencted ones. TEST=manually tested. BUG=716309,712121 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2856533003 Cr-Commit-Position: refs/heads/master@{#476228}
-
Georg Neis authored
See https://github.com/w3c/web-platform-tests/issues/5239 for an explanation. R=domenic@chromium.org, kouhei@chromium.org Bug: Change-Id: I7312e4d774eea1083d2283d8ccbad361bd974d0b Reviewed-on: https://chromium-review.googlesource.com/519242Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#476227}
-
ukai authored
BUG=728482 Review-Url: https://codereview.chromium.org/2913353003 Cr-Commit-Position: refs/heads/master@{#476226}
-
alexclarke authored
It feels strange that if a task is due to run at time t=1.0 and we gave 1s of virtual time budget that that task doesn't run. This patch changes that so the task will run by using a fence instead of disabling the queue. BUG=696001 Review-Url: https://codereview.chromium.org/2909293002 Cr-Commit-Position: refs/heads/master@{#476225}
-
Xianzhu Wang authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I124bb0161d23a65028b55c8fdf6a2a54be1793c8 Reviewed-on: https://chromium-review.googlesource.com/517281 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#476224}
-
Vitalii Iarko authored
Previously, |getIconResId| returned 36dp |text| icon, when it was supposed to return |file| icon. This CL fixes this. Bug:726611 Change-Id: I8763d313185ae6bdc2854a776f831b4900e7310b Reviewed-on: https://chromium-review.googlesource.com/517062Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Theresa Wellington <twellington@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#476223}
-
igorcov authored
The devices that have FRE enabled shouldn't be allowed to powerwash. This CL makes the keyboard shortcut for powerwash available only if the device doesn't have FRE enabled. BUG=724332 TEST=Manually tested for FRE enabled and FRE disabled functionality. Review-Url: https://codereview.chromium.org/2898003002 Cr-Commit-Position: refs/heads/master@{#476222}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/de3ade508f3f..861d4a174136 $ git log de3ade508..861d4a174 --date=short --no-merges --format='%ad %ae %s' 2017-05-31 benjhayden Add HistogramSet.createHistogram() syntactic sugar. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ifb7e85f46b6d3e3b28934be63bff20f90ed1a12b Reviewed-on: https://chromium-review.googlesource.com/520847 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#476221}
-