GitLab

Somehow totalDuration is still becoming negative, this change puts
a final check for negative values before updating the animation.

BUG=622540

Review-Url: https://codereview.chromium.org/2111203003
Cr-Commit-Position: refs/heads/master@{#403214}

Now that the PDF plug-in supports native accessibility, we can remove
the accessibility JSON interface and the ChromeVox code that calls it.

BUG=54724
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2103043003
Cr-Commit-Position: refs/heads/master@{#403213}

Apparently this is what the server sends back. It's a nicer format than
the timestamp struct, but a bit unexpected.

BUG=621090

Review-Url: https://codereview.chromium.org/2110393004
Cr-Commit-Position: refs/heads/master@{#403212}

Revert of Fix MultibufferDataSource::GetSize (patchset #1 id:1 of https://codereview.chromium.org/2110853006/ )

Reason for revert:
I believe this CL is causing flakyness in the video related tests on the GPU FYI waterfall.

Examples:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28NVIDIA%29/builds/25925
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/48492
https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release/builds/5019

Seeing this in the output log:
[27562:1287:0630/083352:WARNING:webmediaplayer_impl.cc(335)] Using MultibufferDataSource
[27562:34423:0630/083352:ERROR:ffmpeg_demuxer.cc(1510)] OnReadFrameDone result=-541478725 IsMaxMemoryUsageReached=0
[27562:1287:0630/083352:WARNING:webmediaplayer_impl.cc(335)] Using MultibufferDataSource
[27562:1287:0630/083352:FATAL:resource_multibuffer_data_provider.cc(75)] Check failed: byte_pos() < url_data_->length() (32768 vs. 10292) http://127.0.0.1:53903/resources/red-green.theora.ogv

Original issue's description:
> Fix MultibufferDataSource::GetSize
>
> When file loading is finished ResourceMultiBufferDataProvider count
> DataBuffer queue size twice, so GetSize returned incorrect value.
>
> BUG=
>
> Committed: https://crrev.com/bbaba3c8053a39f6d11d78a6e4770b37a9639067
> Cr-Commit-Position: refs/heads/master@{#403123}

TBR=hubbe@chromium.org,kostya-k@yandex-team.ru
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624853

Review-Url: https://codereview.chromium.org/2115483003
Cr-Commit-Position: refs/heads/master@{#403211}

When --touch-devices flag is used on X, we use TouchEvent(native_event)
constructor, which uses ui::GetTouchForceFromXEvent() to initialize the force
value. On Ozone we don't do this, and force gets initialized to NaN.

This CL makes Ozone on X consistent with X in that it uses GetTouchForceFromXEvent(xev)
to initialize the force value in the constructed TouchEvent.

BUG=NONE

Review-Url: https://codereview.chromium.org/2103823003
Cr-Commit-Position: refs/heads/master@{#403210}

Allows users to set the overridden network conditions of the session to preset values including 2G, 3G, 4G, Wifi, and Offline.

BUG=chromedriver:984

Review-Url: https://codereview.chromium.org/2065733002
Cr-Commit-Position: refs/heads/master@{#403209}

Empty usernames aren't supported by the partners. Therefore, every time we return it or show it in the account chooser we worsen the UX.

BUG=400674

Review-Url: https://codereview.chromium.org/2110993003
Cr-Commit-Position: refs/heads/master@{#403208}

This information will easily allow the server to use different
experiments in different channels and different versions.

BUG=622374

Review-Url: https://codereview.chromium.org/2103223002
Cr-Commit-Position: refs/heads/master@{#403207}

This new ChromeIdentityInteractionManager reauthenticate method is more
flexible and allow the implementation to do some internal cleanup based
on a unique identifier (the email can change).

BUG=623928

Review-Url: https://codereview.chromium.org/2110183006
Cr-Commit-Position: refs/heads/master@{#403206}

Revert of Eliminate the ChannelMojo channel for renderers (patchset #4 id:60001 of https://codereview.chromium.org/2109043002/ )

Reason for revert:
http://crbug.com/624556

Original issue's description:
> Eliminate the ChannelMojo channel for renderers, instead obtain Bootstrap interface from child connection.
>
> R=rockot@chromium.org
> http://crbug.com/623396
>
> BUG=
>
> Committed: https://crrev.com/9e883c385ccc47607a9341d618678b35195cc8fe
> Cr-Commit-Position: refs/heads/master@{#402812}

TBR=ben@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2111673006
Cr-Commit-Position: refs/heads/master@{#403205}

This page seems to be working again locally.

BUG=618708

Review-Url: https://codereview.chromium.org/2108313003
Cr-Commit-Position: refs/heads/master@{#403204}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ead31d8dd552..a9f8ed16a47c

$ git log ead31d8dd..a9f8ed16a --date=short --no-merges --format='%ad %ae %s'

BUG=621113

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2103053007
Cr-Commit-Position: refs/heads/master@{#403203}

BUG=504084

Review-Url: https://codereview.chromium.org/2104203003
Cr-Commit-Position: refs/heads/master@{#403202}

BUG=622374

Review-Url: https://codereview.chromium.org/2104143002
Cr-Commit-Position: refs/heads/master@{#403201}

media-fragment tests are not in a state to be upstreamed
to wpt. So removing the unneeded TODO's for now.

BUG=588956

Review-Url: https://codereview.chromium.org/2103003002
Cr-Commit-Position: refs/heads/master@{#403200}

Revert of [tools/perf] Add system_health_smoke_test that run all system health stories (patchset #8 id:160001 of https://codereview.chromium.org/2110653002/ )

Reason for revert:
This change is failing on Android Tests bots.

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35105/steps/telemetry_perf_unittests

Original issue's description:
> [tools/perf] Add system_health_smoke_test that run all system health stories
>
> BUG=615382
>
> Committed: https://crrev.com/8095da730db4f644cc7691acca63f32b85536bce
> Cr-Commit-Position: refs/heads/master@{#403163}

TBR=petrcermak@chromium.org,perezju@chromium.org,nednguyen@chromium.org,nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615382

Review-Url: https://codereview.chromium.org/2117533002
Cr-Commit-Position: refs/heads/master@{#403199}

Add ios_image_decoder_impl.* and pass an instance to the NTPSnippetsService when it is instantiated on iOS.

BUG=609127

Review-Url: https://codereview.chromium.org/2111573002
Cr-Commit-Position: refs/heads/master@{#403198}

This method does not exist API < 18 and it is simpler to just
trust the |require_software_codec| value which is the inverse
of |allow_autodetection_|.

BUG=613238,622927,624482
TEST=none

Review-Url: https://codereview.chromium.org/2114473002
Cr-Commit-Position: refs/heads/master@{#403197}

Needed because default notification close button is part of views
hierarchy and covered by the notification surface. This CL adds
a floating version of close button that sits on top of the notification
surface.

BUG=b/25816173
TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2093563007
Cr-Commit-Position: refs/heads/master@{#403196}

Show dialogs for syncing to managed accounts earlier in the signin flow, moving them forward to be alongside the dialog for importing/wiping sync data.

BUG=595411, 612165

Review-Url: https://codereview.chromium.org/2014833002
Cr-Commit-Position: refs/heads/master@{#403195}

Swaps Chrome/Chromium where appropriate.
Screenshot in bug.

BUG=622174
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2106253002
Cr-Commit-Position: refs/heads/master@{#403194}

This catches issues with compositing solid color quads.
Test is initially expected to fail until reference images are generated.

R=kbr@chromium.org
BUG=624256
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2112603003
Cr-Commit-Position: refs/heads/master@{#403193}

https://chromium.googlesource.com/angle/angle.git/+log/be5a8a4..3c75419

BUG=chromium:617848,598924,chromium:617627,chromium:534814,483282,620937

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2119463002
Cr-Commit-Position: refs/heads/master@{#403192}

This CL changes the return types of both properties to FrozenArray<>,
amends Notification.actions to also freeze the individual
NotificationAction objects contained therein, and enables the properties
by default.

In addition, [SameObject] semantics have been added to the two
properties, which now mean that they will continue to return the same
value, making the equality operator work as expected.

Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/0mBO8Q5FhTo/2OagzgagBgAJ

BUG=547716, 442132

Review-Url: https://codereview.chromium.org/1974033003
Cr-Commit-Position: refs/heads/master@{#403191}

1. Moved and resized the avatar icon as well as icon badges
1. Moved avatar name up to be on the right of the profile icon
2. Moved username and "Your accounts" link up and below the avatar name
3. Other dimension and padding changes

See design doc here ("Reflow the items in the first section"): https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.6xesoh23gozz

See redlines here:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu#

See screenshots here (marked with "3.*"):
https://drive.google.com/corp/drive/folders/0B7Fvv7JszRyGY2NrSEhheHptdG8

Downstream CL: https://codereview.chromium.org/2052473003/

BUG=615893

Review-Url: https://codereview.chromium.org/2023093002
Cr-Commit-Position: refs/heads/master@{#403190}

BUG=621512

Review-Url: https://codereview.chromium.org/2106793002
Cr-Commit-Position: refs/heads/master@{#403189}

Instead of observing through the WebstoreAPI, observe directly in the TabHelper.
This is a great deal less code, more direct, and also fixes a lifetime issue
with the TabHelper being deleted before the inline installation completes.

BUG=613949

Review-Url: https://codereview.chromium.org/2103663002
Cr-Commit-Position: refs/heads/master@{#403188}

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2102123002
Cr-Commit-Position: refs/heads/master@{#403187}

If DidStopLoading is called on WebContentsObserver immeditely after navigation
is requested, then window_ in could be released via StopObservingIfDone as soon
as GoForward/GoBack is called

OerscrollNavigationOverlay::OnOverscrollCompleted requests navigaions by calling
GoForward/GoBack on the controller. If these navigations immeditely trigger
DidStopLoading, main_window->SetTransform would segfault.
Protect against this case by setting up the transforms and window positioning
before doing navigation.

BUG=623620

Review-Url: https://codereview.chromium.org/2102283002
Cr-Commit-Position: refs/heads/master@{#403186}

AcceptConnection and OnInitialize are racing. Only pause the interface
registry if OnInitialize is not invoked.

TEST=arc video playback well
BUG=620845

Review-Url: https://codereview.chromium.org/2112493003
Cr-Commit-Position: refs/heads/master@{#403185}

https://helpx.adobe.com/security/products/flash-player/apsb16-18.html

BUG=412078
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
TBR=jschuh@chromium.org

Review-Url: https://codereview.chromium.org/2113703002
Cr-Commit-Position: refs/heads/master@{#403184}

Reduce the depth used by PerformanceTests/Parser/
query-selector-deep.html and query-selector-id-deep.html

These performance tests have been disabled since June 2013 as they were
observed to crash "on 6 of the last 9 runs"

BUG=245702

Review-Url: https://codereview.chromium.org/1880383002
Cr-Commit-Position: refs/heads/master@{#403183}

This patch keeps track of a script tag's type and language attributes,
and gates preloading if they are invalid. This aligns the preload scanner's
policy with the ScriptLoader's policy.

BUG=623109

Review-Url: https://codereview.chromium.org/2099853002
Cr-Commit-Position: refs/heads/master@{#403182}

In addition to removing the failure expectations associated with http://crbug.com/608457, this CL also sorts expectation lines in the file, and changes expectations based on local runs on my workstation:

Added pass expectations:
 crbug.com/508725 imported/wpt/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script.html [ Pass ]
 crbug.com/508725 imported/wpt/mediacapture-streams/GUM-trivial-constraint.https.html [ Pass ]
crbug.com/508725 imported/wpt/pointerevents/pointerevent_constructor.html [ Pass ]

Removed failure expectations:
 crbug.com/508734 imported/wpt/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-fixed.html [ Timeout ]

BUG=608457

Review-Url: https://codereview.chromium.org/2113463003
Cr-Commit-Position: refs/heads/master@{#403181}

There's a crash caused by asynchronous audio focus events.
MediaSessionDelegate may receive audio focus change signals after
MediaSession::~MediaSession is called. This CL adds checks to see if the
native MediaSession is destroyed before calling it's methods.

BUG=624208

Review-Url: https://codereview.chromium.org/2111163002
Cr-Commit-Position: refs/heads/master@{#403180}

It is a standalone .so library meant to be LD_PRELOAD-ed
using awkward tricks into the Android zygote to get heap dumps.
Never worked too well in Chrome as it intercepted only malloc
calls, without being able to hook allocations in PartitionAlloc
or Blink GC.
This is subsumed by the work of crbug.com/602701 which
integrates native heap profiling with chrome://tracing and
supports all the major chrome allocators.
For future heap profiling adventures use
//components/tracing/docs/heap_profiler.md

This CL also removes //third_party/bsdtrees that was introduced
as a dependency to libheap_profiler. Nothing else seems to
depend on it.

BUG=382489

Review-Url: https://codereview.chromium.org/2105873005
Cr-Commit-Position: refs/heads/master@{#403179}

Cleaning up video-controls-visibility* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2118453002
Cr-Commit-Position: refs/heads/master@{#403178}

ScatteredStreamWriter is the core class that will be used to
serialize proto messages in flight into the trace buffer chunks.
This class handles writes and spreads them over non-contiguous
memory chunks without causing extra copies.

BUG=608719

Review-Url: https://codereview.chromium.org/2047273002
Cr-Commit-Position: refs/heads/master@{#403177}

Design doc: https://docs.google.com/document/d/1qdlgaC277SnnmQv7hoNFTGp-OCvokEc4mA2NmAzOyBU/edit?usp=sharing

BUG=550967
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1991273003
Cr-Commit-Position: refs/heads/master@{#403176}

Jim is no longer working on Chromium (much?), and does not typically respond to
metrics code reviews. Avoid delaying contributors by removing him from the list
of OWNERS.

BUG=none
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2114483002
Cr-Commit-Position: refs/heads/master@{#403175}