- 12 May, 2017 8 commits
-
-
pdyson authored
BUG=705331 Review-Url: https://codereview.chromium.org/2867683002 Cr-Commit-Position: refs/heads/master@{#471137}
-
thakis authored
The code guarded by it hasn't been compiling for a while, and this code was added over 5 years ago. It probably isn't used any longer. BUG=675877 Review-Url: https://codereview.chromium.org/2869953003 Cr-Commit-Position: refs/heads/master@{#471136}
-
yuweih authored
This CL implements the viewport fling animation for iOS client. This re-impements Android client's FlingAnimationJob and impements a simplified version of Android's Scroller in C++. BUG=714193 Review-Url: https://codereview.chromium.org/2869723007 Cr-Commit-Position: refs/heads/master@{#471135}
-
glebl authored
To correctly paint a float from LayoutNG we need to know the BFC offset of the container to which we are attaching this float. It's used to calculate {@code left_offset}, {@code top_offset}. In most situations {@code (left|top)_offset} equals to float's logical offset except the cases where a float needs to be re-attached to a non-zero height parent. Example: <body> <p style="height: 60px">Example</p> <div id="zero-height-div"><float></div> Here the float's logical offset is 0 relative to its #zero-height-div parent. Because of the "zero height" div this float is re-attached to the 1st non-empty parent => body. To paint this float correctly we provide the modified {@code (top|left)_offset} which is relative to the float's new parent. I.e. for our example {@code top_offset} == #zero-height-div's BFC offset - body's BFC offset + float's logical offset BUG=635619 TESTS=Fixes 8 tests in CSS2/floats-clear, 1 in CSS2/floats, 1 in CSS2/positioning, 2 in fast/block/margin-collapse, 2 in fast/block/float. Total: 14 Review-Url: https://codereview.chromium.org/2850893003 Cr-Commit-Position: refs/heads/master@{#471134} -
binji authored
See https://html.spec.whatwg.org/multipage/infrastructure.html#safe-passing-of-structured-data And the web platform test here: https://github.com/w3c/web-platform-tests/blob/master/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-history.html BUG=chromium:718193 Review-Url: https://codereview.chromium.org/2857303003 Cr-Commit-Position: refs/heads/master@{#471133}
-
Mike Bjorge authored
Change-Id: Idfb49bbd33b9813ef84a3f24904d57e53462f6d8 Reviewed-on: https://chromium-review.googlesource.com/499013Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Mike Bjorge <mbjorge@chromium.org> Cr-Commit-Position: refs/heads/master@{#471132}
-
xing.xu authored
A Surface may be submitted with many CompositorFrames, Surface and Frame are not the same concept. Here use CompositorFrameSinkSupport::EvictFrame to destroy a Surface is misleading, so rename to CompositorFrameSinkSupport::EvictCurrentSurface. BUG=691649 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2872883002 Cr-Commit-Position: refs/heads/master@{#471131}
-
juncai authored
This CL changes the url string to "chrome://settings/#Bluetooth". BUG=720248 Review-Url: https://codereview.chromium.org/2873963007 Cr-Commit-Position: refs/heads/master@{#471130}
-
- 11 May, 2017 32 commits
-
-
jam authored
Add new constructors for mojo::DataPipe and content::ResourceRequestCompletionStatus to do this. BUG=717714 Review-Url: https://codereview.chromium.org/2875143002 Cr-Commit-Position: refs/heads/master@{#471129}
-
mcasas authored
This CL wires the GetPhotoCapabibilities() method for Mac and fills in the only available capability, the photo resolution, which is equal to the "live" capture resolution. This CL also fills in the Linux/CrOs capture reoslution as the only supported PhotoCapabilities.{height,width}. BUG=721478 Review-Url: https://codereview.chromium.org/2868393004 Cr-Commit-Position: refs/heads/master@{#471128} -
alemate authored
We should not SwitchToLastActiveUser() when there is only one user logged in. This covers restart on signin, when last_active_user may be outdated. BUG=714250 Review-Url: https://codereview.chromium.org/2872133009 Cr-Commit-Position: refs/heads/master@{#471127}
-
Mike Baxley authored
Create OKButton shared matcher, since this button is likely used other places. Bug: Change-Id: Ib45265f6be2ebc2d59f3e912bc4d6e6fb628771d Reviewed-on: https://chromium-review.googlesource.com/503493Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#471126}
-
Noel Gordon authored
Add a render process mojo interface exposed to the browser for receiving process-wide spellcheck control and updates from the browser process. Fold the enable IPC into the Initialize() mojo API (the enable IPC was only ever called right after an Init IPC) by adding an |enable| argument. Mojo does not support set<> so use vector<> instead on the mojo APIs. Use a binding set on the server-side to automate mojo request disconnect and clean-up. Update the browser test to use mojo instead of IPC in the mock renderer and add a test for a custom dictionary update. Change the InitSpellcheck helper: spellcheck->InitForRenderer() isn't needed (creating a SpellcheckService does that for us). Bug:714480 Change-Id: I5365c42fc10c7766054c5b80fb366ceaa4d59159 Reviewed-on: https://chromium-review.googlesource.com/487341Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#471125}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/59e58189c55d..1ff6ffc1f618 $ git log 59e58189c..1ff6ffc1f --date=short --no-merges --format='%ad %ae %s' 2017-05-11 simonhatch Dashboard - Post a task in migrate_test_names to add tests from patterns. 2017-05-11 simonhatch Dashboard - Remove unused args from getCheckedOrAllAlerts Created with: roll-dep src/third_party/catapult BUG=713335 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I0860054268acd2d93b9f65a3c4367b1ec18817f8 Reviewed-on: https://chromium-review.googlesource.com/503611 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#471124}
-
Bo Liu authored
Since native/ has been entirely moved into browser/, the target should move as well. Cleaned up a few unneeded DEPS as well. BUG=716604 Change-Id: I77fb632279b96318e5aa6d4eefe70046df41188f Reviewed-on: https://chromium-review.googlesource.com/503647Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#471123}
-
hzl authored
Create a link to flakiness dashboard for each test case, so that engineers will see the flakiness level for that test case. BUG=717631 Review-Url: https://codereview.chromium.org/2873723002 Cr-Commit-Position: refs/heads/master@{#471122}
-
wfh authored
This was mistakenly removed in crrev.com/2621363002. BUG=721562 Review-Url: https://codereview.chromium.org/2879683004 Cr-Commit-Position: refs/heads/master@{#471121}
-
ananta authored
We have a new class AppCacheNetworkServiceHandler which gets created on the IO thread. This class provides functionality for checking if a request can be serviced out of the AppCache. I was looking at AppCacheRequestHandler for this as well. However that class is tied deeply to the underlying job which gets a touch complicated for lifetime managemnt if the request is not really being served out the cache. Added some comments for that class to see if we could remove it once the pieces begin to align. This class implements the AppCacheStorage::Delegate interface which tells us if a response is available for a URL. Currently we just trace if a response is found and call the StartURLRequest callback in both cases. Going forward the plan is to create a URLLoaderFactory for AppCache and pass it back to the callback. Optionally we could create the loader right there as well. Thanks to jam for pointing that out. The other changes are to have the original ResourceRequest pointer in the AppCacheURLLoaderRequest class instead of a copy. We ensure that ownership is transferred correctly. BUG=715632 Review-Url: https://codereview.chromium.org/2874663004 Cr-Commit-Position: refs/heads/master@{#471120}
-
Bret Sepulveda authored
BUG=668251 R=timloh@chromium.org Review-Url: https://codereview.chromium.org/2866933002 . Cr-Commit-Position: refs/heads/master@{#471119}
-
nednguyen authored
BUG=721549 TBR=perezju@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2876963002 Cr-Commit-Position: refs/heads/master@{#471118}
-
mdjones authored
The toolbar scenelayer will draw even if the user is in the tab switcher with no tabs. This null check prevents requesting a default theme color from a nonexistent tab. BUG=720213 Review-Url: https://codereview.chromium.org/2874323002 Cr-Commit-Position: refs/heads/master@{#471117}
-
dongseong.hwang authored
This CL makes |gpu_proecess_host| select the right callback by GMB id, not brute-force FIFO. It becomes more stable code for the future change. e.g. reordering IPC for priotization BUG=475633, 629521 Review-Url: https://codereview.chromium.org/2878573002 Cr-Commit-Position: refs/heads/master@{#471116}
-
horo authored
This method name was renamed by https://codereview.chromium.org/2125523003. BUG=624711 Review-Url: https://codereview.chromium.org/2878663002 Cr-Commit-Position: refs/heads/master@{#471115}
-
emaxx authored
The test app allows to perform the following manual testing when installed through the DeviceLoginScreenAppInstallList device policy into the Chrome OS sign-in profile: * Click "Add user" and type the username on the test domain; * The certificate selection dialog pops out, containing the certificate provided by the test app; * After selecting the certificate, the PIN dialog appears; * Wrongly typed PIN results in keeping the dialog displayed, but now with an additional error message; * Correctly typed PIN hides the PIN dialog, and moves the login process forward; * Afterwards, the login process is expected to fail, as the test app doesn't implement the real signing operation and responds with a garbage data. BUG=626343 TEST=manual - install the app through the device policy via YAPS and follow the test steps described above TBR=achuith@ Review-Url: https://codereview.chromium.org/2873973004 Cr-Commit-Position: refs/heads/master@{#471114} -
hiroshige authored
Follow-up of a regression bug caused by [1]: Previously, ImageResourceContent::Create() returned a content with kCached, while after [1] it returns a content with kNotStarted. This causes behavior changes if Create() is called with non-null argument. [1] https://codereview.chromium.org/2746343002/ This CL fixes this issue by renaming Create() with a non-null argument to ImageResourceContent::CreateLoaded() that sets the status to kCached. The callsites of CreateLoaded() were affected by the bug, i.e. a callsite in HTMLImageElement and others in tests. Create() with the nullptr argument is renamed to CreateNotStarted(), which is only called from ImageResource and is not affected by the bug. BUG=667641, 382170, 690480 Review-Url: https://codereview.chromium.org/2869733004 Cr-Commit-Position: refs/heads/master@{#471113}
-
chrishtr authored
BUG=718564 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2876473005 Cr-Commit-Position: refs/heads/master@{#471112}
-
thakis authored
This conditional build mode was added almost a decade ago in http://bugs.webkig.org/show_bug.cgi?id=14981 and the code guarded by it hasn't been compiling in a few weeks at least. It's probably safe to say that it hasn't been used in a long time. BUG=675877 Review-Url: https://codereview.chromium.org/2871983002 Cr-Commit-Position: refs/heads/master@{#471111}
-
Jennifer Apacible authored
Still failing after updating the expectation to Failure Pass Timeout. Skipping the test for now. See crbug for more details. BUG=720511 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2879693002 . Cr-Commit-Position: refs/heads/master@{#471110}
-
Jeff Carpenter authored
This reverts commit ff67881b. Reason for revert: Updated credentials but that uncovered a bug with how we handle responses from the Gerrit API. Original change's description: > [WPT Export] Create GitHub PRs from Gerrit CLs > > Bug: 700092 > Change-Id: I7fd398d1e25b77493eef609cbf818747216cd140 > Reviewed-on: https://chromium-review.googlesource.com/479931 > Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Cr-Commit-Position: refs/heads/master@{#471061} TBR=qyearsley@chromium.org,jeffcarp@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 700092 Change-Id: Ieb6f34d9762184033c10d6ba7c3b4e8208a7fe5b Reviewed-on: https://chromium-review.googlesource.com/503553Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#471109}
-
tkent authored
It makes the code simpler. BUG=710535 Review-Url: https://codereview.chromium.org/2865403006 Cr-Commit-Position: refs/heads/master@{#471108}
-
erikchen authored
These metrics are temporary and are intended to be removed once the same metrics are emitted by the memory instrumentation service. BUG=720541 Review-Url: https://codereview.chromium.org/2875823004 Cr-Commit-Position: refs/heads/master@{#471107}
-
Johan Tibell authored
The functionality to store prefs under different keys in the in-memory pref store that overlays the underlying profile's user prefs is unused. Removing this functionality simplifies the code and helps the effort of converting prefs to a Mojo service. Bug: 654988 Change-Id: I5ae8455f64cbce685953b2c9ade6d17f17550921 Reviewed-on: https://chromium-review.googlesource.com/502387Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
-
file://eugenebut authored
Use full URL spec if it ends with / BUG=719982 Review-Url: https://codereview.chromium.org/2876053002 Cr-Commit-Position: refs/heads/master@{#471105}
-
fserb authored
changes default em font size to 16 changes default viewport size to 0x0 BUG=721498 Review-Url: https://codereview.chromium.org/2877823002 Cr-Commit-Position: refs/heads/master@{#471104}
-
zmo authored
Instead of disabling all GPU features because Intel HD 3000 is crash prone, we force Chrome to use discrete GPU. On the up side, now we can get WebGL back. On the down side, now Chrome on these macbooks will burn energy more quickly. BUG=720152 TEST=affected macbook R=ccameron@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2874163003 Cr-Commit-Position: refs/heads/master@{#471103}
-
dgozman authored
For some unknown reason, crrev.com/468815 caused multiple telemetry tests to timeout. This patch partially reverts that revision, applying another fix to original bug by re-requesting target type on demand. BUG=718952,717003 Review-Url: https://codereview.chromium.org/2873393002 Cr-Commit-Position: refs/heads/master@{#471102}
-
gmanikpure authored
Include a user interaction in order to trigger beforeunload dialog. BUG=chromedriver:1803 Review-Url: https://codereview.chromium.org/2878703003 Cr-Commit-Position: refs/heads/master@{#471101}
-
thakis authored
BUG=675877,720442 Review-Url: https://codereview.chromium.org/2872273004 Cr-Commit-Position: refs/heads/master@{#471100}
-
yusukes authored
This CL moves around some code for Chrome OS OOM handling to make the code a bit easier to follow: * Previously, code for selecting "protected" processes was scattered around the file. One was in TabManagerDelegate::GetSortedCandidates for protecting PERSISTENT processes from *both* Chrome and kernel OOM handler, and the other was in LowMemoryKillImpl for protecting FOCUSED and VISIBLE processes from *only* Chrome. This CL moves the former to AdjustOomPrioritiesImpl to simplify the code. * Previously, tab_manager_delegate_chromeos.cc also directly used arc::mojom::ProcessState enums. This CL moves the code to arc::ArcProcess with unit tests to hide ARC details from the TabManagerDelegate class. * Previously, AdjustOomPrioritiesImpl had an assumption that the processes the function protected from the kernel always had -1000 OOM adjustment scores. The assumption is fine, but will make it difficult for us to e.g. protect arc::mojom::ProcessState::TOP processes from the kernel because unlike PERSISTENT ones, TOP processes change time to time and may have positive OOM adjustment scores. With this CL, AdjustOomPrioritiesImpl explicitly sets -1000 for processes the function protects to remove the assumption. In the future, we can modify ArcProcess::IsKillableForKernel as we like to experiment various OOM scoring policy without any artificial restrictions. * Add more unit tests for better code coverage. This CL does NOT change the current Chrome/kernel OOM handling behavior at all. This is pure code refactoring. Also, this CL does not touch the code for handling Chrome tabs. This is only for ARC. BUG=719537 TEST=try TEST=just in case, manually confirmed PERSISTENT processes still have -1000 adjustment. Review-Url: https://codereview.chromium.org/2874543002 Cr-Commit-Position: refs/heads/master@{#471099}
-
Johan Tibell authored
Until we have a distinction between owned and unowned prefs sending these around just wastes CPU cycles. This makes startup 2ms faster on a Nexus 9. Bug: 654988,719770 Change-Id: I87e5c8da9d93226dfdf47acedf42c75f07f01a77 Reviewed-on: https://chromium-review.googlesource.com/497113Reviewed-by:
-
