- 10 Nov, 2020 40 commits
-
-
Mason Freed authored
Per [1], these features were temporarily re-enabled to allow more time for some developers to remove their need for the Origin Trial. This time has now expired, and the features (including via Origin Trial) will now be disabled completely. This reverts [2]. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1136052#c44 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2476673 Bug: 937746, 1136052 Change-Id: I7484f3b768a5ff57679411c06285d901979186c7 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528174 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#825917}
-
Jesse Schettler authored
Bug: 1059779 Change-Id: I1eed0f1e46a7e176e26568db33de769196f7f89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527858 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#825916}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1bc8d7d3cf8a..5aa93984e043 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tmartino@google.com,yuzhehan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1147191 Tbr: tmartino@google.com,yuzhehan@google.com Change-Id: I53b2dd11b573a293c5dd3d451624f41c31a1cb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527580Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825915}
-
Matthew Mourgos authored
Change-Id: I01b06c2660d6878886d28e7b4555ab723fcc74f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528924Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#825914}
-
Miguel Casas authored
AMD ChromeOS has some issues with VP9 Profile 2 hw decoding. While these are addressed, this CL adds a new disable_accelerated_vp9_profile2_decode entry to gpu_workaround_list and uses it to prevent such decoding from being tried. This CL supersedes crrev.com/c/2518785. Bug: 1147466, b/169591197 Change-Id: Id4bb69d6bf6ad02f4523247147c14f8d5e12938e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528582Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#825913}
-
Tommy Martino authored
This reverts commit 73e9db73. Reason for revert: Likely culprit for linker error which closed tree. Sample failing build: https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-lacros-dbg/2634? Original change's description: > Move DefaultFrameHeader to //chromeos/ui/frame/ > > This header/class is directly used by BrowserNonClientFrameViewAsh. > This steps goes one step closed to allow this class to be shared > with Lacros. > > BUG=1113900 > R=jamescook@chromium.org, oshima@chromium.org > > Change-Id: I185560a34265e6ff13c48b48634faf6826f2236a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529570 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825896} TBR=jamescook@chromium.org,oshima@chromium.org,tonikitoo@igalia.com Change-Id: I4fca1a562ad4f9b14937b4e96f73323799369f2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530210Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#825912}
-
Vincent Scheib authored
dougt, juncai, odejesush are no longer actively reviewing changes in these areas. Change-Id: I2c0ea93d2ec30484505a7c9e5ecee4940330946a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524042 Commit-Queue: Vincent Scheib <scheib@chromium.org> Auto-Submit: Vincent Scheib <scheib@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#825911}
-
Youkichi Hosoi authored
Currently the argument is unused but it should be used. BUG=none TEST=Stop an Upstart job with nonempty environment. Change-Id: I5b6485a79a357cb900b3672248d695a376249084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526662Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Youkichi Hosoi <youkichihosoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825910}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c0884991d53..008d63e23dab 2020-11-10 mtklein@google.com replace std::aligned_union 2020-11-10 adlai@google.com Fix up a ton of implicit memory_order_seq_cst for unique id gen 2020-11-10 johnstiles@google.com Add unit test for array with many dimensions. 2020-11-10 csmartdalton@google.com Add a mock implementation of GrMeshDrawOp::Target 2020-11-10 robertphillips@google.com Remove the bulk add-renderTasks entry point from the drawing manager 2020-11-10 kjlubick@google.com [canvaskit] Add support for woff2 fonts 2020-11-10 mtklein@google.com replace std::aligned_storage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: I2b507ff0f98ed5ff4d45d136d429683b4a48994b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527576Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825909}
-
Eric Orth authored
Parse from two separate portions of the input and attempt IsEqual() between the two resulting parsed rdatas. Improves our ability to discover issues in the comparison logic. Bug: 1146873 Change-Id: Ib561dfce0a704a876cc731ef9037759d304f71ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525772 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#825908}
-
Chan Li authored
Bug: 1108016 Change-Id: Ic766443b0034b0d41cece5a4fdabbb95f47b9c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529970Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#825907}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/17ac33b5..f1da47d0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I463f2f5f1197560529321cbcae7099b2d681a57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529671Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825906}
-
Alexander Surkov authored
This is a reland of 45fe0314 Original change's description: > a11y insepct reorg: move PropertyNode class to ui/accessibility > > Bug: 1133330 > Change-Id: I9103d0116c5822a0f9dc291a7a87bd5f902a4efa > AX-Relnotes: n/a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519755 > Commit-Queue: Alexander Surkov <asurkov@igalia.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825789} Bug: 1133330 Change-Id: I6608770602770255d6c7033fd3d70e373de43f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529749Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#825905}
-
Sophie Chang authored
Will add the client itself in a separate CL This is basically following the template of https://chromium-review.googlesource.com/c/chromium/src/+/1416131 Bug: 1146151 Change-Id: I77a32bdf4021768d902f9975c1077f3c0fbd3c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522399Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825904}
-
Daniel Cheng authored
Currently, this all happens to work by chance, because the speculative RFH or the entire FTN happens to be torn down before the browser process ever processes a Detach() IPC for a speculative RFH. However, there are a number of followup CLs that restructure how provisional RenderFrames are managed and owned in the renderer process. To simplify those CLs, explicitly branch in Detach() based on whether or not the RFH is speculative. In the future, additional logic may be added to the speculative branch (e.g. cancelling the navigation, if appropriate). Bug: 1146709 Change-Id: I6490a90f7b447422d698676665b52f6f3a6f8ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524280 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#825903}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9828732beeee..98035e11d907 2020-11-10 jmadill@chromium.org Capture/Replay: Split into separate shared libaries. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I04c7634d9a2cbdf0d04991c78967bf1d4896f789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825902}
-
Nohemi Fernandez authored
This new property will apply a blue tint as an image color background. It is used for existing icons (preserving the current behavior for these icons) but is disabled for sign-in's profile avatar (in this patch). Bug: 1145592 Change-Id: I4c41604633efb5c8801437203642c6f55c1a0382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527383 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#825901}
-
Sajjad Mirza authored
Replace uses of the shlex.split function with one that will mostly do the right thing on Windows. For our purposes splitting on whitespace should be sufficient. Bug: 1090653 Change-Id: Ia787d975ee0bc04147ec4c255bf6102965df7861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527731 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Auto-Submit: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#825900}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1eb165cc6c39..85f69d7b20d2 2020-11-10 alexrudenko@chromium.org Format color suggestion according to the current color format 2020-11-10 tvanderlippe@chromium.org Typecheck changes/ChangesTextEditor.js with TypeScript 2020-11-10 petermarshall@chromium.org Update Mocha to 8.2.1 2020-11-10 tvanderlippe@chromium.org Use TypeScript-authored files in linear_memory_inspector/ 2020-11-10 andoli@chromium.org [ts] Typecheck elements/DevicesSettingsTab.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1101784 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I562f6ac49ea66ff05507ae79da5b9190b0968761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527577Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825899}
-
Chan Li authored
Bug: 1108016 Change-Id: I5f9bfafea7576c645007ca6c7ec7958d90f6b3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523064Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#825898}
-
Sophie Chang authored
Will incorporate field in separate CL Bug: 1146151 Change-Id: I8691cb9c72c41b22566b228d9f832ed90b463bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523660 Auto-Submit: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#825897}
-
Antonio Gomes authored
This header/class is directly used by BrowserNonClientFrameViewAsh. This steps goes one step closed to allow this class to be shared with Lacros. BUG=1113900 R=jamescook@chromium.org, oshima@chromium.org Change-Id: I185560a34265e6ff13c48b48634faf6826f2236a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529570 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#825896}
-
Josie Nordrum authored
Updated expiration date for Fingerprint.Unlock.MatchIgnoredDueTo PowerButtonPress from 2020-11-02 to 2021-02-02. BUG=b:169082982 TEST=None Change-Id: Ia33b24a575acbde3dfb9ff99a9df0c9565d76139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520376Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Josie Nordrum <josienordrum@google.com> Auto-Submit: Josie Nordrum <josienordrum@google.com> Cr-Commit-Position: refs/heads/master@{#825895}
-
Roman Aleksandrov authored
Fixed: 1138387, 1144799 Change-Id: If0bf4ad02202a98e20505f74100dcd6553d718aa Bug: 1138387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523326 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#825894}
-
Ilya Nikolaevskiy authored
Bug: chromium:1134073 Change-Id: I8caa32dcc0443519981e3f8206701c2649819385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529356 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825893}
-
Yue Li authored
Bug: b/159670857 Test: Run existing tests Change-Id: I93e809c9f96e8a8c705cc43b144ecf2ae4d86625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518724Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#825892}
-
spdonghao authored
Bug: 1083428 Change-Id: I3f920bc0669b7e87c3b266e342ac85adff503695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519208Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#825891}
-
Eric Robinson authored
I've also declared a few histograms as obsolete where it seemed appropriate to do so and removed the corresponding code and tests. Bug: 1143730 Change-Id: I28f75c9e25f6daab4dceeb20ed4f6fc90d6260a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424064 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#825890}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011100600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/6EdcOM96U0hrdmIp_UAwPgUiN6Cs86TLI-B-7wQAFR0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159267911,b/172616107,b/172775363,b/172811994 Tbr: media-app@grotations.appspotmail.com Change-Id: Idee6fdcba8bcf103ab6fa47febcde99e88bffa8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529180Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825889}
-
Mike Wasserman authored
Move WebContentsDelegate Bluetooth interface to BluetoothDelegate (RunBluetoothChooser and ShowBluetoothScanningPrompt) Make callers use the ContentBrowserClient's BluetoothDelegate instead. Consolidate android/desktop/extension impls into Chrome delegate. WebView continues not implementing this functionality. Remove unused CastWebView delegation layer. Wire up test delegates and ContentBrowserClients as needed. Move Shell impl/delegation for web test to FakeBluetoothDelegate. Bug: 1048325 Test: No regressions of Web Bluetooth functionality. Change-Id: I0f39a46dbea386ed5ad8e461d7dc25ec81806fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520216 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#825888}
-
Devlin Cronin authored
There's a check in ExecuteCodeFunction that extension()::id() is non-empty, but this is unnecessary. Every extension object necessarily has a non-empty extension ID, and if that ever changed, many, many other things would explode long before this check were reached (for instance, we wouldn't be able to associate the extension with the function, since it's retrieved by ID). Bug: None Change-Id: Id967398b43885e21792c5679fdfd236179157434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518118 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Auto-Submit: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825887}
-
Manuel Rego Casasnovas authored
The method was getting the |container_content_size| as argument, but it was only used to compute the |container_physical_content_size|. The callers have already computed the |container_physical_content_size| before calling this method, so we can simply pass it and avoid recomputing it here. BUG=1098231 Change-Id: I254256dd67123094086f3caa523735893a7b754e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529163 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#825886}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/952ef3e06472..8da8bcdf92fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I716169e11285ac7f1c08abb0d8462c6eb71d60c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529195Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825885}
-
Shrek Shao authored
The newly added clientRenderingAPI metrics is missing from ukm dashboard Adding <enumeration/> tag should fix the issue. Bug: 1147230 Change-Id: Ia9ee0ec673fec3db8daaacbdc6fa1ff1558fa121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527565Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#825884}
-
Joshua Peraza authored
Bug: chromium:912138 Change-Id: Ifee9197731789b3a113ebefe188f95447c126187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526946Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#825883}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604987499-9d0e7b1f2ad8a8a8d61e84a818ba5c2f2988369e.profdata to chrome-win64-master-1604998756-dde3841da8adecb7243697161fbddafddb9cdeef.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic151f4dc56bf1c5b876e5cfe4494a8fcc6ce4fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529177Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825882}
-
Roman Aleksandrov authored
Bug: 1143666 Change-Id: I17ea892172fd2cad26cf711f4313b7385c1de4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529551Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#825881}
-
Mason Freed authored
This test takes almost the full 6s (or longer depending on the build) timeout available. It recently started causing flaky CQ retries, so I'm moving it to SlowTests. If it continues hitting the timeout, it likely needs more direct intervention (fixing the test). Fixed: 1145716 Change-Id: I160b3a8192e43fd53f4552d484313fb63b9792cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529571 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825880}
-
Bartek Nowierski authored
Continuation of crrev.com/c/2517220 This CL makes sure that the build is run on a Windows machine, so that a Windows binary is produced. Otherwise, attempting to run a test on a Windows machine will fail. Bug: 1121427 Change-Id: Iebc07694b09f943b65fe0b89480e9dcf512fef93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526642 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Haiyang Pan <hypan@google.com> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#825879}
-
Kartik Hegde authored
Add the HttpFirewall routine to the ServiceConnection. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest* 3) Applied HttpFirewall changes and successfully ran the HttpFirewall routine on a DUT (verified using cros-health-tool diag --action=run_routine --routine=http_firewall). Change-Id: I15c568de9f4c5c55258240862b6e76a84ea96434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482085Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#825878}
-